Commit Graph

960 Commits

Author SHA1 Message Date
955ebe83a8 String to OUString and cleanup
Change-Id: Idc18c1a6a64edea3399c8747ec0f096a2f964b68
2013-06-29 16:23:24 +02:00
bcb434b47f n#820273: Multilevel labels are rotated.
It looks odd when multilevel labels are rotated as well.
This patch resets the rotation values for outer labels.
2013-06-27 18:48:43 +05:30
ba2cf55398 cppcheck: fix some uninitMemberVar in chart2 part
Change-Id: Idfccf39fc4b34a5e4c2cb0bed4bcd399a73029af
2013-06-17 22:39:30 +02:00
8196dab4f4 Resolves: #i120831# call dispose() from ChartView dtor...
to make sure SfxBaseModel object is freed correctly

Found by: zhangjf
Patch by: zhangjf

(cherry picked from commit 4cb73634a602272d8de33dfe23722912e4494bbc)

Change-Id: I9e316178ef273b13e77d0b166f17fc700363f7bb
2013-05-31 14:59:59 +01:00
f30399c540 Revert "fdo#46808, Convert chart2::Title service to new style"
This reverts commit d256dbede60533369d1aac64cca34721183f6a8a:

For one, the new css.chart2.XTitle2 looked unfinished, in that it transfered the
direct properties of the old-style css.chart2.Title service into attributes, but
left out all the properties inherited by the old-style service from
css.style.ParagraphProperties, css.drawing.FillProperties,
css.drawing.LineProperties (and that missing FIXME css.layout.LayoutElement,
whatever that is supposed to be).  This needs more thought, to either make
available all propertiers as attributes, or none.

For another, this broke JunitTest_chart2_unoapi (sch.ChXChartDocument,
sch.ChartTitle), for hard-to-debug reasons.

Conflicts:
	chart2/source/model/main/Title.cxx
	chart2/source/model/main/Title.hxx
	offapi/com/sun/star/chart2/XTitle2.idl
	sc/source/filter/inc/xlchart.hxx

Change-Id: I4747208a13984904d0e409ea49a73b0f667c86c7
2013-05-23 10:39:21 +02:00
d256dbede6 fdo#46808, Convert chart2::Title service to new style
API CHANGE: The chart2::XTitled interface now takes and returns
   a XTitle2 instead of an XTitle.

Change-Id: I96c35909d3a13f1abb544296a782a0b6a7a58ec6
2013-05-21 08:24:01 +02:00
cb6d67c21f Spelling "separate" (etc) correctly is hard 2013-05-15 11:14:28 +03:00
5d1ad16729 fdo#46808 Convert chart2::FormattedString service to new style
API CHANGE: dropped the following services from the new unified
interface because the current service does not implement them.
    service ::com::sun::style::CharacterProperties;
    [optional] service ::com::sun::style::CharacterPropertiesAsian;
    [optional] service ::com::sun::style::CharacterPropertiesComplex;

Change-Id: I7cb6a5d4e998975b1272f4f4da03feea30cd30b6
2013-05-13 09:38:03 +02:00
2af1f5691e resolved fdo#35756 import more than 64k HTML table cells
Enhanced EditEngine to be able to hold more than 64k paragraphs. Used
also in RTF import Calc and Writer, so that could benefit as well.

* changed all EditEngine,Outliner,... related paragraph index/count
  variables from sal_uInt16 to sal_Int32
  * sal_Int32 instead of sal_uInt32 to match accessibility API
  * matched some Outliner methods' paragraph parameters from sal_uLong
    to sal_Int32
  * containers capable to hold size_t nevertheless are limited to a
    maximum of sal_Int32
* changed definition of EE_PARA_NOT_FOUND and EE_PARA_ALL to
  SAL_MAX_INT32
+ added EE_PARA_MAX_COUNT and EE_TEXTPOS_MAX_COUNT to initialize
  ESelection with what previously were hard coded 0xFFFF all over the
  place
+ for similar reason added EE_TEXTPOS_ALL corresponding to EE_PARA_ALL
  to initialize an ESelection spanning all available text like
  aSel(0,0,EE_PARA_ALL,EE_TEXTPOS_ALL)

Change-Id: I62d1b9c399cd709a4f93dbac31b219a61c46ec00
Reviewed-on: https://gerrit.libreoffice.org/3838
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-05-10 14:01:38 +00:00
67c7ef9525 coverity#705446: self assignment
Change-Id: I950a6d971b1be742fa7c0ce26697cd84121a14d0
2013-05-09 23:29:45 +02:00
2ce25faffd fix typos (wich instead of which) 2013-05-06 20:07:23 +02:00
1bb53530e8 n#816939: Improved label overlap detection - Part 2 2013-05-02 17:25:50 +05:30
64ed03c90e n#816939: Improved label overlap detection. 2013-04-30 10:14:54 +05:30
1e83da9aed some more namespace cleanup
Change-Id: Ib1e80d717f199db8f8ac4181d4377a86d88e3244
2013-04-26 18:01:51 +02:00
8546c324ff Remove pass-through header file sot/inc/sot/clsids.hxx
Change-Id: I122669d4ffaf72fb1d5f6fccc98e8a648f31aa23
Reviewed-on: https://gerrit.libreoffice.org/3490
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 14:55:56 +00:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
1ed7398463 fdo#51656 : Mean value line starts in wrong place in column graph
Change-Id: I2389687e54cec4c0e873bcc120cc21b3c3d11d78
2013-04-01 20:48:52 +02:00
2903c5f59d n#734735: Use full available size for pie charts. 2013-03-20 18:06:38 +05:30
c09c64ede6 fdo#46808, convert drawing::GraphicExportFilter to new style
Change-Id: Icd456209406ee8f4dc4ea1f966058f71dce08d58
2013-03-20 07:32:52 +02:00
bf033461c5 fdo#61135 stepped lines graph: handle ods files
The boilerplate code for drawing the 4 types of stepped is in place (as
described in ODF1.3,
https://tools.oasis-open.org/issues/browse/OFFICE-3662).
We can also read the current attribute values used in Gnumeric. These values
are converted to ODF1.3 during save.

Change-Id: I0f04a779de4b65326ed7ce6de56191f11b51c596
2013-03-19 02:36:46 +01:00
51a18f9bbd warning C4101: unreferenced local variable
Change-Id: I43a0a1dbe37eb76a3d89ace8222cd5f5e3357579
2013-03-14 17:15:39 +01:00
6d2f041a65 warning C4101: unreferenced local variable
Change-Id: I61fb72e824a43d28756edfff7a6655443fe2ee82
2013-03-14 16:49:30 +01:00
e581b9bd1c n#734735: Decrease pie chart's thickness. 2013-03-14 12:56:34 +05:30
bab961dd0a Fix chart2 build
Change-Id: Ia3eb1c1576034c1cbc93e9fb4e60d205a325b132
2013-03-11 18:15:05 +01:00
ded39ea57b #119989# Support relative 3D pie chart height when importing charts.
Reported by: Yan Li
Patch by: Yan Li, Tan Li, alg
Review by: alg(cherry picked from commit 2b1cedbe547ea8f7979f91873dd6e602ebb08a7b)

Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>

Conflicts:
	chart2/source/view/charttypes/PieChart.cxx
	chart2/source/view/main/ChartView.cxx
	sc/source/filter/inc/xlchart.hxx

Change-Id: Ibc6f070021c79809c651ba789409a5fb5096c185
2013-03-11 17:34:44 +01:00
6dddefc6e7 fdo#43460: use isEmpty()
Change-Id: Ia768e684d3cf255239c04d024b35488830cc9fe6
2013-03-09 21:47:31 +01:00
d9a3752143 remove commented out code
This has moved to XShapeDumper.cxx as the comment says...

Change-Id: I0060101a45c359cdf438ae399ec43e39270f9bff
2013-03-09 21:47:30 +01:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
db7a441342 Typo fix: informations -> information and a few other adjacent typos.
FDO:60724

Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-02 02:45:55 +00:00
ca4e453d76 make sure that this coverity report is really a false positive
Change-Id: I2ae6312c533bf2dbfcd5fa691c5acaaee61fe8b2
2013-02-28 06:27:16 +01:00
9fde14ce08 Factor out duplicate enums and types from rsc and vcl into one header
The new header is <rsc/rsc-vcl-shared-types.hxx>, but if some other name or
location is cleaner, feel free to change.

Change-Id: I601923447ff7c1b6cefd71cb2652fcc88d2483d2
2013-02-27 13:50:24 +02:00
405caad685 loplugin: unused variables
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
2013-02-25 03:14:00 +01:00
d05287a9f1 RTL_CONSTASCII_USTRINGPARAM removals
Removed all occurences of RTL_CONSTASCII_USTRINGPARAM in chart2.

Change-Id: I0ab188e2d67a5fc17a3653e5213031f6e2c2581d
Reviewed-on: https://gerrit.libreoffice.org/2244
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-20 22:58:20 +00:00
1aaf9a9b36 Renamed hard-to-remember 8-char headers in editeng.
Change-Id: If255802082890e1b1b4c5197a791fa79a011773e
2013-02-12 15:15:06 -05:00
0bfa66cdf2 MSVC needs explicit OUString in ?:
Change-Id: I9b7db931ea9bd31824bd27f528c2b6214e80924b
2013-01-30 17:40:24 +01:00
97eb8a6e0e Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-30 12:54:40 +00:00
d785b3c41f bnc#590020: Sort data points stably.
std::sort is unstable sort, which is not what we want.  Use std::stable_sort
to sort data points by X values.  If we use unstable sort, it may mess up
the order of the sequence when two data points contain identical X values.

Change-Id: I6453a986185b326dc680fbcec6227ea332235b22
2013-01-25 16:59:58 -05:00
d0b94f5cfe String cleanup.
Change-Id: Ib796e2a101f08f01eb438e8d48c7bffbbd3b19b0
2013-01-25 16:59:57 -05:00
ebed43f4d2 Replace use of std::auto_ptr with boost::scoped_ptr.
Change-Id: Ie821170f9d5b47660370498611d781fd5ba139c8
2013-01-25 16:59:57 -05:00
339f1cb3c2 Make these classes explicitly non-copyable.
Change-Id: I0dcf277a1b72afe294874b42efaf0b24e1b25b8c
2013-01-25 16:59:57 -05:00
8b660baccf A little cleanup.
Change-Id: I69729603bcaadffa06a56296a6ef37af2aef6c54
2013-01-25 16:59:56 -05:00
20f03d3607 C2U macros no longer necessary.
Change-Id: Ia7b3d03e6d00dd2a57cd40dc9a63507652cac84d
2013-01-25 16:59:56 -05:00
228ba082d3 n#791985: Automatically rotate chart labels (if overlapping).
This bug fixes two issues:
* Overlap detection seems to be approximate and
  doesn't work for rotated text. Added a workaround
  for labels rotated at angles 45-135 and 225-315.

* Auto rotate labels, which overlap. This is done
  only for labels having zero degrees rotate.
  For forcing angles, use 'enable overlap' or
  non-zero angles (1 degree).
  Of course, zero degrees plus skipping of labels
  would no longer occur. Better solutions?
2013-01-08 12:50:30 +05:30
e6591c6e94 bnc#791952: Use "center" label placement for "Best fit" in pie charts.
It works better this way for Excel interoperability.  In Excel, Best fit
is slightly different than the center placement, but the two are pretty
close in pie charts.

Change-Id: I7f04a1babb04fd488d8cf90df247c294fa9d7b67
2012-12-08 00:04:46 -05:00
a6a2feffc0 bnc#791952: Better placement of 3D pie chart data labels.
This value appears to control the logical vertical offset of data labels
along the z-axis for 3D pie charts (no effect in 2D pie charts).  With
-0.5, the data labels appear lifted from the top surface of the pie chart.
With -1.0, the labels get placed right at the top surface, which improves
the precision of data label positions.

With this change, data labels that are centered are really centered inside
their respective pie segments.

Change-Id: I26d5d7cb7f68bd09131b70bcb4fc030ac924bcce
2012-12-08 00:04:42 -05:00
4b9740b4ec Remove duplicate defines and put it into a common place.
Change-Id: I55415985f37970e4d1ba8605e6d22c45198fe19f
2012-12-08 00:04:38 -05:00
4ece397f21 cppCheck: Remove some 'redundantAssignment'
These iterators are already assigned with the same value a few lines above.

Change-Id: I4051db7599824cf407af9ec91ef8f6633467ea36
Signed-off-by: jailletc36 <christophe.jaillet@wanadoo.fr>
Reviewed-on: https://gerrit.libreoffice.org/938
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2012-10-30 16:51:05 +00:00
c69280ab4e sal_Bool -> bool in chart2
Change-Id: Idba76b64746fb1eec0a723a9fcbac025eda3d9a1
2012-10-04 21:29:32 +02:00
e1dee0aaac limit degree for b-spline to 15 to prevent std::bad_alloc, fdo#46100
Change-Id: Ib801c6af84b52ed093be2ba5eba902513bfa4070
2012-10-04 19:57:38 +02:00
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00