Commit Graph

466 Commits

Author SHA1 Message Date
ba2cf55398 cppcheck: fix some uninitMemberVar in chart2 part
Change-Id: Idfccf39fc4b34a5e4c2cb0bed4bcd399a73029af
2013-06-17 22:39:30 +02:00
8196dab4f4 Resolves: #i120831# call dispose() from ChartView dtor...
to make sure SfxBaseModel object is freed correctly

Found by: zhangjf
Patch by: zhangjf

(cherry picked from commit 4cb73634a602272d8de33dfe23722912e4494bbc)

Change-Id: I9e316178ef273b13e77d0b166f17fc700363f7bb
2013-05-31 14:59:59 +01:00
f30399c540 Revert "fdo#46808, Convert chart2::Title service to new style"
This reverts commit d256dbede60533369d1aac64cca34721183f6a8a:

For one, the new css.chart2.XTitle2 looked unfinished, in that it transfered the
direct properties of the old-style css.chart2.Title service into attributes, but
left out all the properties inherited by the old-style service from
css.style.ParagraphProperties, css.drawing.FillProperties,
css.drawing.LineProperties (and that missing FIXME css.layout.LayoutElement,
whatever that is supposed to be).  This needs more thought, to either make
available all propertiers as attributes, or none.

For another, this broke JunitTest_chart2_unoapi (sch.ChXChartDocument,
sch.ChartTitle), for hard-to-debug reasons.

Conflicts:
	chart2/source/model/main/Title.cxx
	chart2/source/model/main/Title.hxx
	offapi/com/sun/star/chart2/XTitle2.idl
	sc/source/filter/inc/xlchart.hxx

Change-Id: I4747208a13984904d0e409ea49a73b0f667c86c7
2013-05-23 10:39:21 +02:00
d256dbede6 fdo#46808, Convert chart2::Title service to new style
API CHANGE: The chart2::XTitled interface now takes and returns
   a XTitle2 instead of an XTitle.

Change-Id: I96c35909d3a13f1abb544296a782a0b6a7a58ec6
2013-05-21 08:24:01 +02:00
5d1ad16729 fdo#46808 Convert chart2::FormattedString service to new style
API CHANGE: dropped the following services from the new unified
interface because the current service does not implement them.
    service ::com::sun::style::CharacterProperties;
    [optional] service ::com::sun::style::CharacterPropertiesAsian;
    [optional] service ::com::sun::style::CharacterPropertiesComplex;

Change-Id: I7cb6a5d4e998975b1272f4f4da03feea30cd30b6
2013-05-13 09:38:03 +02:00
2ce25faffd fix typos (wich instead of which) 2013-05-06 20:07:23 +02:00
8546c324ff Remove pass-through header file sot/inc/sot/clsids.hxx
Change-Id: I122669d4ffaf72fb1d5f6fccc98e8a648f31aa23
Reviewed-on: https://gerrit.libreoffice.org/3490
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 14:55:56 +00:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
2903c5f59d n#734735: Use full available size for pie charts. 2013-03-20 18:06:38 +05:30
c09c64ede6 fdo#46808, convert drawing::GraphicExportFilter to new style
Change-Id: Icd456209406ee8f4dc4ea1f966058f71dce08d58
2013-03-20 07:32:52 +02:00
6d2f041a65 warning C4101: unreferenced local variable
Change-Id: I61fb72e824a43d28756edfff7a6655443fe2ee82
2013-03-14 16:49:30 +01:00
bab961dd0a Fix chart2 build
Change-Id: Ia3eb1c1576034c1cbc93e9fb4e60d205a325b132
2013-03-11 18:15:05 +01:00
ded39ea57b #119989# Support relative 3D pie chart height when importing charts.
Reported by: Yan Li
Patch by: Yan Li, Tan Li, alg
Review by: alg(cherry picked from commit 2b1cedbe547ea8f7979f91873dd6e602ebb08a7b)

Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>

Conflicts:
	chart2/source/view/charttypes/PieChart.cxx
	chart2/source/view/main/ChartView.cxx
	sc/source/filter/inc/xlchart.hxx

Change-Id: Ibc6f070021c79809c651ba789409a5fb5096c185
2013-03-11 17:34:44 +01:00
d9a3752143 remove commented out code
This has moved to XShapeDumper.cxx as the comment says...

Change-Id: I0060101a45c359cdf438ae399ec43e39270f9bff
2013-03-09 21:47:30 +01:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
db7a441342 Typo fix: informations -> information and a few other adjacent typos.
FDO:60724

Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-02 02:45:55 +00:00
9fde14ce08 Factor out duplicate enums and types from rsc and vcl into one header
The new header is <rsc/rsc-vcl-shared-types.hxx>, but if some other name or
location is cleaner, feel free to change.

Change-Id: I601923447ff7c1b6cefd71cb2652fcc88d2483d2
2013-02-27 13:50:24 +02:00
405caad685 loplugin: unused variables
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
2013-02-25 03:14:00 +01:00
d05287a9f1 RTL_CONSTASCII_USTRINGPARAM removals
Removed all occurences of RTL_CONSTASCII_USTRINGPARAM in chart2.

Change-Id: I0ab188e2d67a5fc17a3653e5213031f6e2c2581d
Reviewed-on: https://gerrit.libreoffice.org/2244
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-20 22:58:20 +00:00
1aaf9a9b36 Renamed hard-to-remember 8-char headers in editeng.
Change-Id: If255802082890e1b1b4c5197a791fa79a011773e
2013-02-12 15:15:06 -05:00
97eb8a6e0e Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-30 12:54:40 +00:00
d785b3c41f bnc#590020: Sort data points stably.
std::sort is unstable sort, which is not what we want.  Use std::stable_sort
to sort data points by X values.  If we use unstable sort, it may mess up
the order of the sequence when two data points contain identical X values.

Change-Id: I6453a986185b326dc680fbcec6227ea332235b22
2013-01-25 16:59:58 -05:00
d0b94f5cfe String cleanup.
Change-Id: Ib796e2a101f08f01eb438e8d48c7bffbbd3b19b0
2013-01-25 16:59:57 -05:00
ebed43f4d2 Replace use of std::auto_ptr with boost::scoped_ptr.
Change-Id: Ie821170f9d5b47660370498611d781fd5ba139c8
2013-01-25 16:59:57 -05:00
4b9740b4ec Remove duplicate defines and put it into a common place.
Change-Id: I55415985f37970e4d1ba8605e6d22c45198fe19f
2012-12-08 00:04:38 -05:00
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
f188ca44d8 std::auto_ptr is deprecated.
For this usage, boost::shared_ptr is probably an appropriate replacement.

Change-Id: I89bea80d330f362e60af4ce66a23316d0029e0d8
2012-09-20 17:39:46 -04:00
526c2b3c01 Unused local variable.
Change-Id: I67fea6c4749b2c69868132bacd761e90933ed84b
2012-09-20 17:30:30 -04:00
707bedff4f More cosmetic cleanups.
Change-Id: I78a461609bc85cff3cc44dcdf993b16c0a1e37b1
2012-09-20 17:28:42 -04:00
b854de954f deprecate oustringostreaminserter.hxx
the intent of this header has canged over time. now it is already
systematically included with ustring.hxx and the operator overload it
provide fit nicely there...

Just to be safe, since that include as been added to the api during the
3.5 timeframe and therefore is already in 'production'
the header remain and simply attempt to include ustring.hxx
but a warning is issued indicating that this header should not be used
anymore... in a couple of major release we will thenr emove it completely

All internal users of that header are converted.

Change-Id: I8934c55f089e29d78c0f5649b7c87b2ecf024bad
Reviewed-on: https://gerrit.libreoffice.org/634
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-18 10:10:06 +00:00
0e38825ddf Working version of XShapeDumper
Change-Id: I4f4d37abdb1865d0bc05f01518d854872235121f
2012-08-15 13:42:10 +02:00
63c508e3e8 re-base on ALv2 code. Includes:
118568: switch to using ucpp
    Patch contributed by Juergen Schmidt
    http://svn.apache.org/viewvc?view=revision&revision=1209396
2012-07-18 09:29:19 +01:00
4dd7c0369d Various Clang 3.1 -Wunsued-variable, -Wconstant-conversion
Change-Id: I0799f22685609201dfb524c373d065b6184ed53c
2012-07-18 08:23:28 +02:00
5b6123e977 also remove the libxml2 include from chart2
all xml related dumper code is now in drawinglayer/source/dumper and no
longer in chart2

Change-Id: I4197774c0ef62606e8f32e47e3fbda0a0de32ae0
2012-07-13 23:33:38 +02:00
4024d14610 Restructurization of XShape- and EnhancedShape- dumpers, builds fine now
Change-Id: I57e230f5b2aff8cd6818b38776ae0b0b0d614d61
2012-07-12 03:10:14 +02:00
ea18a422cd Working version of XShapeDumper
Change-Id: I4f4d37abdb1865d0bc05f01518d854872235121f
2012-07-12 03:10:00 +02:00
16b57ee7cc Unfinished dumper code
Change-Id: I353c93498c2e0cc8fd4450f0348dfceedb763b51
2012-07-12 03:09:59 +02:00
6b11a18071 Some cppcheck cleaning
Change-Id: I14cab3dfd26ac1568feef902b566873cecf049b9
2012-06-30 18:21:26 +02:00
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
3770bbbdba Remove superfluous empty lines on top
More than two lines are removed for readability.

Change-Id: Ibff6cf68d7c512e240a54065b54a225bb23a782b
2012-06-09 04:57:58 +02:00
9bd64312c2 targetted minor size vs. empty reversion
Change-Id: Icf49ed7746a4325e626976ce376762804d0c82be
2012-05-31 13:09:03 +01:00
bb9f730458 nuke unused typedef
Change-Id: I8848d0e687c3b19be1a8bc1f41c2a0c94e13bbbf
2012-05-31 01:56:28 +09:00
4cd9b2fbd3 WaE: doubles truncated to floats
Change-Id: I42b67cc0670f3d0990708fb299243098c1aa972b
2012-05-02 11:20:33 +01:00
08f4273d75 we can't move that into a test only lib
Revert "move xshape dumper into test"

This reverts commit beccf477581b1f3e85100d43be81ea55d3b3f912.
2012-04-28 03:56:50 +02:00
beccf47758 move xshape dumper into test
XShapeDumper can now be used by other parts of the code too.
Please keep in mind that changing the dumper affects other parts too and
might require a regneration of reference files.

Change-Id: I540420a8bdf8afd8d43c5ea0bb0d82d7e0ecc44b
2012-04-27 23:28:16 +02:00
8a7a891a9f adapt dumper to new xml diff 2012-04-27 03:15:31 +02:00
55b823c6f9 don't use the debug mode for normal tests 2012-04-19 15:51:01 +02:00
67c45c9dbd Calculate correct standard deviation for XErrorBar.
- Add method to calculate X standard deviation.
- Set correct XErrorBar position when using standard deviation error
type.
2012-04-11 17:55:41 +02:00
8a01ee6243 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)\(else if\|if\) *( *\([^!()|&]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\) ) *) *)$/\1\2 ( \3 == \4 )/' \{\} \;
2012-04-06 14:30:05 +02:00
cdd3ea090a Fix format string properly 2012-03-30 13:17:37 +02:00