Commit Graph

5986 Commits

Author SHA1 Message Date
53a08b03a8 122658: Fixed typo in localized string.
Found by: jteera
Reported by: Andrea Pescetti
(cherry picked from commit 8f23dda62c32085f8665483e38345ee13389860e)
2013-07-01 11:52:03 +01:00
710f41b7ae Clean String and sal_Bool in tools
Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655
Reviewed-on: https://gerrit.libreoffice.org/4627
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-30 04:58:49 +00:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
318f2b64cc remove some createFromAscii usage
there are a lot more of them:

git grep 'createFromAscii[^)]*"'

Change-Id: Ibc2e9cae208d8b9c91667bb3b177c6bd6d3a9424
2013-06-29 16:23:23 +02:00
4296394d5c remove pointless external guards for standard headers
Change-Id: I509984a6029b6a86fd1ee3f947394af9cdf71c6a
2013-06-28 18:10:16 +02:00
2cfb215de6 impl_parseLikeNodeToString_throw should be called only on a like_predicate
Change-Id: I3597aadab8b13703ed7b7731d530320c4e5999be
2013-06-28 16:26:07 +02:00
ede7f6ae5f fdo#66130 correct "skip column name" condition for LIKE predicate
When converting a parse tree to SQL snippet for a predicate in the
context of a column, we skip the name of the same column in 'simple'
cases.

This is used mainly in the "Criterion" lines of query design,
and in the search/filter dialogs of forms, tables, etc.

In all other cases (such as when creating a full SQL command, or for
references to *other* columns than the context one), the column name
must be printed out.

In this respect, the condition "should we skip the column name?" in
impl_parseLikeNodeToString_throw was buggy, and different from the
one in the general case (in impl_parseNodeToString_throw), leading
to generating invalid SQL like:
 SELECT foo, bar FROM baz LEFT JOIN qux ON LIKE qux.quu
instead of
 SELECT foo, bar FROM baz LEFT JOIN qux ON baz.baa LIKE qux.quu

Change-Id: Ie14fce319554a66feb0fd0ce1a03d947a46a820a
2013-06-28 16:26:06 +02:00
d6bba47bcb remove ::connectivity::to(Date)?(Time)?String; same as DBTypeConversion::*
Change-Id: I5f2ef1ecff7e2071b55c27b9dc60e7d92950435c
Reviewed-on: https://gerrit.libreoffice.org/4563
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28 12:25:55 +00:00
ab3f90e051 fdo#62699 remove pass-through header
Change-Id: Ib2c6ae071525ba52ee754439c1405da79fa3eeaa
2013-06-28 06:55:38 +02:00
efe0e8b811 fix nanosecond computation
when less/more than nine digits

Change-Id: I222ae7c51e37468a01abc9caab91657ea2593d13
2013-06-27 19:52:44 +02:00
6391e823dc Replace buggy pgsql-sdbc datetime functions with dbtools equivalents
In particular, the string2time function segfaults when called on an empty string
(unconditionally tries to access the n-th character without checking whether the string is that long)
this happens in particular when reading a column of type TIME with a NULL value

Change-Id: I302044f67a92fe20685ce677ba3affdb9b44cb53
2013-06-27 14:37:13 +02:00
1b0a43142b new dbtools::DBTypeConversion::toTimeStringS for time in second precision
(no fractional second)

Change-Id: I8bf448783b24fceae9a750f40887d6296999b203
2013-06-27 09:29:33 +02:00
83dc5c0758 fdo#66216 JDBC no fractional second in time format
fractional second allowed in timestamp. But not in time. Don't ask why.

Change-Id: I5415889ab4cf4835b8b0db7363b7d9eb0a332393
2013-06-27 09:29:32 +02:00
ac146c16c0 fdo#66216 fix DBTypeConversion::toTime overflow
Change-Id: I0aba2344afde94226cfbac5b3221e827e6774b3a
2013-06-27 09:29:32 +02:00
b45b566e17 fdo#66216 fix DBTypeConversion::toTimeString format
std::ostringstream::width is not sticky

Change-Id: I32d77bec68506b7691a4f86dadb24e62fdc13d42
2013-06-27 09:29:32 +02:00
5a2c23ca59 unused constant
Change-Id: I72a27a05c9e3e49b17817c2566fbd7f02b7835c5
2013-06-27 09:29:31 +02:00
89a8a48ccd fixup
Change-Id: I20b56f8051d85aec4331d0e5bd83985580f05dbf
2013-06-21 16:04:21 +02:00
2741cb8685 fdo#49708 when there is no Primary Key, there is no Primay Key
As opposed to a primary key with empty name and no columns (!)

Change-Id: I78ca185947a0e8d37bac64bd50add155afaeed47
2013-06-21 15:42:37 +02:00
caab53cf21 fdo#43460 connectivity,extensions,filter,idl,idlc: use isEmpty()
Change-Id: I78ba286be5aa4d731f734e5eb16adb77c686aad9
Reviewed-on: https://gerrit.libreoffice.org/4325
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-06-18 17:31:20 +00:00
ed9f838720 Revert "fdo#65653, fdo#65619, fdo#65216: Missing check"
This reverts commit 10777b37536be16c6d2e167b59e9e31e37ba3517.

The problem has been fixed in a more safe way by making columnMatchP
treat the case where rParam.xField is not set instead of requiring
it from all callers.

Change-Id: Ic68a764e08446a7b669c6030c2bcd55c7d31772b
2013-06-18 13:06:45 +02:00
20499497b0 fdo#65653 make columnMatchP safer
Change-Id: Id994ab5aed6172d8a93fd331a366fca10a663a48
2013-06-18 13:02:38 +02:00
dd3f8fbaff fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*

Change-Id: If89af70767c3fdc4b1d0cb5e51033ca98583bc5d
Reviewed-on: https://gerrit.libreoffice.org/4286
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-06-17 15:55:21 +00:00
0a52587c7a cppcheck: fix uninitMemberVar for postgresql part
Change-Id: Id37b961ff04ec9cebcc9d35434ccfdff0b512235
2013-06-16 21:39:39 +02:00
10777b3753 fdo#65653, fdo#65619, fdo#65216: Missing check
Problem caused by commit:
16c9ce4877def18ca4578171a96615a632d08092
This commit contains code deduplication.
The deduplication removed one needed check (rParam.xFiled.is()),
which causes segfault when member function of rParam.xField
is called inside columnMatchP().

Change-Id: Ibbdaa758dbbce4b76094e6cc120022ef276b30c4
2013-06-15 11:02:32 +02:00
7275a05167 loplugin warnings
Change-Id: I23ce5efe4ba20e1da5ffd169a2f3140a73dd035f
2013-06-15 09:22:09 +02:00
3222f7b993 cppcheck: reduce scope
Change-Id: Icd0c258e83631de2356503c725139fac2035fb0b
2013-06-12 22:54:20 +02:00
4e5b78d6a5 cppcheck: fix Variable "hr" reassignment
Change-Id: Iafaac91fe3783118817d40f3831e5ca039be64e0
2013-06-12 22:53:09 +02:00
c154f180e2 Ensure UNO context propagation on drivers instantiation
Use a better approach than 33c2427824ac893b15777527b818ec99c78c61dd

(cherry picked from commit 7f635eeb69e1257a37c2d3bfe9afe5e56daf259c)

Conflicts:
	connectivity/source/manager/mdrivermanager.cxx
	connectivity/source/manager/mdrivermanager.hxx

Change-Id: Ic7ce5449d4c5e5231c838f9b7733fd4703e6252c
2013-06-07 14:14:07 +01:00
95c0d568fd use uno::Reference#clear() method...
...instead of assigning an empty value. Reduces code noise.

Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-06-05 08:13:23 +02:00
dcbaf7c253 remove unused componentcontext.hxx includes
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-05 08:13:21 +02:00
1e4422a4b4 re-base on ALv2 code. Includes:
Patches contributed by Mathias Bauer
        gnumake4 work variously
        http://svn.apache.org/viewvc?view=revision&revision=1394707
        http://svn.apache.org/viewvc?view=revision&revision=1394326
        http://svn.apache.org/viewvc?view=revision&revision=1397337
        http://svn.apache.org/viewvc?view=revision&revision=1397315
        http://svn.apache.org/viewvc?view=revision&revision=1396797

	Patches contributed by Andre Fischer
	Fixed getcsym.awk to handle #-comments that contain special regexp chars.
        http://svn.apache.org/viewvc?view=revision&revision=1230971
	118778: Added ADDITIONAL_REPOSITORIES environment variable and its
	automatic setup in configure.
        http://svn.apache.org/viewvc?view=revision&revision=1232004
	118160: Added external CoinMP library.
        http://svn.apache.org/viewvc?view=revision&revision=1233909

	Patches contributed by Herbert Duerr
	#i119168# use generic LICENSE file for langpacks and sdks
        http://svn.apache.org/viewvc?view=revision&revision=1310178
	macosxotoolhelper: need to quote perl regexp if it may contain regexp metachars
        http://svn.apache.org/viewvc?view=revision&revision=1183367
	allow gbuild with empty sysroot on linux
        http://svn.apache.org/viewvc?view=revision&revision=1179186

	Patches contributed by Ingo Schmidt
	native373: #164472# improvements for msi database
        http://svn.apache.org/viewvc?view=revision&revision=1167540
        http://svn.apache.org/viewvc?view=revision&revision=1167539

	Patches contributed by Jurgen Schmidt
	adapt setup package scripts to handle special DS_Store file for
	developer snapshot builds
        http://svn.apache.org/viewvc?view=revision&revision=1232430
	imported patch extensions_i117681.patch
	http://svn.apache.org/viewvc?view=revision&revision=1172102

	Patches contributed by Michael Stahl
	gbuild: RepositoryFixes.mk should be optional
        http://svn.apache.org/viewvc?view=revision&revision=1166123
	xslt filter: remove the FLA horror
	wordml import filter: replace FLA usage with plain XSLT
	http://svn.apache.org/viewvc?view=revision&revision=1363727

	Patch contributed by Oliver-Rainer Wittmann
	i#88652: applied patch, remove unicows deps
	http://svn.apache.org/viewvc?view=revision&revision=1177585

    Remove lots of OS2 conditionals, re-extract Rhino Java, unwind
    cppunit pieces, cleanup Mac image bits, remove coin-mp and
    re-package lpsolve, Oxygen & Crystal, fixup qstart bits, expand
    MPLv2 subset checking.

Change-Id: Iad5c8a76399620b892671633c0d8c29996db3564
2013-06-03 11:41:36 +01:00
d209e13319 fdo#46808, Convert comphelper::ComponentContext in forms module
Change-Id: I8a9913d964633381f00c0a4885cc655805fa1974
2013-06-03 10:00:03 +02:00
2838b8eb5e fdo#46808, Convert ComponentContext in connectivity,extension..
...modules.

Change-Id: Ie61976dc12b514bb85ca42496c0d9173a1c56264
2013-06-03 10:00:02 +02:00
526fbddf69 connectivity: make MSVC happy with pairFirstLess
MSVC 2008 with _DEBUG calls this with parameters in wrong order so needs
more overloads.

Change-Id: I334fd93bea278dc147b3b575d079cacf02de5e87
2013-05-29 23:52:13 +02:00
ac66cb60b0 Ensure socket or pipe are passed to the native driver
(cherry picked from commit ad1186563ea12ce63dfdf738c332bf712084f633)

Change-Id: Ib556732abb42dd3371331368c2b2eb717d505461
2013-05-29 12:58:47 +01:00
33c2427824 Ensure UNO context propagation on drivers instantiation
(cherry picked from commit 78b2bf15963704fafb823e80bbccb287847fe1db)

Change-Id: I876b24bc5324c3aede992c4cadb7014b570de5dc
2013-05-29 12:58:47 +01:00
2ae6f9d1d2 RHEL-5 baseline ver of flex doesn't have nounistd
lets try this hack, if it fails revert and I'll just
manually update the baseline with a newer flex than
flex-2.5.4a-41.fc6

Change-Id: If644489e80fc4e4cdba97808af0fe4d544d08646
2013-05-23 13:57:20 +01:00
7298a2b0c7 fdo#46808, Convert XMultiServiceFactory to XComponentContext
Change-Id: I3a74d4edaa3ff3c2498c3db2720b0e4e5305c2e4
2013-05-22 15:20:03 +02:00
48b29cd42b flat db driver: reorganise OFlatTable
Change-Id: I5d522abdffaf1aeb4ae0996d3a19acdcca474f95
2013-05-19 14:05:24 +02:00
72ced5a1e5 flat file db driver: clean up seekRow
Change-Id: Ib9057944c120522230d5ed00cf5d152e5f0b4726
2013-05-19 14:05:23 +02:00
f2cf75d188 janitorial: spelling in comment
Change-Id: I54854765c7ad88f1749d5ae7ad9203f6d29fa2b6
2013-05-19 14:05:19 +02:00
db6ab9f8f1 remove unused & suspicious method
calls m_pTable->seekRow with m_nRowPos instead of m_nFilePos...

Change-Id: Ibf9b4da3dffdd75402deb9e7a371a312e0464613
2013-05-19 14:05:18 +02:00
6b946f2283 fdo#47951 flat text table: update m_nRowPos when moving by bookmark
Change-Id: Iac154020b4b6309f92b1f68fa5bf79611dfcc91b
2013-05-19 14:05:17 +02:00
dab009a4fc use safer/more explicit C++ casts
Especially in debug mode.

Change-Id: I431851bd46da0f46fdb5cfaa19c76cb139823fa8
2013-05-19 14:05:17 +02:00
9b9612f554 janitorial: clean up comments
Change-Id: Iaa146aad75acdceaeb6701b069f0a538904af298
2013-05-19 14:05:17 +02:00
4f214b2b42 connectivity::file::OResultSet remove totally unused data member
Change-Id: I5c4b2d72b600c8ce9de070dc82bf489d66144342
2013-05-19 14:05:16 +02:00
10e03ade8f janitorial: typos in comments
Change-Id: I6fbd522e796a8f1b6c13136f65bda11c19ffbda4
2013-05-19 14:05:16 +02:00
cb6d67c21f Spelling "separate" (etc) correctly is hard 2013-05-15 11:14:28 +03:00
2c46fa1299 fdo#64528 macab URL is sdbc:address:macab, not sdbc:address:macab:*
Change-Id: I1e5721815c961e14484f78f449910908ed48aeb1
2013-05-13 14:34:29 +02:00
09373d4583 soltools: remove Package_inc and empty unistd.h nonsense
Change-Id: Ic05de69951b28b9cc8d62f0a534b507c424e6b25
2013-05-10 17:56:24 +02:00