Commit Graph

2432 Commits

Author SHA1 Message Date
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
9a95669e50 fdo#43460 dbaccess: use isEmpty()
Change-Id: Ie27a81f4e59c48ef5aa03fb82ab38e920c0646a1
Reviewed-on: https://gerrit.libreoffice.org/4321
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-06-17 19:45:38 +00:00
f62cb42d06 cppcheck: fix reassign
Change-Id: Ic1f02c6734cbb0ac4846f0003f70091d5d5b4315
2013-06-07 00:05:58 +02:00
e6edfb6324 cppcheck: unread variable
Change-Id: I809cdbeb71bf4cf014e6d578f35c8a646a5c937e
2013-06-06 23:53:52 +02:00
95c0d568fd use uno::Reference#clear() method...
...instead of assigning an empty value. Reduces code noise.

Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-06-05 08:13:23 +02:00
d209e13319 fdo#46808, Convert comphelper::ComponentContext in forms module
Change-Id: I8a9913d964633381f00c0a4885cc655805fa1974
2013-06-03 10:00:03 +02:00
6a043e9c0a Use the new type-checking Reference constructor to reduce code noise
Also create a Clang compiler plugin to detect such cases.

Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-22 10:44:29 +00:00
cd2f2e772c make OSingleSelectQueryComposer use *system* parse context
and pass it to the parser and PredicateInput constructors.
This makes the whole story consistent; before system locale settings were already manually passed to parseNodeToPredicateStr, which led to some things being parsed as en_US and others as system locale.

Change-Id: Ib9571b10d79183571e8ab3f79660b41594dc2d1c
2013-05-19 14:05:18 +02:00
11fd73acce SolarMutex does not belong into the URE interface
...so move it from osl/mutex.hxx to its own comphelper/solarmutex.hxx.  It looks
like a newbie mistake that 59e7685d8d812ee8773f57475cbe3aa2a0bdfc81 "Create an
abstract interface to be used to implement a SolarMutex" put it here in the
first place.

I do not consider this an incompatible change really, as no external URE client
code should have used SolarMutex anyway.

(Also included some clean up, like removing unused
{Clearable,Resettable}SolarGuard, and spelling out SolarGuard in the few places
it is used.)

Change-Id: I121ffb5b7cefbc19e88b5405e5a85ffc895be852
2013-05-14 14:41:54 +02:00
3abe867790 fdo#46808, fix call to sdb::tools::ConnectionTools
In my previous conversion to new style I forgot to pass arguments
into the service constructor.

Change-Id: Ibbf750315b3e62869b1eb4c520808327002f2dcc
2013-05-14 09:12:06 +02:00
bd27671c0c Initialise the default-constructed ConnectionTools
Regression from the "convert to new style", which led to ignoring aArguments

Change-Id: I09477578f77b253b8c6435d52e1e636d2e212023
2013-05-14 08:05:13 +02:00
9a7603187e dbaccess: remove Package_inc
Change-Id: I8e6748eef04f25603851a33d049cb9585fa04cc6
2013-05-07 01:41:23 +02:00
5907bb462d Fix compilation error when OSL_DEBUG_LEVEL > 0
Just use SAL_WARN, building up the message using chained << operators instead
of constructing it into a OStringBuffer (or OUStringBuffer) and then passing
that to OSL_FAIL.

Or should we have a real assert() here?

Change-Id: I2c3f64ff2b29a3d81ba444d98c2a38ef49e6d7af
2013-04-25 13:53:54 +03:00
e894e57aab dbaccess: {DECLARE,IMPLEMENT}_CONSTASCII_USTRING are no longer needed
Change-Id: Id404f8f3a5bdbf32c207ee81c6f6be9c9d328679
2013-04-25 11:02:34 +02:00
c32b6be06b fdo#60724 correct spelling
Change-Id: Ieb653adbd0cb4371ec5db57e70bcc551872f647f
2013-04-15 05:32:37 +02:00
0987f56912 WaE: unused variable 'insert_result'
Change-Id: I5b0b7eeaa44e3e9e215b8d0bba7e7189c63c766c
2013-04-09 01:49:04 +03:00
3cfecf8427 fdo#46808, Convert beans::PropertyBag to new style
Change-Id: Ibb2466af4c9289cba93b8330d10db033d296bfc1
2013-04-08 13:53:02 +02:00
002aab3090 fdo#46808, convert sdb::tools::ConnectionTools to new style
service already existed, just needed an IDL file

Change-Id: I9000cff76056efecf7ac748bcfc6dd5b8e902e65
2013-04-08 13:53:01 +02:00
ba044b1e96 remove needless forward rtl::OUString declarations
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
2013-04-07 14:23:12 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
876c619b94 new module i18nlangtag
Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.

This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.

Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
2013-04-05 19:10:48 +02:00
a789a2fc94 fdo#46808, convert sdb::QueryDesigner to new style
Change-Id: I694dd16920304d0f07369e97c87a4a97b92eadeb
2013-04-02 12:54:41 +02:00
2b7ee1db28 remove boilerplate comments
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-04-01 22:45:36 +02:00
5be14df244 ResMgr with LanguageTag
Change-Id: Ie5ce9157a7ea59db7b0509fbaec61d07f8f9edf0
2013-03-29 14:09:01 +01:00
905501b635 fdo#46808, convert sdb::CommandDefinition to new-style
the service already existed, it just needed an IDL file

Change-Id: I99c08b4e3a3ee0131b6fd904803efe7273cd1694
2013-03-25 10:35:04 +02:00
8172eaf8dc fdo#46808, use service constructor
Change-Id: I349557ae5897ad668abab30b34b186e746b94c75
2013-03-25 10:35:04 +02:00
4f6514eb09 Don't complain about missing colon in empty DSN
Empty datasource names occur with the datasource wizard's first page
when no datasource type has been selected yet.

Change-Id: I9bcd025aab046e6cb79db47564f55ae3f0faed55
Reviewed-on: https://gerrit.libreoffice.org/2885
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-21 07:30:47 +00:00
a066525b42 fdo#46808, Convert a bunch of comphelper::ComponentContext stuff
.. to Reference<XComponentContext>
mostly in the dbaccess module, but it also affected some other
modules.

Change-Id: I09b3f6fe7a9b33498b11d98b5521b5aeeb8882be
2013-03-20 07:32:53 +02:00
7014a569cc fix breakage introduced by String->OUString migration
Change-Id: Ia509d23306e71b978247705daa9c9559adbae195
2013-03-17 11:55:26 +01:00
bdc374eadf fdo#38838, String to OUString in dbaccess
Replaced String with OUString in module dbaccess/ui/app , and also removed RTL_CONSTASCII_USTRINGPARAM deprecated macro.

Conflicts:
	dbaccess/source/ui/app/AppControllerDnD.cxx
	dbaccess/source/ui/app/AppControllerGen.cxx
	dbaccess/source/ui/app/AppDetailPageHelper.cxx
	dbaccess/source/ui/browser/unodatbr.cxx

Change-Id: Ie385d44c328fb3f919d53a604d51640a334a1013
Reviewed-on: https://gerrit.libreoffice.org/2386
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-15 01:25:12 +00:00
97346bdddf Revert "There's no reason for these defaults in one constructor but not the other"
The reason is that dbaccess_unoapi dbaccess.ORowSet fails with:

lib.StatusException: couldn't set up test environment
    at mod._dbaccess.ORowSet.createTestEnvironment(ORowSet.java:479)

This reverts commit 36caac0e029a3caf50cb27af339efd69008d414e.
2013-03-12 20:59:43 +01:00
36caac0e02 There's no reason for these defaults in one constructor but not the other
Change-Id: I62e9351a21b0519a3ef70c328f33e1b7f7427926
2013-03-12 18:15:50 +01:00
937b63af33 use startsWith() instead of compareToAscii()
brain damage...

Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
2013-03-11 11:07:09 +01:00
6f28efc2a8 fdo#61726: rename report-builder package to org.libreoffice.report
To prevent future clashes with uno name space rename the
com.sun.star.report package to org.libreoffice.report.

Bump the version to 1.2.4.

Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f
Reviewed-on: https://gerrit.libreoffice.org/2578
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
2013-03-11 08:56:40 +00:00
6dddefc6e7 fdo#43460: use isEmpty()
Change-Id: Ia768e684d3cf255239c04d024b35488830cc9fe6
2013-03-09 21:47:31 +01:00
3912e47044 Work around -Werror=unused-local-typedefs from comphelper/stl_types.hxx
Change-Id: Id9f588e551b40a64bc86cae7c6d50f99659f94ab
2013-03-09 13:03:06 +01:00
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
8035a3af26 some further OUString cleanup
Change-Id: I13eb94092e29ececc9fbf494074acde5f893b605
2013-03-08 04:51:28 +01:00
a3bb733ec6 fdo#46808, Convert singleton theMasterScriptProviderFactory
Change-Id: I647a02e552acdd354463fc46c13c5a73b1c90d09
2013-03-07 08:23:39 +02:00
cd8ea20aa4 fdo#46808, Convert ui::UIConfigurationManager to new-style
Change-Id: I62c37eb6d0e0b2a681a84e1fa0067d0a9f967cf2
2013-03-07 08:23:38 +02:00
21e1e859a7 fdo#60724 change spelling error REMOVEABLE -> REMOVABLE
Only applies to PropertyAttribute::REMOVEABLE, and all instances in comments.
All other instances of the misspelling have remained the same.
Example: AF_REMOVEABLE

Change-Id: I391f4101bbc3e06689318235a37d616065bc1686
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-03-06 10:39:30 +01:00
57d169b606 doubled namespace
Change-Id: I756f4a98b1eedcbe7674e9afd9b06816141688b9
2013-03-04 13:58:39 +01:00
db7e034b14 drop unneeded include
Change-Id: I45c33f16a2b70a938a4f716a54c4a5c64460087e
2013-03-04 14:01:25 +01:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
9330b97595 fdo#61564 when WrappedTargetException not in specification, do not throw it!
Change-Id: Id3c995557f320b1d0241f0ef5d94b1c9aeb66528
2013-03-02 08:11:03 +01:00
db7a441342 Typo fix: informations -> information and a few other adjacent typos.
FDO:60724

Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-02 02:45:55 +00:00
a2db9096e2 fdo#61203 initialise m_aComposedTableName *before* trying to use it
Change-Id: Ie7a19bdfe9e7bc729a62191362ce0779d73385a0
2013-02-28 18:07:20 +01:00
8b66c00a0c janitorial: simplify test expression without semantics change
The "sComposerFilter != m_sRowSetFilter" could not influence the result.
Proof.
 The right hand-side of the || is evaluated only when m_sRowSetFilter.isEmpty()
 So the only case where the removed test could have an influence is when
 m_sRowSetFilter.isEmpty().
 However, the right hand-side of the && is evaluated only when !sComposerFilter.isEmpty().
 We have m_sRowSetFilter.isEmpty() and !sComposerFilter.isEmpty().
 In particular, (sComposerFilter != m_sRowSetFilter) is true.
Qed.

Change-Id: I1484d78cf2d7a5e8ca44f382eb7c440c84d8c10e
2013-02-27 07:01:12 +01:00
cb9e5e786b fdo#51976 make "refetch one row" query easier to optimise
Instead of playing tricks with parameters that when filled in force a part of the WHERE clause to have not influence, actually use several different statements and hardcode in each the kind of test to be done

Change-Id: I93e1978f0420bc627a02291f209c788b9b4f2e96
2013-02-27 07:01:12 +01:00
a4322a23a9 janitorial: save one object
Change-Id: I52b7d8204bb2d34639dea544833318fe86a5ddcf
2013-02-27 07:01:11 +01:00