Commit Graph

873 Commits

Author SHA1 Message Date
f62cb42d06 cppcheck: fix reassign
Change-Id: Ic1f02c6734cbb0ac4846f0003f70091d5d5b4315
2013-06-07 00:05:58 +02:00
95c0d568fd use uno::Reference#clear() method...
...instead of assigning an empty value. Reduces code noise.

Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-06-05 08:13:23 +02:00
6a043e9c0a Use the new type-checking Reference constructor to reduce code noise
Also create a Clang compiler plugin to detect such cases.

Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-22 10:44:29 +00:00
11fd73acce SolarMutex does not belong into the URE interface
...so move it from osl/mutex.hxx to its own comphelper/solarmutex.hxx.  It looks
like a newbie mistake that 59e7685d8d812ee8773f57475cbe3aa2a0bdfc81 "Create an
abstract interface to be used to implement a SolarMutex" put it here in the
first place.

I do not consider this an incompatible change really, as no external URE client
code should have used SolarMutex anyway.

(Also included some clean up, like removing unused
{Clearable,Resettable}SolarGuard, and spelling out SolarGuard in the few places
it is used.)

Change-Id: I121ffb5b7cefbc19e88b5405e5a85ffc895be852
2013-05-14 14:41:54 +02:00
3abe867790 fdo#46808, fix call to sdb::tools::ConnectionTools
In my previous conversion to new style I forgot to pass arguments
into the service constructor.

Change-Id: Ibbf750315b3e62869b1eb4c520808327002f2dcc
2013-05-14 09:12:06 +02:00
bd27671c0c Initialise the default-constructed ConnectionTools
Regression from the "convert to new style", which led to ignoring aArguments

Change-Id: I09477578f77b253b8c6435d52e1e636d2e212023
2013-05-14 08:05:13 +02:00
e894e57aab dbaccess: {DECLARE,IMPLEMENT}_CONSTASCII_USTRING are no longer needed
Change-Id: Id404f8f3a5bdbf32c207ee81c6f6be9c9d328679
2013-04-25 11:02:34 +02:00
3cfecf8427 fdo#46808, Convert beans::PropertyBag to new style
Change-Id: Ibb2466af4c9289cba93b8330d10db033d296bfc1
2013-04-08 13:53:02 +02:00
002aab3090 fdo#46808, convert sdb::tools::ConnectionTools to new style
service already existed, just needed an IDL file

Change-Id: I9000cff76056efecf7ac748bcfc6dd5b8e902e65
2013-04-08 13:53:01 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
a789a2fc94 fdo#46808, convert sdb::QueryDesigner to new style
Change-Id: I694dd16920304d0f07369e97c87a4a97b92eadeb
2013-04-02 12:54:41 +02:00
2b7ee1db28 remove boilerplate comments
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-04-01 22:45:36 +02:00
905501b635 fdo#46808, convert sdb::CommandDefinition to new-style
the service already existed, it just needed an IDL file

Change-Id: I99c08b4e3a3ee0131b6fd904803efe7273cd1694
2013-03-25 10:35:04 +02:00
a066525b42 fdo#46808, Convert a bunch of comphelper::ComponentContext stuff
.. to Reference<XComponentContext>
mostly in the dbaccess module, but it also affected some other
modules.

Change-Id: I09b3f6fe7a9b33498b11d98b5521b5aeeb8882be
2013-03-20 07:32:53 +02:00
97346bdddf Revert "There's no reason for these defaults in one constructor but not the other"
The reason is that dbaccess_unoapi dbaccess.ORowSet fails with:

lib.StatusException: couldn't set up test environment
    at mod._dbaccess.ORowSet.createTestEnvironment(ORowSet.java:479)

This reverts commit 36caac0e029a3caf50cb27af339efd69008d414e.
2013-03-12 20:59:43 +01:00
36caac0e02 There's no reason for these defaults in one constructor but not the other
Change-Id: I62e9351a21b0519a3ef70c328f33e1b7f7427926
2013-03-12 18:15:50 +01:00
937b63af33 use startsWith() instead of compareToAscii()
brain damage...

Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
2013-03-11 11:07:09 +01:00
6f28efc2a8 fdo#61726: rename report-builder package to org.libreoffice.report
To prevent future clashes with uno name space rename the
com.sun.star.report package to org.libreoffice.report.

Bump the version to 1.2.4.

Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f
Reviewed-on: https://gerrit.libreoffice.org/2578
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
2013-03-11 08:56:40 +00:00
6dddefc6e7 fdo#43460: use isEmpty()
Change-Id: Ia768e684d3cf255239c04d024b35488830cc9fe6
2013-03-09 21:47:31 +01:00
a3bb733ec6 fdo#46808, Convert singleton theMasterScriptProviderFactory
Change-Id: I647a02e552acdd354463fc46c13c5a73b1c90d09
2013-03-07 08:23:39 +02:00
cd8ea20aa4 fdo#46808, Convert ui::UIConfigurationManager to new-style
Change-Id: I62c37eb6d0e0b2a681a84e1fa0067d0a9f967cf2
2013-03-07 08:23:38 +02:00
21e1e859a7 fdo#60724 change spelling error REMOVEABLE -> REMOVABLE
Only applies to PropertyAttribute::REMOVEABLE, and all instances in comments.
All other instances of the misspelling have remained the same.
Example: AF_REMOVEABLE

Change-Id: I391f4101bbc3e06689318235a37d616065bc1686
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-03-06 10:39:30 +01:00
57d169b606 doubled namespace
Change-Id: I756f4a98b1eedcbe7674e9afd9b06816141688b9
2013-03-04 13:58:39 +01:00
db7e034b14 drop unneeded include
Change-Id: I45c33f16a2b70a938a4f716a54c4a5c64460087e
2013-03-04 14:01:25 +01:00
9330b97595 fdo#61564 when WrappedTargetException not in specification, do not throw it!
Change-Id: Id3c995557f320b1d0241f0ef5d94b1c9aeb66528
2013-03-02 08:11:03 +01:00
405caad685 loplugin: unused variables
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
2013-02-25 03:14:00 +01:00
1da3af5f1e fdo#38838, ::rtl::OUString, String to OUString
I have cleared out String and ::rtl::OUString calls in module dbaccess/source/core/misc.
It was mainly file dbaccess/source/core/misc/dnstypes.cxx , and it's usages. There are
still some calls in dbaccess for this class(ODnsTypeCollection), that needs refactoring
(eg. in file DbAdminImpl.cxx, method "String ODbDataSourceAdministrationHelper::getConnectionURL() const").
Remaining calls will be my next task (in module dbaccess). I also clear out deprecated macro
RTL_CONSTASCII_USTRINGPARAM every time I find one. The class I've mentioned above
(ODnsTypeCollector) is OK.

Change-Id: Ia0f3bb8cc649d1ecf8decc093f8a1a20ee23c33c
Reviewed-on: https://gerrit.libreoffice.org/2289
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-02-22 09:48:50 +00:00
bed621572c fdo#46808, Use service constructor for awt::DialogProvider
Change-Id: I5d0a3e66afeadafa6d53ff0a255d036b7e3d528d
2013-02-11 08:02:12 +02:00
5a8ec562cc fdo#46808, fix calling convention
Change-Id: I72b7945a6a8838e97184a27661520de55ac45e73
2013-01-28 12:06:32 +02:00
614e31aa24 fdo#46808, Adapt sdb::TableDefinition UNO service to new style
The service already existed, it just did not have an IDL file

Change-Id: Iaac84da8baa3a060eef339d8e477f86ca49fae08
2013-01-28 08:23:11 +02:00
49cf14a3ca fdo#46808, Adapt document::GraphicObjectResolver UNO service to new style
The services already existed, it just did not have an IDL file

Change-Id: I245f78c165dbfde11a981efd7033c5c282f4e8ad
2013-01-28 08:22:53 +02:00
a1808e0d38 Remove more STRINGPARAM macros form dbaccess
Change-Id: I283ccd03dc811dda2f10963f400cd517f42ea7b3
Reviewed-on: https://gerrit.libreoffice.org/1878
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2013-01-27 17:31:43 +00:00
188c2d3442 Remove more STRINGPARAM macros from dbaccess
Change-Id: I5a5af27d7c980f6b71011c33531a49a82d79fbc8
Reviewed-on: https://gerrit.libreoffice.org/1771
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2013-01-21 22:59:17 +00:00
8fcd3360f1 Sanitize/simplify some parameters of functions in dbaccess
Some functions have parameters of OUString, so, we don't need this type of junk:
	::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "LayoutManager" )

and we can use directly:
	"LayoutManager"

I believe this brings some simplification to the code, at first glance!

Also in this patch, changed some equalsAsciiL to ==, this simplifies more code yet.

Change-Id: I38b8076afb84d77ed51c7be407c7f899d80829ff
Reviewed-on: https://gerrit.libreoffice.org/1707
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-16 19:01:49 +00:00
1cf1f9338c fdo#57950: dbaccess: STRINGPARAM and more chained appends
Change-Id: Iab1ba5eb6702d386e2775d7426c3398b606d2d97
Reviewed-on: https://gerrit.libreoffice.org/1706
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-16 19:00:12 +00:00
abcbababca fdo#46808, Convert comphelper::MimeConfigurationHelper to XComponentContext
Change-Id: I74b4f0c4a84f02b218102405eaba24cf47f654ce
2013-01-15 09:56:03 +02:00
251f1b0b38 fdo#46808, Adapt embed::*EmbeddedObjectCreator UNO services to new style
The services already existed, it just did not have an IDL file.
Adapts
  com.sun.star.embed.OOoEmbeddedObjectFactory
  com.sun.star.embed.OLEEmbeddedObjectFactory
  com.sun.star.embed.EmbeddedObjectCreator

Change-Id: I8ba01c7fd956a46c87d02dc7d61bdd5fcdf21ab8
2013-01-15 09:56:03 +02:00
0f2a3a3bdc Removed some RTL_* macros and rtl:: prefixes in dbaccess
Change-Id: I467ad9307536e6cdd32ebcdd40539bd5f8614c85

Conflicts:
	dbaccess/source/core/dataaccess/documentcontainer.cxx
2013-01-10 10:24:09 +01:00
fd5a2eb070 fdo#46808, new method OConfigurationTreeRoot::createWithComponentContext
and use it to replace usage of createWithServiceFactory, and thus
replace usage of XMultiServiceFactory.

Change-Id: Id2f44066683ce17cf7a22f80916031556ef0e82a
2013-01-09 08:08:14 +02:00
bb121c864c fdo#46808, Convert frame::Desktop to new style service.
I had to drop XEventBroadcaster from the merged interface
because it introduced method name conflicts (addEventListener).

Shouldn't be an issue since it was scheduled to be dropped anyhow,
and the service implementation still implements it, so existing clients
will be fine.

I dropped the interface XPropertySet from the combined IDL because nobody
seems to be using it, and it's primary purpose appears to be to set weird
flags.

I dropped the optional interfaces
   XStatusIndicatorFactory
   XDispatchInformationProvider
from the combined IDL because the service does not implement them, and
nobody seems to be using them. I suspect they were mistakenly copied
from XFrame.

I also did not convert the Title, UserDefinedAttributes and LayoutManager
properties to attributes, again because no-one is using them.

Change-Id: I678a00006ed2cca2d6c37c4e39465811442c33af
2012-12-21 10:57:09 +02:00
24f0aa76c0 fdo#46808, use service constructor for embed::StorageFactory
Change-Id: I26cd1cf86118122f392f16801a646df753a7df26
2012-12-10 08:05:53 +02:00
b9a4a0b965 fdo#46808, Convert connectivity::SQLError to use XComponentContext...
...instead of comphelper::ComponentContext.

Change-Id: I40384c2d7cfcabd06506321d686dd8e7c7c5f266
2012-12-10 08:05:49 +02:00
9fc4553b64 fdo#46808, Adapt sdbc::DriverManager UNO service to new style
Change-Id: Ic2be6bd08aaabc81d0fbe0269ca577868defe934
2012-12-10 08:05:36 +02:00
d01fba6afc fdo#46808, Adapt sdbc::ConnectionPool UNO service to new style
ConnectionPool was already a new-style service, but since it was
not exposing all of it's interfaces properly I had to create
a unified interface XConnectionPool.

Change-Id: Idfa3fa3335173ceeab1785b4049422874b6c9d5a
2012-12-10 08:05:31 +02:00
495111b249 fdo#46808, use service constructor for sdb::DatabaseContext
Change-Id: I4d845f289f324912b0fc4d8e26a2947e2d2f889e
2012-12-06 13:35:36 +02:00
773ad75b0d fdo#46808, Adapt util::NumberFormatsSupplier UNO service to new style
Change-Id: I58436d9eea0c38d14cde2dc01aa463d5d71912e9
2012-12-06 13:20:31 +02:00
66a175834c c++ API: use css alias in generated headers, adds global css decl
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star

Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.

Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-30 14:36:36 +01:00
3d4288c1c0 fdo#46808, remove some more XMultiServiceFactory fields
Change-Id: I8d039a933c9fde1a24b35954bb5a1f151e9aa160
2012-11-30 13:59:47 +01:00
2cf0f6ea36 fdo#46808, use service constructor for ucb::CachedDynamicResultSetStubFactory
Change-Id: Iea7b21621c5d341468976507684a9c01f0822034
2012-11-30 13:59:47 +01:00
48f2b7a7af fdo#46808, convert ucbhelper::ResultSet to XComponentContext
Along the way, remove the XMultiServiceFactory member from
a few classes that were not using it.

Change-Id: I9ee2c2ebc01144301ed8e489bd92b4695ff263d0
2012-11-30 13:59:46 +01:00