Commit Graph

415 Commits

Author SHA1 Message Date
caab53cf21 fdo#43460 connectivity,extensions,filter,idl,idlc: use isEmpty()
Change-Id: I78ba286be5aa4d731f734e5eb16adb77c686aad9
Reviewed-on: https://gerrit.libreoffice.org/4325
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-06-18 17:31:20 +00:00
4b373ef7f5 fdo#60724 change spelling error REMOVEABLE -> REMOVABLE II
Change-Id: I0057b9174af6a83f3fde0e27c3a91a4aeca95873
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-05-29 10:43:24 +02:00
2ae6f9d1d2 RHEL-5 baseline ver of flex doesn't have nounistd
lets try this hack, if it fails revert and I'll just
manually update the baseline with a newer flex than
flex-2.5.4a-41.fc6

Change-Id: If644489e80fc4e4cdba97808af0fe4d544d08646
2013-05-23 13:57:20 +01:00
09373d4583 soltools: remove Package_inc and empty unistd.h nonsense
Change-Id: Ic05de69951b28b9cc8d62f0a534b507c424e6b25
2013-05-10 17:56:24 +02:00
84068dae54 fix logical-op-parenthesis warning
Change-Id: Ib97f667c9acb644c3becb81f851ad8c7e4ff31ea
2013-04-07 09:42:18 -04:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
ce2991ee86 Forbid old-style services/singletons inheriting new-style services
...does not make sense.  Adapted some old-style services accordingly, where the
inherited service had been changed to new-style after the fact.

Change-Id: I5f3e4ddf99160778a319062a6c84f83529ff177b
2013-04-03 11:30:06 +02:00
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
488e6875e9 remove external include guards
Change-Id: If5758e02baa8e019923355b6c97043b306223fdd
2013-03-25 19:58:16 +01:00
fa545023ad Introduce HAVE_GCC_PRAGMA_DIAGNOSTIC_{MODIFY,SCOPE}
...replacing hard-coded GCC version checks.  Those checks that guard

  #pragma GCC diagnostic ignored "-Wnon-virtual-dtor"

appear relevant only for GCC itself, not Clang (which used to fail the old
guards because it typically announces itself with a rather low
__GNUC__/__GNUC_MINOR__ version), see 6e67c03dc0225fc66343546b14e902b9d238b1a3
"Enable -Wnon-virtual-dtor for GCC 4.6"

Change-Id: I6bfa4d5caa6192e7a203ce829682bf6bb8d61a1b
2013-03-25 08:52:54 +01:00
c7af37db60 deleting NULL is safe
Change-Id: I3748d0034b2c8e9d9122ad2a9001763eb1265e1d
2013-03-25 10:54:05 +09:00
0ed451e338 coverity#704237 Logically dead code
Change-Id: I7a5087b2ac89ee2839f0e0d8450efc7fca1dd68b
2013-03-23 17:28:48 +01:00
25363b4e45 coverity#440066 Logically dead code
Change-Id: I54d1b22859bd4f0a1e68ce79ed2ce4d7fbeb5107
2013-03-22 19:53:41 +01:00
f25fcba2f2 coverity#440065 Logically dead code
Change-Id: I6b735ca48bd996c71ad6c6103e68af2cd2890d98
2013-03-22 19:42:28 +01:00
5bb4a2ba1d further OUString cleanup
Change-Id: I19954ee5976cb881a5fe73a889c8e04a19b14eb6
2013-03-19 14:18:10 +01:00
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
1b4b53a2ec fix spelling
Change-Id: I52eb4153c3396be88b72cab3b7899f0c6ab18103
2013-03-07 08:23:37 +02:00
21e1e859a7 fdo#60724 change spelling error REMOVEABLE -> REMOVABLE
Only applies to PropertyAttribute::REMOVEABLE, and all instances in comments.
All other instances of the misspelling have remained the same.
Example: AF_REMOVEABLE

Change-Id: I391f4101bbc3e06689318235a37d616065bc1686
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-03-06 10:39:30 +01:00
f68cd77923 Fix type unkown -> unknown
Change-Id: I8d55d5ae5ae38ae2b252859b5400e36301f19ef0
2013-02-21 21:50:01 +01:00
814ae45d4b Some cppcheck cleaning
Change-Id: I099171d85a51095f0ff6d592c1260d931f9769b2
2013-02-13 15:08:20 +01:00
56f4d7dc9d Some cppcheck cleaning
Change-Id: I8609949377181f8edb30ac07b2791cfcd079fc7d
2013-02-12 21:24:25 +01:00
f8569cd9a2 UNO constants cannot be of CHAR type
Change-Id: I13f2f1d38b99a5eb1d10f40c524894e37a47f7e2
2013-01-30 13:52:03 +01:00
f1bca26afc Remove redundant braces around for loops
...that had once been workarounds for compilers that did not yet support the
C++98 scoping rules for declarations in for-init-statements.

Change-Id: I51dc42982b30bf3adea6de1a10a91c0b4b4acfbe
2013-01-26 16:36:09 +01:00
3b269d6d2d API CHANGE: Remove support for individual constants from UNOIDL
...i.e., "const X = N;" declarations outside of constant groups.  This appears
to be unused in practice, and removing it will allow to simplify future code
related to UNO type information.

This removes the definition of "constant-decl", and the branch mentioning
"constant-decl" from the definition of "declaration" at
<http://wiki.openoffice.org/w/index.php?title=Documentation/DevGuide/AppendixD/UNOIDL_Syntax_Specification&oldid=137490>.

Change-Id: I218626f02ebd46ee438bf5453ca1510c9ed8e5f0
2013-01-22 18:39:28 +01:00
f728eda909 unlink() doesn't work that well with URLs
Change-Id: I1d0cbd8b8cbbd3ea5c73d0cea6d9e354b1740c7c
2012-12-02 16:17:03 +01:00
299036996a [oneway] removal cleanup
Change-Id: I1d60bb4042753bd18475166054ad57dceb2fc97d
2012-11-30 16:33:30 +01:00
90eac3e697 API CHANGE remove [oneway] method attributes
Remove non-functional and broken [oneway] attributes from all idl
files. Change idl compiler to no longer digest such idl.

Change-Id: Ie14c5012beccb6242d7cd592d434a88091b695d1
2012-11-30 14:36:35 +01:00
44ea5d1414 Adding SAL_DEPRECATED_INTERNAL to an implementation function is pointless
...as there are typically no direct calls to it anyway.  What is apparently
needed is to decorate the cppumaker-generated headers instead:

* cppumaker obtains deprecation-information from the documentation strings in
  .rdb files.  As these are normally generated by idlc without documentation
  included (no -C), idlc got changed to nevertheless contain documentation
  consisting of just "@deprecated" in this case, to allow to easily tunnel this
  information to cppumaker always.

* The mechanism of parsing for "@deprecated" in documentation strings is
  somewhat crude, of course.

* For now, cppumaker only decorates C++ functions that correspond to UNOIDL
  interface attributes and methods.  More should be possible (but, e.g., being
  able to decorate a complete C++ class corresponding to a deprecated UNOIDL
  interface type depends on whether all platforms would accept
  SAL_DEPRECATED_INTERNAL at the same position in a C++ class declaration.

* This could also be extended to other languages than C++/cppumaker.

* Always using SAL_DEPRECATED_INERNAL instead of SAL_DEPRECATED for decoration
  is to keep things simple and our codebase working.  Improvements are possible
  here, too, of course.

Change-Id: Ia2917892f780d477652e4cd9f286588a6898c3f5
2012-11-23 14:04:51 +01:00
c0fb5ed758 add --with-system-ucpp
Change-Id: Ic322d1be23033049fa3b5cd60c00479bb6cae3ca
2012-09-27 22:45:03 +02:00
6189ffc7ed Fix bool -> byte coercion logic
Change-Id: Iab6dba9484fb5ddb8a8d4efcd46d7b9c8d1acca8
2012-09-26 13:31:45 +02:00
20b77f616a sal_Bool -> bool
Change-Id: I4fd6d247fdc0333ccdace4ebfa947c8d02e559bc
2012-09-26 13:31:44 +02:00
39c3a4d664 idlc: clear include file set in Idlc::reset():
Resetting the set between files reduces the size of the generated
offapi.d from 41M to 4.5M.

Change-Id: I221e6dfb75cbadb5d970f18eccfc85ffdb83ce6c
2012-09-05 15:07:29 +02:00
cf239da5c4 There is not need to allocate memory just for getting the 'indexOf'
a literal within a OUString.

Change-Id: Icc8e22c43f6ddca25cb284a3d45ab39680ad6d1f
2012-08-06 12:22:10 +01:00
7c10706845 idlc: do not use -I., deps need absolute paths
(regression from 63c508e3e86a140e35161c45d2be97779746f6cb)

Change-Id: I03ae2cf6fdb229e26d33ef4611a1495590f90df7
2012-07-20 19:56:17 +02:00
63c508e3e8 re-base on ALv2 code. Includes:
118568: switch to using ucpp
    Patch contributed by Juergen Schmidt
    http://svn.apache.org/viewvc?view=revision&revision=1209396
2012-07-18 09:29:19 +01:00
2c3aa4f3a5 remove malingering legacy RCS tags. 2012-06-28 19:59:06 +01:00
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
5394b379eb removed unused temporary rtl::OUString
Change-Id: I9d118a5fbe2306465d8bcdb9ddd0596588137e5e
2012-05-23 01:06:54 +09:00
34513fe619 WaE: avoid build break on Mac PPC/XCode 2.5
otherwise breaks with
/usr/share/bison.simple: In function ´int yyparse()´:
/usr/share/bison.simple:614: warning: comparison between signed and unsigned integer expressions
/usr/share/bison.simple:626: warning: comparison between signed and unsigned integer expressions
2012-05-06 21:02:52 +02:00
6f1a962490 disable GCC diagnostic #pragma on older GCC versions
Change-Id: Ib0c1ec649b4e391359ef41cebad501b297579557
2012-05-04 20:46:58 +02:00
3e0b2299ec gbuild conversion l10ntools module
Change-Id: I Iea9a77f19856dd870eb72fa57249f959cdd7000c
2012-05-04 09:42:22 +02:00
1bec43481e build: cleaning up previously converted idlc module
Change-Id: Ic90495f677dc42c0430492548deaa9f9b10e4d44
2012-05-01 07:29:06 +02:00
7de8936d08 WaE: Clang empty forloop body
Clang says:
stripped_scanner.ll:198:46: error: for loop has empty body [-Werror,-Wempty-body]
stripped_scanner.ll:198:46: note: put the semicolon on a separate line to silence this warning [-Wempty-body]
2012-04-23 14:16:33 +02:00
8c1e9c7dfd WaE: comparison of integers of different signs and unused functions 2012-04-22 01:34:37 +03:00
8c0a9bca42 idlc: make dependencies: handle removed include files:
Write dummy targets for included files, so the incremental build does not
break with "No rule to make target" if the included file is removed.
2012-04-14 21:07:13 +02:00
2273ce95c7 WaE: don't seem to need this pragma 2012-04-13 13:28:22 +01:00
3c9054eccf WaE: -Werror=parentheses 2012-04-13 13:22:44 +01:00
99b04ed2be WaE: declaration of 'rand' shadows a global declaration 2012-04-13 13:13:42 +02:00
bed6580ec3 gbuild conversion: idlc module 2012-04-13 13:07:50 +02:00