Commit Graph

217 Commits

Author SHA1 Message Date
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
e67c21ee06 Search for char instead of 1 char long string, when possible.
follow-up of a7674482254ee996b1c4fee60f3064778be369aa

Change-Id: I25f40c601454c092078307d931333af1bc1447ac
2013-06-29 09:53:41 +02:00
50e6713e40 fdo#43460 oox: use isEmpty()
Change-Id: If291a72d87001932c605755d628cecc088d50275
Reviewed-on: https://gerrit.libreoffice.org/4324
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-06-17 19:55:17 +00:00
0c0a9c3abb Remove redundant toplevel const
...that might be the reason the Raspbian-ARM tb broke.

Change-Id: I1c238f0bd70dd2237c66b479aa5eb79010f477ce
2013-06-15 12:44:21 +02:00
43b0577604 fdo#58819 VML export of ESCHER_Prop_fillOpacity
Change-Id: Ic50be88b484e5bfba60c5bd8dafb7e6da0b33c9e
2013-06-15 10:45:13 +02:00
98f90fdecc fdo#58819 VML export of ESCHER_Prop_gtextFont
Change-Id: Id0404405b41d5137e726670a959d5e314eb8f2ec
2013-06-15 10:45:12 +02:00
12322f5fd2 fdo#58819 VML export of ESCHER_Prop_fNoLineDrawDash
With this, the bugdoc is (correctly) no longer stroked.

Change-Id: Iaf00e17f2535ece2be09dc8ec0d383f2218a6050
2013-06-15 10:45:11 +02:00
559d194d80 fdo#58819 DOCX VML export: fix shape size for rotated shapes
The problem is that we wrote the size of the shape itself, while VML wants the
bounding box here. The WW8 export ignores the rectangle given in
EscherEx::Commit(), uses SdrObject::GetSnapRect() instead and later refines the
position by using the point got in WW8AttributeOutput::OutputFlyFrame_Impl(),
see PlcDrawObj::WritePlc().

Do the same in the VML export, i.e. ignore the Rectangle we get in
VMLExport::Commit() and use SdrObject::GetSnapRect() + the point given
in DocxAttributeOutput::OutputFlyFrame_Impl() instead.

Change-Id: I5adbdf205792c87f92c1ddf1cf674f87e11eb54e
2013-06-15 10:45:11 +02:00
a1dda85b46 fdo#58819 VML export of ESCHER_Prop_Rotation
Change-Id: I3deb8f914cabd58a284bef825092a6980b1f6310
2013-06-13 17:29:32 +02:00
175d28d564 fdo#58819 VML export of mso-position-*
mso-position-horizontal, mso-position-horizontal-relative,
mso-position-vertical and mso-position-vertical-relative

With this, the watermark in the bugdoc is almost in place, if you ignore
the missing rotation.

Change-Id: I8d3d834089e734654fcbbb0fb6166b4d7e01f80f
2013-06-13 17:14:06 +02:00
1f2e2563a6 fdo#58819 initial VML export of ESCHER_Prop_gtextUNICODE
Change-Id: I67b5dc102fc264d0a643620bbdc5796bdaa46d82
2013-06-13 17:14:06 +02:00
c7e237045d fdo#58819 VML export: handle objects anchored in the header / footer
Previously such shapes landed in the middle of section properties.

Change-Id: I7993eaa721e2b53d8adb1cbdee40992bbeb11416
2013-06-13 12:16:11 +02:00
4e5e40e4c6 In ShapeExport, use general com.sun.star.comp.oox.xls.ExcelFilter
...instead of its export-only part com.sun.star.comp.oox.ExcelFilterExport (for
which even a new-style service com.sun.star.oox.ExcelFilterExport has been
introduced recently, but all of this should probably go away again; that this
filter is used explicitly is probably a rare enough scenario to not warrant a
dedicated new-style service).

The modified code in ShapeExport::WriteOLE2Shape is triggered e.g. with a
Presetation, insert a Spreadsheet as an OLE Object, and save as "Office Open XML
Presentation (.pptx)."

Change-Id: Id2645972caaec5265eed645c9c6e2c308a4d079d
2013-05-31 18:11:29 +02:00
cd582f922b Resolves: #i119631# Teardrop shape cannot be shown correctly in pptx
* subversion/main/filter/inc/filter/msfilter/escherex.hxx
* subversion/main/filter/source/msfilter/escherex.cxx
[]check whether one shape is default shape of ppt by shape type
* subversion/main/svx/inc/svx/msdffdef.hxx
* subversion/main/oox/source/drawingml/customshapegeometry.cxx
* subversion/main/svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx
[]add definition and declaration for tear drop
* subversion/main/svx/source/customshapes/EnhancedCustomShapeGeometry.cxx
[]the content of tear drop shape which incudes "path, adjust value, handle"

Patch by: Ma Bingbing <jiazema@gmail.com>
Suggested by: Wang Zhe <kingwisemmx@gmail.com>
Found by: Zong Dongjun <zongdongjun@gmail.com>
Review by: Wang Zhe <kingwisemmx@gmail.com>

(cherry picked from commit 26218ac2472838d63485c3c6b4dc2f1aa0bdd0f6)

Conflicts:
	filter/inc/filter/msfilter/escherex.hxx
	oox/source/drawingml/customshapegeometry.cxx
	svx/inc/svx/msdffdef.hxx

Change-Id: I8347832bc842cca8b944c28e807af7f45a7da5b0
2013-05-31 10:53:10 +01:00
8079f40743 Make use of IsStarSymbol()
Change-Id: I7a2e3a6f11bbaaaff50e8163e4ce3e2583b1d03c
Reviewed-on: https://gerrit.libreoffice.org/4077
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-05-30 15:54:47 +00:00
a0f85534a7 be case-insensitive for open/starsymbol comparison
Change-Id: I7a342c809a723f5f9c03271c6145d9c367cea6de
Reviewed-on: https://gerrit.libreoffice.org/4015
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-05-27 15:42:33 +00:00
54fbbc20b8 respect element order in OOXML chart export, related fdo#63114
Change-Id: I591a63c38ab18b03a2f86428defbdac0cb96a1c0
2013-05-27 02:18:42 +02:00
6a043e9c0a Use the new type-checking Reference constructor to reduce code noise
Also create a Clang compiler plugin to detect such cases.

Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-22 10:44:29 +00:00
a986eddb9b fdo#46808, Convert oox.ExcelFilterExport service to new style
Service already existed, just needed an IDL file

Change-Id: I397296e5ad7b32febb63e74f8ee9a0db53ba5a81
2013-05-21 13:53:20 +02:00
d4d16d8a27 fdo#46808, Remove unnecessary XMultiServiceFactory member
.. and associated methods

Change-Id: Iec01b4615decc1616e405166088d7d1d844ac0ae
2013-05-21 13:53:20 +02:00
e84a04273b WaE on mac osx build
Change-Id: Ief28d2563b66754d00fdc09d6d68ea3a73aff22a
2013-05-19 10:45:48 -05:00
cb6d67c21f Spelling "separate" (etc) correctly is hard 2013-05-15 11:14:28 +03:00
ddb579666c -Werror=maybe-uninitialized
Change-Id: I320e08d7d83727a93e0644db80943bc2bb896222
2013-05-13 14:17:24 +02:00
1857688e1f Resolves: #i122208# introduce rtl::CStringHash and rtl::CStringEqual
unify the various c-string compares and hashes.

(cherry picked from commit b7e3470a154538a92f0a21b14e726d75723f4a92)

Conflicts:
	oox/inc/oox/export/shapes.hxx
	oox/source/export/shapes.cxx
	sal/inc/rtl/string.hxx
	sdext/source/minimizer/pppoptimizertoken.cxx
	svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx
	vcl/source/glyphs/gcach_ftyp.cxx
	writerfilter/source/resourcemodel/TagLogger.cxx
	xmloff/source/draw/EnhancedCustomShapeToken.cxx

Change-Id: Ib742744077bfb4d38a462d88b44bdef45601b4ae
2013-05-10 12:36:33 +01:00
09d486b897 data label export does not work with bar charts
Excel just removes the chart during import. Additionally we should work
on only exporting the data label information for points that really
contain data labels.

Change-Id: I80aef8effe27c729feb69c25c319ca129dc961a5
2013-05-06 01:36:23 +02:00
062b9f0bdc remove unnecessary explicit namespaces
Change-Id: Idb6bf5704a3b569ae4ae19d35526f19528ab63a6
2013-05-06 01:36:23 +02:00
6e2292b3cd map full transparent solid fill to no fill, fdo#64224
Change-Id: I9ec33b347647bfcd6c1411c4db7af51ca597dc8e
2013-05-06 01:36:23 +02:00
93abb2082a let us be explicit about default values
Different MSO versions behave differently in respect to the default
values. 2007 is not compliant to OOXML and is what our export filter
expects, 2010+ are compliant to OOXML and therefore our charts look
awful.

Change-Id: If301d878a1603ed9835884cfbb9ed9c902526ba0
2013-05-06 01:36:22 +02:00
a4b6f26148 another validation error in chart OOXML export
Change-Id: I2edd5cb877fdf66926483c866382480f7ae3d36f
2013-05-05 19:44:26 +02:00
d28d25d090 respect element order in OOXML chart export, fdo#59857
The chart part of the document passes validation now.

Change-Id: I52c946c0ad399038e5f9ffff08a117f2693c55b5
2013-05-05 19:44:26 +02:00
3ed3d39230 respect element order in OOXML chart export, related fdo#59857
Change-Id: Iecb47635cb8c854ec6c12a12f895972fcf099009
2013-05-05 19:44:26 +02:00
a927086f9a respect element order in OOXML export, related fdo#59857
Change-Id: I00bb173010419a47ee30c9d6ae1173bb1ea0e370
2013-05-05 19:44:26 +02:00
010f58c4ef overlap is only valid for the 2D bar chart, related fdo#59857
Change-Id: Ie17ef54a2b2f2058cef97dacd9110a3065f76f68
2013-05-05 19:44:26 +02:00
16010abe01 respect element order in OOXML chart export, related fdo#59857
Change-Id: Icd40ad5a1a428d6ae0d012b1896a9dd713a4e79b
2013-05-05 19:44:26 +02:00
e415e070d6 respect order of elements in OOXML chart export, related fdo#59857
Change-Id: I541e04d2f4a3b272894ceb67b4bd970e235b96a2
2013-05-05 19:44:25 +02:00
73740b2f75 fdo#60549 - pptx export presentation as well as draw shape objects.
Change-Id: Ibe6e0b9fa55bab7a7d02e55560c1db4c8ed84132
2013-05-02 11:23:48 +01:00
3dc2f24a5d we need to exclude scatter chart for data label export for now
Excel does not like our data label export and removes the charts during
import. I could not figure out what is wrong as the files are valid.

Change-Id: I92458803a48bff1436e7c47ca29d27e487c0642b
2013-05-01 20:29:19 +02:00
d54aa149bd better to use no overlay for now
We have no way to determine whether the lengend touches the chart area
so let us use no overlay for now. That should be much more in line of
the most use cases.

Change-Id: Idecb0113e47a3f7c925ff8c45238152406ce8954
2013-04-30 21:21:06 +02:00
0c58dc8655 only export c:SymbolSize if attribute is there
Change-Id: I4f167d1ec6998b27025450e9339d14d94c06e3c1
2013-04-30 21:21:06 +02:00
bb7dec2fa0 also export point size
The current formula size/250*7 is just a guess based on some test docs.
If someone has an idea how to translate them please tell me.

Change-Id: Ibdd27d52d545ac96882c128485c48a3116eb4467
2013-04-30 21:21:06 +02:00
2af3650659 export markers to OOXML
Change-Id: I0c2cabc8636b0988bdd779f002c1e7dc1e34b65b
2013-04-30 21:21:06 +02:00
99b7b41992 export a:noFill to prevent wrong default
Except for the data label issue my test file looks good now. There are a
few more small issues that I should take care of but it looks nice
already.

Change-Id: I4a6097baefe26088d0246f6335246a211ba143eb
2013-04-30 16:41:20 +02:00
f9cd73ebe1 remove a few more unused variables
Change-Id: I6c70c000f60e7e6e43bd068ccb98b693b80746f2
2013-04-30 00:17:29 +02:00
81b9d43167 c:varyColor is true by default in Excel
And another step closer to opening my test file correctly in Excel.

Change-Id: Ib6aa8ddb2f2792513c7263d86865e08fe5f1483d
2013-04-29 16:43:07 +02:00
5c19f86a07 OSL_TRACE => SAL_WARN in chartexport.cxx
Change-Id: I12ddd18c1b4476d42c097704c2af2d0af4e15a1e
2013-04-29 16:43:06 +02:00
6ddd7fccdc c:delete is true by default in Excel
One step closer to opening my simple test file correctly in Excel.

Change-Id: I1bfa76a46081ba478e44d8d90d8a91790a9a9ff3
2013-04-29 16:43:06 +02:00
e81d0c400c change order to allow validation of chart part
My simple test file is finally valid but is still now shown in Excel.
There must be another bug in our exporter.

Change-Id: Ib55e5b32edc3a556e9081b3008df539275dc289b
2013-04-29 00:15:01 +02:00
3812e99e93 another validation error with OOXML chart export
c:characters does not have an attribute val. The value has to be written
out as normal string.

Change-Id: Icd2c4034918bd223d0c8082a7d137e1ce79a9cfe
2013-04-29 00:15:01 +02:00
672398d84d order of element matters in OOXML export
this fixes one validation error with documents containing charts

Change-Id: I879963484b1cc00322e8c79bf77dfbbf91869587
2013-04-29 00:15:01 +02:00
33671ee413 export for error bars to OOXML, fdo#62312
This does not work yet as we have several validation errors in our
exported OOXML chart doc. I have to clean them up before the documents
are accepted by Excel.

Change-Id: I0bba64a9c6cab489199c8e6f04158fea7b953d0a
2013-04-29 00:15:00 +02:00