e67c21ee06
Search for char instead of 1 char long string, when possible.
...
follow-up of a7674482254ee996b1c4fee60f3064778be369aa
Change-Id: I25f40c601454c092078307d931333af1bc1447ac
2013-06-29 09:53:41 +02:00
61fd1d2e78
fdo#62699 remove rsc/inc/vclrsc.hxx
...
Change-Id: I8a90bfcfff904d42a529644ae7b6f03d0ac762eb
2013-06-28 06:55:38 +02:00
51daa4de4f
fdo#43460 sd,rsc,ucb,sdext: use isEmpty()
...
Change-Id: I7a7a77c26b74078f7fc160fbaa1c8d4e912b844e
Reviewed-on: https://gerrit.libreoffice.org/4442
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2013-06-24 21:44:24 +00:00
96c2986dd4
Quiet cppcheck
...
Change-Id: Ib860b6dc3b7ace5f737d283778827bfb0783b362
2013-05-16 21:57:57 +02:00
56fa2d1bed
Revert "coverity#983096: Resource leak"
...
This reverts commit 039bfd3e517f75cf99eb8eb105d3b83692f6e484.
2013-05-08 10:48:10 +01:00
039bfd3e51
coverity#983096: Resource leak
...
Change-Id: I91c1d505ef0b0eb442bf76e4da66c95fa0e1bb2d
Reviewed-on: https://gerrit.libreoffice.org/3818
Reviewed-by: Noel Power <noel.power@suse.com >
Tested-by: Noel Power <noel.power@suse.com >
2013-05-08 08:27:08 +00:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
876c619b94
new module i18nlangtag
...
Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.
This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.
Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
2013-04-05 19:10:48 +02:00
1fa455b396
ditch unused LANGUAGE_USER[1-9]
...
Change-Id: I5a3b2b27fa2a7ad22cab2ae6d833707f9e490f27
2013-04-03 21:19:25 +02:00
ef291d99fb
rsc with language tags
...
Change-Id: I5401a9bcbd1e359ef62e8d667edf6ead1479ce46
2013-04-03 21:19:24 +02:00
f8e697abc3
correct number of format operands for fprintf
...
Change-Id: I4fbfd3cacaa87ed1a8faa123a269d82f82ba22da
2013-04-03 21:19:24 +02:00
4653d73c57
fix extension replacer (rsc)
...
Change-Id: I0808aeedf87fd181380077f5cfd7b12dc3b33ef3
2013-03-27 15:46:58 +01:00
49a89c84db
stop uninitialized memory leaking into resource files.
...
Change-Id: I8659426dd4ea0c13c8ed839ef5cfb686e6648042
2013-03-27 02:24:25 -07:00
aa753f01ba
-Wunused-macros
...
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
fee08758d1
fdo#39445 writing out tools/fsys.hxx (rsc)
...
Change-Id: Iacab9b8a16d8278ae9a41249d36ca1aaad2d5794
2013-03-27 09:33:01 +01:00
73ff49f47d
remove unused functionality from Resource Compiler
...
and remove ASCII art comments and other useless comments
Change-Id: Iafa5eb5aa421b38b325bdc7cea6045b43a5c582a
2013-03-27 09:33:00 +01:00
488e6875e9
remove external include guards
...
Change-Id: If5758e02baa8e019923355b6c97043b306223fdd
2013-03-25 19:58:16 +01:00
e902022d4b
Revert "replace DirEntry to osl::FileBase in a few cases in rsc"
...
This reverts commit 7540bc8e105e114d4aecb1ed3f3044e5ce8a6fc6.
Conflicts:
rsc/source/rsc/rsc.cxx
Change-Id: I7f89f7bf07f68e053d29283f659241aca8e48eed
2013-03-25 21:44:02 +01:00
89e17604d1
remove unnecessary 'using' lines
...
Change-Id: I7efc18ac16223f83bb9839a76643291f7334ef91
2013-03-25 09:23:46 -07:00
7540bc8e10
replace DirEntry to osl::FileBase in a few cases in rsc
...
Change-Id: Ic0d9fee77891dae03c121f4b48ee9da89730d1aa
2013-03-25 09:23:44 -07:00
fa545023ad
Introduce HAVE_GCC_PRAGMA_DIAGNOSTIC_{MODIFY,SCOPE}
...
...replacing hard-coded GCC version checks. Those checks that guard
#pragma GCC diagnostic ignored "-Wnon-virtual-dtor"
appear relevant only for GCC itself, not Clang (which used to fail the old
guards because it typically announces itself with a rather low
__GNUC__/__GNUC_MINOR__ version), see 6e67c03dc0225fc66343546b14e902b9d238b1a3
"Enable -Wnon-virtual-dtor for GCC 4.6"
Change-Id: I6bfa4d5caa6192e7a203ce829682bf6bb8d61a1b
2013-03-25 08:52:54 +01:00
3b5497f258
Revert "RscCmdLine: don't use obsolete DirEntry"
...
This reverts commit 3b00a7f87b8d428dc8c3d1d0ddb84b74bb2343d4.
Breaks the build on windows, requires adapting
RscCompiler::GetImageFilePath() to match.
2013-03-21 20:35:45 +01:00
5c4bf7a602
stop uninitialized memory leaking into resource files.
...
Change-Id: Ifb74ce0c60e0d0796d5d04a67e9d58721b58593c
2013-03-21 15:22:12 +00:00
3b00a7f87b
RscCmdLine: don't use obsolete DirEntry
...
Change-Id: I49b2ca742da96ced5326b3e31f3cec35bfaabcc2
2013-03-21 16:11:03 +01:00
768dee2c32
fdo#39445 writing out tools/fsys.hxx (rsc)
...
removed unused includes from rscdb.cxx, start.cxx and rscclass.cxx
Change-Id: I6f7e54c9f494b7b40a0cf30f13100073b9c37f17
Reviewed-on: https://gerrit.libreoffice.org/2853
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2013-03-19 20:45:03 +00:00
5bb4a2ba1d
further OUString cleanup
...
Change-Id: I19954ee5976cb881a5fe73a889c8e04a19b14eb6
2013-03-19 14:18:10 +01:00
8b27d78b4a
automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
...
Done with a perl regex:
s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms
Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-03-19 09:00:26 +00:00
3991eaf556
reduce whitespaces between include and filename
...
Change-Id: I15f6ad0a760a28cbac53f99ba4d14ff5c24ce005
2013-03-19 01:26:45 +01:00
de99bcde8a
fdo#39445 writing out tools/fsys.hxx
...
removed unused <tools/fsys.hxx> include from gengal.cxx
changed file copying to sal version in htmlex.cxx
rewrote OutputFile in rsctools.cxx
very minor change in rsc.cxx - instead of creating an empty DirEntry
and getting its path, just used "."
Change-Id: Ifd57d73847ff271bcb64b12a26a564acc051fcef
Reviewed-on: https://gerrit.libreoffice.org/2680
Reviewed-by: Andras Timar <atimar@suse.com >
Tested-by: Andras Timar <atimar@suse.com >
2013-03-14 10:36:24 +00:00
5f606b0a5b
coverity#705676: fix memory leak
...
Change-Id: Ibae1a0d073249ecfbfee0f73473d66bbf2602aff
2013-03-09 17:59:12 +01:00
6583305dd7
simplify compareTo (now correct)
...
Change-Id: Ia4fd2f54d0bda71d472f46949500c0b23ff8e1b7
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2013-03-08 13:04:13 +01:00
3d4723f80a
Revert "simplify some compareTo"
...
This reverts commit 19020191cbf3e3c7a7bf98d0958d86d931ae687b,
s1.compareTo(s2, length-of-s2)
is *not* equivalent to
s1 == s2
2013-03-08 09:03:10 +01:00
19020191cb
simplify some compareTo
...
Change-Id: Ib63cfac8b5f129f31534020fd634750e846e3b98
2013-03-08 05:42:05 +01:00
a6b9173005
fdo#60148 Clean up warnings from the Clang compiler plugin
...
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Eike Rathke <erack@redhat.com >
2013-03-06 12:59:26 +00:00
ce33f85ffd
sal_Bool to bool
...
Change-Id: I8c554fb3faead41c974af9c2a89728bd0bdf5eb6
2013-03-04 23:14:41 +09:00
26e37ca4c7
doubled includes
...
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04 13:58:40 +01:00
2f00b691c0
this dmake file in rsc was inadvertently added
...
Change-Id: Ie8a8a8a4a82e3ca0175ac5a0275da6ca1474fa5d
2013-02-26 14:43:02 +00:00
94477cb5fb
Fix typo accessable/accessible
...
Change-Id: I2f6d00a6361243a52a593acaaf2bf624d8a2730e
2013-02-23 17:29:22 +01:00
e25cdb40df
Reduce scope
...
Change-Id: I8e62de343021942fd80ed6846bfa5c0b0ee4a347
2013-02-13 18:45:46 +01:00
56f4d7dc9d
Some cppcheck cleaning
...
Change-Id: I8609949377181f8edb30ac07b2791cfcd079fc7d
2013-02-12 21:24:25 +01:00
0c1a37e603
Some cppcheck cleaning
...
Change-Id: I74ff9d8d116ebfe9ebc302c79a3763eda9c1250f
2013-02-12 16:08:44 +01:00
b3e64c3708
Some cppcheck cleaning
...
Change-Id: I1b80271473166755e8f0afaa7af8ffc7bea394b3
2013-02-06 07:58:08 +01:00
b8d4b8656f
Some cppcheck cleaning
...
Change-Id: I7217ab7500de5d8220b85e56aceb6e843bd0769f
2013-01-27 23:11:41 +01:00
63bcb139b9
Replaced O[U]String::valueOf( static_cast<> ) with O[U]String::number()
...
Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de
Reviewed-on: https://gerrit.libreoffice.org/1784
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Luboš Luňák <l.lunak@suse.cz >
2013-01-21 15:04:17 +00:00
a2296128cc
Some removal/replacement of the String/UniString with OUString
2013-01-09 10:54:19 +01:00
d72a0b5c61
Check for __GNUC__ instead of GCC in sources
...
We still have checks for $(COM) being GCC or MSC in makefiles, of
course. But there is no reason to pass -D$(COM) to compilations.
Checking the built-in compiler-specific macros __GNUC__, _MSC_VER
(etc) is the right thing to do.
Change-Id: Ia961a29ba74e2c4977e5300a92318f38104c6592
2012-12-27 13:38:15 +02:00
a3ce60eb3c
We only support MSVC 2008 (_MSC_VER 1500) or later
...
We can drop or simplify many conditionals.
Change-Id: I37e820e515cc09845c30b62c89ddb3b6ff370f97
2012-11-28 20:53:40 +02:00
6a9f0cdc02
use LanguageTag
...
Change-Id: I9aa7ff4a1aedee6fa029e3d94301788be1a3761a
2012-11-20 17:44:07 +01:00
13cca3de54
incorrect body alignment
...
Change-Id: Ie62113f0018e71c984845f1684a4876809b901c4
2012-11-20 16:30:02 +01:00
0465fa4a8c
unused variable
...
Change-Id: Id6de037a510b129799c89dc4a7fdb105ac006b2a
2012-11-20 16:30:02 +01:00
