Commit Graph

1121 Commits

Author SHA1 Message Date
710f41b7ae Clean String and sal_Bool in tools
Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655
Reviewed-on: https://gerrit.libreoffice.org/4627
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-30 04:58:49 +00:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
5cb2e3104b remove toolkit/unohlp.hxx hack
Change-Id: Idb9971d848870f4d00dbf77e80e48bf7dfde8913
Reviewed-on: https://gerrit.libreoffice.org/4601
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28 11:49:28 +00:00
f384875119 #119467# Form controls cannot be saved into .ppt file in AOO3.4
Reported by: Du Jing
Patch by: Jianyuan Li
Review by: sunying
2013-06-26 16:45:28 +01:00
51daa4de4f fdo#43460 sd,rsc,ucb,sdext: use isEmpty()
Change-Id: I7a7a77c26b74078f7fc160fbaa1c8d4e912b844e
Reviewed-on: https://gerrit.libreoffice.org/4442
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-06-24 21:44:24 +00:00
02d58eb6e0 cppcheck: fix uninitMemberVar + remove macro
Change-Id: Ifce036595a8a5e95406c8a1752dbb77cfe735a3e
2013-06-16 21:30:09 +02:00
d959ff60f0 Related: #i119536# removed code no longer needed after fix of that task
(cherry picked from commit bcc6f1762eda8ac5290eb10b4ad47a249c9b5f51)

Conflicts:
	sd/source/filter/eppt/epptso.cxx

Change-Id: I42bce7ff99264d3bd1e3e5dbdf8eda87a05361a7
2013-06-12 17:16:53 +01:00
c0e458bda8 Replace String with OUString (sd)
Change-Id: I6916e81828ef7225f9f70217cbeac83b3a70b9b3
Reviewed-on: https://gerrit.libreoffice.org/4221
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-06-12 08:49:42 +00:00
dbc7c605d6 Resolves: #i121183# enhance export of ppt hatch masterpagebackground
(cherry picked from commit 60f299f255a8a2fd2c4aabde6933d4388af3643b)

Conflicts:
	filter/source/msfilter/escherex.cxx
	sd/source/filter/eppt/eppt.cxx
	sd/source/filter/eppt/eppt.hxx

Change-Id: I62d772ab67ed03bfa964040bd07b3684cf2dee8f
2013-06-11 11:30:59 +01:00
db979ee28a fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*

Change-Id: I9a7cce0d3abef42c9d9d0ad56609d94d504854cb
Reviewed-on: https://gerrit.libreoffice.org/4128
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-06-10 08:41:50 +00:00
e9ac56d4d9 Resolves: #i120768# slide content merged Master viewer content
* subversion/main/sd/source/filter/eppt/epptso.cxx

[]should drop the redundant presentation placeholder textbox when import to ppt

Patch by: Ma Bingbing <jiazema@gmail.com>
Suggested by: Wang Zhe <kingwisemmx@gmail.com>
Found by: Yan Ji <yanji.yj@gmail.com>
Review by: Wang Zhe <kingwisemmx@gmail.com>

(cherry picked from commit 691aff9ca443dbd8ad907b32b96c031dd9ffa829)

Change-Id: I1a1de0152feaacb449f2e2bad444d1bff9e7c4cb
2013-06-06 09:19:49 +01:00
60c8198fd9 WaE: comparison of integers of different signs
Change-Id: I603e636b1a93107dfa65a2759ee510c49e03347e
2013-06-06 08:01:25 +03:00
f3d27c66e1 Resolves: #i120967# table's virtual box becomes too small...
when saved as .ppt file

Reported by: Liu Ping Tan
Patch by: Ying Sun
Review by: Jian Yuan Li

(cherry picked from commit 36453dd6be67717b2a2385449f10141fcc3fac35)

Conflicts:
	sd/source/filter/eppt/epptso.cxx

Change-Id: I66ec5b8569c538e3571fa08670d053130939dc02
2013-06-05 16:41:23 +01:00
dcbaf7c253 remove unused componentcontext.hxx includes
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-05 08:13:21 +02:00
9d0fcedaec Remove odd, unused com.sun.star.comp.ooxpptx service name
Change-Id: I746e1fa25137db786f82dda50bfa4b497e94cefd
2013-06-04 08:31:32 +02:00
3505f0e46c Revert "fdo#46808, Convert oox::PowerPointExport service to new style"
This reverts commit 02021163dbbcc8904da0b2138c8b53684dcc8ab4.  The filter
appears to be split in two (com.sun.star.comp.oox.ppt.PowerPointImport
implementation oox::ppt::PowerPointImport from include/oox/ppt/pptimport.hxx for
im-/export, for export calling com.sun.star.comp.Impress.oox.PowerPointExport
implementation PowerPointExport from sd/source/filter/eppt/epptooxml.hxx) for no
good reason, so the com.sun.star.oox.PowerPointExport new-style service is
supporting a hack that should rather be cleaned up.

Conflicts:
	offapi/UnoApi_offapi.mk

Change-Id: I875192a68a8e3458dbfd74b4981a6a2e86ce44d7
2013-06-03 15:33:39 +02:00
018c22d378 UniString::CompareToAscii(RTL_CONSTASCII_STRINGPARAM("x"))==COMPARE_EQUAL ...
...corresponds to OUString::startsWith("x"), not
UniString::CompareToAscii("x")==COMPARE_EQUAL.  Regression introduced with
5b26722ace02f71c79573b3795b2bf7b9412090f "Remove RTL_CONSTASCII_(U)STRINGPARAM
(sd)."

Change-Id: I116defec056ff1e2260a20ba5279180683eefd87
2013-05-31 11:01:19 +02:00
5b26722ace Remove RTL_CONSTASCII_(U)STRINGPARAM (sd)
Change-Id: I179208d5ffe94e95719c7c6d0ea4eb354141531a
Reviewed-on: https://gerrit.libreoffice.org/4107
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-05-31 07:25:26 +00:00
8079f40743 Make use of IsStarSymbol()
Change-Id: I7a2e3a6f11bbaaaff50e8163e4ce3e2583b1d03c
Reviewed-on: https://gerrit.libreoffice.org/4077
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-05-30 15:54:47 +00:00
a0f85534a7 be case-insensitive for open/starsymbol comparison
Change-Id: I7a342c809a723f5f9c03271c6145d9c367cea6de
Reviewed-on: https://gerrit.libreoffice.org/4015
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-05-27 15:42:33 +00:00
c05c16635b Resolves: #i119753# fix audio video object lost when save .ppt file
Reported by: Li Feng Wang
Patch by: Ying Sun
Review by: Jian Yuan Li

(cherry picked from commit fbb7e8d8957877922f2f3a971e88685589f43939)

Conflicts:
	filter/inc/filter/msfilter/escherex.hxx
	filter/source/msfilter/escherex.cxx

Change-Id: I545a9e95c23cfba0cc918c9c4243528570734b2d
2013-05-27 10:23:07 +01:00
28f2af669f Resolves: #i119866# ppt default outline area bullet lost
Reported by: Li Feng Wang
Patch by: Ying Sun
Review by: Jian Yuan Li
(cherry picked from commit 8d04823a6038d32f6ac9821925616da7c5cc44c9)

Conflicts:
	filter/inc/filter/msfilter/svdfppt.hxx
	sd/source/filter/ppt/pptin.cxx

Change-Id: I222003a9e8d474ebc4dd9bc83cdcceded88a79f4
2013-05-26 15:14:07 +01:00
88b8bd644e Resolves: #i119874 Fixed text alignment in RTL layout
This reverts commit 979def88090633bfee0e0445b19999a1dac71ed4,
this time manually confirmed that the import layout does change, but that it
appears to be all desirable changes

Change-Id: Iee5e5ebd16989f65569b02f8b4f6570985157dfc
2013-05-25 12:11:51 +01:00
979def8809 Revert "Resolves: #i119874 Fixed text alignment in RTL layout."
This reverts commit 54c679f481647890f18151f4db05cfc3eff5d98b.

pushed that too soon before verifying if it does what it says
it does
2013-05-24 20:58:32 +01:00
54c679f481 Resolves: #i119874 Fixed text alignment in RTL layout.
Reported by: Li Feng Wang
Patch by: Jianyuan Li
Review by: Andre Fischer
(cherry picked from commit 57fdcdd79d1682ee7d5e88fbab3803631496afa2)

Conflicts:
	filter/inc/filter/msfilter/svdfppt.hxx
	filter/source/msfilter/svdfppt.cxx

Change-Id: I6adae6d40ff106caeea2b9310a57228257d79404

Related: #i119874# Missing part of patch.

Patch by: Jianyuan Li
(cherry picked from commit a7dc3e8b82c87b138c973f1434717d634ed8dc67)

Change-Id: Icff3e1167ab780612ad47775aaa39c9baa99c70f
2013-05-24 18:55:27 +01:00
febce41648 Resolves: #i119458# fix master's subtitle is modified when save .pot template
Reported by: liupingtan
Patch by: Ying Sun
Review by: Jian Yuan Li(cherry picked from commit a19ed1cba504e1531df54de9131960f9dc2c94f9)

Change-Id: Ied47d7f1421d3e27d8c7ad6529234f188af23787
2013-05-23 15:19:10 +01:00
6a043e9c0a Use the new type-checking Reference constructor to reduce code noise
Also create a Clang compiler plugin to detect such cases.

Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-22 10:44:29 +00:00
02021163db fdo#46808, Convert oox::PowerPointExport service to new style
The service already existed, it just needed an IDL file

Change-Id: I1404f4f60abafd489ddfb7294affcc7ff33885ce
2013-05-21 13:53:21 +02:00
0982b526bf Resolves: #i120554# Shape Gradient MS2003 import/export Enhancement
Reported by: Jianyuan Li
Patch by: Jianyuan Li
Review by: SunYing

(cherry picked from commit 09c33de80a0e5fa321979e53bf88c4d17271eba8)

Conflicts:
	filter/inc/filter/msfilter/escherex.hxx
	filter/inc/filter/msfilter/msdffimp.hxx
	filter/source/msfilter/escherex.cxx
	filter/source/msfilter/msdffimp.cxx

Change-Id: I80a60af4862eb99523ea59e4f788b685d6de1fbd

WaE fixes: reorder initialization, handle all cases in switch, ...

(cherry picked from commit 350f294badf378806348e77e6a8ed0b5f1d5b77d)

Conflicts:
	filter/source/msfilter/msdffimp.cxx

Change-Id: I4f1bde463921d48d1e014d0521427eaa9294663e

Add default to switch statements to avoid compiler warnings.

Patch by: Jianyuan Li

(cherry picked from commit f1302af0d803ca969022e69bcf7deeb62459f789)

Change-Id: I4e78e3b565d5922d452d2cfd1bf473af1587d29b
2013-05-20 15:56:19 +01:00
578bd45644 Resolves: #i119551# Avoid grouping shapes on import from PPT...
under certain conditions.

Reported by: Li Feng Wang
Patch and review by: Ma Bingbing and Armin Le Grand
(cherry picked from commit f425d556504e055216d9402241ff598a97204509)

Conflicts:
	sd/source/filter/eppt/epptso.cxx

(cherry picked from commit 8c23e31acc61406103c1565960e4c5b391902754)

Change-Id: I7e610b754ff7215201bc1ac47d618869e4e8fe2b
2013-05-15 15:46:07 +01:00
d6bebd18b3 Revert "Resolves: #i119551# Avoid grouping shapes on import from PPT..."
This reverts commit 8c23e31acc61406103c1565960e4c5b391902754.

wrong one
2013-05-15 15:18:19 +01:00
8c23e31acc Resolves: #i119551# Avoid grouping shapes on import from PPT...
under certain conditions.

Reported by: Li Feng Wang
Patch and review by: Ma Bingbing and Armin Le Grand
(cherry picked from commit f425d556504e055216d9402241ff598a97204509)

Conflicts:
	sd/source/filter/eppt/epptso.cxx

Change-Id: I7e610b754ff7215201bc1ac47d618869e4e8fe2b
2013-05-15 15:06:10 +01:00
1a357b7394 fdo#64586: Fix incorrect import non-empty placeholders + unit test.
Change-Id: Ibcb61dfa12c67fd9f93713ba7eb93f947b122f07
2013-05-15 09:43:07 +02:00
9e0b99a78b Resolves: #i119740# Fixed export of fill property of animations to PPT
Patch by: Tang Meng
Review by: Andre Fischer
(cherry picked from commit c4c014f74afaa9ca1b31c750b0445cf3f34e61a6)

Change-Id: I5a57fed3b8ee13d88eaed6ed6e98a6d167f9fa89
2013-05-12 20:03:25 +01:00
cd086e9457 bnc#758621: Set presentation object as non-empty only if not a placeholder.
Based on work of Felix Zhang <fezhang@suse.com>, thank you!

Change-Id: I26c7cef17b9a5f3d73107b5c974983e58c347d52
2013-05-12 18:05:58 +02:00
acb2943c81 bnc#758621: We don't need this index for anything.
Worse, it prevents us to enter part of the code that we need to execute in
some (valid) circumstances.

Change-Id: I15084b5efa10fbd5cd0d42856c2745c93d6765da
2013-05-12 18:05:57 +02:00
4bba859817 bnc#758621: Kill unused aPlacementId, it is never set.
Based on work of Felix Zhang <fezhang@suse.com>, thank you!

Change-Id: I733a2b69d01f86bcaf0fa401671d475d9b4641a6
2013-05-12 18:05:57 +02:00
b5465ea163 Revert "bnc#758621: show preset texts in slide placeholder"
This reverts commit 95bb951826c7fbaafb055008416f4f1d5cfc95dc.

Mid-air collision :-)  I've been working on an improvement based on this patch
when Muthu pushed it - the following commits are based on the Felix's work,
thank you Felix!

Change-Id: I12d649219911815e6b97d62f4584fa4d258d8917
2013-05-12 18:05:26 +02:00
2af1f5691e resolved fdo#35756 import more than 64k HTML table cells
Enhanced EditEngine to be able to hold more than 64k paragraphs. Used
also in RTF import Calc and Writer, so that could benefit as well.

* changed all EditEngine,Outliner,... related paragraph index/count
  variables from sal_uInt16 to sal_Int32
  * sal_Int32 instead of sal_uInt32 to match accessibility API
  * matched some Outliner methods' paragraph parameters from sal_uLong
    to sal_Int32
  * containers capable to hold size_t nevertheless are limited to a
    maximum of sal_Int32
* changed definition of EE_PARA_NOT_FOUND and EE_PARA_ALL to
  SAL_MAX_INT32
+ added EE_PARA_MAX_COUNT and EE_TEXTPOS_MAX_COUNT to initialize
  ESelection with what previously were hard coded 0xFFFF all over the
  place
+ for similar reason added EE_TEXTPOS_ALL corresponding to EE_PARA_ALL
  to initialize an ESelection spanning all available text like
  aSel(0,0,EE_PARA_ALL,EE_TEXTPOS_ALL)

Change-Id: I62d1b9c399cd709a4f93dbac31b219a61c46ec00
Reviewed-on: https://gerrit.libreoffice.org/3838
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-05-10 14:01:38 +00:00
95bb951826 bnc#758621: show preset texts in slide placeholder 2013-05-10 18:10:46 +05:30
26d7485ab3 icoverity#705451: comparison of array against NULL
Change-Id: I544760548866d55807a3291a31b4ce948a751946
2013-05-09 23:29:45 +02:00
c3eb3de426 fdo#46808, Convert animations::Command to new style
The service already existed, just needed an IDL file

Change-Id: I5e6449522ce77c36df1857213bd028336c3354bf
2013-04-25 14:44:07 +02:00
6f0b59e364 fdo#46808, Convert some XMultiServiceFactory to XComponentContext
Change-Id: If7cc52ffeb35efe0969876a9822106b1fd958b10
2013-04-25 14:44:06 +02:00
8546c324ff Remove pass-through header file sot/inc/sot/clsids.hxx
Change-Id: I122669d4ffaf72fb1d5f6fccc98e8a648f31aa23
Reviewed-on: https://gerrit.libreoffice.org/3490
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 14:55:56 +00:00
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
f1efc98b45 WaE: format specifies type 'int' but the argument has type 'sal_uInt32'
Change-Id: I33f603df67db2caaeebec5fc6f5f6ee2341a0b8f
2013-04-19 00:30:10 +03:00
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
60fbefc615 fdo#60724 informations -> information
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
2013-04-15 04:49:39 +02:00
aac0ada991 Fix #i119545# Fixed import of master page layout from PPT.
Reported by: Li Feng Wang
Patch by: SunYing
Review by: Andre Fischer
(cherry picked from commit f7da26f51bfaddecd7b774bc237d6f5fa082e57c)

Conflicts:
	sd/source/filter/ppt/pptin.cxx

Change-Id: Ic946de22b3f7ab1d498e71f3d5752ad6f89e2de5
2013-04-08 22:12:06 +02:00
844e62d5ab Fix #119523# fix the indent and left margin attribute lost when save as .ppt
Reported by: liupingtan
Patch by: Ying Sun
Review by: Jian Yuan Li(cherry picked from commit 6fa2e38b9cd3ce0df5876d849bcba7d879a6e329)

Conflicts:
	sd/source/filter/eppt/epptso.cxx

Change-Id: I41150838d153c3b99e603924127787f5556ef383
2013-04-07 23:37:39 +02:00