51daa4de4f
fdo#43460 sd,rsc,ucb,sdext: use isEmpty()
...
Change-Id: I7a7a77c26b74078f7fc160fbaa1c8d4e912b844e
Reviewed-on: https://gerrit.libreoffice.org/4442
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2013-06-24 21:44:24 +00:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
ff140bb6b8
Remove StringMirror UNO service.
...
This was a kludge from back in the day when pdfimport was an
extension and could not link against office libs.
While at it, fix mirror method to handle unicode surrogates
correctly.
Change-Id: I3582a7870efdfea50446d3604a185025b1d5a196
2013-03-21 00:54:16 +01:00
8b27d78b4a
automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
...
Done with a perl regex:
s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms
Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-03-19 09:00:26 +00:00
dd3e879cfd
remove some trivial duplicates
...
Change-Id: Ie736cb6d5ff7f4d1998338f4a3a3a3b0a67c79ad
2013-02-25 19:34:36 +01:00
3eaa536ae4
sdext: fix loplugin warnings
...
Change-Id: I4bca280b352f1df40fe75658e418f2e0cb2430e8
2013-02-22 21:43:47 +01:00
07ee72672e
coverity: pass by const reference is more efficient
...
Change-Id: Iec40176a5dd567e667178f07fecd043fe0aa4344
2013-02-17 19:54:18 +01:00
c66ec11c41
coverity: pass by const reference is more efficient
...
Change-Id: I08cebe4aca8eaa5a2be8c319c2de20de10dbd2d3
2013-02-17 19:54:17 +01:00
1976b017c3
Disambiguation for MSC
...
Change-Id: I356af9cebf4779bd5bc4721b0e0e20d7ae4e307e
2013-02-14 17:24:33 +01:00
77fd448d09
Removed several useless macros: UNISTRING, USTR, USTR_ASCII, ASCII_STR, ASCII_STRING, CONST_ASCII, ASCSTR, ASCII, DEFINE_CONST_UNICODE, DEFINE_CONST_OUSTRING
...
Change-Id: I96d690bf9f9b319e9eeafcf218ec5ce87f21215f
Reviewed-on: https://gerrit.libreoffice.org/1954
Reviewed-by: Tor Lillqvist <tml@iki.fi >
Tested-by: Tor Lillqvist <tml@iki.fi >
2013-02-14 13:20:14 +00:00
460c55f620
Modify constructor, remove setters + unused define
...
Change-Id: Ibf878c44ae761e59a04b6d5023296c5918cbf85e
Reviewed-on: https://gerrit.libreoffice.org/1665
Reviewed-by: Noel Power <noel.power@suse.com >
Tested-by: Noel Power <noel.power@suse.com >
2013-01-14 18:32:38 +00:00
c047ef2bf7
Fix Possible inefficient checking for 'm_GlyphsList' emptiness
...
Change-Id: I65c30e751fc01b63a54aa9c31b4b2a792b795a79
2012-12-27 17:13:21 +01:00
0666e43c45
fdo#46808, use service constructor for i18n::CharacterClassification
...
Change-Id: I0499ad7de27b1539e97f01ab8aa0ef2d6713ae76
2012-11-05 18:05:00 +01:00
c0f865c9b5
fdo#46808, use service constructor for i18n::BreakIterator
...
Note that I found a pre-existing bug in linguistic/source/gciterator.cxx
but I was not able to fix it, because doing so appears to expose
bugs elsewhere!
Change-Id: I17fb9108d98a98d0ae13fe5a8e043d2db5b27a6a
2012-10-23 15:27:49 +02:00
b9d1006ebb
re-base on ALv2 code. Includes:
...
#i118662# remove berkeleyDB from module l10tools
Patch contributed by Oliver-Rainer Wittmann
http://svn.apache.org/viewvc?view=revision&revision=1213189
reportdesign: remove extra items from Help menu
Patch contributed by Ariel Constenla-Haile
http://svn.apache.org/viewvc?view=revision&revision=1201215
2012-10-02 12:15:41 +01:00
7d0e247862
-Werror,-Wunused-private-field (Clang towards 3.2)
...
Change-Id: Icb3d354ff73df2eea04f1248bb160c252f7a4f5b
2012-08-31 09:04:16 +02:00
79d386f001
removed unnecessary forward declarations of class
...
except moving 'class SfxStringItem' to cui/source/inc/acccfg.hxx
Change-Id: I11d3803ebcfa02658d376bacf28b3d6030ee9d1b
2012-07-07 10:09:22 +09:00
6b11a18071
Some cppcheck cleaning
...
Change-Id: I14cab3dfd26ac1568feef902b566873cecf049b9
2012-06-30 18:21:26 +02:00
ecf943247f
re-base on ALv2 code.
...
Change-Id: I8018d9b5fa01d1720c0392dc5fdc4a0656f25a35
2012-06-22 09:51:05 +01:00
b9042fad7c
re-base on ALv2 code.
...
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
cd18b8e313
fix invalid vector.push_back(vector.back())
...
The vector::back() does not return a value but a reference, hence this
is invalid.
Change-Id: I8624b649deb8fb4de0d1d8af1288068acc80cef2
2012-06-12 14:14:42 +02:00
0188ebf354
targeted string re-work
...
Change-Id: I88cdf9d4c3faab75a80ff72e4268748296a09e50
2012-06-02 13:45:57 -05:00
4139e6a208
target cppcheck index incrementing revert
...
Change-Id: I890dfe9fbd7b5a850daaa0d2b4d5040a5ddbefd7
2012-05-31 14:58:05 +01:00
bcb4defef7
Fix fdo#45848
...
regression from 5dd4f9ecb2f50cf76b44472e4438297b6c65184c
The change:
- if(m_GlyphsList.size()>1)
+ if(!m_GlyphsList.empty())
is incorrect, so change it back.
2012-04-21 20:49:04 +01:00
d6bc02f8c4
Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
2012-04-06 20:03:42 +02:00
6e67c03dc0
Enable -Wnon-virtual-dtor for GCC 4.6
...
...which has the necessary features to support it.
Change a lot of classes to either contain a protected non-virtual dtor
(which is backwards compatible, so even works for cppumaker-generated
UNO headers) or a public virtual one.
cppuhelper/propertysetmixin.hxx still needs to disable the warning, as
the relevant class has a non-virtual dtor but friends, which would still
cause GCC to warn.
Includes a patch for libcmis, intended to be upstreamed.
2012-03-14 13:32:02 +01:00
e24911bc95
use const_iterator
2012-03-07 08:46:48 +01:00
dba2d32d5b
gbuildize sdext
2012-03-06 10:26:33 +01:00
23af031b09
Fix typos in comments
2012-02-18 09:35:43 +00:00
c424b5dc32
Remove unused pdfi::PDFIProcessor::sortDocument(bool)
2012-02-13 15:20:42 +00:00
20370a163b
Remove unused pdfi::DrawXmlEmitter::GetBreakIterator()
2012-02-13 15:20:41 +00:00
7c704c78d3
Removed some unused parameters; added SAL_UNUSED_PARAMETER.
...
SAL_UNUSED_PARAMETER (expanding to __attribute__ ((unused)) for GCC)
is used to annotate legitimately unused parameters, so that static
analysis tools can tell legitimately unused parameters from truly
unnecessary ones. To that end, some patches for external modules
are also added, that are only applied when compiling with GCC and
add necessary __attribute__ ((unused)) in headers.
2012-01-21 15:21:16 +01:00
9892e4c8d9
Clang -Wunused-variable.
2012-01-16 13:56:40 +01:00
f19d269ab4
Fix for fdo43460 Part XXXII getLength() to isEmpty()
...
Part XXXII
Modules
sdext
2012-01-10 23:08:01 -02:00
cf58b6f81d
fix typo
2011-12-01 12:29:10 +01:00
443a7229f9
Remove uses of charAt
2011-12-01 11:10:28 +01:00
13673b71bc
Remove uses of OUString::setCharAt
2011-11-28 14:56:40 +01:00
dd896dd28e
remove include of pch header from sdext
2011-11-27 13:21:13 -06:00
d7829740dd
keep it simple, original won't compile except on msvc anyway
2011-10-04 15:53:58 +01:00
1e085b43c1
WaE: class has virtual functions, but destructor is not virtual
2011-10-04 17:12:05 +03:00
6671fa81db
Removed uses of rtl::O[U]String[Buffer]::operator sal_{char|Unicode} const *().
2011-09-27 20:22:03 +02:00
be6a8677a6
OSL_TRACE: Remove trailing newlines
...
Done with perl regex:
s/(\n\s*OSL_TRACE\(\s*\"[^\n]+?)\s*(\\n)+(\"[^\n]*\)\;\n)/$1$3/gs;
- removed trailing whitespaces and (multiple) newlines
2011-09-21 09:28:39 +02:00
1d7e004c1e
[cppchecker] deletion of unneeded variables
2011-09-06 22:41:10 +02:00
7685aa6025
Merge branch 'master' into feature/gnumake4
2011-06-19 12:55:08 +02:00
cbf5dc0276
CWS gnumake4: reimplement basegfx_s hack for new build system [hg:c943ed591aff]
2011-06-17 00:49:38 +02:00
d0e148f0a4
createFromAscii -> RTL_CONSTASCII_USTRINGPARAM
2011-06-13 11:42:01 +01:00
5dd4f9ecb2
inefficient emptiness check
2011-04-26 15:24:32 +01:00
761118f831
Merge commit 'ooo/DEV300_m103'
...
Conflicts:
jfreereport/java/flute/makefile.mk
jfreereport/java/libbase/makefile.mk
jfreereport/java/libfonts/makefile.mk
jfreereport/java/libformula/makefile.mk
jfreereport/java/libloader/makefile.mk
jfreereport/java/librepository/makefile.mk
jfreereport/java/libserializer/makefile.mk
jfreereport/java/libxml/makefile.mk
jfreereport/java/sac/makefile.mk
mysqlc/source/mysqlc_connection.cxx
mysqlc/source/mysqlc_connection.hxx
mysqlc/source/mysqlc_databasemetadata.cxx
mysqlc/source/mysqlc_databasemetadata.hxx
mysqlc/source/mysqlc_driver.cxx
mysqlc/source/mysqlc_driver.hxx
mysqlc/source/mysqlc_general.hxx
mysqlc/source/mysqlc_preparedstatement.hxx
mysqlc/source/mysqlc_resultsetmetadata.hxx
mysqlc/source/mysqlc_statement.hxx
sdext/source/minimizer/impoptimizer.cxx
sdext/source/pdfimport/config/description.xml
sdext/source/pdfimport/tree/drawtreevisiting.cxx
sdext/source/presenter/PresenterWindowManager.cxx
swext/prj/build.lst
2011-03-23 16:58:56 +01:00
891c720115
Move OSL_ENSURE(0,...) to OSL_FAIL(...)
2011-03-12 14:12:21 +01:00
530b835583
Move OSL_ENSURE(false,...) to OSL_FAIL(...)
2011-03-12 14:12:21 +01:00
