This fixes the saving / loading of RTL setting of the table, and changes
the UI behavior when you click the LTR/RTL buttons with table border selected
a bit.
Change-Id: I1abcebdad3cdb72307535f82d973eb52418f2787
... because SfxAbstractDialog::GetOutputItemSet() only contains the
items that have been _changed_ in the dialog.
Change-Id: Iaf20bb42b65e420fe4e7aff979378eff7b5e5df2
Set property to cell object if the cell has vertical property. And fix in svx
module by setting cell's vertical property.
Patch By: companycy
Found By: Shan Zu
Review By: jsc
(cherry picked from commit bb8bf7bde59c22776199e791b8cfcbf07992de8e)
Conflicts:
oox/source/drawingml/table/tablecell.cxx
Change-Id: I58bb1548617c4c1e231280a405d6071ea8813039
Enhanced EditEngine to be able to hold more than 64k paragraphs. Used
also in RTF import Calc and Writer, so that could benefit as well.
* changed all EditEngine,Outliner,... related paragraph index/count
variables from sal_uInt16 to sal_Int32
* sal_Int32 instead of sal_uInt32 to match accessibility API
* matched some Outliner methods' paragraph parameters from sal_uLong
to sal_Int32
* containers capable to hold size_t nevertheless are limited to a
maximum of sal_Int32
* changed definition of EE_PARA_NOT_FOUND and EE_PARA_ALL to
SAL_MAX_INT32
+ added EE_PARA_MAX_COUNT and EE_TEXTPOS_MAX_COUNT to initialize
ESelection with what previously were hard coded 0xFFFF all over the
place
+ for similar reason added EE_TEXTPOS_ALL corresponding to EE_PARA_ALL
to initialize an ESelection spanning all available text like
aSel(0,0,EE_PARA_ALL,EE_TEXTPOS_ALL)
Change-Id: I62d1b9c399cd709a4f93dbac31b219a61c46ec00
Reviewed-on: https://gerrit.libreoffice.org/3838
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
IMO Calling this method again is not required. The If Blocks returns
false when User Clicks "Cancel" Button in "Format Cell" Widget,
IMO on Cancel Their is no need to Update the table. And on Ok
SetAttrToSelectedCells method is called which inturn calls
UpdateTableShape() method.
Change-Id: I2bb0bb616cc978717a1494e01f257631aadd613c
Reviewed-on: https://gerrit.libreoffice.org/3391
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
On Insert before, the reference column whose size is going to be used for
newly created column(s) is wrong. As the new columns are inserted before the
reference column, the reference column moved to the new position by no., of new
columns i.e (earlier+newcolumns).
Change-Id: Ib52e3633aecb1220cdf709058391361376dc5f00
Reviewed-on: https://gerrit.libreoffice.org/2958
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
It turns out this is not actually a performance problem but an oversight
in implementation (or a bug, if you want .-)
Every manipulation with a table (e.g., move, resize; actually even a
selection of the table) leads to creation of a full copy of the table
(SdrObject::getFullDragClone()). One of the actions the table copy impl.
does is to call sdr::CellProperties::SetStyleSheet() on every cell of
the new table. CellProperties is derived from
sdr::properties::TextProperties and CellProperties::SetStyleSheet() just
passes the call to TextProperties::SetStyleSheet(). This is where the
trouble begins :-)
The SDR representation of a table, SdrTableObj, is derived from
SdrTextObj. Because of that, SdrTextObj needs to be able to contain more
than one SdrText (because a table needs one for every cell). This is
handled correctly by TextProperties. But, because there is no SDR
representation of a single cell, CellProperties uses the SdrTableObj as
the SDR object it works on. Therefore TextProperties::SetStyleSheet()
processes all SdrText objects of the _whole table_, not just a single
cell. And this is repeated for every other cell...
Change-Id: Iab2e2d0e1e8038710645c0bd24666e6032b0a003
Done with a perl regex:
s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms
Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files
svx/source/dialog/hdft.src
Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml
Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
The table in impress is drawn under the rectangular are, on Selecting
the table it was only selecting the rectangular area and not the cells
inside, Making the layout to be as RTL which was mirroring the table.
But, We need the table to be in RTL Writing mode and not mirroring the
table. Now on applying my patch, If table is selected, it will select
the entire cells inside which is the actual table and the functionality
works fine.
Change-Id: I9d6bdde5019322488be66fa89a6488d348b2cf44
Reviewed-on: https://gerrit.libreoffice.org/1964
Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
i) Resolves fdo#59889 formatting in dragging edge of RTL table resizes column width of the next column instead of current column.
ii) prevents resizing the whole table on dragging edge
In NxN LTR table vertical edge responsible for resizing the column x(x=0 to N-1) is, Edge x+1. But, in RTL table
vertical edge responisble for resizing the column x(x=0 to N-1, but from right to left)is, Edge x.
Use (nEdge-1)instead nEdge-- to avoid conflicts.
Change-Id: If412b443ec8f82942ff80ba3aec24a9bfc053ac9
Reviewed-on: https://gerrit.libreoffice.org/1979
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
When writingmode is set to RTL, the table is start drawn from Last column
to first column. There is no problem with left&right lines, Because these
are not depends on the LTR or RTL writingmode. But the bottom & top line
depends on writing mode. As these two lines are drawn from previous cell to
next cell(left to right) the nX value should be nX-1 in RTL writingmode.
Change-Id: I3e21c7dd469ed5ba29e66f79da471b662632182e
Reviewed-on: https://gerrit.libreoffice.org/1834
Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
The function getHorizontalEdge contains more function calls to the
getRowCount(). Instead we store the return value of getRowCount()
value in a const integer varible nRowCount and use it.
Change-Id: I3e1460913099d1060d5005329e0b63e5ebcd362c
Reviewed-on: https://gerrit.libreoffice.org/1777
Reviewed-by: Radek Doulík <rodo@novell.com>
Tested-by: Radek Doulík <rodo@novell.com>
The problem was in calculating the cell area, the width should be
subtracted to Right end of cell instead it was adding width to Left
end of the origin cell
Change-Id: I3f31e0c4e0acae84ab5052823fc49932255137d3
Reviewed-on: https://gerrit.libreoffice.org/1686
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
