Commit Graph

2570 Commits

Author SHA1 Message Date
d70786a761 Revert "resmgr: bInUse is useless"
This was pretty lame. It's static. To be sure revert it.

This reverts commit 504499ad9f17be5350b878fa99e814612eaffb5f.
2013-06-30 20:46:58 +02:00
504499ad9f resmgr: bInUse is useless
Change-Id: I619d5d1ff9f6242be652674e4df54ad5c5ddc017
2013-06-30 20:28:58 +02:00
ea862e1ed0 WaE clang unhappy with an ambiguous if/else
Change-Id: I1e419793454ad5401a2d55a2c709bab08f4cf053
2013-06-30 02:21:31 -05:00
710f41b7ae Clean String and sal_Bool in tools
Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655
Reviewed-on: https://gerrit.libreoffice.org/4627
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-30 04:58:49 +00:00
9e8e5568e2 make this more resilient to stream problems
The metafile stream read in ooxmlexport test for fdo51550.odt is broken
for some reason, so mnTotalSize is not initialized. That means that we
try to seek by an arbitrary value in the destructor.

Change-Id: I3bd5ef3708c816fc8a749b446cecf98c3aa52f65
2013-06-20 12:43:59 +02:00
733d88433c fdo#43460 tools: use isEmpty()
Change-Id: I832473cab555d8ac5c6b2a47d51124ac63e996e9
Reviewed-on: https://gerrit.libreoffice.org/4333
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-06-18 17:15:41 +00:00
ce959ab7ce mingw64: use the right integer sizes on win64
Change-Id: Idb263ad369d2dad4fe4de924f2b2404a0fcf62d3
2013-06-10 14:03:34 +02:00
2cb247a12d fix file and lineno info for DBG_UNHANDLED_EXCEPTION
which I broke in commit 863d38fbfa4fb4861e476828c46410602100919e
"move DBG_UNHANDLED_EXCEPTION out of line"

Change-Id: Ic30e985cc356d81013ced1ce74ec6c78469d9882
2013-06-10 10:20:45 +02:00
dbd675df91 Some "cast from ... to ... loses precision fixes"
Change-Id: Ib1d827bfa224e8708fd1e41b1ad213bcfef9a012
2013-06-04 15:19:09 +02:00
c1acf1d72e Resolves: #i115630# secured OutputDevice::ImplDrawHatch in vcl
and PolyPolygon::Optimize in tools to useful fallbacks when working on
PolyPolygons (what they do *not* support)

(cherry picked from commit dbe489ab9766d96c5cafb079bc4778103bded783)

Conflicts:
	vcl/source/gdi/outdev4.cxx

Change-Id: I5d2374ec95702cb0cab29d2e82710d4aa29fa823
2013-05-23 15:19:11 +01:00
6bf00f0f94 fix for linking
caused by my commit
863d38fbfa4fb4861e476828c46410602100919e "move DBG_UNHANDLED_EXCEPTION out of line"

Change-Id: Idfd84d987ba9151ba476ce0516a9e5fbdb2003ec
2013-05-21 13:53:21 +02:00
863d38fbfa move DBG_UNHANDLED_EXCEPTION out of line
makes it easier to set a breakpoint on it.
Plus it's getting a little big to be a macro.

Change-Id: I2827aa3618ba966fbc85a4a56e0e794a55630730
Reviewed-on: https://gerrit.libreoffice.org/3988
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-21 10:02:39 +00:00
abb6f47bd3 Secured some places where PolyPolygons were created
using a all-points count and a all-points array

(cherry picked from commit 8ee49906f04106317997e9ca3bb890870816e274)

Conflicts:
	svtools/source/filter/wmf/enhwmf.cxx
	svtools/source/filter/wmf/winwmf.cxx
	tools/inc/tools/poly.hxx
	tools/source/generic/poly2.cxx

Change-Id: I57f7f08d8dd87c83c30ab2d16ca22b772b2bd834
2013-05-19 14:47:38 +01:00
cd9d1bdf5e resolved fdo#63805 max day of month of the intended month
Since 6619955e72c1c2f29a32e82478d19147c0d7610a Date::GetDaysInMonth()
operates on the normalized value that corresponds to the actual values
set at the Date instance, obtain and set number of days for the intended
month instead of using the rolled-over date.

Change-Id: Ia6b007675104f8e134b278f216c3bb48b72f061c
2013-05-17 14:13:36 +02:00
11fd73acce SolarMutex does not belong into the URE interface
...so move it from osl/mutex.hxx to its own comphelper/solarmutex.hxx.  It looks
like a newbie mistake that 59e7685d8d812ee8773f57475cbe3aa2a0bdfc81 "Create an
abstract interface to be used to implement a SolarMutex" put it here in the
first place.

I do not consider this an incompatible change really, as no external URE client
code should have used SolarMutex anyway.

(Also included some clean up, like removing unused
{Clearable,Resettable}SolarGuard, and spelling out SolarGuard in the few places
it is used.)

Change-Id: I121ffb5b7cefbc19e88b5405e5a85ffc895be852
2013-05-14 14:41:54 +02:00
6b5523d1d7 Resolves: #i115917# Better conversion of C1 and C2 bezier curve points
Patch by: osnola
Review by: alg

(cherry picked from commit 76741df0b60b9157710f8e66720275749dbf98bd)

Conflicts:
	tools/source/generic/poly.cxx

Change-Id: I0de15a92e68b766258e285ed17365816064da141
2013-05-13 20:47:48 +01:00
86b73eeef4 fdo#63154: Remove _CL and _LF from solar.h
And use RTL_CHAR_{CR,LF} from rtl/string.h

Conflicts:

	vcl/source/app/dbggui.cxx

Change-Id: I05b0325006845e48eb5483485a9042aa7b0cd22a
Reviewed-on: https://gerrit.libreoffice.org/3740
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-05-09 09:49:15 +00:00
3c38b7727a zlib: remove ExternalPackage_zlib
Change-Id: I5bce88b2044279a6563fd68c35f9c1ac824c8850
2013-05-08 23:34:26 +02:00
2092f8810a Show only filename in "Recent Files" list
As discussed here: http://nabble.documentfoundation.org/Libreoffice-ux-advise-Recent-files-dropdown-td4052945.html#a4052996

The changes are (inspired by Gedit):
* Display only the filename, not the (abbreviated) path
* Show the protocol name before the file, if not local (e.g. "ftp: myfile.odt")
* After the keyboard shortcut (a number from 1 to 10) display a '.' instead of a ':' (because the protocol has a ':')
* FIX: Display whitespace as whitespace, not "%20"

Change-Id: I47472c901aa866adb76c7c7ab36bc871f82ad8df
Reviewed-on: https://gerrit.libreoffice.org/3700
Reviewed-by: Jan Holesovsky <kendy@suse.cz>
Tested-by: Jan Holesovsky <kendy@suse.cz>
2013-05-02 09:04:18 +00:00
1b14676b5f redo fix for fdo#64078
use std::abs instead of labs

Change-Id: Icb09fb1715d4795c718773a37e66947d67019bb7
2013-04-30 14:18:33 +01:00
38d7278e38 fix for fdo#64078
Change-Id: Ib8c70b0074485ccd8bf6095c070610fe90e22d4a
2013-04-30 14:07:51 +01:00
72e5d0c8fb Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-30 13:34:06 +01:00
ec8617568f Bin ugly (ab)use of preprocessor in headers
The time when it made sense to use "clever" #ifdefs to, for performance or
compiler reasons, conditionally bypass private parts of a class declaration
passed a decade or longer ago.

Still more of this in sw and sc. People working on those modules might want to
do it too, or not.

Change-Id: I1053139ca5e5e2631f7b22d99d3bada54fc337be
Reviewed-on: https://gerrit.libreoffice.org/3627
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-27 09:28:37 +00:00
1cc9bbfd57 gbuild: drop empty use_packages calls
Change-Id: I8e9f70eb5d929c98b4379416c2259a74e31d587f
Reviewed-on: https://gerrit.libreoffice.org/3503
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24 05:18:15 +00:00
c042cd05e9 gbuild: drop uses of removed packages
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac
Reviewed-on: https://gerrit.libreoffice.org/3502
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24 05:18:03 +00:00
6c7659b584 move URE headers to include/
Change-Id: Ib48a12e902f2311c295b2007f08f44dee28f431d
Reviewed-on: https://gerrit.libreoffice.org/3499
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24 05:17:10 +00:00
b9337e22ce execute move of global headers
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details

Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
2013-04-23 22:20:31 +02:00
62badf3828 Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-22 09:37:38 +01:00
609cb4b332 we want the int. overloads of abs() here
Change-Id: Ie82c51f65a2a0e13d6d30c85a23286574fd50b90
2013-04-20 16:27:19 +02:00
699a22fd49 Include <cmath> for std::abs()
Change-Id: Id94260d41e821386e2c0aef67075658bee7fd49f
2013-04-20 16:09:14 +03:00
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
5df981a2a2 tools ::Time: change constructor to fixed-length integers
Change-Id: I20180cda1a28f898f487aff605796077d3418be3
2013-04-19 17:27:10 +02:00
877f55490f Wrap large values in SAL_CONST_INT64
Change-Id: I9a263e2232d63e5794f757cab39b93e13c7d159f
2013-04-19 17:08:08 +02:00
ec49915442 Wrap large values in SAL_CONST_UINT64
Change-Id: I865808911043a61de5c4209fa889dbff7c8baf28
2013-04-19 17:05:55 +02:00
6e7cec47f0 Presumably "call clock" should be "wall clock"
Change-Id: I7bcdfccc17de7057cc47720bd6ce78345f2d6d7c
2013-04-19 11:09:26 +03:00
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
70b45b2f55 Move {pre,post}x.h to where {pre,post}mac.h and {pre,post}win.h are
Change-Id: I561aa6cc1de7ed6128d25c82cd493d5d5718e052
2013-04-16 23:12:49 +03:00
1264480bc3 fdo#60724 correct spelling
Change-Id: I3d978cb657647b4a4e9709258c6a6a4ac1d339a9
2013-04-15 05:39:31 +02:00
c32b6be06b fdo#60724 correct spelling
Change-Id: Ieb653adbd0cb4371ec5db57e70bcc551872f647f
2013-04-15 05:32:37 +02:00
c3d8b06f00 Get rid of SHL_SBC
GetAppData(SHL_SBC) was used only locally in the sb library so no need for
it. Just use a static pointer field.

Change-Id: I37c8429b6c9e521a00c52bb622f78bdc4afe345c
2013-04-12 23:04:11 +03:00
8dba30fcf6 Get rid of GetAppData(SHL_IDE)
It seems to be used only locally in basctl so there is really no reason for
it.

Change-Id: I9ad0a67621e190257e028fd3689f692e639eaf56
2013-04-12 22:42:08 +03:00
d8dbe5844b Kill empty ImpDeInitWinTools() and the header with only its definition
Change-Id: Ica82a4612da952c0c084974b708ef9dac753dcf6
2013-04-12 19:55:36 +03:00
db8786e34b The silly toolsdll.cxx was the same for unx and win
Change-Id: Ia83a37980446ee9a52e096e64a9ab77f106c8b37
2013-04-12 19:55:36 +03:00
8034992e22 Bin a local X11 wrapper header, vcl/inc/unx/salstd.hxx
We already have <tools/prex.h> and <tools/postx.h>, so make those be
sufficient instead. Bin another local vcl header vcl/inc/unx/svunx.h that just
included those prex.h and postx.h. Adapt includers accordingly.

Change-Id: I6638b3260fd3da45478fcc216b41f8c8a539f0d7
2013-04-10 19:26:05 +03:00
4976dd85fa Introduce characters utilities in rtl/character.hxx
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, with slight modifications
to sal/inc/rtl/character.hxx:
* Replaced "#pragma once" with explicit include guard for now.
* Missing includes.
* Cosmetic clean-up.

Change-Id: I94d01cd4e766f92c70f941839a67101fa2c97654
2013-04-10 10:43:38 +02:00
cf9bc834a4 update documentation
Change-Id: Idc3416bb304d728c646d699aa1c4348a3ef80b58
2013-04-08 15:34:31 +02:00
5aecdfaed2 make internal method static.
Change-Id: Id2b5bd1772009785b4aa44bf4de91e5c1b372c9e
2013-04-08 10:13:26 +01:00
ba044b1e96 remove needless forward rtl::OUString declarations
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
2013-04-07 14:23:12 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
5b08c6e7a2 Typo in comment in resmgr.hxx
Change-Id: I6378c79f77ab897bf5a4e39c00944037beeef328
Reviewed-on: https://gerrit.libreoffice.org/3220
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-04-07 09:15:29 +00:00