Commit Graph

237 Commits

Author SHA1 Message Date
710f41b7ae Clean String and sal_Bool in tools
Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655
Reviewed-on: https://gerrit.libreoffice.org/4627
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-30 04:58:49 +00:00
c1acf1d72e Resolves: #i115630# secured OutputDevice::ImplDrawHatch in vcl
and PolyPolygon::Optimize in tools to useful fallbacks when working on
PolyPolygons (what they do *not* support)

(cherry picked from commit dbe489ab9766d96c5cafb079bc4778103bded783)

Conflicts:
	vcl/source/gdi/outdev4.cxx

Change-Id: I5d2374ec95702cb0cab29d2e82710d4aa29fa823
2013-05-23 15:19:11 +01:00
abb6f47bd3 Secured some places where PolyPolygons were created
using a all-points count and a all-points array

(cherry picked from commit 8ee49906f04106317997e9ca3bb890870816e274)

Conflicts:
	svtools/source/filter/wmf/enhwmf.cxx
	svtools/source/filter/wmf/winwmf.cxx
	tools/inc/tools/poly.hxx
	tools/source/generic/poly2.cxx

Change-Id: I57f7f08d8dd87c83c30ab2d16ca22b772b2bd834
2013-05-19 14:47:38 +01:00
6b5523d1d7 Resolves: #i115917# Better conversion of C1 and C2 bezier curve points
Patch by: osnola
Review by: alg

(cherry picked from commit 76741df0b60b9157710f8e66720275749dbf98bd)

Conflicts:
	tools/source/generic/poly.cxx

Change-Id: I0de15a92e68b766258e285ed17365816064da141
2013-05-13 20:47:48 +01:00
86b73eeef4 fdo#63154: Remove _CL and _LF from solar.h
And use RTL_CHAR_{CR,LF} from rtl/string.h

Conflicts:

	vcl/source/app/dbggui.cxx

Change-Id: I05b0325006845e48eb5483485a9042aa7b0cd22a
Reviewed-on: https://gerrit.libreoffice.org/3740
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-05-09 09:49:15 +00:00
1b14676b5f redo fix for fdo#64078
use std::abs instead of labs

Change-Id: Icb09fb1715d4795c718773a37e66947d67019bb7
2013-04-30 14:18:33 +01:00
38d7278e38 fix for fdo#64078
Change-Id: Ib8c70b0074485ccd8bf6095c070610fe90e22d4a
2013-04-30 14:07:51 +01:00
ec8617568f Bin ugly (ab)use of preprocessor in headers
The time when it made sense to use "clever" #ifdefs to, for performance or
compiler reasons, conditionally bypass private parts of a class declaration
passed a decade or longer ago.

Still more of this in sw and sc. People working on those modules might want to
do it too, or not.

Change-Id: I1053139ca5e5e2631f7b22d99d3bada54fc337be
Reviewed-on: https://gerrit.libreoffice.org/3627
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-27 09:28:37 +00:00
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
d8dbe5844b Kill empty ImpDeInitWinTools() and the header with only its definition
Change-Id: Ica82a4612da952c0c084974b708ef9dac753dcf6
2013-04-12 19:55:36 +03:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
5ea8a48a3b clean up DBG_ERRORn
Those were DBG_ERRORn before and were falsely changed to OSL_TRACE by me.

See:
1707a350af8a0909ae88c2b11deb714f8b2a93ff
533f89e49395bbc31baaab9ade46db934b383e14

Change-Id: I4f4188ba25b988128a539542f49797ea6985702e
Reviewed-on: https://gerrit.libreoffice.org/2900
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-22 17:25:40 +00:00
37d2588844 Remove RTL_CONSTASCII_(U)STRINGPARAM in tools
Change-Id: Id97070321ad6b20f349896d3b4e1ae51cc82ece7
Reviewed-on: https://gerrit.libreoffice.org/2769
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-16 17:12:27 +00:00
77e21bb36a Change definition of "dark" colour for fdo#61993
- Increase the threshold for "dark" colours from Luminosity<=38 to
  Luminosity<=60.

  This makes LibreOffice align more closely with MS Word when
  considering whether "automatic" font colour should be black or white,
  a decision that is based on whether the background colour is "dark".

  Beware that this also affects other areas.

- Fix the coefficients for GetLuminosity which appeared to be off
  by one according to the "Rec 601" coefficients for Luma quoted at
  http://en.wikipedia.org/wiki/Luma_%28video%29

Change-Id: I0af1f77909713e3db5ea8ee98456146569679594
Reviewed-on: https://gerrit.libreoffice.org/2601
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-11 14:54:57 +00:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
875c997c7d fdo#39446 - Bloat Removal. Removing uncallable code with callcatcher
Removed several unused methods.

Could not remove ScVbaFormat<ooo::vba::excel::XStyle>::getAddIndent() and ScVbaFormat<ooo::vba::excel::XStyle>::setAddIndent(com::sun::uno::Any const&) because it breaks compilation (they are implementing pure virtual methods).
Should Test::test1Table1Page() really be removed? (test class)

Conflicts:
        unusedcode.easy

Change-Id: I98a761f66f28e3a82661c10a5fa1dc7e109fff2f
2013-02-27 15:40:16 +01:00
63b0ce97ba fdo#38838 searched, replaced and removed String::CreateFromInt32().
I ran the following code replace:
    s/(Uni|Xub)?String\s*::\s*CreateFromInt32/OUString::number/

And finally removed String::CreateFromInt32().

Change-Id: I53b26a59c68511ae09f0ee82cfade210d0de3fa5
Reviewed-on: https://gerrit.libreoffice.org/2279
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-24 12:59:02 +00:00
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
a4c7ded1fd Cleanup: #include <tools/gen.hxx>
Change-Id: Ic547b4a59102afc8bdbc85ec95ac312e32ef2530
Reviewed-on: https://gerrit.libreoffice.org/1484
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-07 13:14:57 +00:00
a94b6ec2d5 callcatcher: update unused code post binfilter death
Change-Id: I5b25d14ef2769126f98523551597f43812b9feb7
2012-11-14 10:11:32 +00:00
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
17d4bb38fa cleanup files in tools/source
This is a follow-up patch of 7710faa45640d25a83136a35044aafdb1b168d88.

Change-Id: I1f54cbe5c3170e9a79e11e9b9c1da3791419a4ba
2012-08-19 21:27:00 +02:00
9cadf9bdf3 fdo#39468: Translated German comments in core/tools/source
Change-Id: I28ec097a70a8d71312d9e8382c3cf71a1eabde88
2012-08-19 21:26:59 +02:00
920dcaec05 re-indent falsely formatted code in tools/source
Change-Id: Ibc26313e79dd5f992c4bfb9454a9798fb1a78f00
2012-08-18 18:33:54 +02:00
42352dff5a removed ascii-art and blank lines in tools/source
Change-Id: I3f95d12a8c325c96c586253b5d9bb7dce24c0858
2012-08-18 18:33:50 +02:00
34569eb28f drop bogus eof lines
Change-Id: Idda2852c3e96ce15fde75d5a95369ec50a012410
2012-08-07 13:45:27 +02:00
535e83550e re-base on ALv2 code. Includes:
Avoid some uses of non portable #!/bin/bash in shell scripts.
    Patch contributed by Pedro Giffuni
    http://svn.apache.org/viewvc?view=revision&revision=1235297
    remove redundant namespace, patch contributed Mathias Bauer
    http://svn.apache.org/viewvc?view=revision&revision=1162610
    removal of OS/2 port changes, and preferring our similiar
    tools/inc/tools/solar.h DLLPOSTFIX cleanup.
    i118595 - Removal of the use of getopt() from rscdep.
    Patch contributed by Andre Fische
    http://svn.apache.org/viewvc?view=revision&revision=1202270
2012-07-11 18:12:35 +01:00
739e20ac58 Decrease header files dependencies
Change-Id: I654e71e56d60bf629625df09eb93b21c9ef670e8
2012-07-11 11:12:15 +05:30
278000a28b Remove unused defines
Some of them were commented out for documentation purpose.

Change-Id: I29a6b2cbe774b527f0c3a0be5675160817a7f3ce
2012-07-02 17:46:25 +02:00
b63027f099 Remove some unused defines and controls
Change-Id: I96f76ed6b33f5c786d1e3ab3981a535037a9c1b5
2012-06-29 15:59:53 +02:00
cd8e530dcd convert BitInt signatures to rtl::OUString
Change-Id: Ic461cdb6283fe48e97787b3f1e8950559d576ca9
2012-06-22 12:27:33 +01:00
a22a7923c0 ditch some XubStrings
Change-Id: I00e1202de7bf5d20b4ac314dd138a3bb486245cb
2012-05-22 12:48:27 +01:00
2b0244db8b Removed unnecessary SvLibrary
Change-Id: I42e64af8ed88e652341707d5f9d2da3daaa0f9bb
2012-05-09 13:46:19 +02:00
b26df89e6c callcatcher: remove some unused code 2012-04-02 14:53:47 +01:00
55a4020907 remove ToDouble/ToFloat 2012-03-20 12:57:34 +00:00
6e67c03dc0 Enable -Wnon-virtual-dtor for GCC 4.6
...which has the necessary features to support it.

Change a lot of classes to either contain a protected non-virtual dtor
(which is backwards compatible, so even works for cppumaker-generated
UNO headers) or a public virtual one.

cppuhelper/propertysetmixin.hxx still needs to disable the warning, as
the relevant class has a non-virtual dtor but friends, which would still
cause GCC to warn.

Includes a patch for libcmis, intended to be upstreamed.
2012-03-14 13:32:02 +01:00
2dd1722d27 Fix a bug found with cclang
Null pointer passed as an argument to a 'nonnull'
2012-02-16 22:36:35 +01:00
2adad6a4b3 fdo#39428 Remove/audit SvStream operator>>/<<(long)
Replaced calls to operator<<(long) with sal::static_int_cast<sal_Int32>
Replaced calls to operator>>(long) to use sal_Int32
2012-01-18 22:56:13 -05:00
05a8ecca55 removed some dead code 2012-01-18 20:02:19 -05:00
804e86170f remove unused methods 2012-01-17 17:01:26 +01:00
81e50fb2e3 Fix for fdo43460 Part XXXIX getLength() to isEmpty()
Part XXXIX
Modules
testtools, toolkit, tools
2012-01-16 18:49:04 -02:00
1074c1ab9e removed unused macro 2012-01-16 07:38:59 +09:00
72c50c2354 make it possible to create 360 degrees arc (circle) 2012-01-12 11:13:18 +01:00
d59211357a Removed unnecessary tools/debug.hxx includes. 2012-01-06 23:55:51 +01:00
a0ebf6ee3f Revert "callcatcher: Remove unused code"
This reverts commit bbad7057b2bdb614a5e97a945039323efe39c4ee.
2011-12-22 20:29:18 -05:00
bbad7057b2 callcatcher: Remove unused code 2011-12-22 19:55:53 -05:00
864bc59e66 Removed COMPRESSMODE_FULL support from SvStream 2011-12-19 21:56:53 +01:00
6a8f6c4b13 Removed extra semicolons 2011-12-15 16:38:50 +00:00
87ec1f8857 callcatcher: remove unused code post automation removal 2011-12-09 13:57:16 +00:00
5f7649aead remove include of pch header from tools 2011-11-27 13:25:56 -06:00