Commit Graph

204 Commits

Author SHA1 Message Date
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
670e2329df fdo#46808, Convert xml::crypto services to new style
Also remove the unnecessary XInitialization implementations.

Change-Id: I81f32b2cdcf69b84fe4b15382f9294073a7f2f20
2013-06-10 10:20:44 +02:00
9eb4e4dc51 Some more modules at least building with mingw64
Change-Id: I3ea039655aecb7885bb310b1f2c29d66f9f7bb4f
2013-06-06 19:49:56 +02:00
e2e2cc6114 remove usage of RTL_CONSTASCII_USTRINGPARAM
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.

Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
e79b387e03 It is very wrong to #undef _DEBUG in some source files of a library
Nowadays in a dbgutil build with MSVC, the debugging runtime (C++
library) is used. Just like with the GNU libstdc++, it is not binary
compatible with the non-debugging variant.

All sources that go into one DLL or EXE must be compiled with the same
_DEBUG settings (unless one is extremely careful and knows exactly
what one is doing, which presumably is not the case with this code).

With previous compilers this has gone undetected, but with MSVC2012 at
least, you get link-time errors, which is a good thing:

nssinitializer.o : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in biginteger.o

nssinitializer.o : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MDd_DynamicDebug' in biginteger.o

Whether this actually has caused run-time erroneous behaviour or
not in a dbgutil build is another thing...

Change-Id: I0c42161f00a0e37b438e3b911e3c0058edadd800
2013-04-17 13:23:35 +03:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
a9e6e5bf4d The [_]DEBUG_WAS_DEFINED macros are not used here
...but only in connectivity/source/drivers/mozab/{pre,post}_include_mozilla.h,
which is never included from here, so this smells like cargo-cult.

Change-Id: Iac0d7d60caad7c090445d551b7adb50424130e2a
2013-03-25 08:52:56 +01:00
ec52e5e5a2 Consolidate XMLSEC_NO_SIZE_T setting in xmlsecurity/xmlsec-wrapper.h
...so all xmlsec/*.h includes are bundled there now (except, for pragmatic
reasons, the xmlsec/mscrypto/*.h ones that unconditionally include windows.h and
only work on Windows).

Change-Id: I33e642f4f6a2e40edd6950af7f209c8b76c6e5fe
2013-03-25 08:52:55 +01:00
3b006a10b7 stricmp macro is unused
...since f3eb77586e067a46211334a78987652815f47744 "further removing of dead
code."

Change-Id: I6805c5adafcf19782f352cdacd0d99a9e7681eb6
2013-03-25 08:52:55 +01:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
1af22c05c6 fix other problems found by Wundef
Change-Id: Ib4aba95436f82d2a20b07a092f0fd07e0620fdcf
2013-03-18 17:15:57 +01:00
41e03a166e doubled using
Change-Id: Ib1d3213a688194bfb027b7bca5bd9ac1b7bb1b28
2013-03-05 12:34:33 +01:00
875c997c7d fdo#39446 - Bloat Removal. Removing uncallable code with callcatcher
Removed several unused methods.

Could not remove ScVbaFormat<ooo::vba::excel::XStyle>::getAddIndent() and ScVbaFormat<ooo::vba::excel::XStyle>::setAddIndent(com::sun::uno::Any const&) because it breaks compilation (they are implementing pure virtual methods).
Should Test::test1Table1Page() really be removed? (test class)

Conflicts:
        unusedcode.easy

Change-Id: I98a761f66f28e3a82661c10a5fa1dc7e109fff2f
2013-02-27 15:40:16 +01:00
0be1b5f4a6 coverity#982735 Negative loop bound
Change-Id: I597cd1204b0b7f5c7351482c3cdd00fc6111218a
Reviewed-on: https://gerrit.libreoffice.org/2224
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:50:50 +00:00
975e269476 coverity#705782 Resource Leak
Change-Id: I8346d3fd2ce4345cc9a352abb608cfec5f6939f4
Reviewed-on: https://gerrit.libreoffice.org/2223
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:49:57 +00:00
50ba5ad06a coverity#982249 Unchecked return value
Change-Id: I959599c899b489aa42ccce60c6794869041522a0
Reviewed-on: https://gerrit.libreoffice.org/2222
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:48:32 +00:00
9a49ff646b nsscrypto_initializer: MSVC does not support C99 dynamic arrays
Change-Id: I407b2308756b46fbf0920881fc20972b486819b7
2013-02-19 11:34:29 +01:00
08ac21ddd9 coverity#705355 coverity#705356 Missing break in switch
Change-Id: I9a0a370eb1279a184a47e15bcefc6ce5e4025aa3
Reviewed-on: https://gerrit.libreoffice.org/2226
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-18 23:15:49 +00:00
21e2c2f164 coverity#982590 Explicit null dereferenced
Change-Id: Ie898603f64a4568a8502caf3db154ae5ce008af9
Reviewed-on: https://gerrit.libreoffice.org/2227
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-18 23:12:09 +00:00
cbe8883b51 coverity#982591 Dereference after null check
Change-Id: I8651ecb0287d686da3e1ca6a6e46549abe3e0c38
Reviewed-on: https://gerrit.libreoffice.org/2225
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-02-18 21:38:42 +00:00
b1959dbfad Remove unused cppuhelper/servicefactory.hxx includes
Change-Id: I27fd4d1f1dfafccaa7936defb5cd687d6266e0a2
2012-12-21 15:56:44 +01:00
66a175834c c++ API: use css alias in generated headers, adds global css decl
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star

Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.

Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-30 14:36:36 +01:00
8648c974ea Clean-up "SYSTEM_MOZILLA" -> "SYSTEM_NSS"
Change-Id: I47ec3aeb14445b697bf8f5af34c5d16a14069735
2012-11-19 16:14:12 +01:00
14800ce5f2 Improve logging
Change-Id: I5ff457c76970356a5748f6f319f32a1f49b86ca1
2012-11-07 16:55:20 +01:00
13d21b1f03 'xMSF' : undeclared identifier
Change-Id: Iba7a18b0c28da6a3955e62fe54ba96842e571064
2012-11-06 11:45:45 +02:00
1dedb15b17 fdo#46808, Adapt xml::crypto::SEInitializer UNO service to new style
Also create an NSSInitializer service IDL and split it's interfaces
out from SEInitializer.
It looks like this was the intention all along, but someone
took a shortcut.

Change-Id: I53ac1cb5d38b78b6718fe22c9666eae1f194a3b7
2012-11-05 16:43:14 +01:00
1f9f8f4f40 loplugin: some log, indent and unused variable warnings
fix up some indents, remove some unused OUStrings and add some log areas

Change-Id: I5c50807aff7a726b03b72522975d9b75e6685b9b
2012-10-13 20:34:54 +01:00
dd11a1e57a Fixes/improvements on previous commit
* UUIInteractionHandler still needs to implement XInitialization.

* Moved ambiguating InteractionHandler typedef out of the way.

* Removed InteractionHandler.createDefault, as it was originally stated that "it
  is strongly recommended that [the "Parent"] property is supplied."

* Added back documentation about Parent and Context.

* Simplified some call-sites to directly use XInteractionHandler2.

Change-Id: I1029b8f3cf079171c75920cafaaa44b5bbada883
2012-10-04 14:42:52 +02:00
c25cb8a641 fdo#46808, Adapt task::InteractionHandler UNO service to new style
Since we don't need to expose XInitialisation, we can make the new-style
service implement XInteractionHandler2.

Change-Id: Ib27beed1c12df17592c6472d6f58c233d2c41558
2012-10-04 14:42:52 +02:00
350b031df0 callcatcher: remove some of the slightly trickier unused methods
Change-Id: Ief164c980f3a92316e1f47cb50bdf243155b6dd9
2012-08-20 12:12:21 +01:00
9b2e6d4536 Replace usage of rtl/memory.h in xmlsecurity their equivalent from string.h
Change-Id: Id4a088864ee28163160d6ac408592952fe6c797d
2012-08-04 17:46:59 +02:00
6eeb0942c3 re-base on ALv2 code. Includes:
retain presence of MPL licensed nssrenam.h symbol renamer.
2012-07-17 11:51:17 +01:00
8e1bffe7ff Remove include guards
Change-Id: Ib4ba76d0083e5bd75cc589a55318089c004f591f
2012-06-29 15:59:53 +02:00
4c4d748767 Remove some more include guards
Change-Id: I7c62d086cb593744785abecae7a107686a4d65ce
2012-06-29 09:25:10 +02:00
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
3770bbbdba Remove superfluous empty lines on top
More than two lines are removed for readability.

Change-Id: Ibff6cf68d7c512e240a54065b54a225bb23a782b
2012-06-09 04:57:58 +02:00
d95d58af08 nuke unused namespace
Change-Id: Ic00cdfce4172af0a2f0aa1aa33ef5e386d407976
2012-06-01 01:04:50 +09:00
601500f8a8 targeted string re-work
Change-Id: I6ce76c22118586b213161a0e307a53b22b318004
2012-05-29 19:30:23 -05:00
7ead068be9 more robust nss initialization, related fdo#45171
fall back to without profile if path is invalid or profile does not
exist

Change-Id: Ic9a73fbaaa288f8bc99dab2b1d679c2cbe6baa89
2012-05-04 15:13:53 +02:00
2073131576 Resolves: fdo#39825 Make detection of certificate folder ui-configurable
Display in the (unix) options gui the NSS cert dir that has been auto-detected
for use with digital signatures. Show the other detected possibilities and
allow it to be overridden.

The autodetection should basically work out of the box, but if there's some
bustage at least the UI can be used to sort it out and/or let developers
debug it.

This removes the need for the horrible MOZILLA_CERTIFICATE_FOLDER hack,
though that's still supported.
2012-04-27 11:12:41 +01:00
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
f770c5d6bc Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)return \([^()]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\) ) *);/\1return \2 == \3;/' \{\} \;
2012-04-06 12:48:32 +02:00
643a582793 removed duplicate #includes
in vbahelper / writerfilter / writerperfect / xmlhelp / xmloff / xmlscript / xmlsecurity
2012-04-04 01:39:08 +09:00
140c90f430 Fix "pEncryptedData" not initialized 2012-02-18 08:04:53 +01:00
5833c182ed callcatcher: update list 2012-02-01 11:13:44 +00:00
7c4807bfc0 Fix for fdo43460 Part LV getLength() to isEmpty()
Part LV
Modules
xmlsecurity
2012-01-28 09:56:30 -02:00
785bf20ab3 WaE: narrowing conversion from sal_Int32 to unsigned int 2012-01-15 20:27:25 +01:00
0669fdb487 fix for gcc 4.7/C++11: this is not string literal operator 2012-01-11 07:49:53 +01:00
d59211357a Removed unnecessary tools/debug.hxx includes. 2012-01-06 23:55:51 +01:00