Commit Graph

149 Commits

Author SHA1 Message Date
da3b039d41 reportbuilder: fix javadoc error: reference not found
Change-Id: Ic548a23a9d1e1acc90386da76416c76990f3a5b3
Reviewed-on: https://gerrit.libreoffice.org/11309
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-07 13:03:24 -05:00
653025e6f1 reportbuilder: fix unknown tag: noinspection (IntelliJ)
Change-Id: I97c464547068d0d17a0d4423e8462097c73624aa
Reviewed-on: https://gerrit.libreoffice.org/11243
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-09-02 06:11:52 -05:00
4db06c5a69 reportbuilder: fix javadoc error: no summary or caption for table
Change-Id: I5697ebe0481491d70ee728cac5343aaf892ad29f
Reviewed-on: https://gerrit.libreoffice.org/11242
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:14:57 -05:00
18d72e76f1 reportbuilder: fix javadoc error: self-closing element not allowed
Change-Id: Iabfa4dd2c1018b982b50798bf09347e0b11901a4
Reviewed-on: https://gerrit.libreoffice.org/11240
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:13:49 -05:00
fbe8186434 reportbuilder: fix javadoc error: unknown tag: returns
Change-Id: I3cc2afca6e59a8bc9e3374e5cebf9b2e903da78b
Reviewed-on: https://gerrit.libreoffice.org/11241
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:07:26 -05:00
610cfb3771 java: fix reportbuilder and wizard
which I broke in commits
70f56bc22fe95 "java: reduce scope, make member classes private"
and
34bcf9b498b "java: remove dead methods"

Change-Id: Id21482782bbc102e60f346a2bf51096af2fcbe22
2014-08-29 13:14:58 +02:00
0ce1267ae2 remove more unnecessary constructor declarations
Change-Id: Ie5a243006b112c2e6daf12992f3dba8baf12748d
2014-08-20 12:12:43 +02:00
c0415d5f1e java: remove unnecessary constructor declarations
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor

Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20 12:12:15 +02:00
8c9fdc4a96 java: remove modifiers implied by the context
found by PMD

Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20 11:45:28 +02:00
2922a967a1 java: Avoid naming non-fields with the prefix m_
found by PMD

Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
2014-08-20 10:35:53 +02:00
3a8d351988 java: remove unused methods
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-19 14:57:13 +02:00
439354a0b4 upgrade to apache-commons-1.2
Change-Id: Ic356c6a23f42b5fe37be1075e8508bb168eac9a1
Reviewed-on: https://gerrit.libreoffice.org/10927
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-16 21:56:35 -05:00
0d916bb240 java: remove unused imports
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14 10:59:49 +02:00
ac5954d7c5 java: remove commented out code
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
4a4127d2c4 make some java methods private
found by UCDetector

Change-Id: Ic2edbc85194731116aac34064238d11ef1926a98
2014-08-13 13:34:43 +02:00
34bcf9b498 java: remove dead methods
found by UCDetector

Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13 10:24:10 +02:00
4155c28ae1 java: remove unused interfaces
found by UCDetector

Change-Id: Ide8b3b5c9969048aff84eed16b9eea096abad349
2014-08-13 09:44:17 +02:00
8583da1e93 java: remove unused fields
found by UCDetector

Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
2014-08-13 08:49:24 +02:00
68cd011c90 java: reduce scope, make some methods private
found by UCDetector

Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13 08:49:23 +02:00
70f56bc22f java: reduce scope, make member classes private
found by UCDetector

Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13 08:49:23 +02:00
da677dfd59 java: reduce scope, make fields private
found by UCDetector

Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13 08:49:22 +02:00
14d1a11ec4 java: reduce scope, make constructors private
found by UCDetector

Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
2014-08-13 08:49:22 +02:00
e701b3f732 java: reduce scope, make constants private
found by UCDetector

Change-Id: Ide9975e361ed17ac8cdcbe67ba74c563a9392d57
2014-08-12 12:16:37 +02:00
5656fe58a0 java: fix broken javadoc tags
Change-Id: I43d25ba49b758739ee8dc891b0db3e527004ec8b
2014-08-12 09:41:31 +02:00
1c496506bc java: remove useless javadoc tags
that are not conveying any useful information

Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-12 09:41:31 +02:00
0477e6c39b java: add @Override annotation to overriding methods
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
d5a31b2215 java: remove unused parameters
Change-Id: Ifc44c51ddbd21fabaad686bc3d38e2dab54d97aa
2014-08-11 12:33:02 +02:00
41709cc268 java: remove unused parameters
Change-Id: I47c618117e079bb2ef90d92c449c8166ea957fa5
2014-08-11 12:33:02 +02:00
616b3ad504 java: remove exceptions from throws clauses that are not
.. actually thrown

Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
2014-08-08 09:48:20 +02:00
2d700944b5 java: remove unused imports
Change-Id: Idbba5bb89bee4d88ed0306d5151e238a1bc19cec
2014-08-08 09:48:17 +02:00
8d6cf7a147 java: remove dead methods
Change-Id: I9f2e705fd603a7c8832c0f0772bee9f395380a0d
2014-08-08 09:48:16 +02:00
0c5f51ebbc java: remove commented out code
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05 11:31:50 +02:00
d26540bb05 java: remove unused fields
Change-Id: I6c93864f501f646a8940eac221a88c87b3f75525
2014-08-05 11:31:50 +02:00
f6aea4202c java: removed unused imports
Change-Id: I3e3d15719cd1bc4fe4f0dec2c21a3414bde6a808
2014-08-04 13:38:29 +02:00
5687788744 Resolves fdo#81213: Wrong table-clause generated by reportbuilder
Oracle doesn't accept "AS" for making an alias from a table
See https://bugs.freedesktop.org/show_bug.cgi?id=81213#c2
https://bugs.freedesktop.org/show_bug.cgi?id=81213#c4
https://bugs.freedesktop.org/show_bug.cgi?id=81213#c5
for more information

(thank you Lionel)

Change-Id: I33c86d78b2590116d4af46ffd3e54c3c791268ea
2014-07-22 18:38:21 +02:00
aa48af5753 fdo#67935 "print on group change" acted as "print in first group instance"
The "parent" group changed iff this is the first iteration of *this*
group *or* *detail* *section*.

The "parent" group's first iteration means that we are in the first
value of the parent group (in other words, the *grand*-*parent* group
changed).

Change-Id: Ia4a798cb37db2f17e7deef1058b25795bfc02648
Reviewed-on: https://gerrit.libreoffice.org/9503
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-27 05:46:58 -05:00
3c1e30b77d Correct common misspellings, and remove some ASCII art along the way.
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17 12:38:38 +00:00
b1b0530983 typo: independend -> independent 2014-04-14 12:31:59 +02:00
2b15c85a8c bump apache-commons-logging to 1.1.3
Change-Id: Ibeebcc8616a3547f2e2dbf4d613ce4c02ba9d176
2014-03-25 13:06:34 +00:00
bc1b0fca47 Remove visual noise from reportbuilder
Change-Id: I4063ea1ea95ddd1a3c220ca0da89cdcd78f62410
Reviewed-on: https://gerrit.libreoffice.org/8294
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 09:17:11 -06:00
f1a73892b3 Typo: apropriate -> appropriate
Change-Id: I05e23039dc3ae0b6595c87fe550f4228ad93d5d6
2014-02-25 22:04:17 +01:00
9bbb7ca9f7 Typo: formating -> formatting
Change-Id: If4aba89909a3ef049a756182c37d8a5d6812ae70
2014-02-06 22:41:48 +01:00
b0e3c6b8fa typo in comment
Change-Id: I900a8956fd9eae330bf12829bc94c8b18b1c6513
2014-02-05 07:43:04 +01:00
7ce47d69b3 fdo#69873 FixedText (label) is implemented as no value
And the actual label is put as *body* of the cell.
I'd prefer that the value be put as string-value attribute of the cell,
but since in the report definition the label is as body
(as opposed to as an attribute), it is easier that way.

We could move (actually *copy* for backwards compatibility reasons)
the label to an attribute of the rpt:fixed-content element
(similar to the rpt:formula attribute of rpt:formatted-text)
but it is not obvious this is completely desirable:
Indeed it would keep us from putting anything more complex than a string there
(which we don't do anyway now, but thinking of future extensibility here);
I'll leave the exploration of that idea to the indefinite future.

Change-Id: Ia0f7460718ee35a971117e2f79c0997e17e1095e
2014-02-05 07:43:03 +01:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
070ca1e280 jfreereport: stop pointlessly renaming the jar files
Change-Id: Ia2c5ce1176496e98643e2cefc65d4c6d0cf9c781
2013-10-25 23:31:30 +02:00
0089d3ae94 fdo#62994 reportbuilder survive empty formula
Change-Id: I1da053871d107730ad9a135deb48313d8a877d89
2013-10-08 20:42:37 +02:00
7f436c1fd3 typo fixes in comments
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
6a1ad344a8 fdo#69147 report sort columns are RESULT columns
as opposed to table columns or other expressions.
So it makes no sense to slap a table name on them.
Notwithstanding HSQLDB 1.8 (our embedded database) bugs.

Change-Id: Ib5d0b1479e29b9efeafca9ebc2eb7ed8e0f42b79
2013-09-13 12:08:02 +02:00
fc92c1abeb fdo#67930 don't use variables for formattedtext in header/footer
I don't know why it was going through variables.
Instead, put the value where it is supposed to,
like for formattedtext in detail section.
Try it, and if something breaks, we can revert.

This also works around fdo#67930

Change-Id: Ia7f08afd8a037d3ac75676c5221ddb36aa791354
2013-08-12 18:43:37 +02:00