Commit Graph

10719 Commits

Author SHA1 Message Date
7bf1e66ac5 convert AX_FONTDATA to o3tl::typed_flags
Change-Id: If51119fbdde4b1d923b794d126fdae99ca238f81
Reviewed-on: https://gerrit.libreoffice.org/36463
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-13 12:02:20 +02:00
1a2afa01c9 Simplify passing options to jfw_startVM
Change-Id: Idac31e282fe4df69449298a03d491473e460c742
Reviewed-on: https://gerrit.libreoffice.org/36495
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-13 07:47:48 +02:00
3c3f7d784e Removed duplicated includes
No automatic tools. Manual checked and tested.

Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754
Reviewed-on: https://gerrit.libreoffice.org/36371
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-13 07:46:16 +02:00
76fbd18a51 Notebookbar: remove dependency between all containers and IPrioritable
Change-Id: I92bff0d68470763c88172744e82d9b5915ffb6f1
Reviewed-on: https://gerrit.libreoffice.org/36387
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-04-12 22:25:53 +02:00
4f55dfb564 convert AX_FONTDATA constants to scoped enum
Change-Id: I0de365c8f654973f483d09fc9170f40bda7cbd9e
Reviewed-on: https://gerrit.libreoffice.org/36457
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-12 15:42:34 +02:00
2685678cd0 Revert "Work around clang-cl issue with MSVC's safeint.h for now"
This reverts commit acbb7e3243afec515bf98b2b34454afc5320bf66.  No longer needed
with safeint.h from recent "Windows Software Development Kit - Windows
10.0.15063.137".
2017-04-12 14:34:10 +02:00
aa708712ff convert selection menu to .ui
Change-Id: Ie4cf80202c333600ce027c78aa3c379ef33f4f80
Reviewed-on: https://gerrit.libreoffice.org/36449
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-12 14:00:01 +02:00
a3c294e6ad convert ReadWriteGuardMode to scoped enum
Change-Id: I21ae815d5bbd7b39cd690168738c21925558585e
Reviewed-on: https://gerrit.libreoffice.org/36452
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-12 12:49:35 +02:00
3cee2b2d58 convert style menu to .ui
Change-Id: I85683007062c4cc1160ace7b3bf962ee5c021b6e
2017-04-12 09:58:28 +01:00
bc937896e2 convert preset menu to .ui
Change-Id: I31cbe438f5f5b790ca8f4373010b28d948c2b53e
2017-04-12 09:40:00 +01:00
9e4d84daf2 drop document_io_logring.txt and use global logging
Change-Id: Ibda0ce925bc76355e636022c955077ac89e66cce
Reviewed-on: https://gerrit.libreoffice.org/36434
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-12 09:57:50 +02:00
f1bbafc584 Convert rtl_uString -> OUString in jfw_get/setVMParameters
Change-Id: I55f96873661f686cd9625d69523718ccb54659dc
2017-04-12 09:36:20 +02:00
346b5cfd90 Convert some rtl_uString -> OUString in jvmfwk
Change-Id: I08de5cab29dabc6fd824d5df8bac12c8520a05ae
2017-04-12 09:36:20 +02:00
59fddf430f Calls to jvmfwk/framework.hxx must not pass in null, drop JFW_E_INVALID_ARG
Change-Id: Iff4b8ccc79e194f645791ac73818e3b677ae32a6
2017-04-11 19:10:48 +02:00
7635e0c1c7 sal_Bool -> bool
Change-Id: If632eb547aa5082ad13eac8c2ad39a1742309fc7
2017-04-11 18:38:51 +02:00
33cf2b6613 Let jfw_isVMRunning return the result; there are no error conditions
Change-Id: I004b3d6f6b7b32d1bb41072d7fdd4a66f944d992
2017-04-11 18:33:31 +02:00
16f29aa720 sal_Bool -> bool
Change-Id: Iec70d6726e36af607a0a5b5a0f6dc86d05322435
2017-04-11 18:28:43 +02:00
15c98f1740 jfw_existJRE requires non-null args, never returns JFW_E_INVALID_ARG
Change-Id: I2067b77393427a5a6a4273c2f609ff8d335f436a
2017-04-11 18:25:04 +02:00
583508ced2 sal_Bool -> bool
Change-Id: I8df49f349308cc17d684d5c0e8215aa628dfaeda
2017-04-11 18:18:42 +02:00
f0454e72c1 Use std::unique_ptr<JavaInfo> for lifecycle management in jvmfwk/framework.hxx
Change-Id: Ie604c75e92c407ff3118aaa58155648d956c91fb
2017-04-11 18:04:54 +02:00
0451019f75 OFFICE-2102: ODF export: write <text:s> after non-mark elements too
... and fix the wrong export for <text:meta-field>, which erroneously
did not use the same bIsPrevCharSpace flag as everything else (which was
obviously a bug, as there should be one flag per paragraph).

Interop testing demonstrates that at least Word and Calligra Words
differ in their interpretation of spaces following <draw:frame> and
other shape elements, and <text:note>: if there is a U+0020 space
before the element, LO will not collapse a U+0020 space behind the
element but Word and Calligra Words do collapse it.

The distinction between "mark elements" and "non-mark elements" in the
whitespace collapsing implementation in OOo since the beginning was
never explicitly spelled out in ODF, although listing the
<text:bookmark> etc. elements in ODF 1.1, 5.1.1 was a strong hint.

Fortunately all 3 applications agree that a <text:s> following a
<draw:frame> is consumed as a space, and it is valid to write a <text:s>
in this situation, so just do that to improve interoperability.

Change-Id: I42260c0528db9fe7e87e8dbae5105aeadb83780d
2017-04-11 16:56:38 +02:00
87713a4743 xmloff: rename one overloaded XMLTextParagraphExport::exportText
... to exportCharacterData. The others all export XTexts.

Change-Id: Ic4b1d6364c15d99d839e2736d4c2966d7aa302d4
2017-04-11 16:56:38 +02:00
3927105e19 convert ruler menu to .ui
Change-Id: I5f9b0033288ccd4b58e055998834185970f987b0
2017-04-11 13:58:57 +01:00
25e92d7f7c loplugin:inlinefields in XMLTextParagraphExport
Change-Id: If0e80fbe21b6d8bed55357d7fc09027fc4a37e06
Reviewed-on: https://gerrit.libreoffice.org/36373
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-11 10:32:55 +02:00
9fa75f677a loplugin:mergeclasses merge E3dScene with E3dPolyScene
Change-Id: I70f28fb4c87ad8c0e0ad46f4ce04914b6536d6b9
Reviewed-on: https://gerrit.libreoffice.org/36376
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-11 10:16:16 +02:00
ade95165ef loplugin:inlinefields in SvXMLExport
Change-Id: I9e9dddcbdd450f40b34318c90b8c2d8d3980dbd6
Reviewed-on: https://gerrit.libreoffice.org/36374
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-11 08:09:51 +02:00
489a0039f8 loplugin:inlinefields in SdrPageProperties
Change-Id: If6aa6f62687b46ccca2b6b3bffba2eac4e2753ef
Reviewed-on: https://gerrit.libreoffice.org/36372
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-11 08:09:29 +02:00
6bd33bd263 loplugin:inlinefields in SdrMarkView
Change-Id: I2662c7dbae0189fe2057149d825df39bb976a295
Reviewed-on: https://gerrit.libreoffice.org/36354
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 13:41:14 +02:00
2a0ce97aed loplugin:inlinefields in PPTTextObj
Change-Id: If0bdb1cad649eb6acceca125367cbd1c3c267fc0
Reviewed-on: https://gerrit.libreoffice.org/36350
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 13:40:56 +02:00
369d54131f loplugin:inlinefields in PPTParaPropSet
Change-Id: I2a307d5be85f10b410f211c020fdaa9c2bec2bec
Reviewed-on: https://gerrit.libreoffice.org/36349
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 13:40:40 +02:00
748fea983f loplugin:inlinefields in SvxMSDffManager
Change-Id: I30a7f593c1d2f751adcdde1a381fb616c2dfed74
Reviewed-on: https://gerrit.libreoffice.org/36347
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 13:39:37 +02:00
d608fa64b7 loplugin:inlinefields in PPTTextRulerInterpreter
Change-Id: Ic814a5dce507b5a0cb49a093a60bd71768ee40d5
Reviewed-on: https://gerrit.libreoffice.org/36348
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 11:57:09 +02:00
1b921c2f1b loplugin:inlinefields in OpenFileDropTargetListener
Change-Id: Ib1f7004ce57f144309d396bc71419f3d1036ff74
Reviewed-on: https://gerrit.libreoffice.org/36353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 11:51:14 +02:00
91afe55196 loplugin:inlinefields in SfxSaveAsTemplateDialog
Change-Id: I7b32fc64b96e2f89edc810d4a95d3a3f6f885957
Reviewed-on: https://gerrit.libreoffice.org/36352
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 11:40:27 +02:00
5ab0d0a69f loplugin:inlinefields in oox::vml::VMLExport
Change-Id: Ia6880212503b2945953ca4c3d62d3ddb1d159c7b
Reviewed-on: https://gerrit.libreoffice.org/36351
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 11:40:13 +02:00
dd700ceda7 loplugin:inlinefields in SvxAutoCorrect
Change-Id: I09aa52551dd1ed96bc9a72baec6afe5a4a05c1dd
Reviewed-on: https://gerrit.libreoffice.org/36346
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 11:26:20 +02:00
40d26609ef Keep list sorted
Change-Id: I34fd3ed006bdcecbe8b7e1f17cb379242a5eef95
2017-04-10 11:12:12 +02:00
5128960109 loplugin:inlinefields in formula::FormulaCompiler
Change-Id: I6dc6dfd064bf944db278b4663812d71b6cc49b3a
Reviewed-on: https://gerrit.libreoffice.org/36344
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 10:51:37 +02:00
bad606febb Clean up uses of SAL_U/SAL_W: embedserv
Change-Id: I5a73acf6ccfc1709e95e55fa15c32ec6dda2657a
2017-04-10 10:16:11 +02:00
4b05610223 loplugin:sallogareas
Change-Id: I382360e7756c8e0afa47c6bc96dfc04fec558a45
2017-04-10 09:13:36 +02:00
2841cf6c9f loplugin:inlinefields in utl::ReadWriteMutex
Change-Id: Ibd31d1c0ec154be886f9fd4d2e7a439b2d7f5f4a
Reviewed-on: https://gerrit.libreoffice.org/36267
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 08:52:36 +02:00
52117bb8c3 loplugin:inlinefields in INetMIMEMessageStream
Change-Id: I675b53a55e02899f0cf325245cedb298f6903281
Reviewed-on: https://gerrit.libreoffice.org/36266
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 08:52:26 +02:00
67af00a76a new loplugin:inlinefields
look for fields which can be declared inline in the parent class.

start with some likely candidates in svx

Change-Id: I56cdca273272b72bb728ed2e3f5e1e976f8c7c32
Reviewed-on: https://gerrit.libreoffice.org/36262
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10 08:51:52 +02:00
ee73747ab5 tdf#107018 PDF export of PDF images: handle references in nested dictionaries
Also get rid of the GetKeyOffset() and GetKeyValueLength() calls when
copying dictionaries: the reference already knows its offset and length,
so no need to call them. This makes the dictionary and the array
handling more similar.

Change-Id: I65936acfaf857636a8d83da3a4cec69289eb89d8
Reviewed-on: https://gerrit.libreoffice.org/36282
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-04-07 21:07:52 +00:00
50057a37a8 Introduce o3tl::string_view.hxx approximation of C++17 <string_view>
...and use it in configmgr/source/writemodfile.hxx

Change-Id: Ie683dc21010ed45cc454ff89bea0376994b351f2
Reviewed-on: https://gerrit.libreoffice.org/36270
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-07 20:12:31 +00:00
a7d008a8df Resolves: tdf#106732 the intent was surely to return a const ref
Change-Id: Iaaa1f76a689645adaebf4fe5b87003ad238f71f2
2017-04-07 18:36:59 +01:00
209dc36408 fix build error with unique_ptr in tubes
Change-Id: Ife80c0886e725b6b556e4a8104b004e1f6ac4199
2017-04-07 14:42:58 +02:00
289158d59e Revert "Remove button handler and let the button dispatch the uno cmd"
This reverts commit 6584735bba4b96fbde5c7be55dc6c98878ad059a.

Ooops, that doesn't build any more without the previous reverted one.
2017-04-07 14:20:18 +02:00
b805e5705c Revert "Related tdf#105566 Update Infobar when signature status changes"
This reverts commit d8faf3bf9a82e8f49340b5020ec4ee931cc2f3f4.

This causes an infinite recursion in JunitTest_sfx2_complex
involving the newly added SignatureHelper::updateInfoBarState().
2017-04-07 14:15:23 +02:00
7d98edfa49 tdf#39468 Translate German comments
Translate German comments and terms in dbaccess/, extensions/, formula/,
include/, reportdesign/, rsc/, sd/, svtools/, and vcl/

Change-Id: Ie20dadda0eeb0786eb328c6c652287d5481c5e3b
Reviewed-on: https://gerrit.libreoffice.org/36249
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-07 11:15:03 +00:00