Commit Graph

3330 Commits

Author SHA1 Message Date
f74149bc21 Fix some typos for "height"
Change-Id: Ibe1fdd7a63ff09097cfe053279d779592d389539
2013-11-25 23:03:11 +01:00
480a0ef7c1 rigth -> right (other occurences)
Change-Id: Ic899aa36b1b18237f90295eaa04ea83450958c87
2013-11-23 21:49:02 +01:00
73342dbb82 remove unnecessary RTL_CONSTASCII_STRINGPARAM
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.

Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
2013-11-22 08:07:19 +02:00
1730df0127 remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::append
Convert code like:
   aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") );
to:
   aOStringBuf.append( " is missing )" );
which compiles down to the same code.

Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
2013-11-20 10:07:32 +02:00
52bbd9cc00 remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii calls
Convert code like:
    aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
    aStrBuf.append( "ln(x)" );
which compiles down to the same code.

Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20 10:07:32 +02:00
3af99e4d59 convert equalsAsciiL calls to startsWith calls
Convert code like:
    aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
    aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.

Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-20 10:07:31 +02:00
363cc39717 convert equalsAsciiL calls to startWith calls where possible
Simplify code like:
    aStr.equalsAsciiL( "%", 1 )
to
    aStr.startsWith( "%" )

Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19 12:49:29 +02:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
d4fa4c7b38 fdo#69500: Revert "fix bug #60700 - de-crutify ODF files"
This reverts commit da06166015689eca260c702602bef4cea58afbd3.
2013-11-18 13:27:50 +01:00
986644335c fdo#66864: Return from full-screen should restore toolbars.
The fix for fdo#37758 was not correct, we shouldn't fiddle with the m_bVisible
itself, but instead react on the m_bMasterHide flag; or at least that is my
understanding of the related framework code (why is it so confusing?!)

Change-Id: I791fcea9e5e5313b6a5b776cb3187cbd1a028386
2013-11-15 11:11:47 +01:00
ab5d1fbfb4 SAL_WARN_UNUSED com::sun::uno::Any
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14 21:02:40 +01:00
24cad6a649 Move MediaDescriptor from comphelper to unotools
...so it will be able to use SvtSecurityOptions internally.

Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
2013-11-14 11:13:24 +01:00
d366c9b20e remove unnecessary sal_Unicode casts in various places
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14 08:17:32 +02:00
9c5a91efdb expand out the A2S macro
Which is not doing anything useful anymore.

Change-Id: I83422e811d52a77b65655924c07b55dd7229449c
2013-11-13 09:08:08 +02:00
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11 12:58:13 +02:00
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
c4a593b6b1 remove unnecessary use of OUString constructor in FRAMEWORK module
Change-Id: Icbed4f318043a166ed78fe0c49a53f87ebf7201d
2013-11-11 08:36:07 +02:00
897bf27a95 cppcheck: reduce scope
Change-Id: I06c97b99a55d8b291ea31e6a751ced01b0b80e23
2013-11-10 14:41:22 +01:00
dfe1a6fbd8 Unwind SFX_REFERER_USER
...and remove remaining unused content of sfx2/source/inc/referers.hxx.

Change-Id: I5c533f63e13da930f6944af0e85d4b061c30e5b0
2013-11-08 17:54:16 +01:00
15b5412fad fixincludeguards.sh: framework
Change-Id: Ia6f3cb21977095df45a176db2bf68f508c70191c
2013-11-05 09:28:53 +01:00
5285beeaa4 remove redundant calls to OUString constructor in if expression
Convert code like:
  if( aStr == OUString("xxxx") )
to this:
  if( aStr == "xxxx" )

Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04 10:11:08 +02:00
aeb41c9b9b remove redundant calls to OUString constructor
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-04 08:06:10 +02:00
b1f5986c57 StatusIndicatorFactory::impl_reschedule(): lock SolarMutex
... before calling Reschedule().

Change-Id: I244fdd1a4642ea0e1ad266f6d9c4c56527018952
2013-11-03 15:20:51 +01:00
5a10e33f4d Improve exception messages (for debugging)
Change-Id: Id2e00e0b0363c58c88585dd15f34156e57a7aaac
2013-11-01 09:00:17 +01:00
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
1beabca95b remove local css namespace definitions
As we have it globally in sal/types.h those are not necessary.

Change-Id: I18bba2c763c4680c4fa7fde4c5158953b5cfad82
2013-10-28 15:16:17 +01:00
dd28837249 vcl: mark more Image constructors as "explicit"
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
2013-10-22 14:42:17 +02:00
45e366eadb drop unnecessary tools/string includes
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
5c046a31e1 WaE: unused parameter 'SystemType'
Change-Id: I52717d85269dd1802b942ba19f5710b9e469faf1
2013-10-12 20:34:54 +03:00
87708fd311 Simplify
Change-Id: Ic2afa7e60da57c5b516a043f717dea21a3cf0d55
2013-10-12 19:17:21 +03:00
fd4d263d2d CID#738544 unitialized member
Change-Id: I4f2342776467594f3512af624a653a9b827a0afe
2013-10-09 16:59:45 +01:00
ad7b757a25 'ist' -> 'is' here and there.
Change-Id: I0a463c38214b95582db2c7b3979367255426c14e
2013-10-04 20:27:30 +02:00
6925df8b39 WaE: unused variable
Change-Id: I73aabeff7d28ef3526d18188c6fab2e0bc2529d7
2013-10-02 20:04:10 +03:00
ed2cd062eb -Werror,-Wunused-variable
Change-Id: I703d08f4c1080e5c5afaab9652ea2c18b4f365f1
2013-10-02 17:48:35 +02:00
a1c126c264 -Werror,-Wunused-variable
Change-Id: I548eec1fdcc862b76361c56724667f2d9f6e0950
2013-10-02 17:35:11 +02:00
bdc0e87a15 -Werror,-Wunused-const-variable
Change-Id: Iac6d103afb5d6ed3f59e589ec174f6aad253a0aa
2013-10-02 16:49:31 +02:00
eb103fa411 -Werror,-Wunused-const-variable
Change-Id: Id416a7bcb3ac3ea5354f6f7b5ec3daa1dc742f8d
2013-10-02 16:49:31 +02:00
2ad1494c6b -Werror,-Wunused-const-variable
Change-Id: I52bd479bd40031acc2742b93ab77420f26070b59
2013-10-02 16:49:31 +02:00
062855b4ae -Werror,-Wunused-const-variable
Change-Id: I93796237cb953445e42fde5822ad51bc3edcce10
2013-10-02 16:49:31 +02:00
7f436c1fd3 typo fixes in comments
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
7d491bec40 Everytimes -> Every time
Change-Id: Ib84cee7dbb493387760ce68c25ec442bf0a4a121
2013-09-26 10:37:00 +02:00
6a3cf741d1 Otherwhise -> Otherwise
Change-Id: Iaec23e1d240f675a04b52cd251c4cb2a1242bb44
2013-09-26 10:21:12 +02:00
a1bc57563f Some spellchecker love in the comments
Change-Id: I88dee4ae25ac57a78b72fa020b76e0d9b7709b31
2013-09-26 10:02:26 +02:00
98de5b40c8 Related: fdo#38838 remove UniString::EqualsIgnoreCaseAscii
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
2013-09-25 19:24:23 +02:00
05dd2fb998 Disable all features that rely on orcus.
Change-Id: I6dcf91491497cd9d3662adaeceb73b4b544a56c9
2013-09-18 22:37:58 -04:00
0cd21c2bed drop intermediate Strings
Change-Id: I7f730d4f5329525eda9f78514dcaa3788149d077
2013-09-17 10:11:08 +01:00
e8ecf30ea6 convert FRAMEWORK module from String to OUString
Change-Id: Iafa6b5f213d37093e7e46065c9264c7bb7fae377
2013-09-17 09:05:49 +02:00
c4f5b1745c Replace char[] by OUStringBuffer/OUString
Change-Id: I233d067b3fcb93c80ab3c458b19b4f60680fe84b
2013-09-14 01:23:15 +02:00