4439e5f689
loplugin:vclwidgets
...
Change-Id: I43f8530026261138585eb530b2bc83d3d9be704f
2015-07-16 10:54:10 +02:00
9edaebe651
Remove unused modelInvalid
...
Change-Id: I18701b367dcca36afb8e6f28645453294881683f
2015-07-16 10:52:54 +02:00
b1663b86ae
handle legend position combobox correctly
...
Change-Id: Ic19e8cd20d739761975db2b00cb92fd27f8ac4be
2015-07-16 08:15:20 +02:00
9ce5cfff0a
enable the chart sidebar again
...
Change-Id: I0ad9d962436562aa1026c50e5ec16f844f889eef
2015-07-16 08:15:20 +02:00
4be80459e5
adapt to UX discussion
...
Change-Id: I6a7ba1f13cddf20b2751f2ee113427db43978cfa
2015-07-16 08:15:20 +02:00
a40526eb95
adapt code to last round of discussions
...
Change-Id: Id0d2bae2a232f80ebe46cb55602c15c57b074e87
2015-07-16 08:15:20 +02:00
6503c1c9c4
handle change to grid line checkboxes
...
Change-Id: Ib39dc1669dfefe82eaefff1608de4fe1d4ef5832
2015-07-16 08:15:19 +02:00
374d3fbf89
handle changes to legend checkbox
...
Change-Id: I3901ce4f7664eb7b8eca50014f5916fd6ccb0854
2015-07-16 08:15:19 +02:00
234ac0e3e8
also react to title checkboxes
...
This needs to improved when tdf#92768 has been implemented. Also we need
to rethink the default strings.
Change-Id: I74b9bdf0caeaf314f103aa7b13dad3215e828423
2015-07-16 08:15:19 +02:00
209f082433
disable Z axis boxes for non-3D charts
...
Change-Id: I0a651dbed939be572e06e3389fa024cafc214854
2015-07-16 08:15:19 +02:00
c296eec292
react to changing the checkboxes: axis
...
Change-Id: Ic1296b9035dce00837b8e8d24cc63e1d9bda0b88
2015-07-16 08:15:18 +02:00
d380dbbc2b
wire axis visiblity
...
Change-Id: Ide5fe06f7ba6f477fd1bdf5f408915a023319675
2015-07-16 08:15:18 +02:00
c03d781e35
sidebar needs to listen to chart modifications
...
Change-Id: I3dd0ae1c1c7fe14ee08571e96b1804d5d9972e2c
2015-07-16 08:15:18 +02:00
49d2400f8d
remove my accidently committed debug messages
...
Change-Id: Ia890837520b57291ae119de30dc7586b65e30b81
2015-07-16 08:15:18 +02:00
20f0c633c9
remove unused member variables
...
Change-Id: I2db9b587eea0569df5225171244cee545d6155df
2015-07-16 08:15:18 +02:00
8630982a90
wire gridlines in chart elements panel
...
Change-Id: Ibf1e863d6cc469f0fcc42e0a6077cfa104b16ba1
2015-07-16 08:15:17 +02:00
6dbb9564f9
wire title and legend checkboxes
...
Change-Id: I4c6d5e213f44588cf2d53d9c12ed8033307fd863
2015-07-16 08:15:17 +02:00
1d0696a349
we need access to the chart model in the chart sidebar
...
Change-Id: I607b5ada047f84cd7a229640772a332702f93f1e
2015-07-16 08:15:17 +02:00
8de7d44f96
disable newly unused code since last disable
...
Change-Id: I9f0abc3963ac4687e29fc629f1b9e9bb1fffaf8a
2015-07-13 20:59:05 +01:00
f90307a937
disable that code for now
...
Change-Id: I9f65babd0314498145746c452180ccf4fab64720
Reviewed-on: https://gerrit.libreoffice.org/17020
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-07-13 18:20:05 +00:00
2aea9e37d6
Introduce generic sub toolbar controller
...
Currently many toolbar controllers are basically doing the
same thing - show some docked toolbar. So the idea here is
to have one generic controller that will handle all these
cases in a unified way. It will get the name of the toolbar
that it's supposed to show from the configuration, based on
the command it was registered for.
Right now it can handle both simple (i.e. with DROPDOWNONLY
bits) and split (i.e. with DROPDOWN bits) scenarios, where
for split kind it replaces the function (and the image) of
the main part of the button, with the last selected function,
for easy reusing. A button is considered to be a split one,
if the name of the initial default command was passed along
with the sub toolbar name, otherwise it will be a simple
button.
The core change is in framework/. Other parts are a usage
example, in form of converting the custom shapes buttons
to this new controller.
Change-Id: I087cc58c3db1889ca69a26546d4f00fe07e2a58d
Reviewed-on: https://gerrit.libreoffice.org/16967
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com >
2015-07-13 12:09:52 +00:00
5b16fff9ac
loplugin:staticmethods
...
Change-Id: I8b57b7ce707438ad3c7c901b03c94d9045585ed8
2015-07-13 09:21:51 +02:00
7f0161d88e
WaE: C2872 chart is ambiguous
...
Change-Id: Ib847a0f4ec804766727a2d7a247912f93b30045c
2015-07-12 21:28:45 +01:00
9c5fc87cee
WaE: C4065 switch contains default but no case
...
Change-Id: I33620609d0b39c8bedf5641101e5c0229364cde0
2015-07-12 21:27:48 +01:00
5d5667062c
add ChartElements panel
...
Change-Id: I935a0d637a9ea3a1716d6e839e65c4e565a2c840
2015-07-12 18:56:49 +02:00
b33b2afe6a
big step towards real chart sidebar
...
Change-Id: I9b7d1f963746f7689b02099fbae77c9c943bad58
2015-07-12 18:56:49 +02:00
efd13b27a4
finally manage to register chart2 in the ChartController
...
We need to do some jumps through pink hoops to connect the chart
controller with the host sidebar.
Would we use the chart window as parent for our sidebar the sidebar
would be directlz beside the chart and not at the border of the host
window.
Change-Id: Ica44ae370518882ef367999f57251b1256907016
2015-07-12 18:56:48 +02:00
498e03c2a3
fix crash
...
Change-Id: Ic1bc31b68c4a2aafb1e40ebff84fbf052df7041f
2015-07-12 18:56:47 +02:00
04716cb9ac
add SidebarChangeHandler to chart2
...
I still need to wire the correct frame to the correct sidebar for it to
work.
Change-Id: I0fecc2be674d6b024bc39e707930a4c30f67cb81
2015-07-12 18:56:47 +02:00
2b5ebcc45b
chart2: typed Link<>
...
Change-Id: I98c882d64cb4d6430390ac705f3f2208dd523598
2015-07-08 08:59:06 +02:00
799cc41b53
Fix typos
...
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0
Reviewed-on: https://gerrit.libreoffice.org/16834
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2015-07-08 05:48:18 +00:00
ffa8892c5a
Fix typos
...
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc
Reviewed-on: https://gerrit.libreoffice.org/16705
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2015-07-04 10:23:17 +00:00
1a8915ef83
Fix typos
...
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
Reviewed-on: https://gerrit.libreoffice.org/16582
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Andras Timar <andras.timar@collabora.com >
2015-06-30 15:57:12 +00:00
5d5dc059cb
Fix typos
...
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2015-06-28 12:35:58 +00:00
aade27554d
Fix typos
...
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-22 12:36:21 +00:00
4729774b24
remove unnecessary check for null when calling delete
...
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'
Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
dcf6abfcdf
cppcheck:unreadVariable
...
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15 14:06:31 +02:00
4ea281a3cc
cppcheck:redundantAssignment
...
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15 13:34:14 +02:00
b226928c6d
cppcheck: redundantCondition [part1]
...
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-14 12:17:55 +02:00
d203948fdb
convert 'it.begin() == it.end()' to 'it.empty()'
...
Change-Id: I244a9eb6bce6b1c649653ec38ebb9a39f8b4c145
Reviewed-on: https://gerrit.libreoffice.org/16212
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-06-11 06:48:29 +00:00
bc14d27dd0
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: If5ab427ab320e2623df182e6143c4e7123610eae
2015-06-08 16:23:25 +02:00
0f71828a95
cppcheck: noExplicitConstructor
...
Change-Id: I8b03c27188b02c3c4a9a9fbbe0df1fb1ae1c5caf
2015-06-08 11:14:38 +01:00
b9f9576949
WaE: ‘<::’ cannot begin a template-argument list
...
This is an internal include file deep inside chart2, so just use css::. The
file uses css:: already in a couple of places anyway. So maybe I should have
been brave and just changed all the ugly ::com::sun:⭐ : into css::?
Change-Id: I705db39ff55f3e47c7e9d2f79fee625d76a22ca0
2015-06-05 17:48:33 +03:00
81610561ed
uno::Sequence provides now begin and end
...
use begin() and end() when calling std::copy on an uno::Sequence
Inspired by commit b34b648fc3262c5d9aa295f621e8fe9c97d4c6b2
"uno::Sequence provides now begin and end"
Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b
Reviewed-on: https://gerrit.libreoffice.org/16057
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-06-04 06:35:44 +00:00
20bb2e7074
GL3D Bar chart -> experimental
...
Change-Id: I2d5948651e5c31a6ce3cadcc9ff09683a60d49bd
Reviewed-on: https://gerrit.libreoffice.org/16022
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Andras Timar <andras.timar@collabora.com >
2015-06-02 08:46:22 +00:00
7e5c1101cb
Time based charting -> experimental
...
Change-Id: I1c190be0ef226d1f14d083f292cf2ea15a6d1645
Reviewed-on: https://gerrit.libreoffice.org/16023
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Andras Timar <andras.timar@collabora.com >
2015-06-02 08:46:00 +00:00
9509ce6103
some whitespace clean-up
...
Change-Id: I80aa6692c528176e38b5414145b484a32a9906f6
2015-06-02 00:14:43 +02:00
ba81e5c6bd
tdf#91702 - fix stack-based MessBox allocation.
...
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
2015-05-29 12:16:28 +00:00
e0b2e6e3f7
loplugin:loopvartoosmall
...
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
2015-05-29 08:48:41 +02:00
cc7b8dab75
tdf#91633 - dispose chart data-table entries correctly.
...
Change-Id: Ia26df029888f47a0395ea3c8bd7e0e51a1706c2a
2015-05-26 17:54:28 +01:00
