ab9add5c96
loplugin:sallogareas
...
Change-Id: Ib1f06cb5f925535858bc14aab6f59ad7fd2a3a8d
2015-11-20 10:14:49 +01:00
162ae47a04
editeng lok: invalidate on scroll
...
E.g. when a Witer comment has long enough contents to get scrolled, the
desktop case repaints its contents by vcl::Window::Scroll(), followed by
a vcl::Window::Update(), i.e. vcl::Window::Invalidate() is not called.
The result of this in case of tiled rendering is that no tile is
repainted, so call vcl::Window::Invalidate() after scrolling manually.
A generic VCL-level invalidate-after-scroll is not wanted, as the
scrolling of the document contents and the main document window is not
in sync when tiled rendering.
Change-Id: I74296a0f0e52c92cf3db6aefa73f28bb2b202871
2015-11-19 16:35:03 +01:00
2224d88f6b
editeng: wrong default item for EE_PARA_FORBIDDENRULES
...
Change-Id: Idad6192fd1e3049913fac3dd906264fde6d1914e
2015-11-18 20:41:29 +01:00
6848461383
editeng: wrong default item for EE_PARA_HANGINGPUNCTUATION
...
Change-Id: Ib23b5847625964c701bda23d7c58ad32c6024c9b
2015-11-18 20:41:28 +01:00
2e9277c050
use unique_ptr for pImpl in editeng/
...
Change-Id: I43ae9f706db15594b3a0c5cba41436d009588393
2015-11-18 08:35:34 +02:00
61f168d987
Add SvStream::ReadUtf16 (don't assume sal_Unicode is unsigned short)
...
Change-Id: I74f34e3389582617fa83f8f4a3d6867cf87189e1
2015-11-17 10:36:13 +01:00
c830aa6401
editeng: fix SvxTableField::operator==()
...
This was erroneously returning false due to inverted dynamic_cast check,
causing "svl/source/items/itempool.cxx:750: unequal items in Put(): no
operator==?, with ID/pos 4048"
(regression from fa91dd31f39a24329d288d4e1cda28db3a16af0d)
Change-Id: I9c5b49150470fc78d58ecd2a2e990637627bd591
2015-11-17 10:20:34 +01:00
22e97c1308
editeng lok: respect origin of map mode for TEXT_SELECTION
...
With this, selections of Writer comment text show up at the correct
position, not at the top left corner of the window.
Change-Id: If865503d9a02a27730e382d65c42c706dd533a93
2015-11-13 17:30:53 +01:00
e988ab84f1
editeng lok: respect origin of map mode for INVALIDATE_VISIBLE_CURSOR
...
Writer comments are separate widgets, but we want to have coordinates in
absolutes twips, so give Writer a chance to inform us about the delta.
For now only do this in case the map unit is twips, as Impress sets the
origin already.
Change-Id: Idf340944165e44b0888c00965d6be7798712ff76
2015-11-13 13:34:03 +01:00
fa91dd31f3
5th step to remove tools/rtti.hxx
...
tools/rtti.hxx removed
completed the interface of some Sdr.* Items
and removed pseudo items
Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-11-11 10:49:30 +00:00
97ebf71c8b
editeng: boost::ptr_vector->std::vector<std::unique_ptr>
...
Change-Id: I49cf179016a0690cb87bc12880da8b1824ac01cc
2015-11-10 15:30:04 +02:00
5f86c1f379
editeng: boost::ptr_vector->std::vector<std::unique_ptr>
...
Change-Id: Iee1e64d22e799653bc58d6a72c57c55787e45d84
2015-11-10 15:30:03 +02:00
5a7a4325ec
editeng: boost::ptr_vector->std::vector<std::unique_ptr>
...
Change-Id: I2b4cdb3809de0e9c69253d2cd05714e15fdc8913
2015-11-10 15:30:03 +02:00
05b9c892b8
editeng: boost::ptr_vector->std::vector<std::unique_ptr>
...
Change-Id: I5b3d8e0e20938d8e66045ea6282f37afe29474e2
2015-11-10 15:30:03 +02:00
c1cd376c28
editeng: boost::ptr_vector->std::vector<std::unique_ptr>
...
Change-Id: I7a49ed58cb20c365308db703c67e43c6687f35e4
2015-11-10 15:30:03 +02:00
a249cfc2bc
editeng: boost::ptr_vector->std::vector<std::unique_ptr>
...
Change-Id: I562b1f7cd1e5e7f7fc03b8f54bd6117255703eb5
2015-11-10 15:30:03 +02:00
ed381a77fc
editeng: boost::ptr_vector->std::vector<std::unique_ptr>
...
Change-Id: I8fc80274e7eb33c81062f8514f63e6d0682d1b8f
2015-11-10 15:30:03 +02:00
d489e76a51
editeng: boost::ptr_vector->std::vector<std::unique_ptr>
...
Change-Id: I212c6b990da655ad7947154ca9e62981b049489e
2015-11-10 15:30:03 +02:00
bb4379a2e4
editeng: boost::ptr_vector->std::vector<std::unique_ptr>
...
Change-Id: Ifc44041290d44c5e4dcbd9a0882b99fe0f8f62a5
2015-11-10 15:30:03 +02:00
217f7f236f
loplugin:nullptr (automatic rewrite)
...
Change-Id: I9fe00eef7ddcd4a3c87e497a8d62f98e71a0d6d8
2015-11-10 10:31:24 +01:00
e31205f3ec
EditUndoRemoveChars::GetStr must return a reference
...
...as ImpEditEngine::ImpRemoveChars (editeng/source/editeng/impedit2.cxx) calls
pCurUndo->GetStr() += aStr;
Regression introduced with d5e11f5ffb741aabe7e43be78ef764a1f3cafd8e "convert
editeng/source/editeng/editundo.hxx from String to OUString."
Change-Id: Iab3dd3b861bca715a90e89e3a63a6f298657367d
2015-11-09 12:11:15 +01:00
6c80a8fe89
new loplugin: oncevar
...
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-09 08:34:40 +00:00
108ecc45ce
loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
...
Change-Id: Icf08e69ba327225da816bd57648d4242dcbf3280
2015-11-06 09:35:37 +01:00
609b227873
fix tdf#95488, crash in report wizard
...
This reverts commit bb76b8f10697f3d5ca1f9a2f19902b043bd61cd7
"loplugin:mergeclasses"
Change-Id: Ib65459ab45cd4cefa859ed75f9ddc4f070879b1d
2015-11-05 12:02:00 +02:00
f57a6593e2
editeng: Eliminate unecessary padding in classes
...
Edit the order of SvxLRSpaceItem and PaintFirstLineInfo members to
remove unecessary padding due to data alignment.
Change-Id: Icf2c92ef86a32384e51d1cb6f1a079b10995dfd5
Reviewed-on: https://gerrit.libreoffice.org/19763
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
2015-11-04 08:16:13 +00:00
2b48a5f155
dynamic_cast fixed again
...
changes commit 5ae015fc74330ac4c24b67370c59518084f1d201 to check the
SvxFieldItem
Change-Id: I2c327a0a16fdd3e9341365554e10fb6fe04e1efe
Reviewed-on: https://gerrit.libreoffice.org/19757
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-11-03 18:42:30 +00:00
b1704274d3
Wrong dynamic_cast
...
EditCharAttrib doesn't inherit from or related to SvxFieldItem
Moreover, we can see lines like this:
const SvxFieldItem* pFieldItem = dynamic_cast<const SvxFieldItem*>(pAttr->GetItem());
Change-Id: I9f5710dc4a9a4e71d31538620a9ddc1dedee063f
Reviewed-on: https://gerrit.libreoffice.org/19575
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-11-03 09:56:24 +00:00
be729e7721
tdf#94269: Replace "n" prefix for bool variables with "b"
...
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797
Signed-off-by: Michael Stahl <mstahl@redhat.com >
2015-11-02 23:40:57 +01:00
3c971162b5
use uno::Reference::set method instead of assignment
...
Change-Id: I150f213ab033f5fc1b50abe4e1529292206c9feb
Reviewed-on: https://gerrit.libreoffice.org/19689
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-31 12:56:38 +00:00
addb63fa8a
convert Sequence<XInterface> constructions to use initializer lists
...
Change-Id: I66475190cc0f18465c56b94af7bc0d5a1ca81242
2015-10-30 08:10:22 +02:00
644487a115
loplugin:unusedmethods
...
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861
Reviewed-on: https://gerrit.libreoffice.org/19231
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-27 08:20:43 +00:00
1fe9270955
Replace boost::bind by lambdas in editeng tree.
...
Change-Id: I3e0383757fb50e9223b5b87558e880859de7f396
Reviewed-on: https://gerrit.libreoffice.org/19619
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-27 05:42:48 +00:00
7076cc68fd
get rid of erroneous 0x7ff language mask
...
Change-Id: I2b3501967fc0088e0bebf6c366e033c61b652921
2015-10-23 20:36:45 +01:00
97893e56e6
more tdf#76964 fall back to primary language via getLanguage
...
Change-Id: I7718ff6f93f704e37e9a046cb07c497b2d533a2a
2015-10-23 20:27:53 +01:00
a1ff0745cc
Resolves: tdf#76964 fall back to primary language via getLanguage
...
instead of bittwiddling which ends up trying to resolve the
system language
Change-Id: I545bd5e39f99003ddedf3c90031e8b818edc1de2
2015-10-23 09:13:09 +01:00
a673713bb3
more removal of com::sun::star typedefs
...
Change-Id: Ia73f1b4f1dcfa3f0936359e744afe76e02dcd2eb
2015-10-21 15:10:24 +02:00
6dd98f8b94
loplugin:defaultparams
...
Change-Id: Id5e399309144b99757e172e69e8e6dbc5fbff365
2015-10-20 11:45:21 +02:00
ad6e444a31
loplugin:defaultparams
...
Change-Id: I62e0ec63ff09c200e0b621c8b042a976e8ce630e
2015-10-19 17:49:51 +02:00
c8479bdc5b
convert DBG_ASSERTWARNING to SAL_WARN_IF
...
I know the comment in debug.hxx said to use SAL_INFO, but SAL_WARN makes
much more sense.
Change-Id: I3d81f9db89ef8cebe1e4f2983941d69b4c7e6b7d
2015-10-19 13:08:29 +02:00
39e63bfac5
convert remaing DBG_WARNING to SAL_INFO
...
and drop the macro
Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-19 13:08:29 +02:00
1778ad2545
WaE: loplugin:defaultparams
...
Change-Id: I65f4cc10c4a3dc5ffc21b64d76dc32f1613a0062
2015-10-19 11:36:06 +03:00
c260c34be0
fix cppcheck:nullPointerRedundantCheck commit
...
fix my commit 2d64fcf4c8d3316ad9ae2232601678553dcad6a3
"cppcheck:nullPointerRedundantCheck"
Change-Id: I0875005d938b43a91e15c564a23d70cb097548a9
2015-10-19 09:44:30 +02:00
2d64fcf4c8
cppcheck:nullPointerRedundantCheck
...
Change-Id: I00a58a90f96e9eaf681239146213706e278ea5e1
Reviewed-on: https://gerrit.libreoffice.org/19421
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-19 06:48:51 +00:00
11754fd792
editeng tiled rendering: avoid selections callbacks in Paint()
...
Given that we emit selection callbacks on each logical operations (set
selection, deselect all, etc) already, it's not necessary to emit
callbacks in DrawSelection() when it's called from Paint().
Change-Id: I6781c71ee2f292de2a1c7d129fc49b514aca2be1
2015-10-16 11:25:50 +02:00
0e8a40e8b8
calling IsSet() before Call() on Link<> is unnecessary
...
the Call() already does a check
Found with:
git grep -A 1 -w 'IsSet()'
| grep -B 1 '.Call('
| grep ':'
| cut -d ':' -f 1
Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15 12:29:01 +02:00
f7764214f2
editeng: add EditView::GetSelectionRectangles()
...
This gives sd access to the selection rectangles as well (as opposed
only to the document model positions of selections).
Change-Id: Icb903e91f9e868573403b360bbe839705ddf2916
2015-10-13 16:42:41 +02:00
1716b3a338
remove some useless comments
...
found with git grep '// /'
Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-13 10:07:49 +02:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
bff4c13475
Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
...
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
1cb13d87b5
editeng, sw, sc: use comphelper::string::join()
...
Change-Id: I9b0a32271a965bc4089720ccb61b26b67ceab7b2
2015-10-08 08:37:58 +02:00
