wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
384,285 Commits 5 Branches 0 Tags
4c749b121c8b415ef2b7b0445ede1dc4ccc0e6d0
Commit Graph

160 Commits

Author SHA1 Message Date
Stephan Bergmann
b0339005b8 loplugin:sallogareas 
Change-Id: I2220ab194384fb397716bf3227d38716ba54f537
 2015-11-19 16:05:35 +01:00
Noel Grandin
8569c6d0ad use initialiser list for Sequence<OUString> 
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02
Reviewed-on: https://gerrit.libreoffice.org/19978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-16 08:35:42 +00:00
Noel Grandin
25aec383f9 use initialiser for Sequence<OUString> 
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:18:55 +00:00
Stephan Bergmann
06c5c63020 loplugin:nullptr (automatic rewrite) 
Change-Id: Ie178c474921c1695927a9b01a9972baf09fbb73d
 2015-11-10 10:31:27 +01:00
Stephan Bergmann
69ef5d40c2 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: Iff1f68969f0f044c59a92ab4c019c471511743f7
 2015-11-06 09:36:08 +01:00
Noel Grandin
7408498de3 loplugin:stringconstant 
Change-Id: I865efc1884b82d430fe7df2e432d43f5425a83d4
 2015-11-02 14:50:33 +02:00
Noel Grandin
5797d29e9e use uno::Reference::set method instead of assignment 
Change-Id: Ic979f8a7734d0ef7a915d47a875cdcd460c0cc58
 2015-11-02 12:23:16 +02:00
Stephan Bergmann
71b4afde11 loplugin:defaultparams 
Change-Id: Icf92bef2685c507dd61416260f662dfdd24354d5
 2015-10-19 17:50:20 +02:00
Noel Grandin
d191d1f9b6 com::sun::star->css in framework 
Change-Id: If5a77db83fcbef5ed436f2043ddeb7c515a840dc
Reviewed-on: https://gerrit.libreoffice.org/19356
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-14 06:37:16 +00:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Andrea Gelmini
a18fc918d5 Fix typos 
Change-Id: I051caee9ec6181074201ac4a8cb6fcec4fdf2293
Reviewed-on: https://gerrit.libreoffice.org/18951
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
 2015-09-30 13:50:06 +00:00
Stephan Bergmann
e9b7506415 loplugin:stringconstant: OUStringBuffer: appendAscii -> append 
Change-Id: Iadb6e16a7aca322a78a82ae1a52f5d085b300efc
 2015-08-31 08:03:15 +02:00
Noel Grandin
bd8b93fdff make PostUserEvent Link<> typed 
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
 2015-08-28 09:49:56 +02:00
Michael Stahl
9be8c4f212 sfx2: remove the global SidebarController::maSidebarControllerContainer 
This global was crashing on exit, unsurprising as it contains UNO
services that reference VCL objects.

It turns out that there is already a UNO singleton
framework::ContextChangeEventMultiplexer that effectively contains this
mapping already, so try to hook that up without creating a public API of
it, which is made quite a bit harder by framework's inexplicable
multitude of libraries.

Change-Id: I4baf67b42c630191fa8879d650eeb62520c331a5
 2015-07-14 11:50:44 +02:00
Andrea Gelmini
799cc41b53 Fix typos 
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0
Reviewed-on: https://gerrit.libreoffice.org/16834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-07-08 05:48:18 +00:00
Stephan Bergmann
a1a5588b1b loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I4a72a60d621c65e63310ef70b991f9c86f00494d
 2015-06-08 16:25:25 +02:00
Noel Grandin
10749bbf82 remove the last of the OUString #defines in header files 
Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
 2015-05-19 09:42:41 +02:00
Stephan Bergmann
4f00dce2b3 Use IMPL_[STATIC_]LINK_NOARG where applicable 
Change-Id: I1e24b032bdeea017b0e77c5446e55310899ce752
 2015-05-10 11:25:48 +02:00
Stephan Bergmann
9bb254fc85 NOINSTANCE is implied now in IMPL_STATIC_LINK... 
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
 2015-05-10 11:25:47 +02:00
Noel Grandin
b13fbd19b7 convert BMP_SCALE constant to scoped enum 
Change-Id: Ibc9f88d2588c028cd71aa86c26d970a73025ef22
 2015-05-06 09:01:30 +02:00
Stephan Bergmann
e6c08b6b30 Remove unnecessary STATIC_LINK macro 
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
 2015-04-29 18:29:59 +02:00
Michael Stahl
deb50a2a8a remove some @author tags from suspiciously unidiomatic code 
Change-Id: I3930420fe502978f8e14a688f2eb99c74d185f7b
 2015-04-25 22:45:51 +02:00
Stephan Bergmann
5d950b3afd Clean up C-style casts from pointers to void 
Change-Id: Ide77480339e35a886f0d33c2a194244064c02488
 2015-03-28 19:09:21 +01:00
Michael Stahl
465359c35f do not call virtual Commit() from dtors of utl::ConfigItem subclasses 
~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not
invoking its subclasses' ImplCommit() but its own.

Change-Id: Ic675e9cd3be1494c740a4f289be3bdbf0d1a122b
 2015-03-11 16:50:03 +01:00
Michael Stahl
765f6211b1 utl::ConfigItem::Commit() should call ClearModified() 
Rename the virtual function, and add a new non-virtual Commit() to do
that.

Change-Id: I09421df781ba965d6ff638b46cd8214fb3a00022
 2015-03-11 16:50:00 +01:00
Caolán McNamara
af6cd2356a rename MenuConfiguration::Attributes->MenuAttributes 
Change-Id: I2ada1394c4cbee7c27b02f241ee4a254597a5dd8
 2015-02-04 20:49:59 +00:00
Caolán McNamara
4904180247 fix leak from framework::AddonMenuManager::BuildMenu 
provide a callback when a menu item gets deleted

Change-Id: I5b5f1a181fb10f53f6b1fe7b5637d385e1517530
 2015-02-04 16:34:53 +00:00
Stephan Bergmann
d69fb68f30 Some more loplugin:cstylecast: framework 
Change-Id: Iebd80b596bcc1f740ff9f3b0f168472144cacbed
 2015-01-20 09:06:48 +01:00
Michael Stahl
2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load 
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
 2015-01-09 00:00:47 +01:00
Eike Rathke
8e94c40f13 how about scope 
Change-Id: I4c9e5f754974b6726fc86bc87775ba81832b3984
 2015-01-06 11:59:53 +01:00
Eike Rathke
549b7fad48 workaround a weird gcc optimization werror bug 
gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1)

framework/source/fwe/classes/addonsoptions.cxx: In member function ‘void framework::AddonsOptions_Impl::ReadAndAssociateImages(const rtl::OUString&, const rtl::OUString&)’:
framework/source/fwe/classes/addonsoptions.cxx:267:16: error: array subscript is above array bounds [-Werror=array-bounds]
         struct ImageEntry
                ^

The combination of aScaled[2]; aImage[2]; aURL[2] in sequence apparently lead
to some overoptimization and/or alignment problem, already declaring aImage[3]
helped (but not aScaled[3]), but that's not what we want.

Change-Id: I82e28d4887ab8072a17d0a9341d322c1cf61aedc
 2015-01-06 11:40:23 +01:00
Caolán McNamara
fd1372ba8b boost::unordered_map->std::unordered_map 
you can get debug stl this way

Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
 2015-01-02 16:14:36 +00:00
Stephan Bergmann
b98352996c framework: Use appropriate OUString functions on string constants 
Change-Id: I5da5cd3254102c742021b3e7b4e1f907ca897ca5
 2014-12-18 14:12:22 +01:00
Michael Weghorn
38b8c1e880 fdo#39440 reduce scope of local variables 
This addresses some cppcheck warnings.

Change-Id: I57f336c6ab3c418eac82397edeadecb4c1b168a7
Reviewed-on: https://gerrit.libreoffice.org/13495
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-12-16 20:42:30 +00:00
Stephan Bergmann
b733f5c4f4 framework: Use appropriate OUString functions on string constants 
Change-Id: I72bb5ff2ab8a55061072fde567fcc1c4a8e20a2f
 2014-12-12 17:52:18 +01:00
Stephan Bergmann
179810cdf2 Further clean-up 
Change-Id: I20049b482c831e4ac2221fddfe80deb9847e72c3
 2014-12-03 20:30:18 +01:00
Vishv Brahmbhatt
9de4fe9853 Code clean-up/consolidation task. 
Removing the duplicate code,and consolidating changes
by using  method "getExpandedFilePath" of comphelper.

Signed-off-by: Stephan Bergmann <sbergman@redhat.com>: adapted to recent change
from comphelper::getExpandedFilePath to comphelper::getExpandedUri; fixed the
two changes in framework to actually modify the by--non-const--ref argument;
fixed a loplugin:unreffun.  More clean-up to follow.

Change-Id: Ie8875bcb61b616385bd64151f0a915bf7cce04e5
 2014-12-03 20:30:18 +01:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use 
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
 2014-11-18 18:51:49 +01:00
Noel Grandin
a7542d38dd fdo#84938: replace MIB_ constants with enum 
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a
Reviewed-on: https://gerrit.libreoffice.org/12179
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-01 14:53:39 +00:00
Noel Grandin
035fe8a6aa fdo#84938: replace MENUITEM constants with enum 
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
 2014-10-23 12:55:35 +02:00
Stephan Bergmann
ad9498f8b8 More -Werror,-Wunused-private-field 
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
 2014-10-15 15:58:56 +02:00
Caolán McNamara
9a65df2513 coverity#1078526 Logically dead code 
Change-Id: I203511fcb1e740d7d371821d49a7c13a72e6fc3b
 2014-10-03 09:07:56 +01:00
Noel Grandin
1777c425fe loplugin: cstylecast 
Change-Id: I4a8786f335b5f9a14116c546d32f1ff6cff99930
 2014-10-02 07:37:19 +02:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Julien Nabet
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20 
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
 2014-05-23 22:11:52 +02:00
Tsutomu Uchino
61ce018658 Resolves: #i86528# use the module manager to identify the context... 
for addons menu merging

(cherry picked from commit 2aac0070dbef6c1ad7eeccf7d4015cdcbffe067e)

Conflicts:
	framework/source/classes/menumanager.cxx
	framework/source/fwe/classes/addonmenu.cxx
	framework/source/uielement/menubarmanager.cxx
	include/framework/addonmenu.hxx

Change-Id: I3b606671db3a4c6ba8ed2b850e01e1ac91db7581
 2014-05-19 13:28:17 +01:00
Hussian Alamri
b1e29a6ac5 Single line between methods 2014-05-17 21:14:06 +01:00
Julien Nabet
68741d0055 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part13 
Change-Id: Ieecfd7ccb10c75ac639d0ba8e7cb588607097c2a
 2014-05-15 22:52:22 +02:00
Hussian Alamri
493bd11fcb Removed redundant private methods comments 2014-05-14 14:17:01 +01:00
Noel Grandin
248145f99e Find places where uno::Sequence is passed by value. 
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.

Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-05-14 08:10:22 +00:00