Commit Graph

7342 Commits

Author SHA1 Message Date
67a6bfb1f1 crashtesting: fdo30583-1 hits the Clone ugly tree all the way down
Change-Id: I091c3a61a28275e090975016908e3b25c7506fba
2015-11-23 21:21:38 +00:00
eb0da37545 crashtesting: ooo55544-2.sxi, etc. missing Clones
Change-Id: I3e1b8f78289500bad8013e858f9abf03ab14914a
2015-11-23 20:39:04 +00:00
d058765ff3 updae getTileMode
Change-Id: Ic8d67f08d40f475020c0534570fe3bea07aa431b
2015-11-23 14:26:00 +00:00
b639fe60ea VirtualDevices either match another device depth, or are 1 bit
cairo can therefore always render to a svp virtual device with
need for a fallback

Change-Id: I5d03ae541820389e26f7448444444be009fb28a4
2015-11-23 14:25:59 +00:00
c43a3a5867 establish that Virtual Devices either match Physical Device depth or ...
are 1 or (rarely) 8 bit and lock that down.

Change-Id: I3d946ebef34ffb71c5adea7aa420af50e9584e05
2015-11-23 14:25:59 +00:00
a4fc2b364f vcl: simplify Image internals
Image could be of 2 types - BITMAP or IMAGE, where BITMAP used to
store the content in a Bitmap and IMAGE in a ImplImageData, which
contained a BitmapEx. This was refactored with this commit to
always store the content in a BitmapEx and there are no distinct
image types anymore. This greatly simplfies the code.

Drawing of the image in case of type IMAGE was done in the class
ImplImageBmp which also modified the image according to
DrawImageFlags (for example to create a "disabled" image). This
was moved to ImplImage and the bitmap manipulation code was moved
to BitmapProcessor (done in previous commits).

Change-Id: Iec9f63a7c05618c457d8465f1ec60ed4f16bd579
2015-11-23 13:59:25 +01:00
49b0711dad vcl: add colorizeImage to BitmapProcessor
Change-Id: Ic90368e83d7f9a187eb8404d8aaec4380ff5bcb1
2015-11-23 13:59:25 +01:00
15f66df860 vcl: Bitmap processor to create a disabled image
Change-Id: Iba5d86988736fa28329e1ba2783dfb15e37815a8
2015-11-23 13:59:24 +01:00
d95a715dd8 remove unused constructor parameter
Change-Id: Ia2d1a8d7d43ceac36b6bce87f5a733d6bce3bd6f
2015-11-23 13:59:24 +01:00
56a9594649 Update-check, expand to allow reporting of H/W and OS versions.
Off by default.
Expand config options to show the user agent used.
Re-use this to show more useful info in Help->About too.

Change-Id: I1044116ef9beeb341a537c0f4451dca54e198f67
Reviewed-on: https://gerrit.libreoffice.org/20098
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-11-23 11:18:08 +00:00
91cbbb7797 loplugin:sallogareas
Change-Id: Ibffaa2e3924877b22abbcd17aaa8fac01607f639
2015-11-23 09:56:10 +01:00
fc06f801ee LOK: add Document::getTileMode()
So that clients can know if they get old-style RGBA or new-style ARGB
output in paintTile().

Change-Id: Icfde4b3259444b3524e64478ccd976664a3fe0ed
2015-11-23 09:52:32 +01:00
229583f298 Fix build
Change-Id: I310d10793613bae05d7b89f6cb4773a1c2d5556b
2015-11-23 00:09:38 +02:00
1335f3bd80 SvxSmartTagsControl: Do not leak sub menus
And while on it, move other things to smart pointers as well.

Change-Id: I8b234b8a9fe60e0ca82bb08e48f6b7db94cbcd4d
2015-11-23 00:04:06 +02:00
fae2fa5570 crashtesting: fdo72067-2.odp missing SdrEdgeLineDeltaAnzItem::Clone
Change-Id: I6dea8c690d07b670358f8488c6be83ec49c8ee43
2015-11-22 21:02:27 +00:00
ec5250dcc6 loplugin:staticmethods
Change-Id: Ia306219fdcce4633e85c34db343a99b21e88157e
2015-11-20 16:03:37 +01:00
536c259cb9 tdf#67770 store sidebar elements states
deck & panel states at user registry level
when disposing a sidebar

if a shared deck (with "any" context application) is modified,
it apply to all applications (eg. Gallery between calc and writer); TODO ?

clean ResourceManager Get/Set const/non-const

add panels when deck is created & refactoring

* macro example

Sub Main

controller = thisComponent.currentcontroller
sidebar = thisComponent.currentcontroller.getSidebar()

sidebar.setVisible(true)

decks = sidebar.getdecks()
deck = decks.getByName("PropertyDeck")

deck.activate(true)
deck.setTitle("new deck title")
deck.moveLast()

panels = deck.getPanels()
panel = panels.getByName("TextPropertyPanel")

panel.setTitle("new panel title")
panel.expand(true) ' expand and collapse other
panel.moveLast()

End Sub

Change-Id: I2552000af92a366ebb51a479962a094b72e400b6
Reviewed-on: https://gerrit.libreoffice.org/17992
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-11-20 13:33:29 +00:00
b8793748b0 Seems more natural to pass a homogenous list by initializer_list
...than by template parameter pack (even if that requires using ServiceDecl*, as
initializer_list cannot take reference types)

Change-Id: Ia986201b52d8daedfe925f132ebc79bc2c0ba378
2015-11-20 13:39:52 +01:00
009face61b Revert "vcl: Initial NotebookBar implementation."
Will use a different approach for NotebookBar.
Also this should not be in 5.1.

This reverts commit 8c1014021dbe9da2e18233d215b970f5359db67b.

Change-Id: Ic699723818a890bf4c3be3a2c045527148bd118b
Reviewed-on: https://gerrit.libreoffice.org/20075
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-20 11:14:24 +00:00
6f5c6cf490 mark WeakReference with SAL_WARN_UNUSED
Change-Id: I9d56cdecba8066058a0c6f128720534fcf6f6e34
2015-11-20 11:48:48 +02:00
ab9add5c96 loplugin:sallogareas
Change-Id: Ib1f06cb5f925535858bc14aab6f59ad7fd2a3a8d
2015-11-20 10:14:49 +01:00
e58120920f tdf#95938 Toolbar context menu has no commands
because of an integer overflow

Change-Id: I75103450d0af59fd6f3196f451984e0dce45c693
Reviewed-on: https://gerrit.libreoffice.org/20072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-20 09:03:55 +00:00
fe3fd05966 add mapKeysToSequence/mapValuesToSequence methods to comphelper
and use them

Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec
Reviewed-on: https://gerrit.libreoffice.org/20055
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-20 08:14:13 +00:00
b0339005b8 loplugin:sallogareas
Change-Id: I2220ab194384fb397716bf3227d38716ba54f537
2015-11-19 16:05:35 +01:00
a3eec8a043 Toolbar: Add 'Save As' to 'Save' dropdown
Change-Id: I6597ae5569b29d09a8c44fc9a55b71166aa37b05
2015-11-19 13:39:17 +01:00
0e6e0cea8f Add OpenGLContext::UseNoProgram()
Will be useful in cases where there is some external library code that uses
shaders outside of our OpenGLContext.

Change-Id: I59c57e3225f55d13e69b6a9b7c0db1a7487c586d
2015-11-19 14:05:29 +02:00
6480b4d11a move translating a command name to image name out of framework
This is the first step to decouple resolving of command names to
image (icon) names. This is necessary to make allow additional
processing of images before the image is passed on and better
decision which image source to take.

Change-Id: I129dc6a1ae812aaaca32696ef2a2749d5fa86a54
2015-11-19 13:02:53 +01:00
f1132fd50a SystemMenuData::nSize is never read
...and of little use if all users of SystemMenuData agree on the definition in
vcl/sysdata.hxx

Change-Id: Id102a30074b611e3ad37ce69ce27c929f4505495
Reviewed-on: https://gerrit.libreoffice.org/20044
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-18 21:10:41 +00:00
78214c982e Revert "ToolBox: Remove unused methods"
The ImplLoadRes method *is* used in
ToolBox::ToolBox( vcl::Window* pParent, const ResId& rResId ).
This change breaks the navigator panel, and therefore the
JunitTest_toolkit_unoapi_1 test.

This reverts commit 99648095012187ef284d0a9399a8e12878b2a370.
2015-11-18 22:26:32 +02:00
eedcc2c45c cosmetics
Change-Id: Ic06bef4c80426b97a2613fe296ae0aa0ee55a215
2015-11-18 21:02:07 +01:00
270f8ea48b rename FormulaToken HasForceArray to IsInForceArray
... to name it was it does and to distinguish from
ScParameterClassification::HasForceArray(OpCode) which IS about a
function having ForceArray parameters.

Change-Id: I8af4e1d0353cdb5ad0a9b837ae0763dc77242734
2015-11-18 21:02:06 +01:00
79f4b7a7c4 svx: SdrEdgeNode1HorzDistItem etc. missing Clone overrides
Change-Id: I2bc2de3c3a71dd54e432905c129a3dbd5395f6ab
2015-11-18 20:41:28 +01:00
0ea68eecdd gtktiledviewer: allow passing initializeForRendering() arguments
Change-Id: Ic7b52764cf2fedbf73d4dcaaf36d1055b8ee22f2
2015-11-18 16:39:18 +01:00
479325dec8 vcl::ITiledRenderable::initializeForTiledRendering: support init. arguments
Change-Id: I9a6a75457078dc6383673f4c1a2012b69b5cefdd
2015-11-18 16:39:18 +01:00
4bddfc00d2 lok::Document::initializeForRendering: support init. arguments
Change-Id: I8aaf19a50f25f495cb87fba7ff6a4b0f56ed7d80
2015-11-18 16:39:17 +01:00
0b07406f71 Use C++11 char16_t for sal_Unicode
...in LIBO_INTERNAL_ONLY, __cplusplus, non-MSVC case.

It turns out that sal_Unicode happens to not be mangled into any symbols that
make up the stable URE interface, so (for LIBO_INTERNAL_ONLY, at least) we are
free to replace the typedef to sal_uInt16 with a typedef to any integral type
layout-compatible with that.  (sal_Unicode does appear in some symbols in sal's
PRIVATE_textenc.1 section, but that is private between the sal and sal_textenc
libraries, so changing those symbols does not require a change of SONAME.)
C++11 chart16_t is the obvious choice (and will ultimately allow using u"..."
to write literals of type array-of-sal_Unicode).  Reportedly, char16_t is
supported since GCC 4.4 and Clang 2.9 but will only be available in MSVC 2015.

For plain C, we continue to use sal_uInt16.  We could theoretically use C11
char16_t from <uchar.h>, but at least the Mac OS X 10.11 SDK still does not
offer that C11 header.

For MSVC, we continue to use wchar_t (which is actually unsigned short, due to
/Zc:wchar_t-) for now.  Potential options there include dropping /Zc:wchar_t-
and using true wchar_t, or using C++11 char16_t once support for MSVC 2013 is
dropped.

Some code needed to be adapted that was written in a way assuming that
sal_Unicode is unsigned short (which indicates that changing sal_Unicode for
non-LIBO_INTERNAL_ONLY would be an ABI change).  OUStringBuffer::append can now
differentiate between being called with sal_Unicode (to append a single
character) and erroneously being called with sal_uInt16 (intending to append a
number's textual representation, for which the sal_Int32 overload must be used
instead).  Bugs found are 379fe0409e7973b36210cffa3dd1dfd4032f0ecc "Assume that
this code wants to append a number, not a character" and
dc148335a6a438848325f24c49198fba81043279 "Assume this wants to append the
numerical representation."

The GDB support for pretty-printing of sal_Unicode-related data in
solenv/gdb/libreoffice/sal.py can presumably be simplified now.

Change-Id: I445b3a80e65b7cb004d9e08b38bdc9ee93bc9401
Reviewed-on: https://gerrit.libreoffice.org/20036
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-18 15:20:43 +00:00
5da5076871 Unify menu-based toolbar controllers
The new GenericPopupToolbarController takes by default
the popup menu controller that registered for the same
.uno:Something command, and sets ToolBoxItemBits to
ToolBoxItemBits::DROPDOWNONLY. If a different command
specified using the "Value" property - takes the popup
menu controller that registered for this command, and
sets bits to ToolBoxItemBits::DROPDOWN.

Change-Id: I75c5300bd27fcc9f618f2ee0df2aa6aefd088239
Reviewed-on: https://gerrit.libreoffice.org/20040
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-11-18 15:16:58 +00:00
9964809501 ToolBox: Remove unused methods
Change-Id: Ic56cf27c61a904278770f0617d827e574d1eae68
2015-11-18 16:05:44 +01:00
ee655627ad xmloff: add meta:generator constants LO_43x and LO_44x
Change-Id: I1d962ad637f19b02855616edebcedbad719689c5
2015-11-18 14:30:38 +01:00
2af0870fae xmloff: document potential pitfall with SvI18NMap usage
Change-Id: I37050203f9d7b4f04b6d0b0dc5c4e04855d017f7
2015-11-18 14:30:37 +01:00
5328bb57e7 Indentation fixes
Change-Id: Ib508e6f3c89266660e6163bbef2c7f50f5d01806
2015-11-18 12:58:10 +01:00
53f16c39f5 remove unused typedefs and inline use-once typedefs
and improve the script a little

Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84
Reviewed-on: https://gerrit.libreoffice.org/20033
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-18 10:38:08 +00:00
2e9277c050 use unique_ptr for pImpl in editeng/
Change-Id: I43ae9f706db15594b3a0c5cba41436d009588393
2015-11-18 08:35:34 +02:00
032dae364b use unique_ptr for pImpl in sfx2/
Change-Id: I564fa80a2642a4849127f3c25236634289b5b93d
2015-11-18 08:35:34 +02:00
9c205723fc use unique_ptr for pImpl in sax/
Change-Id: I0bef03451437cbdc5b0fed6b67690ac1d547291d
2015-11-18 08:35:34 +02:00
0d62716f67 use unique_ptr for pImpl in svl/
Change-Id: Ieef897314ac0f056c0a09a5182ca59800fd58f41
2015-11-18 08:35:34 +02:00
f43db67355 use unique_ptr for pImpl in svtools/
Change-Id: Ic82db5859464978ca58094e2b6f44e3c9ba30b4c
2015-11-18 08:35:34 +02:00
d9e6270392 loplugin:unnecessaryvirtual
update the plugin with lessons learned from the mergeclasses plugin and
re-run it

Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711
Reviewed-on: https://gerrit.libreoffice.org/20015
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17 12:26:32 +00:00
be3d2309f0 other #includes should be AFTER the include-once #define
found with the following script:
git ls-files *.hxx | xargs perl -0777 -ne 'if
(/include.*
.*
.*

"; close ARGV }'

Change-Id: I3afb0e81eb315c34bc0eb6bb4733dd1f0537d5c0
2015-11-17 14:24:58 +02:00
048a32d903 use unique_ptr for pImpl in tools/
Change-Id: I7ac7eca32a67524f6c87696c16b16128e6d8518b
2015-11-17 13:21:49 +02:00