wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
393,172 Commits 5 Branches 0 Tags
4e596d1cb10e0902c354ce8a94f9d1fc7e6e0cf2
Commit Graph

965 Commits

Author SHA1 Message Date
Caolán McNamara
4e596d1cb1 drop dramatic distracting comment 
Change-Id: Ic4b5537075e7ea9a713409982bb21e12f6b53e3f
Reviewed-on: https://gerrit.libreoffice.org/26271
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-06-14 14:53:44 +00:00
Stephan Bergmann
9c6a58f8c4 Clean up uses of Any::getValue() in basic 
Change-Id: Ice269eae6b0278d5e089d973aae72b3f871c1272
 2016-06-14 16:02:55 +02:00
Michael Stahl
62d270116b tools: rename SvStream::Read/Write to ReadBytes/WriteBytes 
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a
Reviewed-on: https://gerrit.libreoffice.org/25972
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-06-06 18:09:11 +00:00
Noel Grandin
850a8d27ca Convert GRAPHIC to scoped enum 
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea
Reviewed-on: https://gerrit.libreoffice.org/25534
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-27 12:59:23 +00:00
Noel Grandin
f107d45381 Convert SbxClassType to scoped enum 
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b
Reviewed-on: https://gerrit.libreoffice.org/25259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-23 11:49:32 +00:00
Noel Grandin
8762aa986d clang-tidy modernize-loop-convert in b* 
Change-Id: I8ac6eb59e213eafa78e3dc4578738b53e8adef5b
 2016-04-21 10:27:17 +02:00
Stephan Bergmann
d29c682259 Avoid reserved identifiers 
Change-Id: If64f146fd9c6417ed16d459cef39b3a2d47bfb4d
 2016-04-12 15:50:19 +02:00
Noel Grandin
f678b82f0e clang-tidy performance-unnecessary-value-param in basic 
Change-Id: I997213ca28efc2df04d454ffaf3c81c9cbad09ac
 2016-04-11 11:38:57 +02:00
Julien Nabet
43109b751b tdf#99089: avoid some crashes in Basic 
First stacktrace:

soffice.bin: /home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx:577:
sal_Unicode rtl::OUString::operator[](sal_Int32) const:
Assertion `index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())' failed.
...
3  0x00002aaaab327452 in __GI___assert_fail (assertion=0x2aaaaeea62a8 "index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())", file=0x2aaaaeea6260 "/home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx", line=577, function=0x2aaaaeea6860 <rtl::OUString::operator[](int) const::__PRETTY_FUNCTION__> "sal_Unicode rtl::OUString::operator[](sal_Int32) const") at assert.c:101
4  0x00002aaaaed91e89 in rtl::OUString::operator[](int) const (this=0x7fffffff2770, index=0) at /home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx:577
5  0x00002aaaaee1c66f in SbRtl_Val(StarBASIC*, SbxArray&, bool) (pBasic=0xa2a7ec0, rPar=..., bWrite=false)
    at /home/julien/compile-libreoffice/libreoffice/basic/source/runtime/methods.cxx:1792

Second stacktrace:

0x00002aaaaee6054d in printfmtstr (rStr="", rRes="", rFmt="\£0.##") at /home/julien/compile-libreoffice/libreoffice/basic/source/sbx/sbxscan.cxx:534
534             while( *pFmt != '\' );
(gdb) bt
0  0x00002aaaaee6054d in printfmtstr(rtl::OUString const&, rtl::OUString&, rtl::OUString const&) (rStr="", rRes="", rFmt="\£0.##")
    at /home/julien/compile-libreoffice/libreoffice/basic/source/sbx/sbxscan.cxx:534
1  0x00002aaaaee617ce in SbxValue::Format(rtl::OUString&, rtl::OUString const*) const (this=0xb12dd60, rRes="", pFmt=0x7fffffff20e0)
    at /home/julien/compile-libreoffice/libreoffice/basic/source/sbx/sbxscan.cxx:883
2  0x00002aaaaee217af in SbRtl_Format(StarBASIC*, SbxArray&, bool) (pBasic=0xa2cffa0, rPar=..., bWrite=false)
    at /home/julien/compile-libreoffice/libreoffice/basic/source/runtime/methods.cxx:3519

Change-Id: I1798a1545ce08efa9d6fc39f4696195f9dc96c67
Reviewed-on: https://gerrit.libreoffice.org/23956
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-04-10 08:17:56 +00:00
Stephan Bergmann
f7a3bdf623 Turn SbiOpcode into scoped enum 
Change-Id: I75d808dd3a42e57e7f55bad97e24fef65bb62dc6
 2016-04-06 08:31:46 +02:00
Arnaud Versini
c1e4d402c6 BASIC : Use a vector to store the argv stack 
Change-Id: I29c93aec598b7f784f549ce05f6b32dfabbfc3ad
Reviewed-on: https://gerrit.libreoffice.org/23815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2016-04-04 19:44:19 +00:00
Jochen Nitschke
8c2f2e1dd7 tdf#94306 replace boost::noncopyable in .. 
.. accessibility, avmedia, basctl, basic and bridges
remove boost from module if not needed anymore

Change-Id: I6177f8276766a0a7df1703e81bf1b448912df6e2
Reviewed-on: https://gerrit.libreoffice.org/23744
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-04-04 06:54:36 +00:00
Arnaud Versini
917e3656e9 BASIC : Use a vector to store the go sub stack. 
Change-Id: I80987f3f7c036279a8292a7fbbd2dcd232196226
Reviewed-on: https://gerrit.libreoffice.org/23753
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2016-04-03 17:34:04 +00:00
Noel Grandin
402572e25c loplugin:constantparam in basic 
Change-Id: I6831cb8628eed76db35070934f62dccb1345ba12
 2016-03-23 11:22:34 +02:00
Arnaud Versini
bb3930bb91 BASIC : Use std::vector in SbiRuntime to save references 
Change-Id: Ica819538b39e58416825e651d057620a66f731cd
Reviewed-on: https://gerrit.libreoffice.org/23193
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2016-03-20 12:56:04 +00:00
Steven Guo
5819268ad7 tdf#94306 Replace boost::noncopyable with plain C++11 deleted copy ctors 
Replaced boost::noncopyable with plain C++11 deleted copy ctors
in /basic/* files.

Change-Id: I9c0eb0a51ec5cb25c88c72b55f42864e73006e6b
Reviewed-on: https://gerrit.libreoffice.org/22969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-03-08 16:10:46 +00:00
Stephan Bergmann
29cb1f1923 Remove ancient StarPortal leftovers 
No UNO bridge has a "user" token in its description anyway, so
needsSecurityRestrictions always returned false.

Change-Id: Ibc3aa25212a2e8b245c13578fa29582be42791e6
 2016-03-08 15:06:39 +01:00
Steven Guo
472d900e81 tdf84938 Replaced Sb_Attr_ defined constants with enum class in runtime.hxx 
Replaced the #define Sb_Attr_* constants with SbAttributes enum class in runtime.hxx and adjusted uses in methods.cxx.

Change-Id: Ic7f6f6452849ffc9675ffd697ffc130276082318
Reviewed-on: https://gerrit.libreoffice.org/22948
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-07 09:06:12 +00:00
Noel Grandin
37a6bafea8 loplugin:unuseddefaultparam in various 
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0
Reviewed-on: https://gerrit.libreoffice.org/22900
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-07 05:56:59 +00:00
Noel Grandin
bd2bf6bd55 loplugin:unuseddefaultparams in basic 
Change-Id: I286efdac6af47a859693fccc71b445915f76945c
 2016-03-03 08:11:02 +02:00
baltasarq
d9dacecd90 tdf#84938 Change average enum for scoped enum 
This is a [partial] patch for tdf#84938, involving the substitution of an average enum for a scoped one.

Change-Id: I4b3a19914d30a14dec2640355ba392b943e1ddd7
Reviewed-on: https://gerrit.libreoffice.org/22808
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-02 12:42:24 +00:00
Eike Rathke
c20c697294 change to SearchOptions2 
Change-Id: I07a72492f1cdc566109bf8e9247368558f420abe
 2016-02-25 17:33:36 +01:00
Noel Grandin
2d0dab5b15 loplugin:commaoperator in basic/ 
Change-Id: I320a06e50d032a55d8d5e6354959c12327e319ee
 2016-02-22 16:55:11 +02:00
Noel Grandin
2087484c65 use consistent #define checks for the Windows platform 
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro

In this stage we focus on replacing usage of the WIN macro

Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-17 11:33:57 +00:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Eike Rathke
599f0cbe1d interface to new XTextSearch2 with SearchOptions2, tdf#72196 
Places that had utl::TextSearch::UpgradeToSearchOptions2() introduced
are worth an inspection if the new SearchAlgorithms2::WILDCARD search
should be supported or at least use SearchOptions2 instead of
SearchOptions to eliminate the small performance penalty that conversion
involves.

Change-Id: I565f73af2b551ae9ad0f488e672823dc6c5c1109
 2016-02-05 17:02:47 +01:00
Andrea Gelmini
fbec6ac089 Fix typos 
Change-Id: I3fba2c76c83381eb398c80947ef4849bccf7ab27
Reviewed-on: https://gerrit.libreoffice.org/21078
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-01-05 13:40:54 +00:00
Andrea Gelmini
92e60e1b80 Fix typos 
Change-Id: I1b79005d9c4e32325b8dadcc4f805975d6bf2727
Reviewed-on: https://gerrit.libreoffice.org/21103
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
 2016-01-05 07:32:28 +00:00
Matteo Casalin
cb98c423bb sal_uLong/sal_uIntPtr/sal_uInt16 to sal_uInt32 
also avoid some explicit temporaries and group some checks.

Change-Id: I7795b208dde53fd383b8c75f72dd9f56429aea2b
 2015-12-27 16:51:27 +01:00
Matteo Casalin
7d8919d2d5 sal_uLong/sal_uIntPtr for ScNumFormatAbbrev 
Change-Id: I45f2a43fe4295e44691ab00c93af3fca41b1dcfa
 2015-12-27 16:51:26 +01:00
Damjan Jovanovic
98f0e0eda5 Resolves: #i19221# Print Tab(5); "Hello" does not work 
Implement the Tab() function in AOO Basic.

Patch by: me

(cherry picked from commit fa1315d25186643ea537972609c117e0c9bb1fbc)

Change-Id: Ifa9843661ce3862347c6351a078ddb207169182a
 2015-12-15 13:48:28 +00:00
Stephan Bergmann
c4c059beb3 DBG_TRACE_BASIC/PROFILING had been rotting for quite some time now 
...e.g., it still used the long-gone tools String class

Change-Id: I9d1930c72fbae3208a0f3da14c6991f30d89a9bc
 2015-12-10 08:18:15 +01:00
Oliver Specht
fa91dd31f3 5th step to remove tools/rtti.hxx 
tools/rtti.hxx removed
completed the interface of some Sdr.*  Items
and removed pseudo items

Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-11-11 10:49:30 +00:00
Noel Grandin
db17d3c17c new loplugin: memoryvar 
detect when we can convert a new/delete sequence on a local variable to
use std::unique_ptr

Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc
Reviewed-on: https://gerrit.libreoffice.org/19884
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-11 07:16:20 +00:00
Damjan Jovanovic
f7715e6821 Resolves: #i61854# Basic: Default title of Msgboxes should be changed 
Found by: berend dot cornelius at germany dot sun dot com
Patch by: Pathangi Janardhanan Jatinshravan <JATINSHR001 at e dot ntu dot edu dot sg>
Review by: Damjan Jovanovic

(cherry picked from commit 519770a2b47d4bb95a7616cedcc1582ae83ab205)

Change-Id: I61c9eacd285c8335925f1569b64bb2d600caf545
 2015-11-10 09:45:21 +00:00
Stephan Bergmann
08e49fa337 loplugin:nullptr (automatic rewrite) 
Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
 2015-11-10 10:31:17 +01:00
Stephan Bergmann
a80bab7058 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: I9979100550a86ac3f42d74a5403fb3ffd9d5006b
 2015-11-06 09:34:39 +01:00
Damjan Jovanovic
42a63dd0e8 Resolves: #i61277# Basic open file with random access erases all data. 
StarBasic tries to emulate truncation of files opened for writing
by deleting them before opening them (if they exist). However there
are exclusion to the truncation behaviour when the file is opened
in append mode or is a binary file. Another exclusion - that was
missing with disasterous consequences - is that the file should
not be truncated when opened in random access mode.

(cherry picked from commit 72b2f07ccac7578ef36fc2b92dcba49abe397ebc)

Change-Id: Ic0053039ce5fd67ad42bf5332ae301d83f1a158d
 2015-11-04 14:04:36 +00:00
Noel Grandin
59b072e22b yyyyy 
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
 2015-11-04 14:10:44 +02:00
Benjamin Ni
be729e7721 tdf#94269: Replace "n" prefix for bool variables with "b" 
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797
Signed-off-by: Michael Stahl <mstahl@redhat.com>
 2015-11-02 23:40:57 +01:00
Stephan Bergmann
fc0b9a3493 loplugin:defaultparams 
Change-Id: I5a3852f85f20543165e174da9cd9a36da9a3df8d
 2015-10-20 11:44:49 +02:00
Stephan Bergmann
af9684f604 loplugin:defaultparams 
Change-Id: Ib0f01af2c7a7186d138369c177a563b322a87214
 2015-10-19 17:49:12 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Caolán McNamara
31ee230b6e Related: tdf#94814 some cleanup of static_cast following dynamic_cast 
to the same type

Change-Id: I197e88acbc30f8e8bb9e7f2d54803971df6062af
 2015-10-06 15:10:51 +01:00
Stephan Bergmann
e8233e1510 clang-analyzer-deadcode.DeadStores 
Change-Id: I03769bd4105e4e1d140b2885978ea9da9ef866de
 2015-10-06 15:31:16 +02:00
Oliver Specht
89d39bc100 tdf#94559: 4th step to remove rtti.hxx 
replaced use of PTR_CAST, IS_TYPE, ISA in
    idl, editeng, sc, sd, sw, sfx2, sot, starmath

Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653
Reviewed-on: https://gerrit.libreoffice.org/19132
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-10-06 07:29:37 +00:00
Caolán McNamara
e9ae1b64af checkUnoObjectType etc always deref their ptr arg, convert to ref 
Change-Id: Iabdb057fb2dc05cfb8c98864dc5109360b50633a
 2015-10-02 11:38:58 +01:00
Andrea Gelmini
2957be02c5 Fix typos 
Change-Id: I776c517ba87838c0c3391f79010a30fa7fe2abd3
Reviewed-on: https://gerrit.libreoffice.org/18939
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2015-10-02 08:54:51 +00:00
Caolán McNamara
62b39a7c48 coverity#1325255 Unchecked dynamic_cast 
Change-Id: Ie1a6b231e0313d1c00ffb9ab0137af2beeb05e02
 2015-10-01 14:05:27 +01:00
Noel Grandin
58aea3f36c loplugin:unusedmethods 
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
  the $WORKDIR

Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-01 10:43:24 +00:00