wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
367,277 Commits 5 Branches 0 Tags
514baf79795018fb68c2d40fcd512dfcafc4101a
Commit Graph

2219 Commits

Author SHA1 Message Date
Noel Grandin
7f8f277b94 fdo#84938: convert STREAM_ #defines to 'enum class' 
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
 2015-01-07 11:20:44 +02:00
Juan Picca
5573fd8cf9 fdo#39596: replace cstyle casts 
Change-Id: I1a0814ec973b1dc0f4db4ee88a999d9ffc219e7a
Reviewed-on: https://gerrit.libreoffice.org/13701
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-01-05 10:06:36 +00:00
Caolán McNamara
7f476fea47 boost::unordered_map -> c++11 std::unordered_map 
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
 2014-12-27 23:00:45 +00:00
Caolán McNamara
60935c7319 avoid 'don't create ItemSets with full range before FreezeIdRanges assert' 
Change-Id: I3dbb760cd5dbf2e72d1886eaca537bb9ecf9f8cc
 2014-12-22 13:55:20 +00:00
Stephan Bergmann
d9e2c27044 basctl: Use appropriate OUString functions on string constants 
Change-Id: I3e1ff06ac42b53d4cbbdc5a4590bf505d0746d2d
 2014-12-18 14:12:23 +01:00
Tobias Madl
afa5bded78 timers: Timer never started, remove it completely. 
Change-Id: I119529498f4bea014e5e0d3d81c39203080ff1c4
 2014-12-09 12:35:05 +00:00
Jennifer Liebel
e5f67b2e94 changed timers to idle 
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
 2014-12-09 12:34:57 +00:00
Jennifer Liebel
7523b588f1 changed timers to idles 
Change-Id: Ic045e0c066ff1f607f0582b88e72375efaaa708f
 2014-12-09 12:34:51 +00:00
Kohei Yoshida
28c251e3cc Remove more unnecessary header includes and use forward declaration. 
Change-Id: I88d0fb0e7c20d4b1414516e3bd2f961811b2eb8c
 2014-12-08 23:23:33 -05:00
Michael Weghorn
3338f47918 reduce scope of local variables 
This eliminates some of the warnings from Cppcheck report of
2014-11-29.

Change-Id: Id5bf885de12a6de262d2cca9fa71627ac67f50d9
Reviewed-on: https://gerrit.libreoffice.org/13330
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-08 08:01:58 +00:00
Stephan Bergmann
991457df43 loplugin:unreffun 
Change-Id: I6dbb20c82b58b81aa4cfb8cc3cf80f6d1202075d
 2014-12-05 11:11:30 +01:00
Andrea Gelmini
4758ab313d Removed useless includes in basctl/source/basicide/ tree 
It compiles on Windows and Linux, here, with flags:
   --with-help --with-java --with-lang="it"
Made with the ignorant brute force of removing each include
one by one.
The tree with each commit (used to bisect) it's here:
https://github.com/Gelma/core/commits/gr_push_brute_force_slot_2

Conflicts:
	basctl/source/basicide/bastype2.cxx

Change-Id: If88eebb6ecba6ae7ab1e98713b66b10f1ad57dca
Reviewed-on: https://gerrit.libreoffice.org/12963
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-12-05 09:12:26 +00:00
David Tardon
d242b464b1 be more explicit 
Change-Id: I33b639b3505d5db2ea8b708d80e68e576ec53308
 2014-12-04 23:10:26 +01:00
David Tardon
51bacc6a06 impl. Clone for all subclasses of SdrPage 
Change-Id: Ie370161e51ff83cb605bc57d317ff945404e5611
 2014-12-04 23:10:25 +01:00
David Tardon
9638e6207c ooo#93212 avoid slicing during construction of SdrPage 
Also hide copy ctor and assignment operator of all derived classes, to
ensure that Clone() is the only method to make copies of them.

Change-Id: Icb3b50c63b086abe8c9add32e3041fe19692d20b
 2014-12-04 23:10:24 +01:00
Stephan Bergmann
2dfcbfbdde Use std::initializer_list 
Change-Id: I726fc6429a2eb7827d09d04584fd0b725e78f650
 2014-12-03 15:47:25 +01:00
Tobias Madl
14596452e7 fdo#84938: replace EVENT_ constants with enum 
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f
Reviewed-on: https://gerrit.libreoffice.org/13134
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-01 07:43:31 +00:00
Caolán McNamara
8c041824b6 all these ids and their associated resources were unnecessary 
Change-Id: I3f538668c9c5f1727b8cf49ab72fd5879e12f156
 2014-11-25 14:54:03 +00:00
Caolán McNamara
8307821419 We now only need one bit of information here 
whether there *is* an id, or whether there is not an id.  An id of 0 seems to
be used as a flag that an interface is some sort of superclass which can be
subclassed by something else and have its toolbars etc reused.

Convert this to a bool so we don't need an a resource id for each one and just
drop the third arg for the normal "final" case and use a different define for
the inheritable case

Change-Id: I98380f03d73d57bf8cba02d339097e384518abaa
 2014-11-25 14:54:02 +00:00
Tobias Madl
371c549b49 timers: Timer never started, remove it completely. 
Change-Id: I119529498f4bea014e5e0d3d81c39203080ff1c4
Reviewed-on: https://gerrit.libreoffice.org/13030
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
 2014-11-22 00:46:24 +00:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use 
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
 2014-11-17 11:06:53 +01:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method 
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-11-14 09:20:38 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Noel Grandin
a52f29216d fdo#84938: replace HELPMODE_ constants with enum 
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e
Reviewed-on: https://gerrit.libreoffice.org/12333
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-11 06:17:36 +00:00
Noel Grandin
31d902d3c0 fdo#84938: replace MOUSE_ modifier constants with enum 
and make the two categories of constants non-overlapping, we
really don't need to risk confusion in order to save 6 bits in
a data structure like this.

Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
 2014-11-07 14:53:36 +02:00
Stephan Bergmann
fc0d57b7af Revert "use the new OUString::fromUtf8 method" 
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
 2014-11-06 17:24:13 +01:00
Noel Grandin
05050cdb23 use the new OUString::fromUtf8 method 
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
 2014-11-06 13:51:10 +02:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals 
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
 2014-11-05 08:44:19 +02:00
Jan Holesovsky
31af61ea09 Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip" 
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.

Conflicts:

	cui/source/tabpages/transfrm.cxx
	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx
	tools/source/generic/rational.cxx

Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
 2014-10-23 18:34:39 +02:00
Jan Holesovsky
858c2a2977 Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit" 
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.

Conflicts:

	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx

Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
 2014-10-23 18:34:34 +02:00
Noel Grandin
50a8c89f36 loplugin: cstylecast 
Change-Id: I9134aff4f2e6bff43ebb78c605e0ff521eac6ffc
 2014-10-23 12:36:14 +02:00
Noel Grandin
67c9d05451 fdo#84938: replace TIB_ constants with enum 
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84
Reviewed-on: https://gerrit.libreoffice.org/12023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-20 07:16:46 +00:00
Caolán McNamara
f5b1b266bc coverity#1247646 Uncaught exception 
Change-Id: I332fb602466613e9e79ba4510879411e0bee9da6
 2014-10-17 15:19:54 +01:00
Caolán McNamara
d4cdaa2ad6 coverity#1247644 Uncaught exception 
Change-Id: Idbaef5c196c29a2e066f667e6bd50189a7b1834c
 2014-10-17 15:19:53 +01:00
David Tardon
582ef22d3e fdo#84854 it seems long is not enough on 32 bit 
Fraction used BigInt internally for computations, rational does nothing
like that.

Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
 2014-10-16 17:44:44 +02:00
Stephan Bergmann
ad9498f8b8 More -Werror,-Wunused-private-field 
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
 2014-10-15 15:58:56 +02:00
Noel Grandin
8044acf2db convert SFX_CALLMODE constants to SfxCallMode enum class 
and fix a couple of bugs in SC and SW where the call mode was
being passed to the hints parameter by accident

Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58
Reviewed-on: https://gerrit.libreoffice.org/11916
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-11 15:14:52 +00:00
Caolán McNamara
6033e2d29d Resolves: fdo#60904 allow export of VBAProject 
xModLibContainerExport has a "VBAProject" entry but
xDlgLibContainerExport doesn't, so just export the
one we do have

Change-Id: I15f7794904a5aff7679f2cf9fd654d741fd5cbe3
 2014-10-09 15:42:20 +01:00
Juan Picca
47a2d7642d fdo#81356: convert Fraction to boost::rational<long> - wip 
* Added rational util functions used by Fraction class not
  available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
  1. fraction.IsValid() -- rational only allow valid values, ie
     denominator() != 0
  2. rational.denominator() == 0 -- always false
  3. rational.denominator() < 0 -- always false but implementation
     detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
  1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
  boost::rational throws the exception boost::bad_rational

Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2014-10-09 11:33:33 +00:00
Noel Grandin
8dbde0845a fdo#82577: Handle Region 
Put the VCL Region class in the vcl namespace. Avoids clash with the X11
Region typedef.

Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
 2014-09-30 09:58:23 +02:00
Stephan Bergmann
9703cc63ce Remove o3tl/heap_ptr.hxx, use std::unique_ptr instead 
Change-Id: Iac70c9be13892a36bfb5975f62e5345b88d4f144
 2014-09-24 14:54:51 +02:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window 
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
 2014-09-23 14:11:39 +03:00
Noel Grandin
60e78fbb80 fdo#82577: Handle Font 
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.

Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
 2014-09-18 08:54:37 +02:00
Stephan Bergmann
eea7bf09d5 basctl: sal_False/True -> false/true 
Change-Id: I6f9414eba5fce8797f07a3796a12b5213c0ed4e0
 2014-09-15 18:22:36 +02:00
Caolán McNamara
c929930177 DBG_ASSERT -> assert where we go on to deref the testee 
Change-Id: Id38a9e2e0ca0b1c52cb3306adf77eb43d710c9c6
 2014-09-15 09:09:10 +01:00
Caolán McNamara
a88b2d8418 Resolves: fdo#81039 crash on adding new macro library 
regression from

commit bf28399df0b73364b12309032e4a8b571389c2cf
Date:   Fri Feb 7 15:54:45 2014 +0100
    auto_ptr -> heap_ptr

Change-Id: Ib54c708cbdcb97a7489df4a1b3a7e9367f81ff6b
 2014-09-14 16:21:03 +01:00
Stephan Bergmann
ea733ab5b6 Turn SfxItemState into a C++11 scoped enumeration 
...to gain further confidence in the claim "that none of the existing
code tries to uses combinations of these enum values"
(d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState")

Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13
Reviewed-on: https://gerrit.libreoffice.org/11384
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2014-09-12 06:08:32 +00:00
Norbert Thiebaud
ec1de2a4ff coverity#735600 Division by zero 
Change-Id: Ia936814ae37ae802fab36f7bde56de09338eb617
 2014-09-12 01:45:28 +02:00
Stephan Bergmann
39e91c585d Replace uses of old SFX_ITEM_AVAILABLE alias with SFX_ITEM_DEFAULT 
Change-Id: I88eeac06413fc3935cbbdb357ff8bf9acaa383a8
 2014-09-10 16:37:20 +02:00
Stephan Bergmann
7af850c896 vcl: sal_Bool -> bool 
Change-Id: Iff4da6d6281eb9194db348ebc10fbe7718538401
 2014-09-10 08:36:06 +02:00