df46ec0580
osl_getCommandArg always returns osl_Process_E_None
...
Change-Id: I0ff1e44f17976fd3a3060d8ee7fe15d77c918b79
2014-12-12 09:29:05 +01:00
54cbb57d4c
fdo#39440 reduce scope of local variables
...
This addresses some cppcheck warnings.
Change-Id: Ib35eb591534c3f23adc3cb7b7fa9696dc5cbeabf
Reviewed-on: https://gerrit.libreoffice.org/13383
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2014-12-09 03:24:35 +00:00
827430c8c0
Fold URE: Windows
...
...assuming the delayLoadHook in cli_ure/source/native/native_bootstrap.cxx is
no longer necessary and loading of cppuhelper from the program dir cannot fail
regardless in whatever scenario the cli_cppuhelper library itself is loaded.
Change-Id: I13f32b327bca4cce9780864f5e57cdad3860afe5
2014-12-03 15:19:55 +01:00
6a0fe37dec
sal: clean up public headers with include-what-you-use
...
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
da40cac540
Fix common typos. No automatic tools. Handmade…
...
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-11-12 11:04:11 +00:00
0371a63365
remove unnecessary 'using namespace rtl' declarations
...
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-29 11:28:54 +00:00
04740cb7e2
cli_ure (Windows): std::auto_ptr -> std::unique_ptr
...
Change-Id: Ibe794daffa347d194ff8c66a44c7eec4bcc9b83d
2014-10-02 15:20:26 +02:00
25df8adbc0
cli_ure: adapt destructors in cli_uno library to "C++/CLI"
...
commit 4b56d82c7d20ba5897d87aaf7fc94da5356b8eec converted the cli_uno
library from "Managed C++" to "C++/CLI", but forgot one detail:
The destructors on "ref" classes were mapped to Finalize() methods in
the old syntax, but the new one maps them to Dispose() methods, which
are only invoked on stack-allocated objects. Presumably this omission
results in leaking of native C++ UNO objects.
Reading the C++/CLI documentation i get the impression that:
1) the destructor should explicitly call the finalizer
2) the CLR will not call the finalizer itself iff the destructor is
invoked
http://msdn.microsoft.com/en-us/library/ms235315.aspx
http://msdn.microsoft.com/en-us/library/ke3a209d%28v=vs.110%29.aspx
Change-Id: I509d9b69a399c3d7d6597060ab9b7c78c5916e11
Reviewed-on: https://gerrit.libreoffice.org/11132
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-08-27 05:06:32 -05:00
5f15f18859
warning C4189: local variable is initialized but not referenced
...
Change-Id: Ic8a76a9ab73a3466fe155e2ca8eecedeb6e810c9
2014-08-13 10:10:49 +02:00
608ebc6f01
Remove redundant inclusions of header "cppuhelper/shlib.h"
...
Change-Id: Iab402035613a6cc96b7b4ebd2981a1fd0f8bed23
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-08-08 12:02:16 +02:00
9bac4d413e
typo: more then -> more than
...
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
a0233e6e03
Typo: habe->have
...
Change-Id: Ic76a399fc4073fcb713bb566f3fbee2077e20e52
2014-06-29 13:15:52 +02:00
b19db6b21d
Typo: apend->append
...
Change-Id: I062c95ca8d478ba6c241723dda25c1dc4d7bb852
2014-06-29 13:15:51 +02:00
637b0ef1b5
cli_ure: Win32 make quoting problem, use sed to work around
...
Change-Id: Ide8a3c574a1904e08921684453256d1d3c98fd78
2014-06-09 17:05:52 +02:00
0e507ae031
various: remove SAL_THROW macro
...
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
e7bc3cab01
remove boilerplate in UNO Exception constructor calls
...
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.
Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
d0322208bc
Combine unoidl::loadProvider and unoidl::Manager::addProvider
...
Change-Id: I1240656cc2a4d713c838eb80fa90ce3485aad614
2014-05-23 13:44:03 +02:00
2bd7767d01
Resolves fdo#70681: fixincludeguards.pl: all that's left
...
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-15 12:50:46 +00:00
acc04202e8
use css prefix consistently
...
Change-Id: Ia2f827381ec768a7867918d61d7afb2f68457832
2014-05-12 19:52:28 +02:00
49dff05943
cli_ure: fix dbglevel=2 build on windows
...
Some blocks are completely unused.
According to http://msdn.microsoft.com/de-de/library/ms235298.aspx
rtl_uString * __pin * pp_sInterfaces = &_sInterfaces;
should be
pin_ptr<rtl_uString *> pp_sInterfaces = &_sInterfaces;
Change-Id: I039e94649d542fb5b51231b2e0df0a4dc1170c19
Reviewed-on: https://gerrit.libreoffice.org/9318
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-12 14:53:26 +00:00
4f9b21248f
simplify ternary conditions "xxx ? yyy : false"
...
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
11b81c1026
Fix memory leaks
...
Change-Id: Id67d5375bedc6e6c10082d9c5ee69d6e932be158
2014-04-29 10:14:12 +02:00
b8239ac2f9
typo: noone -> no one
2014-04-14 12:32:54 +02:00
f7dca81251
cli_ure: simplify deprecated XTypeProvider.getImplementationId
...
Change-Id: If6f975bdc3d554828ff1ad3adc656579eda92a42
2014-03-10 17:39:53 +01:00
1712e6c614
Remove visual noise from cli_ure
...
Change-Id: I1ddada46767b2840c663a0a077e1b723f9645b56
Reviewed-on: https://gerrit.libreoffice.org/8240
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 06:15:25 -06:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
bbe3bec949
Drop unused #include
...
Change-Id: Id05440ffb8eb9990d2d08f721d6914f3dbc86cab
2014-02-14 18:44:05 +09:00
a83b2af9ab
Clean-up uno/lbnames.h
...
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
2013-12-16 21:43:12 +01:00
52bbd9cc00
remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii calls
...
Convert code like:
aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
aStrBuf.append( "ln(x)" );
which compiles down to the same code.
Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20 10:07:32 +02:00
e5eac916e8
cli_ure: remove Package_config
...
- cliuno.snk is used from SRCDIR
- climaker.exe.config is not packaged and appears unnecessary
Change-Id: Ia0e364bd3b488841aeb8ae75c26aa0cd4ff86012
2013-10-28 14:03:13 +01:00
7f436c1fd3
typo fixes in comments
...
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
f212aa9f84
fix existing comments
...
Change-Id: I06dca63053dae5d3dceb49bf67adb0c100b56e8b
2013-08-31 22:41:12 +02:00
78ced6235b
fix indentation
...
This is a follow up commit to
- 22d1beb78a475e4846af945afde1c4d6c263b5d6
- 1c7af455ab9345304a7ac48ce2e0310de2ac8a75
Change-Id: I55ff666c357c89ad355a1a5bc0d0347fcc188476
2013-08-31 22:41:11 +02:00
bf42b6f9f5
fdo#62475 - remove visual noise
...
This is a follow up commit to
- 22d1beb78a475e4846af945afde1c4d6c263b5d6
- 1c7af455ab9345304a7ac48ce2e0310de2ac8a75
Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
2013-08-31 22:41:10 +02:00
1c7af455ab
Re-work 8bit characters in source code, or remove them.
...
Change-Id: I93e14d4936c0ffbe03425d4a54bb0e09bc62b3e3
Reviewed-on: https://gerrit.libreoffice.org/5550
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Meeks <michael.meeks@suse.com >
Tested-by: Michael Meeks <michael.meeks@suse.com >
2013-08-20 19:30:59 +00:00
e39e9e4cd8
Source files shouldn't have executable bit set.
...
Change-Id: Iafad6249a7998d7c749c1ca2979a606078cfcb5e
Reviewed-on: https://gerrit.libreoffice.org/4070
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-05-28 12:09:27 +00:00
1728ab7125
Remove dependency of climaker on registry format
...
See the comment in climaker_app.cxx main about room for improvement.
Change-Id: I11cc2f62c9d42269d5c96253198ee4e730496e75
2013-04-29 13:35:53 +02:00
3a77c4fa06
Fix compilation error after fe4ffd81045144ffb8d69ae9e5df7ef191005128
...
Whether it works, no idea. But on the other hand, from the dicsussion
in fdo#61503 it doesn't seem as if that commit was deeply insightful
either. (And how it compiled on the commit author's machine, no idea.)
Change-Id: If6355b33c406e8da5bdb2bf77aaf8b2ac0c39343
2013-04-25 12:46:34 +03:00
fe4ffd8104
fdo#61503 fix cli_cppuhelper bootstrap error
...
Change-Id: I777d2d866cfc8b2363b418fd5cba6576e3a2b8ec
Reviewed-on: https://gerrit.libreoffice.org/3600
Reviewed-by: Peter Foley <pefoley2@verizon.net >
Tested-by: Peter Foley <pefoley2@verizon.net >
2013-04-24 21:28:47 +00:00
5275ed805a
Revert "Revert "WIP: Experimental new binary type.rdb format""
...
This reverts commit 67e69a55820f50973ca0de75ccab2bb07d0bada8, applying a band-
aid fix to cli_ure/source/climaker for now.
Conflicts:
stoc/inc/bootstrapservices.hxx
stoc/source/tdmanager/lrucache.hxx
stoc/source/tdmanager/tdmgr.cxx
stoc/source/tdmanager/tdmgr_common.hxx
stoc/source/tdmanager/tdmgr_tdenumeration.cxx
stoc/source/tdmanager/tdmgr_tdenumeration.hxx
Change-Id: Iae669985d0194f06fa349a4a39f0ebd230bc5d28
2013-04-22 18:25:42 +02:00
eeaa2ecd1e
remove unused component_canUnload functions
...
Change-Id: Id3f41e2a620c47bb848718d0fc994739be2d64fc
2013-04-19 16:52:03 +02:00
b25a9a2f58
Adapt to prefixed bootstrap_component_getFactory
...
Change-Id: I397f339b20bf43fbe68df18c50c23f90323f3df5
2013-04-16 10:53:34 +02:00
92c6a38175
Fixed 4 spelling errors in the comments.
...
Change-Id: Ic48f52d7ea4f6a4964f627e3051c96c46ffc2f76
Reviewed-on: https://gerrit.libreoffice.org/3164
Reviewed-by: Andras Timar <atimar@suse.com >
Tested-by: Andras Timar <atimar@suse.com >
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-04-07 21:28:01 +00:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
39d45390f4
removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
...
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms
Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-03-19 10:48:30 +00:00
616c6924f1
s/the the/the/
...
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
13ed66c9ce
s/Whith/With/
...
Change-Id: I098290a33a3d455594bd200034b279eef02c792b
2013-02-22 09:39:47 +02:00
ce22d30eeb
do not try to concatenate two string literals using +
...
Change-Id: I7f06a9b065d5dd24da48e06792cacd27d157a656
2013-01-30 15:13:01 +01:00
97eb8a6e0e
Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING
...
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz >
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
2013-01-30 12:54:40 +00:00
4ab80620f0
WaE: C4564 from MSVS 2010
...
Change-Id: I675b1cbda896e1a5e15d34f3973e8fcd6ea6c45b
2012-12-24 21:11:40 +02:00