7f8f277b94
fdo#84938: convert STREAM_ #defines to 'enum class'
...
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07 11:20:44 +02:00
f8922b67a4
Remove unnecessary comphelper::string::getToken
...
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
2015-01-02 14:22:21 +01:00
3639824532
extensions: Use appropriate OUString functions on string constants
...
Change-Id: Ief21a59fc58cdd6fb3398bbe5080ed5a53cb374e
2014-12-19 10:03:51 +01:00
15b4ab8d19
cppuhelper: clean up public headers with include-what-you-use
...
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
7970fa5130
cleanup improper SOLARIS linker libs and options
...
and, most importantly, forget MOTIF!
Change-Id: I0230932618b396ec4d5bf7638a13e5a80a4fada0
Signed-off-by: Michael Stahl <mstahl@redhat.com >
2014-11-11 19:44:56 +01:00
fc0d57b7af
Revert "use the new OUString::fromUtf8 method"
...
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06 17:24:13 +01:00
05050cdb23
use the new OUString::fromUtf8 method
...
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06 13:51:10 +02:00
0e36884e78
coverity#982164 silence Unchecked return value from library
...
Change-Id: Ie2479e3dc73a7c7e8d2d0c5c979bde2ea5d05a1e
2014-10-27 14:34:21 +00:00
2f4546487a
coverity#982164 silence Unchecked return value from library
...
Change-Id: Ibec38a7e7846c463601b0a876778f53003cf0441
2014-10-25 16:56:25 +01:00
28dbb39389
coverity#982163 silence Unchecked return value from library
...
Change-Id: I6b9a3c6ce75472da551706b1c1555eff4ba1abc8
2014-10-25 16:56:25 +01:00
ad9498f8b8
More -Werror,-Wunused-private-field
...
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html >
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
e5bf214ebb
loplugin: cstylecast
...
Change-Id: I6ea98852ba775d85ccd54823b67224ea7f587c65
2014-10-01 13:08:43 +02:00
c353caee1c
loplugin: cstylecast
...
Change-Id: I53b69a488c70769cbb841db519bc28fd211dc087
2014-09-29 12:50:35 +02:00
8305efa9e8
coverity#983665 Uncaught exception
...
Change-Id: I3d0cd9a9bde8c3705abd876e832b6b7e56bb7fad
2014-09-26 10:11:02 +01:00
d66b757083
Leftover XLIB_Window -> Window
...
Change-Id: I51aa3e3fbf440bbd16d43ab8113cd69937060bf3
2014-09-23 14:19:31 +02:00
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
15c609f33d
Use prex.h/postx.h
...
Change-Id: I055ae0426df86a1ea49385bc8c0b176cc4b9d940
2014-09-23 09:29:56 +02:00
961d061ba1
set names on some UNIX-only threads
...
Change-Id: I4c247916256618312e7d98673d9db4d26e26fa39
2014-08-25 13:21:58 +02:00
30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
708fc1c187
fdo#82577, fdo#82579: Handle Cursor
...
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor
typedef and some ancient Carbon (?) Cursor typedef on OS X.
Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
2014-08-23 19:20:03 +03:00
c9d7b9fdc4
warning C4628: digraphs not supported with -Ze...
...
...Character sequence '<:' not interpreted as alternate token for '['
Change-Id: If5024a7e3ede9b416f391583a2d3959620f2437c
2014-08-13 10:10:36 +02:00
6d28e240f0
coverity#982457 Explicit null dereferenced
...
Change-Id: Ia5229858cdb2c6d8088ed6684186e5cfc1fe4213
2014-07-19 21:26:01 +01:00
9fb4cf25cf
coverity#983663 Uncaught exception
...
Change-Id: Iecfbb9b7cd1cb8507028cbaf7e39a1e401f74dbe
2014-07-02 10:46:47 +01:00
5f5768e022
coverity#983661 Uncaught exception
...
Change-Id: Id0cecd2a6431e21c896210e255f37ba220a0941f
2014-07-02 10:46:46 +01:00
1851e1e29c
coverity#983659 Uncaught exception
...
and
coverity#983660 Uncaught exception
Change-Id: I509805fd6517196d505e78bcbf632d83dff01f03
2014-07-02 10:46:46 +01:00
bae5099882
coverity#983658 Uncaught exception
...
Change-Id: I99cb4f64b093765d0667ddcddf1f696891450a9a
2014-07-02 10:46:45 +01:00
bcfc61a49f
more mac build fix
...
Change-Id: I4d0f1c21aed9bbcc97f432b0f1872c508853708c
2014-06-24 13:19:25 +02:00
4d93f2263d
fix mac build
...
after my commit e2080e7 "new compilerplugin returnbyref"
Change-Id: Iec1663507ddda009903c31aa3ceedfe5380c1962
2014-06-24 13:13:05 +02:00
e2080e70fe
new compilerplugin returnbyref
...
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
b09b5f8f7c
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
...
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
8d471d4b37
Fix previous commit (extensions part)
...
Change-Id: I942cca3639e4d823415da557262e35432a798d04
2014-05-11 10:24:46 +02:00
bd59628620
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10
...
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-11 10:16:42 +02:00
f106f41956
postwin.h handles OPTIONAL already
...
Change-Id: Ia04bc545f90a093f70bbd7036b7b9403af15daa1
2014-05-09 22:32:53 +02:00
93f5d5a919
The opaque PostUserEvent IDs are actually pointers
...
...so declare them as such. This avoids the recurring mistake of storing such
IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to
potentially not remove the event, it thus firing "too late" and probably causing
a crash.
While at it, consolidate the trivially unnecessary overloads of both
Application::PostUserEvent and Window::PostUserEvent. And in each of them, it
looks like deleting the mpLink member was missing from the failure branch.
Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
2014-05-07 11:49:46 +02:00
7ae4102f17
extensions: sal_Bool->bool
...
Change-Id: I1730f99c08690138e9aa7aba54304fd7bc51491d
2014-05-02 08:49:22 +02:00
f400bdce03
fixincludeguards.sh: extensions
...
Change-Id: If652bce4cf7621795b084bcbc0aa4c46dd903878
2014-04-19 11:10:10 +02:00
a6611be6bc
Clean up function declarations and some unused functions
...
Change-Id: Ie81d270267b6c3c3620ade62eb393b28d995a654
2014-04-13 23:44:29 +02:00
e98e738a82
replace some SvStream seeking with calls to remainingSize()
...
Change-Id: I2905e98425b9991d6138ab0adc15083d313ca445
2014-04-11 23:08:11 +02:00
01f529b546
Whatever those odd dummy function definitions were supposed to be good for
...
...introduced in d2237276cb3e32493ff8f9f71e06301937434622 "INTEGRATION: CWS
vcl09 (1.6.10): #109426# make rpnp.so work on Linux" without any explanation,
but probably a misguided attempt at getting things working in the face of a
missing libgcc_s.so or libstdc++.so (though the names used here do not match any
there), and seemingly not necessary.
Change-Id: Ib092d426f4acfd3ece30adb754c1bb76d4eca381
2014-04-09 08:54:21 +02:00
4da62012fe
Fix a memory leak by freeing last pBytes
...
Change-Id: I7d170d704fa8950057698856d12df63992e38381
Reviewed-on: https://gerrit.libreoffice.org/8822
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-04-04 07:20:50 -05:00
8f7c677dbb
Avoid possible resource leaks by boost::scoped_array
...
Change-Id: Ibf92b3098c50388d8b6d27f4476e613a1f8918b5
2014-04-02 16:09:11 +09:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
b0ff06a5bc
coverity#984088 Uninitialized pointer field
...
Change-Id: I228f7c8f99b0cc3117fbeab78efbeddd74896d54
2014-03-19 20:22:51 +00:00
4d6560f506
fdo#54938: Convert some places to use cppu::supportsService
...
The last cases are non obvious, so it's pratically done
Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547
Reviewed-on: https://gerrit.libreoffice.org/8445
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com >
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com >
2014-03-04 07:30:02 -06:00
15246c959a
Remove visual noise from extensions
...
Change-Id: I0397d0d0e5343b7ed192a790664b068ac6955bd3
Reviewed-on: https://gerrit.libreoffice.org/8259
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 07:34:29 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
9aee4d1c9e
harmonize Tell() Seek() type.
...
Change-Id: I2e472aa0279d0763762d3c660207cd74da512626
2014-02-24 23:14:45 -06:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 16:22:17 +00:00
