wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
367,277 Commits 5 Branches 0 Tags
514baf79795018fb68c2d40fcd512dfcafc4101a
Commit Graph

265 Commits

Author SHA1 Message Date
Caolán McNamara
8ab4d2f29f drop crashrep unused since start of LibreOffice 
Change-Id: I3df1216054c133314b2317849744a0a37e9fbc8f
Reviewed-on: https://gerrit.libreoffice.org/13733
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-01-07 11:41:32 +00:00
Noel Grandin
566f16a2fd java: unnecessary imports 
found by CodePro

Change-Id: If1b75e43f81d70984422e437147048a491395b66
 2015-01-05 10:15:13 +02:00
Noel Grandin
10039462df java: remove more dead code 
found by looking for unused parameters (in Eclipse)

Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
 2015-01-05 09:59:03 +02:00
Noel Grandin
46540d08b1 java: these fields can become local variables 
found by PMD

Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
 2015-01-05 08:23:30 +02:00
Noel Grandin
43cc8ad33e java: remove dead code 
found by UCDetector

Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
 2015-01-05 08:23:29 +02:00
Noel Grandin
2d82619a52 java: static fields that should not be static 
Found by FindBugs.

Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
 2014-12-19 10:41:58 +02:00
Noel Grandin
cba3956750 java: this does not need to be a Thread 
It is just being used as a Runnable

Change-Id: I1e652ab0f3b0450d3a85384b9dd513419e2f8046
 2014-12-19 10:41:54 +02:00
Noel Grandin
7557f23b31 java: reduce visibility of fields and methods 
found by PMD

Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-11 06:09:03 +00:00
Noel Grandin
ffffc526e3 java: remove comment noise 
Change-Id: If6347197ff4436b4edd06e6e62d8e8e6fe1d4db6
Reviewed-on: https://gerrit.libreoffice.org/13408
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-10 08:06:38 +00:00
Noel Grandin
9adb820158 java: simplify the getMSF() methods 
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3
Reviewed-on: https://gerrit.libreoffice.org/13406
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-10 08:04:58 +00:00
Noel Grandin
58eab57648 java: final fields that can be static 
found by PMD

Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-25 06:06:48 +00:00
Noel Grandin
1658c017a2 java,framework: remove unused vars and parameters 
Change-Id: I7df5ff730436b95cb93af9f813d7bc572da2b951
Reviewed-on: https://gerrit.libreoffice.org/13098
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-25 05:05:24 +00:00
Noel Grandin
fe095dada4 java,qadev: remove unused parameters and local vars 
Change-Id: Ifb9f9374051fe88dc4cd5a7a28b2c8c992ced873
Reviewed-on: https://gerrit.libreoffice.org/13097
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-11-24 20:45:17 +00:00
Noel Grandin
0063cf2856 java: make fields final where possible 
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
 2014-11-18 12:44:28 +02:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Noel Grandin
bb437029c1 java: convert fields to local variables where possible 
found by PMD

Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:03:29 +00:00
Noel Grandin
03c7c26cbe java: final fields that can be static 
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
 2014-10-17 08:26:21 +02:00
Noel Grandin
9341bf3dc3 java: when rethrowing, store the original exception 
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
 2014-10-16 12:27:15 +02:00
Noel Grandin
f635ba0684 java: remove some unnecessary intermediary object creation 
Change-Id: Id4949fa08546e710fbf9bd0c7e3bf62979f29c83
 2014-10-07 13:20:01 +02:00
Noel Grandin
83636d2c09 java: when rethrowing exceptions, store the original cause 
so that we get a nice complete stacktrace when it hits the final
handler

Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
 2014-09-25 13:47:25 +02:00
Noel Grandin
c0415d5f1e java: remove unnecessary constructor declarations 
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor

Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
 2014-08-20 12:12:15 +02:00
Noel Grandin
8c9fdc4a96 java: remove modifiers implied by the context 
found by PMD

Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
 2014-08-20 11:45:28 +02:00
Noel Grandin
2922a967a1 java: Avoid naming non-fields with the prefix m_ 
found by PMD

Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
 2014-08-20 10:35:53 +02:00
Noel Grandin
4b4bff3402 java: no need to instantiate String objects directly 
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
 2014-08-19 14:57:18 +02:00
Noel Grandin
0764292c5d java: use 'Short.valueOf' instead of 'new Short' 
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
 2014-08-19 14:57:18 +02:00
Noel Grandin
8a2c6c29af java: use 'Long.valueOf' instead of 'new Long' 
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
 2014-08-19 14:57:17 +02:00
Noel Grandin
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer' 
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
 2014-08-19 14:57:17 +02:00
Noel Grandin
be1bb7b1cc java: use Boolean.valueOf instead of instantiating Boolean objects 
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
 2014-08-19 14:57:16 +02:00
Noel Grandin
56ef5533fc java: classes in java.lang package do not need to be fully qualified 
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
 2014-08-19 14:57:16 +02:00
Noel Grandin
3a8d351988 java: remove unused methods 
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
 2014-08-19 14:57:13 +02:00
Noel Grandin
0d916bb240 java: remove unused imports 
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
 2014-08-14 10:59:49 +02:00
Noel Grandin
ac5954d7c5 java: remove commented out code 
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
 2014-08-14 10:59:48 +02:00
Noel Grandin
5ce80c9728 remove dead java constants 
found by UCDetector

Change-Id: I1f8f5ba4f3ab1a1ef134dd0988f913dab7501351
 2014-08-13 13:34:43 +02:00
Noel Grandin
34bcf9b498 java: remove dead methods 
found by UCDetector

Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
 2014-08-13 10:24:10 +02:00
Noel Grandin
8583da1e93 java: remove unused fields 
found by UCDetector

Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
 2014-08-13 08:49:24 +02:00
Noel Grandin
68cd011c90 java: reduce scope, make some methods private 
found by UCDetector

Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
 2014-08-13 08:49:23 +02:00
Noel Grandin
70f56bc22f java: reduce scope, make member classes private 
found by UCDetector

Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
 2014-08-13 08:49:23 +02:00
Noel Grandin
da677dfd59 java: reduce scope, make fields private 
found by UCDetector

Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
 2014-08-13 08:49:22 +02:00
Noel Grandin
14d1a11ec4 java: reduce scope, make constructors private 
found by UCDetector

Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
 2014-08-13 08:49:22 +02:00
Noel Grandin
e701b3f732 java: reduce scope, make constants private 
found by UCDetector

Change-Id: Ide9975e361ed17ac8cdcbe67ba74c563a9392d57
 2014-08-12 12:16:37 +02:00
Noel Grandin
5656fe58a0 java: fix broken javadoc tags 
Change-Id: I43d25ba49b758739ee8dc891b0db3e527004ec8b
 2014-08-12 09:41:31 +02:00
Noel Grandin
1c496506bc java: remove useless javadoc tags 
that are not conveying any useful information

Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
 2014-08-12 09:41:31 +02:00
Noel Grandin
0477e6c39b java: add @Override annotation to overriding methods 
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
 2014-08-12 09:41:28 +02:00
Noel Grandin
41709cc268 java: remove unused parameters 
Change-Id: I47c618117e079bb2ef90d92c449c8166ea957fa5
 2014-08-11 12:33:02 +02:00
Noel Grandin
616b3ad504 java: remove exceptions from throws clauses that are not 
.. actually thrown

Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
 2014-08-08 09:48:20 +02:00
Noel Grandin
b58c053fed java: remove unnecessary semi-colons 
Change-Id: Ibeeefc6e6ee8f7bed97a02f569f239ff035d38c4
 2014-08-08 09:48:18 +02:00
Noel Grandin
a274d19d11 java: remove redundant super-interfaces 
Change-Id: Iaf671ef87057362c804999a5154d8e8277bbc4b8
 2014-08-08 09:48:18 +02:00
Noel Grandin
27459c71ef java: remove unused fields 
Change-Id: I25fef9590a34ec8d9aab182b3d267ae3cd649a87
 2014-08-08 09:48:16 +02:00
Noel Grandin
0c5f51ebbc java: remove commented out code 
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
 2014-08-05 11:31:50 +02:00
Noel Grandin
d26540bb05 java: remove unused fields 
Change-Id: I6c93864f501f646a8940eac221a88c87b3f75525
 2014-08-05 11:31:50 +02:00