64cccf36f2
fdo#84938: convert SEF_EXPORT_ #defines to 'enum class'
...
Change-Id: I7165d0f1b6b4af4de5e5b39a21f36d726a1b0e30
2015-01-06 10:59:42 +02:00
8447eeb192
fdo#84938: convert ERROR_ #defines to 'enum class'
...
Change-Id: Ie76bac6b91a9faa4f9ff7dbdf2b455ea9016cf72
2015-01-06 10:59:42 +02:00
c29657e0d6
fdo#84938: convert EXPORT_ #defines to 'enum class'
...
Change-Id: I2ed239fa073b5fa8fb56c1af9d4b0bac89acfacf
2015-01-06 10:59:42 +02:00
ec5bf66d36
fdo#84938: convert XML_EXPORT_FLAG_ to 'enum class'
...
Change-Id: I43d778e0eee19a56ea37898ec1c4309d3407775e
2015-01-06 10:59:41 +02:00
dc28e90d20
fdo#84938: convert IMPORT_ constants to 'enum class'
...
Change-Id: Idaa8f07c62b3ba93c27ca5fe286720254baac10d
2015-01-06 10:59:41 +02:00
465356ecc8
remove unused #defines
...
Change-Id: Ia56012ec795da47a2b6c2482289b698793703918
2015-01-06 10:59:41 +02:00
d1ce6effb6
fdo#84938: convert TEXT_PROP_MAP #defines to 'enum class'
...
Change-Id: Ia8c5913c60e3d509a906965d813c8d1380396dc6
2015-01-06 10:59:40 +02:00
fd1372ba8b
boost::unordered_map->std::unordered_map
...
you can get debug stl this way
Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
66c7dbbf7d
Don't assume that the ZOrder property of shapes is an enumeration
...
...at least when we can easily not assume it.
shapes = shapes of the same XShapes
an enumeration = it is the sequence 0, 1, 2, 3, ..., XShapes->getCount()-1
We replace the ZOrder property by the index of the XShape in the
XShapes (the same XShapes that is passed to seekShapes()... when that
is easy to find. Else, use ZOrder and hope for the best.
ZOrders are not always an enumeration. For example, in documents
(forms) created by the Base forms wizard, it is not the case.
The wrong assumptions was leading to the following bugs in the Base
form wizard:
- Only the first two controls in the form were successfully saved. The
others were just dropped.
- Whereas the labels had the proper style (background and text
colour) applied while creating the document, these were not saved
successfully
Change-Id: I15b9a3ef3b16eafa9698332e35d82d51d51627f8
2014-12-19 23:33:33 +01:00
06344c91db
remove invalid attribute that is not read anyway
...
Change-Id: Id7770ffda49ba7bc0ebc780c67c56b81152213f7
2014-12-07 01:13:52 +01:00
8e417a8fed
use correct xml element name, related fdo#45266
...
Below data-pilot-groups the correct element name is
data-pilot-group-member and not data-pilot-member.
Change-Id: I41aecb7f85a881d13b3eaaa7be8de737b47ea312
2014-12-07 01:13:52 +01:00
a2df86642d
last inconsitently named data table value
...
Change-Id: I1a558616156f5217e309c5957967a69d81c20b8e
2014-12-07 01:13:51 +01:00
6c238230d4
more fixes for inconsistent naming
...
Change-Id: Iedb1b30d4e3905f884bc3bb39d4703a883e95c46
2014-12-07 01:13:51 +01:00
f04802e04c
use a consistent naming scheme
...
Change-Id: Ia420779fd875cb2a81b90871b26940f8a0258b4d
2014-12-07 01:13:51 +01:00
5c3f47e44c
Remove ptr_vector header include in favor of forward declaration.
...
Change-Id: I0aed7ec1bd8ac30ef18147b385c8649a413e4e3a
2014-11-25 18:55:15 -05:00
aea2dbc319
Remove now useless setTextEmbeddedGraphicURL()
...
Since this commit:
286e2f5c6ec829bc0987b1be7016699f7ef03e5e
it's not necessary to update the package URL.
Change-Id: I25c829e9bc0c666838baf19cd60f19938ebb430c
2014-11-16 20:48:19 +01:00
a8af20dbba
typo: represant->represent
...
Change-Id: If783e9338644a97206d99864ed19807e5fb3882d
2014-11-12 12:26:19 +01:00
da40cac540
Fix common typos. No automatic tools. Handmade…
...
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-11-12 11:04:11 +00:00
e43e830eee
xmloff: XML_DROPDOWN should be XML_DROP_DOWN
...
Change-Id: I47247289bb4367faa9a07f3568270718b5423353
2014-11-11 14:58:06 +01:00
f7c14f5730
xmloff: remove unused parameter of SvxXMLListStyleContext::FillUnoNumRule()
...
Change-Id: I359f37ce778d55e6868bd1c78c0ff0d452f36088
2014-11-08 22:58:21 +01:00
1535f39388
sw: store Outline Numbering as ODF fragment instead of SfxPoolItems
...
This should be less fragile and re-uses some xmloff and unocore code.
Storing from ~SwBaseNumRules() does not work because other gobals that
the export code relies on are already dead at the time it is called from
a terminate() listener, so store when the dialog updates a format.
Change-Id: I4e148b82d0a338ec7ffa6429c6e162db79f8c44e
2014-11-08 22:58:21 +01:00
c0a5d390e5
fdo#80403: Import baseclasses implement FastParser interfaces
...
SvXMLImportContext implements XFastContextHandler
SvXMLImport implements XFastDocumentHandler
Change-Id: Id400260af112f4a448fe469c9580f0ebacec4ab6
2014-10-31 09:22:30 +01:00
0c0e3e7539
Fixed typos. No automatic tools (sed, and so on).
...
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f
Reviewed-on: https://gerrit.libreoffice.org/12150
Reviewed-by: Bryan Quigley <gquigs@gmail.com >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-10-30 17:16:02 +00:00
ad9498f8b8
More -Werror,-Wunused-private-field
...
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html >
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
c190577f75
loplugin: cstylecast
...
Change-Id: I25b82a96aace448a8debe90c181b22976ea95414
2014-10-01 13:08:43 +02:00
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
68daa8a226
xmloff: std::auto_ptr -> std::unique_ptr
...
Change-Id: I8baa6c0573af3629bacbf1891c3196c165883d9e
2014-09-30 08:13:48 +02:00
5aa360cae0
Resolves: fdo#80468 and fdo#81223 image/frame backgrounds wrong
...
writer has code to fill in missing new properties from the old properties
if they exist. But xmloff is stripping them out before they get there.
Don't strip them out, and add in a missing check for one of the
archaic bg colors and add a regression test for fdo#81223
Change-Id: I9a541a9bee0a01c90f2c33383f1144ecd8b0bfff
2014-09-29 16:31:32 +01:00
32d6415617
fdo#83512 Make use of OUStringHash and OStringHash
...
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-09-18 13:12:48 +02:00
66c6d1ef20
prevent invalid ods files with loext:fill-character
...
ODF specifies that extension elements in a document are removed before
the validation. With our old implementation of the number format export
this could result in two number:text elements following each other.
According to the spec a number:text element may not follow another
number:text element.
The number:text element before loext:fill is actually not that
interesting so it makes more sense to make this one an extension
element.
Possible documents showing issues:
fdo45268-1.xlsx
fdo49150-1.xlsx
and many more
Change-Id: I3ad92b8a61a246b3dbc0132d9a2c367488a766d0
2014-08-16 07:14:28 +02:00
a772be514e
just use a typedef, don't inherit from boost::ptr_container
...
Change-Id: I1a63802dfeb702f6f6e9506339fd299b98fd8604
2014-08-16 06:52:16 +02:00
61294d454d
remove unnecessary whitespace
...
Change-Id: I9de4fdd28c6d75133289b1c8a655381ecc5675c7
2014-08-16 06:43:08 +02:00
223f761330
fdo#75757: remove inheritance to std::vector
...
typedefs just work.
Change-Id: Ib91c0d4c383b5efac1ad9b93e574dec62e8234a4
Reviewed-on: https://gerrit.libreoffice.org/10754
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-08-05 21:26:50 +00:00
a9bae49661
fdo#75757: remove inheritance to std::vector
...
Typedef'ing SvxXMLListStyle_Impl is enough.
Change-Id: I281766822aea60794510c959581f0b821aea6642
Reviewed-on: https://gerrit.libreoffice.org/10729
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-05 08:30:26 +00:00
7e0e581c16
cleanup usage of MapUnit enum
...
some places were using the wrong enum constant, and some places were
unnnecessarily converting to sal_Int16
Change-Id: I754993533c840cd33106820d99af2dc951f26a80
2014-07-31 11:38:48 +02:00
65803ad94c
fix some dodgy FieldUnit conversions
...
the FieldUnit enum was being converted in some dodgy ways and
in some places the MapUnit enum values were being used.
Change-Id: Ic9aacb84058d1c14c3a4a79ef6676082df9a7270
2014-07-31 11:38:47 +02:00
6c2c974dd3
bnc#885825: Handle ODF import and export of data label border properties.
...
Change-Id: Ic8c7bc873768008537cd52a3fd4b11031b403139
2014-07-26 16:26:09 -04:00
52a36fb30a
pImplize XMLPropertyHandlerFactory.
...
Change-Id: Iff524c9065e9374b39db998e3860704555130995
2014-07-25 15:54:19 -04:00
690f7ff883
Store the handler as a const pointer.
...
Handlers are conceptually stateless; we can keep them as const objects.
Change-Id: I3d35ab0695037632e82f67f901c9795adf9bdd8d
2014-07-25 15:54:12 -04:00
dbf84a3574
The 'mutable' keyword exists for this kind of use.
...
Change-Id: Ic52192f53039b7f1b4529a93c13de74c5f54e7f8
2014-07-25 15:54:02 -04:00
63a94bd053
Get the math right.
...
Change-Id: I6c0073d27d18676b85809bd5f294e90e23ec9770
2014-07-25 14:13:02 -04:00
0915d82bec
Document what's in the type of the map entry.
...
And organize xmltypes.hxx a bit to make it easier to follow. Also
rename MID_FLAG_PROPERTY_MAY_EXCEPT to MID_FLAG_PROPERTY_MAY_THROW.
Change-Id: If18f07159a613555cf031bea5e07c04c7c45abec
2014-07-25 14:04:56 -04:00
8a690c88a9
Apply pimpl to XMLPropertySetMapper.
...
Let's hide its implementation for real this time.
Change-Id: I18c82f4969f2e3560536a68e9bbd86b9282e2ace
2014-07-25 11:50:02 -04:00
9746dc9ad6
fix ODF validation errors
...
Introduced by 7d9bb549d498d6beed2c4050c402d09643febdfa
Change-Id: I09411486b93a031a0c405579d34d9e744b8002a7
2014-07-02 23:03:09 +02:00
4ff115b3e7
drop UniReference in favour of rtl::Reference
...
since they're doing the same thing.
Change-Id: I76134b6b848db8628f315fe5bd9eb972a6bf0cb6
2014-07-02 15:23:52 +02:00
7d9bb549d4
Related: #i124638# Second step of DrawingLayer FillAttributes...
...
for Writer objects, now added support for Paragraph and PageStyle (including
Header and Footer) for direct attributes and style attributes
(cherry picked from commit cc25c58f7052827bfebdc9fbeec668c8fa29ed1b)
Conflicts:
cui/source/factory/dlgfact.cxx
cui/source/factory/dlgfact.hxx
cui/source/inc/bbdlg.hxx
cui/source/inc/cuires.hrc
cui/source/tabpages/bbdlg.cxx
cui/source/tabpages/bbdlg.src
cui/source/tabpages/page.cxx
cui/source/tabpages/tparea.cxx
include/svx/pagectrl.hxx
include/svx/svxdlg.hxx
include/svx/svxids.hrc
include/xmloff/PageMasterStyleMap.hxx
include/xmloff/prstylei.hxx
include/xmloff/txtprmap.hxx
svx/Package_inc.mk
svx/inc/svx/hdft.hxx
svx/source/dialog/hdft.cxx
svx/source/dialog/pagectrl.cxx
svx/source/tbxctrls/tbxcolorupdate.cxx
svx/source/unodraw/unobrushitemhelper.cxx
sw/Library_sw.mk
sw/inc/fillattributes.hxx
sw/inc/format.hxx
sw/inc/frmatr.hxx
sw/inc/frmfmt.hxx
sw/inc/hintids.hxx
sw/inc/hints.hxx
sw/inc/ndtxt.hxx
sw/inc/node.hxx
sw/inc/swunohelper.hxx
sw/inc/unobrushitemhelper.hxx
sw/inc/unoprnms.hxx
sw/source/core/attr/format.cxx
sw/source/core/attr/hints.cxx
sw/source/core/doc/docdesc.cxx
sw/source/core/doc/docdraw.cxx
sw/source/core/doc/docfmt.cxx
sw/source/core/doc/docnew.cxx
sw/source/core/doc/docredln.cxx
sw/source/core/doc/poolfmt.cxx
sw/source/core/doc/visiturl.cxx
sw/source/core/docnode/node.cxx
sw/source/core/inc/frame.hxx
sw/source/core/inc/frmtool.hxx
sw/source/core/inc/rolbck.hxx
sw/source/core/layout/atrfrm.cxx
sw/source/core/layout/fillattributes.cxx
sw/source/core/layout/findfrm.cxx
sw/source/core/layout/paintfrm.cxx
sw/source/core/txtnode/ndtxt.cxx
sw/source/core/txtnode/thints.cxx
sw/source/core/txtnode/txtedt.cxx
sw/source/core/undo/rolbck.cxx
sw/source/core/unocore/swunohelper.cxx
sw/source/core/unocore/unoframe.cxx
sw/source/core/unocore/unomap.cxx
sw/source/core/unocore/unoparagraph.cxx
sw/source/core/unocore/unoprnms.cxx
sw/source/core/unocore/unostyle.cxx
sw/source/ui/chrdlg/paradlg.src
sw/source/ui/chrdlg/pardlg.cxx
sw/source/ui/fmtui/tmpdlg.cxx
sw/source/ui/fmtui/tmpdlg.src
sw/source/uibase/app/docst.cxx
sw/source/uibase/app/docstyle.cxx
sw/source/uibase/frmdlg/colex.cxx
sw/source/uibase/shells/basesh.cxx
sw/source/uibase/shells/textsh1.cxx
sw/source/uibase/uiview/viewstat.cxx
sw/source/uibase/utlui/uitool.cxx
xmloff/inc/PageMasterImportContext.hxx
xmloff/inc/xmloff/XMLShapeStyleContext.hxx
xmloff/source/draw/XMLShapeStyleContext.cxx
xmloff/source/draw/sdpropls.hxx
xmloff/source/style/PageMasterExportPropMapper.cxx
xmloff/source/style/PageMasterImportContext.cxx
xmloff/source/style/PageMasterPropHdlFactory.cxx
xmloff/source/style/PageMasterStyleMap.cxx
xmloff/source/style/prstylei.cxx
xmloff/source/text/txtexppr.cxx
xmloff/source/text/txtprhdl.cxx
xmloff/source/text/txtprmap.cxx
xmloff/source/text/txtstyli.cxx
Conflicts:
svx/source/dialog/hdft.cxx
sw/source/core/doc/visiturl.cxx
sw/source/core/txtnode/thints.cxx
sw/source/core/txtnode/txtatr2.cxx
sw/source/core/unocore/unostyle.cxx
Change-Id: I7e8779db6c0cbd1e242b63eab888f468f2de509a
2014-07-01 13:30:09 +02:00
430484932e
Typo: beeing->being
...
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
17dc7f1153
remove spurious com::sun: ⭐ :util prefix
...
Change-Id: I002a14fe0cb0cbdb4d5da51db8da6c8208cf604e
2014-06-25 15:04:47 +02:00
1d38cb3655
fdo#71076, fdo#71767: Preserve number formats when charts are copied.
...
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
