wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
395,208 Commits 5 Branches 0 Tags
51cf057f4e5277ef5ce99c76dd67aeff702a448e
Commit Graph

2548 Commits

Author SHA1 Message Date
Muhammet Kara
3e79c2f8c2 tdf#91665 l10n: replace string lists - by separate strings 
Convert the stingarray to resource strings.

Change-Id: Iae9c52c21fd004c052fa78d959dfa92ad1d16a7d
Reviewed-on: https://gerrit.libreoffice.org/27641
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-01 06:22:14 +00:00
Noel Grandin
508c95f1b6 improve passstuffbyref return analysis 
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:48:25 +00:00
Caolán McNamara
a860df25dd masses of MessBoxes not being disposed promptly 
since...

commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f
Date:   Thu May 28 21:35:43 2015 +0100

    tdf#91702 - fix stack-based MessBox allocation.

There is no special ScopedVclPtr<X>::Create or
ScopedVclPtrInstance<X>::Create just
VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo
doesn't call dispose on the owned X

Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
 2016-07-26 11:26:52 +01:00
Noel Grandin
938821fb08 new loplugin overrideparam 
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.

Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-25 06:09:17 +00:00
Stephan Bergmann
922d67cbdb remove excess whitespace 
Change-Id: I11d775eed216e7d8a59d0b891dffcf191780aa9b
 2016-07-15 11:12:14 +02:00
nadith
e7d709cb24 tdf#100726: Improve readability of OUString concatenations in basctl module 
Change-Id: Iad8e3a2b74062640660c0ea8121dc6a5d043c080
Reviewed-on: https://gerrit.libreoffice.org/27228
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-15 08:38:57 +00:00
Mark Page
f7b1cd6616 Moved SfxModule owner to SfxApplication 
::GetAppData replaced with SfxApplication::GetModule
that now returns SfxModule*

SfxModule no longer registers self for ownership
instead it is now registered using SfxApplication::SetModule

Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8
Reviewed-on: https://gerrit.libreoffice.org/26914
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-13 06:32:46 +00:00
Stephan Bergmann
e15fc69491 loplugin:redundantcast: redundant static_casts in basctl 
Change-Id: Iac1a400f37ee25bfbebbe95bb22f9708581899f4
 2016-07-08 16:47:31 +02:00
Stephan Bergmann
580c0f5ede loplugin:passstuffbyref also for {css::uno,rtl}::Reference 
Change-Id: I2ddc6111cede4f7322aabbd1e5ecc671fe101d4e
 2016-07-07 18:59:55 +02:00
Arnold Dumas
aee49860ee tdf#100726: Improve readability of OUString concatenations 
Change-Id: I7018f3c339ffcab7d46d97f1d3784da1be644f0a
Reviewed-on: https://gerrit.libreoffice.org/26870
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-07-04 10:24:30 +00:00
Mark Page
66576fc1f6 SfxModule to use initializer_list instead of variadic arguments 
The compiler can perform type checking with initializer lists

Change-Id: I1d26b56a3a2b67fe719f33d758ca9b0c95ebd4d1
Reviewed-on: https://gerrit.libreoffice.org/26852
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-04 07:08:38 +00:00
Stephan Bergmann
f904bd567f loplugin:stringconcat 
Change-Id: I4156d1d57d0afaa2fc7ef93370fa824b38d273e4
 2016-07-04 08:22:25 +02:00
Muhammet Kara
d5784e91e9 Improve readability of OUString concatanation in LibPage 
, ScriptDocument
, PropBrw
, VBATest
, SbUnoClass
, SbModule
, and SbiSymPool

It is more readable and more efficient as a bonus.
See: https://goo.gl/jsVAwy:

Change-Id: I73926989345193b133e538d5aeca36f12723162c
Reviewed-on: https://gerrit.libreoffice.org/26853
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-07-03 15:46:58 +00:00
Noel Grandin
920d4463f6 loplugin:singlevalfields in vcl(part1) 
Change-Id: I0031199937cc95793951a070c4b3d8910933e69f
Reviewed-on: https://gerrit.libreoffice.org/26595
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-24 10:51:45 +00:00
Noel Grandin
2b7109a12a loplugin:singlevalfields in basctl 
Change-Id: Ia533309bb0e7f33b492b230a372916c0c6fd6ec3
Reviewed-on: https://gerrit.libreoffice.org/26631
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-24 10:51:11 +00:00
Muhammet Kara
456902abb4 Improve readability of OUString concatanation in LocalizationMgr 
It is more readable and more efficient as a bonus.
See: https://goo.gl/jsVAwy:

Change-Id: I56ba7aa1477361a686ffb50955525b73cce24197
Reviewed-on: https://gerrit.libreoffice.org/26585
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-23 14:01:31 +00:00
Noel Grandin
aa0d0536a4 tdf#97527 - vcl: reference-count Menu 
some places are marked with "dodgy"- need to check those to see
what is going on, because they are leaving dangling pointers behind
in the Menu class

Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b
Reviewed-on: https://gerrit.libreoffice.org/26516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-23 06:28:00 +00:00
Gökhan Gurbetoğlu
fbed9850fd Fixed a typo where highlighting was highlightning 
Or maybe it was intentionally done by some lightning superpowered guy?

Change-Id: I76c6b6ef94dae4c97a26537451cff0179074995b
Reviewed-on: https://gerrit.libreoffice.org/26295
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
 2016-06-16 05:58:03 +00:00
Noel Grandin
9f4e283fc8 loplugin:sallogareas 
Change-Id: I6ce045db236b81aa8bc7bce2a0e20c4132c5931f
 2016-06-13 10:25:40 +02:00
Noel Grandin
ab10f9fc11 convert DBG_ASSERT(false, to SAL_WARN( 
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c
Reviewed-on: https://gerrit.libreoffice.org/26187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-12 09:04:15 +00:00
Arnaud Versini
c0d7dfa56c BASIC : Add SbModule::FindMethod 
Change-Id: I3418c4a3d24b3b6630d6c80a6c8aa9d4ffb7e73a
Reviewed-on: https://gerrit.libreoffice.org/24346
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-12 07:43:03 +00:00
Noel Grandin
dfa8ecef62 Revert "Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flag"" 
This reverts commit abde31a2bc68302e1afafe1fcc3f5d85369010f8.

Since my analysis was completely incorrect, and the bug was elsewhere.
 2016-06-06 15:31:41 +02:00
Noel Grandin
abde31a2bc Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flag" 
This reverts commit e319ef1171dab61fff2201f5c1470ca09894c395.

Apparently, at some point, someone added a 'bool bDummy' param to
SfxModule, but only updated 2 of the 5 callsites. Since we're
passing in pointers here, at the other call sites, the bDummy
param evaluated to 'true'.
 2016-06-06 10:16:23 +02:00
Mark Page
e319ef1171 Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flag 
The SfxModuleArr_Impl is a static container of SfxModule, since
this is private to the SfxModule class it does not require
wrapping.

The bDummy flag is unused, and complicates the class

Change-Id: Ib03b215543a0c37d4edf20b2d0fc141a783e115e
Reviewed-on: https://gerrit.libreoffice.org/25859
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-06 07:40:25 +00:00
Noel Grandin
fa135fd0e0 remove unused SID constants and associated code 
found with a python script that looks like:

process = subprocess.Popen(
  "git ls-files *.hrc | xargs grep -hE '#define +SID_' | cut -d ' ' -f 2 | sort -u",
  shell=True, stdout=subprocess.PIPE)
for line in iter(process.stdout.readline, b''):
  line = line.strip()
  if line.startswith("//"): continue
  if line.startswith("sfx"): continue
  if len(line) < 10: continue
  i = subprocess.check_output("git grep -nP \"#define +" + line + " \"",
                              shell=True)
  if i.count("#define") < 2: continue
  print line + "
" + i

Change-Id: I40eac2569c2b5b129d9459cb723a9d6f26d09264
Reviewed-on: https://gerrit.libreoffice.org/25715
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-01 06:48:13 +00:00
Noel Grandin
b860b73f2b Convert VCL_MESSAGE to scoped enum 
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933
Reviewed-on: https://gerrit.libreoffice.org/25720
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-01 06:46:29 +00:00
Noel Grandin
c47b170c71 Convert SelectionMode to scoped enum 
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1
Reviewed-on: https://gerrit.libreoffice.org/25611
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-30 06:41:28 +00:00
Noel Grandin
f107d45381 Convert SbxClassType to scoped enum 
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b
Reviewed-on: https://gerrit.libreoffice.org/25259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-23 11:49:32 +00:00
Noel Grandin
2383d557e5 clang-tidy misc-unused-alias-decls 
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124
Reviewed-on: https://gerrit.libreoffice.org/25075
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-19 13:07:28 +00:00
Noel Grandin
2c8fe2e737 update unusedmethods plugin to deal with constructors 
and fix the operator< implementations in some of the other
plugins too.

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 10:03:44 +00:00
Noel Grandin
d96c114171 clang-tidy modernize-make-shared 
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a
Reviewed-on: https://gerrit.libreoffice.org/25056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 06:58:44 +00:00
Muhammet Kara
98505584ba Give unique, comprehensible names to idles tdf#97087 
Timers and idles should have programmer comprehensible, unique names.

Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a
Reviewed-on: https://gerrit.libreoffice.org/24605
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-05-16 01:06:48 +00:00
Caolán McNamara
71c4a2b761 mpDefDialogParent is not used since 2002 
i.e.

commit c0ae87cb5f2989bc4b8dff4907994d513ee87e39
Author: Stephan Schäfer <ssa@openoffice.org>
Date:   Tue Oct 22 08:39:05 2002 +0000

    #103442# choose DefDialogParent on-the-fly

and so calling SetDefDialogParent doesn't achieve anything

Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
 2016-05-12 10:09:26 +01:00
Stephan Bergmann
9c121778fe Add SAL_FALLTHROUGH, where apparently appropriate 
Change-Id: Ief09facecb6243815309a59e23a5673db5e1d94d
 2016-05-10 17:07:45 +02:00
Noel Grandin
58a32075ca use Any constructor instead of temporaries 
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
 2016-05-04 12:39:40 +02:00
Stephan Bergmann
6e70103da0 While at it, delete Any functions on sal_Bool* 
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of
sal_Bool across the code base

Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
 2016-05-04 11:59:23 +02:00
Noel Grandin
e8fd5a07ec update loplugin stylepolice to check local pointers vars 
are actually pointer vars.

Also convert from regex to normal code, so we can enable this
plugin all the time.

Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1
Reviewed-on: https://gerrit.libreoffice.org/24391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-26 10:55:58 +00:00
Caolán McNamara
4f92eb777a Resolves: tdf#99425 crash when closing dialog editor 
with undocked "Object Catalog" toolbar

Change-Id: I70d51cec699333c5cfc1461d61734c1bbb5323da
 2016-04-21 16:10:23 +01:00
Noel Grandin
8762aa986d clang-tidy modernize-loop-convert in b* 
Change-Id: I8ac6eb59e213eafa78e3dc4578738b53e8adef5b
 2016-04-21 10:27:17 +02:00
Noel Grandin
789055bc2a clang-tidy performance-unnecessary-copy-initialization 
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.

Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:37:31 +00:00
Jochen Nitschke
150ac9cf05 clean-up: unused using declarations and includes 
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.

Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:25:24 +00:00
Ryan McCoskrie
a6af1b545a Remove the hardly used SyntaxLineSet typedef 
Change-Id: Ib38bbbdcc65620329d1471d0d61ede65c4f834e6
Reviewed-on: https://gerrit.libreoffice.org/24176
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:17:02 +00:00
Julien Nabet
60b61b7859 tdf#97380: don't destroy completely window when replace dialog 
0x00002aaaf64ff222 in basctl::ScriptDocument::Impl::isApplication (this=0x9999999999999999) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:210
210	        inline  bool    isApplication() const   { return m_bValid && m_bIsApplication; }
(gdb) bt
0  0x00002aaaf64ff222 in basctl::ScriptDocument::Impl::isApplication (this=0x9999999999999999) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:210
1  0x00002aaaf64fa12e in basctl::ScriptDocument::isApplication (this=0x576b458) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:1311
2  0x00002aaaf648f6d7 in basctl::MarkDocumentModified (rDocument=...) at /home/julien/lo/libreoffice/basctl/source/basicide/basobj3.cxx:256
3  0x00002aaaf645e2a9 in basctl::implImportDialog (pWin=0x576b210, rCurPath=<error reading variable: Cannot access memory at address 0x999999999999999d>, rDocument=...,
    aLibName="Standard") at /home/julien/lo/libreoffice/basctl/source/basicide/baside3.cxx:1154
4  0x00002aaaf645eda9 in basctl::DialogWindow::ImportDialog (this=0x576b210) at /home/julien/lo/libreoffice/basctl/source/basicide/baside3.cxx:1213

Change-Id: I7365b2cacc8a3783fdc8e573bbc10ff574d9c4ed
Reviewed-on: https://gerrit.libreoffice.org/24139
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-04-16 22:27:16 +00:00
Julien Nabet
5b72c4ce7f basctl: prefix some members 
Change-Id: I59660153a33e83dc9457fbee082e8da444b04b58
Reviewed-on: https://gerrit.libreoffice.org/24126
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-04-16 14:17:11 +00:00
Noel Grandin
b8eb294651 loplugin:passstuffbyref in various 
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
 2016-04-14 10:24:47 +02:00
Stephan Bergmann
58ecaf1f47 Get rid of _SVX_NOIDERESIDS 
Change-Id: Iab728d51c24ccbedad5fa181850a673129d489ae
 2016-04-12 15:50:23 +02:00
Noel Grandin
48b8898bd7 clang-tidy performance-unnecessary-value-param in basctl 
Change-Id: Ie48eb08edd1335661d1ef57ae652713143951317
 2016-04-12 12:05:01 +02:00
Jochen Nitschke
4c7ec9f112 cleanup: remove unused com/sun/star/uno includes 
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.

Add a few missing includes provided by them.

Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-12 06:38:26 +00:00
Jochen Nitschke
b4ddacbc55 fix copy assignment signatures 
get value by reference

introduced in
commit 8c2f2e1dd77cdce9bdf63beff5a79f91adc44630 and
commit f9b200ce54cd67ddc04747f9676568a86e14d864

Change-Id: Iba84dd752f4cbdde9f3676c434d107efabe63a38
Reviewed-on: https://gerrit.libreoffice.org/23974
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-11 07:05:40 +00:00
Noel Grandin
db43ef00c1 sequence->vector in xmlscript 
Change-Id: I4f99cd9dc659f54bd4818559dd3e0dbce1e8f5d4
Reviewed-on: https://gerrit.libreoffice.org/23795
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-05 06:25:39 +00:00