938821fb08
new loplugin overrideparam
...
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.
Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-07-25 06:09:17 +00:00
7b2966dbf2
nBufSiz can be a non-class local constant
...
Change-Id: I2a7d32eabd01622261a1163781ac2a8b64bdee3f
2016-07-16 18:27:18 +02:00
30d722a8f9
Reduce #include dependencies
...
Change-Id: I5c6c379717869028102ab2a1ae7929dfbc447904
2016-07-16 18:27:18 +02:00
c9b4e29813
loplugin:constparams in tools
...
Change-Id: Iea05efbb90a0a95fefd18ae9673095a31422f06c
Reviewed-on: https://gerrit.libreoffice.org/27137
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-07-13 06:38:12 +00:00
f7b1cd6616
Moved SfxModule owner to SfxApplication
...
::GetAppData replaced with SfxApplication::GetModule
that now returns SfxModule*
SfxModule no longer registers self for ownership
instead it is now registered using SfxApplication::SetModule
Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8
Reviewed-on: https://gerrit.libreoffice.org/26914
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-07-13 06:32:46 +00:00
6d4f2dcc7c
Resolves: tdf#100452 class Date full (BCE,CE) proleptic Gregorian calendar
...
... implementing signed years with year 0 gap.
Date(31,12,-1) last day BCE
Date(1,1,1) first day CE
New class Date member functions:
* AddYears(sal_Int16) to be used instead of
aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap.
* convenience GetNextYear() to be used insted of GetYear()+1
* convenience GetPrevYear() to be used insted of GetYear()-1
* AddMonths(sal_Int32)
* operator=(const css::util::Date&)
New class DateTime member functions:
* operator=(const css::util::DateTime&)
Made some conversion ctors explicit, specifically Date(sal_Int32)
Adapted hopefully all places that used a sal_uInt16 year to use
sal_Int16 where appropriate.
Eliminated some quirks in date handling found on the fly.
Added era handling to i18npool icu calendar setting interface, which
missing was responsible for 0001-01-01 entered in Calc being set as
-0001-01-01, hence subtracting one day resulted in -0002-12-31.
Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f
Reviewed-on: https://gerrit.libreoffice.org/27049
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Jenkins <ci@libreoffice.org >
2016-07-08 20:41:02 +00:00
e0fe01bb03
Prepare for loplugin:redundantcast checking for redundant static_casts
...
Change-Id: Id113c4e99e74c40b577841e3486aea295bbd0310
2016-07-08 16:47:31 +02:00
d44c1c2ca6
LinkParamNone can be complete but uninstantiatable
...
Change-Id: I39bd23cd95ff97c6aeb00c9b02901ad6262767c1
Reviewed-on: https://gerrit.libreoffice.org/27031
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2016-07-08 10:53:10 +00:00
48a8d6d843
loplugin:singlevalfields in various
...
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e
Reviewed-on: https://gerrit.libreoffice.org/26738
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-28 11:21:17 +00:00
08fc0da403
tdf#75280 Cleaning up of sal_uIntPtr usage #1a
...
Change-Id: Ief2cc6ab03316c2530d386d662db21ca1c9ddb30
Reviewed-on: https://gerrit.libreoffice.org/25898
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2016-06-27 10:18:49 +00:00
6ab52cbb0e
reduce "no DbgTestSolarMutex function set" warning
...
Change-Id: I68c67e77a2759c8542dd4a44a78a9fcf8aa7dcc0
Reviewed-on: https://gerrit.libreoffice.org/26056
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-09 06:48:35 +00:00
c941b5a103
remove some manual refcounting in tools
...
Change-Id: Ic911b38f77dda7ce564f315a97624c9054c77a38
Reviewed-on: https://gerrit.libreoffice.org/26010
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-08 06:39:30 +00:00
62d270116b
tools: rename SvStream::Read/Write to ReadBytes/WriteBytes
...
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a
Reviewed-on: https://gerrit.libreoffice.org/25972
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2016-06-06 18:09:11 +00:00
8e8a88ec1a
loplugin:unusedfields
...
Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d
Reviewed-on: https://gerrit.libreoffice.org/25724
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-02 06:32:07 +00:00
59dbfecedb
Convert RSC_TOOLBOXITEM to scoped enum
...
Change-Id: Ic90b6950016417d5f57963ab69fd20905a943bb7
Reviewed-on: https://gerrit.libreoffice.org/25683
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-31 06:39:52 +00:00
ee1bf3538b
Fix bitmask
...
Change-Id: I0da9c57b2b442bb4c4b34ae63507fb98e7fbbe51
2016-05-30 11:19:03 +02:00
a499d1b980
Convert WINDOW flags to scoped enum
...
Change-Id: I952fcc940cfe4daca5a810a406a2b8ecd3bd6f47
Reviewed-on: https://gerrit.libreoffice.org/25582
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-30 08:32:06 +00:00
284ca1a584
Convert RSC_TOOLBOX to scoped enum
...
and drop unused (in .src files) constants
Change-Id: I1ef085d128893dc3234592e248451f248efb08ba
Reviewed-on: https://gerrit.libreoffice.org/25581
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-30 08:08:40 +00:00
ff5ce47439
Revert "remove unused RSC_DOCKWINDOW flags"
...
This reverts commit c8754b38ce205845aad5cde3c5ad4070ce38f7d5.
This causes toolkit.AccessibleDropDownListBox to fail with:
LOG> ImplementationName Unknown, does not implement XServiceInfo
Exception while getting Environment Couldn't create a test object
2016-05-27 14:10:31 +02:00
c8754b38ce
remove unused RSC_DOCKWINDOW flags
...
Change-Id: I2e2d82760b10876a7cf2a8cfb375926eb24d23e4
Reviewed-on: https://gerrit.libreoffice.org/25462
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-27 08:31:49 +00:00
74713b34a3
loplugin:unusedmethods
...
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda
Reviewed-on: https://gerrit.libreoffice.org/25431
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-26 07:50:33 +00:00
702eb3d389
convert RSC_IMAGE to scoped enum
...
and drop unused RSC_IMAGE_IMAGEBITMAP
Change-Id: I6c38e5e8e17d288ab525bbef368ebbc7e860e154
Reviewed-on: https://gerrit.libreoffice.org/25458
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-26 07:25:30 +00:00
a92cb70768
remove unused WORKWIN constants
...
Change-Id: I2216f52999271a3d39c8062c1ad58bd6664306a7
Reviewed-on: https://gerrit.libreoffice.org/25465
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-26 07:22:13 +00:00
12eec0ce0c
Convert METRICFORMATTER to scoped enum
...
Change-Id: If7004e0ca3f2dc229b1b36c07811eef09456b437
Reviewed-on: https://gerrit.libreoffice.org/25464
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-26 07:22:01 +00:00
ba91f894cc
Convert METRICFIELD to scoped enum
...
Change-Id: I283d578071af549c0f8f50de728859b6715e47b5
Reviewed-on: https://gerrit.libreoffice.org/25463
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-26 07:19:41 +00:00
8d1295a104
new src file has ExtraLong in use anymore
...
Change-Id: I1d31fb41a8f7def6a95a46dd61d0be4b608c6994
2016-05-25 15:51:31 +01:00
bad1f11fff
no src file has BorderStyle in use anymore
...
Change-Id: Id2d2d845c73a7c83bef2e66ede542e99b0475af8
2016-05-25 15:51:31 +01:00
07f1a39509
(nearly) nothing uses GetUniqueId anymore, so remove it.
...
The odd one out is the usage in Formula, which attempts
to restore focus to a particular window identified by
an unique id. In this case restore focus by keeping a VclPtr
to the desired window.
Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-25 14:24:20 +01:00
44e20713eb
Convert RSC_IMAGEBUTTON to scoped enum
...
Change-Id: Iedb0cfa8678627dbd0445e05524bd26a2c5838a2
Reviewed-on: https://gerrit.libreoffice.org/25258
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-22 17:54:00 +00:00
ef0e063938
Convert RSC_IMAGELIST to scoped enum
...
Change-Id: Iaf5f0723ab3e23e9afa1836a1b4cd8af2d86f010
Reviewed-on: https://gerrit.libreoffice.org/25257
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-22 17:53:52 +00:00
581e4da584
loplugin:unusedmethods in tools
...
Change-Id: I26a4ce6e849615d6d24632650ca03c40ab16502e
Reviewed-on: https://gerrit.libreoffice.org/25089
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-19 06:40:28 +00:00
d9bdc157b4
remove ACCELITEM stuff from rsc
...
Change-Id: I97dade0324edfb2d67ee33ef07498166b499c13c
Reviewed-on: https://gerrit.libreoffice.org/25003
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-16 09:19:20 +00:00
52372ae037
convert NUMERICFORMATTER to scoped enum
...
Change-Id: Ia6762153a73f01a237bfc03bf9a95a4117d1d998
Reviewed-on: https://gerrit.libreoffice.org/25010
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-16 06:43:19 +00:00
b852642ecd
remove unused RSC_SYSWINDOW and RSC_WORKWIN
...
Change-Id: I2c7db8a635c6770ff3221ee28b9349668d8d5881
Reviewed-on: https://gerrit.libreoffice.org/25004
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-16 06:43:06 +00:00
ee6af9f72c
convert RSC_MENUITEM to scoped enum
...
Change-Id: I35469edc7d8e5621f016f5eba613474d45711cd3
Reviewed-on: https://gerrit.libreoffice.org/24998
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-16 06:42:57 +00:00
743cdf36d1
convert RSC_MENU to scoped enum
...
Change-Id: Ice3784b4168738550d2c0f5ee6da1bd49d15becf
Reviewed-on: https://gerrit.libreoffice.org/24997
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-16 06:42:47 +00:00
1938fd869b
Convert RSWND to scoped enum
...
Change-Id: If6e5753ade8b096a4ba1c10b47c2360ff26d181f
Reviewed-on: https://gerrit.libreoffice.org/24993
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-16 06:42:38 +00:00
50ac0f503b
convert FONT_EMPHASIS_MARK to scoped enum
...
Change-Id: I137c78b337e57d3442db08334128e79d186b278f
Reviewed-on: https://gerrit.libreoffice.org/24753
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-09 09:41:34 +00:00
f3d9aab841
teach passstuffbyref plugin to check for..
...
unnecessarily passing primitives by const ref.
Suggested by Tor Lillqvist
Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6
Reviewed-on: https://gerrit.libreoffice.org/24672
Reviewed-by: Tor Lillqvist <tml@collabora.com >
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-06 06:48:38 +00:00
668e3d422c
use std::vector<> instead of embedding next pointers for ErrorHandler data
...
Change-Id: I759fc0d2bbc113873e2dda8edc8eb2eaf8036626
2016-04-25 09:13:35 +02:00
d848960a3e
rename Errhdl_Impl to ErrorHandler_Impl
...
Change-Id: I2405c74487a869def2436f19917937f69ab32916
Reviewed-on: https://gerrit.libreoffice.org/24310
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-25 06:02:27 +00:00
f4b8b9ad11
rename EDcr_Impl to DynamicErrorInfo_Impl
...
Change-Id: Id184df4e4466930ba75e47e257ceb75be2fab34b
Reviewed-on: https://gerrit.libreoffice.org/24309
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-25 06:01:56 +00:00
494bd08c48
remove tools/solarmutex.hxx
...
Deprecated in favour of comphelper::SolarMutex
Change-Id: I159077562660de5df25601fa471447f4b64a2cf1
Reviewed-on: https://gerrit.libreoffice.org/24079
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-15 08:09:01 +00:00
e07ca6480d
Avoid reserved identifier
...
Change-Id: I2e632b1e3f6f8725b184918c2205c3772bb37e32
2016-04-12 20:03:48 +02:00
f9aee52eb5
give tools::ResId a shave and a haircut
...
m_nRT2 and m_nWinBits fields are not in use anymore, at least as far
back as 2013, when the heading files were moved around
Change-Id: Ie3299a5999976450803332aeab72d5c0e68227e2
Reviewed-on: https://gerrit.libreoffice.org/23960
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-12 06:46:38 +00:00
50d02ad99f
clang-tidy performance-unnecessary-value-param in tools
...
Change-Id: I57b2fd191dfd937f3327f148b27767b364acf667
2016-04-11 15:12:10 +02:00
e5dd156a44
loplugin:constantparam
...
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-04-11 08:26:01 +02:00
953f8f2cfe
loplugin:constantparam in tools
...
Change-Id: I8b2a722b525722bd09ed1f27c648062d6f29cce7
Reviewed-on: https://gerrit.libreoffice.org/23723
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-04 09:09:39 +00:00
a83698b980
tools: split out color macros into own header
...
Change-Id: Ib983601d60a3dae1e738bb385dfbb36094bdb064
2016-03-18 12:54:26 +11:00
8ca50d20c1
loplugin:constantparam in tools
...
Change-Id: I3774661799c074561c694515baba42a375d0a077
Reviewed-on: https://gerrit.libreoffice.org/23301
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-03-17 06:09:42 +00:00