Commit Graph

163 Commits

Author SHA1 Message Date
392a483e10 fdo#46808, Adapt UNO services to new style, Part 7, updating ::create
Update code to use factory method PathSubstitutions::create

Change-Id: I3721bd93c36b207d849eea19102f5ac61cadd205
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, added some tweaks.
2012-06-06 10:01:22 +02:00
d08578912f fdo#46808, Adapt UNO services to new style, Part 7, updating ::create
Update calls to factories to use new SimpleFileAccess::create method

Change-Id: Ie5b0696fe2228a9033b19969245a53c21a61aa14
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, added some tweaks.
2012-06-06 10:01:22 +02:00
aca9239724 targeted string re-work
Change-Id: Ia651a93951da514105183775a5f49d031a192937
2012-06-02 17:57:17 -05:00
dc0d009f10 targetted misc. minor cppcheck cleanups reversion
Change-Id: Ic7f91c035d3e7f0e792d2e9ab217e1fc4ebcf697
2012-05-31 14:58:05 +01:00
c9afb3f5a7 This incorporates the suggested changes. 2012-04-23 19:37:11 +02:00
e4fb171d3a Replaced a few equal calls with == 2012-04-08 19:24:00 +02:00
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
743f22045c Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)\(else if\|if\) *( *\([^!()|&]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\)) *) *)$/\1\2 ( \3 == \4 )/' \{\} \;
2012-04-06 15:07:41 +02:00
15f14ec794 reorganize trickier statics 2012-04-02 14:53:48 +01:00
16244e7f24 removed duplicate includes in avmedia / basic / canvas / chart2 / comphelper 2012-03-28 00:30:29 +09:00
ed0ffbba06 over-engineered thread-safe static OUString
This is a ridiculous over-engineered thread-safe static string for
something which is called so few times, and costs 1k of long-term
memory as the OUString dtor needs to be put into a callback
queue to get called at module unload time.

Just return a new string every time, *rolls eyes*
2012-03-22 12:26:42 +00:00
e4fe6a9c46 state *what* was not found when throwing exception 2012-03-08 12:02:38 +00:00
2d7550d53f Removed unused macro 2012-03-08 00:06:25 +09:00
99ff0ab0b2 Remove unused code from basic 2012-03-05 18:54:28 +02:00
1543f1ec6d basic: tolerate empty / missing dialog.xlc and script.xlc files 2012-02-24 16:46:47 +00:00
1dc601f1b6 basic: remove un-used return value indicating failure 2012-02-24 16:46:46 +00:00
f150ed241f OUString ctor for string literals without RTL_CONSTASCII stuff
http://lists.freedesktop.org/archives/libreoffice/2012-February/025662.html
2012-02-22 16:21:37 +01:00
7be0cc289d A few safe replacements of pathes->paths 2012-02-01 14:43:37 +01:00
7c704c78d3 Removed some unused parameters; added SAL_UNUSED_PARAMETER.
SAL_UNUSED_PARAMETER (expanding to __attribute__ ((unused)) for GCC)
is used to annotate legitimately unused parameters, so that static
analysis tools can tell legitimately unused parameters from truly
unnecessary ones.  To that end, some patches for external modules
are also added, that are only applied when compiling with GCC and
add necessary __attribute__ ((unused)) in headers.
2012-01-21 15:21:16 +01:00
9201704ede Fix for fdo43460 Part IV getLength to isEmpty
Part IV
Module
basic (small fix per demand from Ivan Timofeev)
binaryurp
bridges
2011-12-13 00:11:25 +04:00
91d4fe75ee Fix for fdo43460 Part III getLength to isEmpty
Part III
Module
basic
2011-12-10 21:13:58 +04:00
3c795a953f removed dead code 2011-11-29 10:07:04 +09:00
2ca38d3c7c rmove include of pch header in basic 2011-11-27 12:55:59 -06:00
0c7bff0271 Changed sal/log.h -> sal/log.hxx, drop _S from C++ streaming log macros.
A compile time check ensures the common case of streaming just a plain
C-style string literal still produces reasonably compact call-site code.
The format-string variants are still available in sal/detail/log.h, but
only to be used in obsolete osl/diagnose.h etc., and going to be removed
again eventually.
2011-11-23 15:50:58 +01:00
e2de4357f5 catch by const reference 2011-11-23 02:21:44 +09:00
d6a8934eeb Remove no longer necessary "(void) x; // avoid warnings". 2011-11-22 17:03:12 +01:00
70a6b9ffbd New sal/log.h obsoletes osl/diagnose.h and tools/debug.hxx.
* New SAL_INFO..., SAL_WARN... macros.
* New SAL_STREAM supersedes OSL_FORMAT.
* oustringostreaminserter.hxx moved from unotest to rtl (and always UTF-8 now).
* TODO to enable GCC __attribute__((format)) in sal/log.h (requires call-site
  cleanup).
* Further functionality in tools/debug.hxx (DBG_MEMTEST, DBG_CTOR, etc.) not yet
  addressed.
* Some replacements tools String -> rtl::OUString.
2011-11-22 09:41:47 +01:00
8ff1724924 these are files--no trailing / 2011-10-27 16:49:08 +02:00
d1076b1b7f Second attempt at (cross-platform) OSL_FORMAT. 2011-10-08 18:56:48 +02:00
256f192582 Revert "Introduced OSL_FORMAT, adpated some places to it."
Breaks the MSVC build for me: 'osl_detail_formatString' : C linkage
function cannot return C++ class 'rtl::OString'.

This reverts commit 6b900b8bede24c8710d62e9e7cbff613a0b12f9f.
2011-10-08 15:07:06 +03:00
6b900b8bed Introduced OSL_FORMAT, adpated some places to it. 2011-10-08 12:59:09 +02:00
e1a1091d0a catch ignored exceptions by const reference 2011-08-24 11:30:17 +09:00
117281ba12 fix leaking 'Pictures' streams from basic dialogs in base
With database document, any contents of the Pictures folder ( afaics only basic dialogs store content here ) is never cleaned up between saves.
2011-08-22 15:44:55 +01:00
15f482b1e9 Add prefixes for some component_getFactory functions 2011-08-18 14:15:27 +02:00
caee685234 fdo#40173 write out *newly* empty library 2011-08-17 19:18:08 +02:00
03e9161e2e fdo#40079: load Dialog library before trying to get embedded images 2011-08-17 14:10:21 +01:00
e00c67ba62 Janitorial: deduplicate code; no behaviour change 2011-08-17 14:10:20 +01:00
cadce8b253 class SfxLibrary: Typo in private member name: maOrig*ni*alStorageURL 2011-08-14 11:49:04 -05:00
c8e76fbfed convert basic to gbuild 2011-07-30 10:39:20 +02:00
ba586696ef fixed typo 2011-07-26 23:54:35 +09:00
1b465fcc0f Do not use macros from comphelper's componentmodule.hxx 2011-07-21 13:30:54 +02:00
9df8682ced Merge remote-tracking branch 'origin/integration/dev300_m106'
Conflicts:
	basic/source/classes/sbunoobj.cxx
	basic/source/inc/runtime.hxx
	basic/source/runtime/step1.cxx
	desktop/source/deployment/dp_services.cxx
	drawinglayer/prj/d.lst
	drawinglayer/source/primitive2d/makefile.mk
	sfx2/source/appl/appinit.cxx
	sfx2/source/appl/appquit.cxx
	sfx2/source/inc/appdata.hxx
	sfx2/source/view/viewfrm.cxx
	svx/source/fmcomp/gridctrl.cxx
	vbahelper/source/vbahelper/vbahelper.cxx
2011-05-27 20:46:20 +02:00
a8c91a4b69 Revert "maybe temporary fix for crash when accessing basic uno services"
This reverts commit 1aa0150844d37e28cf0b420cbc60a96ad478edbe.
2011-05-17 15:30:54 +01:00
8d31e03997 maybe temporary fix for crash when accessing basic uno services
OModule implementation ( in comphelper/source/misc/componentmodule.cxx ) has been changed by commit f9496177a4c942f2acc39a978a3cd65689f14d8d, it seems we need to have a registerClient call made on the module in order for it to work. Adding a BasicModuleClient instance seems to do that ( not sure though if this is a correct fix )
2011-05-16 21:30:04 +01:00
f51c3f66b1 Merge commit 'ooo/DEV300_m106' into integration/dev300_m106
Conflicts:
	avmedia/source/gstreamer/gstframegrabber.cxx
	avmedia/source/gstreamer/gstplayer.cxx
	avmedia/source/gstreamer/gstplayer.hxx
	basic/inc/basic/sbxdef.hxx
	basic/source/classes/sbxmod.cxx
	basic/source/comp/makefile.mk
	basic/source/comp/sbcomp.cxx
	basic/source/inc/namecont.hxx
	basic/source/inc/scriptcont.hxx
	basic/source/runtime/methods.cxx
	basic/source/runtime/runtime.cxx
	basic/source/runtime/stdobj.cxx
	basic/source/runtime/step1.cxx
	basic/source/uno/namecont.cxx
	basic/util/makefile.mk
	connectivity/source/commontools/predicateinput.cxx
	connectivity/source/drivers/dbase/DNoException.cxx
	connectivity/source/drivers/dbase/DTable.cxx
	connectivity/source/drivers/file/fcomp.cxx
	connectivity/source/drivers/jdbc/JConnection.cxx
	connectivity/source/drivers/odbcbase/OResultSet.cxx
	connectivity/source/drivers/odbcbase/OStatement.cxx
	connectivity/source/parse/sqlnode.cxx
	desktop/source/app/app.cxx
	drawinglayer/inc/drawinglayer/primitive2d/drawinglayer_primitivetypes2d.hxx
	drawinglayer/source/processor2d/vclprocessor2d.cxx
	formula/inc/formula/token.hxx
	formula/source/core/api/token.cxx
	fpicker/source/win32/filepicker/VistaFilePickerImpl.hxx
	fpicker/source/win32/filepicker/platform_vista.h
	framework/source/helper/persistentwindowstate.cxx
	framework/source/uielement/menubarmanager.cxx
	oovbaapi/ooo/vba/XFoundFiles.idl
	oovbaapi/ooo/vba/excel/XApplication.idl
	oovbaapi/ooo/vba/msforms/XCheckBox.idl
	oovbaapi/ooo/vba/msforms/XComboBox.idl
	oovbaapi/ooo/vba/msforms/XControl.idl
	oovbaapi/ooo/vba/msforms/XGroupBox.idl
	oovbaapi/ooo/vba/msforms/XLabel.idl
	oovbaapi/ooo/vba/msforms/XListBox.idl
	oovbaapi/ooo/vba/msforms/XNewFont.idl
	oovbaapi/ooo/vba/msforms/XRadioButton.idl
	oovbaapi/ooo/vba/msforms/XTextBox.idl
	oovbaapi/ooo/vba/msforms/XToggleButton.idl
	scripting/source/dlgprov/dlgevtatt.cxx
	sfx2/source/control/unoctitm.cxx
	sfx2/source/doc/objstor.cxx
	sfx2/source/doc/objxtor.cxx
	svx/inc/svx/svdograf.hxx
	svx/source/form/fmpage.cxx
	svx/source/form/fmpgeimp.cxx
	svx/source/svdraw/svdedtv.cxx
	svx/source/svdraw/svdfmtf.cxx
	svx/source/svdraw/svdograf.cxx
	svx/source/svdraw/svdouno.cxx
	svx/source/xml/xmlgrhlp.cxx
	uui/source/iahndl-ssl.cxx
	vbahelper/Library_msforms.mk
	vbahelper/Library_vbahelper.mk
	vbahelper/inc/vbahelper/vbahelper.hxx
	vbahelper/prj/build.lst
	vbahelper/source/msforms/vbacombobox.cxx
	vbahelper/source/msforms/vbacontrol.cxx
	vbahelper/source/msforms/vbacontrols.cxx
	vbahelper/source/msforms/vbaframe.cxx
	vbahelper/source/msforms/vbaframe.hxx
	vbahelper/source/msforms/vbalabel.cxx
	vbahelper/source/msforms/vbalabel.hxx
	vbahelper/source/msforms/vbalistbox.cxx
	vbahelper/source/msforms/vbalistbox.hxx
	vbahelper/source/msforms/vbamultipage.cxx
	vbahelper/source/msforms/vbatogglebutton.cxx
	vbahelper/source/msforms/vbauserform.cxx
	vbahelper/source/vbahelper/vbacommandbar.cxx
	vbahelper/source/vbahelper/vbacommandbarcontrol.cxx
	vbahelper/source/vbahelper/vbacommandbarcontrols.hxx
	vbahelper/source/vbahelper/vbahelper.cxx
	vbahelper/source/vbahelper/vbawindowbase.cxx
	xmloff/source/meta/xmlmetai.cxx
	xmloff/source/style/PageMasterExportPropMapper.cxx
	xmloff/source/style/PageMasterStyleMap.cxx
	xmloff/source/text/txtexppr.cxx
	xmloff/source/text/txtprmap.cxx
2011-04-28 00:12:58 +02:00
76b3568e65 cppcheck inefficient checking for emptiness
From cppcheck: Using xxxx.empty() instead of xxxx.size() can be faster.
 xxxx.size() can take linear time but xxxx.empty() is guaranteed to take
 constant time
2011-04-22 11:31:09 +02:00
e60d365c86 drop bogus executable flag from [ch]xx/bas/asm files 2011-03-29 21:40:28 +01:00
b46dab973c calcvba: #164410# improve VBA compatibility implementation in various areas: Excel symbols, MSForms symbols, document and forms event handling 2011-03-25 10:40:25 +01:00
18cf2ccd24 Revert "Replace String with rtl::OUString"
You can't hope to change *some* virtual methods of a hierarchy and
leave others untouched, they all have to be changed together.

This reverts commit 9f46bee92be38f2d59295cabd9f1fdb149708153.
2011-03-22 17:05:42 +00:00
1a0760384e Replace String with rtl::OUString 2011-03-22 08:03:25 +01:00