Commit Graph

10033 Commits

Author SHA1 Message Date
f4785d5754 make XOBitmap uncopyable
Change-Id: I9c28434e8923451ddb1af4fa3c63917db206f47a
Reviewed-on: https://gerrit.libreoffice.org/32940
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-11 08:51:59 +00:00
feade09e18 SfxUShortRangesItem is unused
Change-Id: I6f88f37eca2bdd6b40c8713f1b2e35ad0be94ab0
2017-01-11 10:11:02 +02:00
a1d3dc1cbd post ctor, pre dtor there is always a mpMgr and its mpGlobalMgr
move the ImplEnsureGraphicManager calls to be the first thing
in the ctor to ensure that its also always available during
the ctoring, this is hopefully a good change

Change-Id: Iccddee7cac152df66dec0039df207a7575e1fa54
2017-01-10 14:18:45 +00:00
ad915fafd5 tdf#104830, need an own termination listener for lib objects
The destruction of the SwDLL object happens already through the normal
termination listener but the other termination listeners might still
depend on it. Also the outstanding events might need the SwDLL instance
to be still around.

This makes the destruction of the instance explicit and at a time when
it should be safe. We should use the same code for calc, impress, math
and base as well.

Change-Id: I50b8f30426f5a4a54e362e748fe962839abca73e
Reviewed-on: https://gerrit.libreoffice.org/32856
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-10 13:23:43 +00:00
8065e33626 move the ImplRegisterObj outside ImplSetGraphicManager and rename it
Change-Id: I1eded3ee41787b9a3339e01cf6e1157724bba1a6
2017-01-10 12:18:56 +00:00
3a44ef1d5d GraphicManagerDestroyed would just set the default manager again
which is the only one that could already be set. Seeing
as the manager is always there if a Graphic exists then
the maObjList must be empty at the dtor time

Change-Id: Id447d1e62a4b94b0ef986edf3cc05629c90e511b
2017-01-10 11:30:19 +00:00
8564b5beb1 first GraphicManager* arg of ImplSetGraphicManager is thus always null
Change-Id: I3da98280d3c1d95663e6e43ce7a5ca82c001c334
2017-01-10 08:53:15 +00:00
56d071c10c rename SAL_DEBUG_TRACE to SAL_DEBUG_BACKTRACE
since "trace" is such a generic term, this makes it easier to actually find the feature when you need it.

And add feature to limit stack depth of the reported backtrace.

Change-Id: Iab3e4ceb2e8480e7b5e2b920eb6c5d7631e21c43
Reviewed-on: https://gerrit.libreoffice.org/31752
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10 06:31:33 +00:00
014b9ac2e4 loplugin:unusedmethods
Change-Id: Ibe11923601760ded53a277c48631e4893606b2d6
Reviewed-on: https://gerrit.libreoffice.org/32875
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10 06:29:10 +00:00
4434b00290 defaults are good enough
Change-Id: I4520e00b8c48938a4ff1ed89e3c61948d886972c
Reviewed-on: https://gerrit.libreoffice.org/32889
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-10 00:18:45 +00:00
855fbe4edc second arg of deformed copy ctor isn't used
except in the qa test

Change-Id: I84d1a06194e4c11b218c417663f12195c9f76526
Reviewed-on: https://gerrit.libreoffice.org/32890
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09 20:35:21 +00:00
ff7ee9796f New loplugin:externvar: i18npool
Change-Id: Id38d1fde0e0f6e08899e83697f586d513b635aad
2017-01-09 15:42:59 +01:00
387a035d74 New loplugin:externvar: sal
Change-Id: Iefc33784f21e7a0b88c8d6308618926e38ab8554
2017-01-09 15:41:25 +01:00
ea86f1ca5c defaults are good enough
and protected isn't necessary

Change-Id: I6219632fe1da36d484864c2500e9ac14978f2cb8
2017-01-09 12:12:22 +00:00
eef56fc73b Related: coverity#1371305 unnecessary inheritence
SvDataCopyStream used to do extra Load/Save things that are long
gone, so there is no reason for the common base anymore

Change-Id: Ib321021002adb480bb96298f199141dc3fe2ec2b
Reviewed-on: https://gerrit.libreoffice.org/32851
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09 11:19:33 +00:00
e497d4d490 coverity#1371227 Missing move assignment operator
Change-Id: I2de6b5e2910ff570c08e662769d5e6ee188825a7
Reviewed-on: https://gerrit.libreoffice.org/32843
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-09 09:05:41 +00:00
048e30c1f8 tdf#101828 handle rtf/richtext correctly
Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0
Reviewed-on: https://gerrit.libreoffice.org/32682
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-09 00:34:30 +00:00
a1f97ed2aa XSubToolbarController is only used by SvxColorToolBoxControl
Change-Id: I10c31aa9c773649c99b52c2d34cb648a37bf42ac
2017-01-08 16:07:28 +02:00
215953f981 There is no SfxToolbox class
Change-Id: I30dd797921420a4009455841052f5c5436f4a93b
2017-01-08 16:07:27 +02:00
87f9e8945f default copy ctor and assignment operator are good enough
and block default move equivalents

Change-Id: Ib8a1050803446c2e099f66602fae0465bd8165cf
2017-01-07 21:57:03 +00:00
d911663f0f Typo: Acess->Access
Found thanks to Buovjaga

Change-Id: I73e36f50a1fd393859ba775ab084a488047864a3
Reviewed-on: https://gerrit.libreoffice.org/32810
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-07 10:08:48 +00:00
0ad4b2570f lok: refill font list if empty
After preinit stage the font list is empty
when creating documents.

Reviewed-on: https://gerrit.libreoffice.org/32108
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Conflicts:
	sd/source/ui/docshell/docshel4.cxx
	svtools/source/control/ctrltool.cxx

Change-Id: Ia6938d521626f4b4022f0f993e77c017e4932415
Reviewed-on: https://gerrit.libreoffice.org/32796
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-01-07 00:20:59 +00:00
9e7ff6a7e4 coverity#1398371 Useless call
Change-Id: I3614bb162cec889ee102e0284b6a3a33a98df470
2017-01-07 00:04:51 +00:00
6b89bcf85a check "#ERRxxx!" constants for accepted error values, tdf#105024 follow-up
Change-Id: I9a11695710baa2f4e022c8e07f01b962cfabe2e7
2017-01-05 18:23:45 +01:00
ab3fe69ffb finish moving ImageList to framework
Change-Id: I9d9f292066321174af8b0bcd96c58de5fc7566b8
2017-01-05 15:54:29 +00:00
3cd39b91f8 move ImageList to framework
this can probably be replaced by a std::*map<Image>

Change-Id: Ic36c5f406f5ea51cb9ff135858e319e0877179c7
2017-01-05 15:00:54 +00:00
4f5cd607e3 move CommandImageResolver out of vcl and beside its only user
Change-Id: I2bd70d87bb12d5750d8427b8a8fe786cfce8961b
2017-01-05 15:00:54 +00:00
57990e4b8e move ImageType enum out of CommandImageResolver.hxx
Change-Id: I0b4da9a4edff8d0f9016fbd79cb205bdf2b35268
2017-01-05 15:00:54 +00:00
b07fac2f7a oox: rename misleadingly prefixed m_pShapeStyle
Change-Id: I07fdc4fff2dd05b57d1a0635d0bed8d1afd6dc58
2017-01-05 15:51:31 +01:00
cdff2caffa No need for heap-allocated OUStringBuffer
Change-Id: Id2dbe3ecce9eba2eefab90f43b9a2a6894839cfb
2017-01-05 15:41:59 +01:00
fbf10700c5 ImageList doesn't need to be a friend of Image
Change-Id: I3bfe3b6fcd033f1cab503934cf4442adb0143939
2017-01-05 13:50:29 +00:00
21033d04fd Clean up a usage of OUStringBuffer
Change-Id: I8435865f1a67a3a6d889c1b8a3d30e632ffc61fd
2017-01-05 14:24:28 +01:00
9253dae361 drop newly unused InsertFromHorizontalBitmap
Change-Id: Ia0b0032bf261712be30ac23c8e5ce993011b2e5c
2017-01-05 13:24:09 +00:00
619456ed85 unwind RID_SVXBMP_FRMSEL_ARROWS imagelist
Change-Id: Id74ebd81b3688383271b581b69734fecfe3eb079
2017-01-05 13:24:09 +00:00
1016cd7856 flatten and simplify this resource hierarchy
Change-Id: I622dae5f36b44c08e597d94fe8184ad92504d038
2017-01-05 13:24:09 +00:00
c03d803a72 Replace side-effect--only uses of makeStringAndClear() with setLength(0)
Change-Id: Iaf8011f1bd6a10b324653899b7f51458f7d0b68a
2017-01-05 13:52:17 +01:00
9152f16b79 tdf#102059 NotebookBar accessible using F6 key
Change-Id: I873c49d8c0557eb3702de921fb5d2281acfed526
Reviewed-on: https://gerrit.libreoffice.org/32459
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-05 09:36:54 +00:00
ad9cfbcf02 Don't exclude a var from loplugin:salbool merely because of use in >>=
Change-Id: I1b8a3dfa1dc6b351ab0903a74eae19dfa6d0888d
2017-01-05 09:17:47 +01:00
9ae8e4d356 Base SvxLineEndWindow on ToolbarPopup
Fixes size and position issues under gtk3/wayland

Change-Id: I357a5935e2b44fd3d5effde8cf7d3499e26384db
2017-01-05 00:11:29 +02:00
835556b51a Prefix SvxLineEndWindow members
Change-Id: I0cfe88c65cc75757938a9f8004c219fbe39f88dd
2017-01-05 00:11:29 +02:00
9e4ae869f4 Get rid of SvxLineEndWindow resizing
Change-Id: I0135f084f64b9709688f0f9205940baf193c5d83
2017-01-05 00:11:29 +02:00
a487e548a0 Use command labels for the color popup title
Change-Id: I2f61e25ef4451775320f8fa1761a951ab94af7d5
2017-01-05 00:11:28 +02:00
59ad262ab9 last bitmaps that pMaskColor arg was used on converted to true transparency
Change-Id: I99bb32355bc53e2c870f84e60fc1e35b9dfe8270
2017-01-04 20:34:55 +00:00
4d1cbb7e89 drop unused SplitWindow::ImplDrawButtonRect
Change-Id: I0ccb4adfec39f8717d5921e04809af65be066d0a
2017-01-04 20:34:55 +00:00
8077cc31a0 all users of InsertFromHorizontalBitmap use all args
Change-Id: I458036b084645af509d64a78f5389415dfc4115a
2017-01-04 20:34:55 +00:00
9e7b0ef950 follow up remove unused autohide leftovers
Change-Id: Ic7281e915075519c300a330557399111838d7d34
2017-01-04 16:50:44 +00:00
b4a31534b9 drop AutoHide code
only used from reportdesign and that appears to be overlooked from an earlier
eradication program

Change-Id: I196fd7ccbc909c935daf534d55e6b39de8510f23
2017-01-04 16:50:44 +00:00
4ad249af88 tdf#105093 sd PDF export: handle embedded videos
In practie embedded files always have a temp file URL, so from the PDF
export's point of view they are still URLs, just at the end the contents
of the URL is embedded to the PDF, not just the URL itself.

So add a SetScreenStream() that's similar to SetScreenURL(), but it's
for embedded, not linked videos.

Change-Id: Ifcc60357ef0f5fed0bdec02e0c84cb16ee147781
Reviewed-on: https://gerrit.libreoffice.org/32727
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-04 16:27:44 +00:00
da7b100184 tdf#97228 Moved class ControlCacheKey in a seperate include file.
class ControlCacheKey defined in include/vcl/salnativewidgets.hxx is used
only by vcl therefore it is moved to a seperate include file named
ControlCacheKey.hxx which is inside vcl/inc/ControlCacheKey.hxx.

This header file contains the definition of the the class ControlCacheKey.

Since this class uses an object of another class named Size which is
defined in gen.hxx therefore this is included in ControlCacheKey.hxx.

All the files that references the class ControlCacheKey includes
ControlCacheKey.hxx with the syntax: #include "ControlCacheKey.hxx"

Change-Id: I7d7b3e1cf6950a953e6bbed670c1914826b2bacd
Reviewed-on: https://gerrit.libreoffice.org/32422
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-04 16:02:26 +00:00
0e71075bb7 Related: tdf#104841 sw PDF export: handle linked videos on non-first pages
Be explicit about the page number, this way a video on the second page
doesn't end up as an annotation for the first page. (In the Impress case
each slide is exported separately, so there this wasn't a problem.)

Change-Id: I83ba9cb4a3b2a6734bd88a138654e391199651c6
Reviewed-on: https://gerrit.libreoffice.org/32696
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-04 08:15:51 +00:00