wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
401,943 Commits 5 Branches 0 Tags
584262fed1368dba382d88dfd25fe35ac7d4b349
Commit Graph

332 Commits

Author SHA1 Message Date
Julien Nabet
d911663f0f Typo: Acess->Access 
Found thanks to Buovjaga

Change-Id: I73e36f50a1fd393859ba775ab084a488047864a3
Reviewed-on: https://gerrit.libreoffice.org/32810
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-01-07 10:08:48 +00:00
Jochen Nitschke
bd3402ba43 tdf#88206 replace cppu::WeakImplHelper* in sax and xml* 
Change-Id: I75f4000a17155fbdff96fe0733dc0225b20cd4d2
Reviewed-on: https://gerrit.libreoffice.org/31678
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-06 18:22:00 +00:00
Noel Grandin
29a9e97db6 loplugin field-can-be-private in include/vcl..xmlscript 
Change-Id: Ia03f7cccb256d825daa4dc6f4c0598448e46e6cf
Reviewed-on: https://gerrit.libreoffice.org/31069
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-23 07:17:50 +00:00
Noel Grandin
f4e24dd79c loplugin:datamembershadow in xmloff 
Change-Id: Ibea23b1757be1ec007f48261130aad74ce750cfc
Reviewed-on: https://gerrit.libreoffice.org/30925
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-17 08:59:58 +00:00
Noel Grandin
7cca2c7fb3 new loplugin finalprotected 
look for final classes, and make sure they don't have protected members

Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4
Reviewed-on: https://gerrit.libreoffice.org/30895
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-16 09:10:16 +00:00
David Tardon
4ead110a8c remove prop. name variable 
It is not used consistently anyway.

Change-Id: Ia842668dfb36dc2a8fbf3b938758b81c78d5c868
 2016-11-15 19:58:54 +01:00
Noel Grandin
5f77e6e930 update loplugin:unnnecessaryvirtual to handler destructors 
and update modules writerfilter..xmloff with the resulting changes

Change-Id: I54d19c22ddb0ff579b32e4934d266c925b19305c
Reviewed-on: https://gerrit.libreoffice.org/30530
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-04 07:15:03 +00:00
Takeshi Abe
c498c97f74 The default std::less<sal_uInt16> is fine 
Change-Id: I29cd62ef0b687613ed9bda5170511dcae2fc6e7e
Reviewed-on: https://gerrit.libreoffice.org/30282
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2016-10-26 08:39:09 +00:00
Noel Grandin
a41ecf9227 loplugin:expandablemethods in xmloff 
Change-Id: I995a4167ac4df5ca35d963dcf68ae802a997e1e1
 2016-10-24 13:35:36 +02:00
Andrea Gelmini
525311b0d6 Fix typos 
Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4
Reviewed-on: https://gerrit.libreoffice.org/30040
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
 2016-10-23 17:17:01 +00:00
Noel Grandin
f0ae4082eb loplugin:expandablemethodds in include/xmloff 
Change-Id: I6b1430220adaf240ef873ff908e3a767dfc278bf
Reviewed-on: https://gerrit.libreoffice.org/30106
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-21 06:18:01 +00:00
Noel Grandin
7477ab1391 loplugin:inlineablemethods in xmloff 
Change-Id: I22202f85c65a862ccdafe1d521e2945e3d99252a
 2016-10-18 08:51:07 +02:00
Noel Grandin
62223f9a8a loplugin:unnecessaryoverride 
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae
Reviewed-on: https://gerrit.libreoffice.org/29656
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-13 06:47:44 +00:00
Noel Grandin
5c84f40ea2 loplugin:constantfunction 
update the plugin similarly to
    commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970
    Author: Stephan Bergmann <sbergman@redhat.com>
    Date:   Fri Oct 7 12:05:49 2016 +0200
    loplugin:staticmethods: Don't be fooled by decls starting with macros

Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510
Reviewed-on: https://gerrit.libreoffice.org/29665
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-11 06:15:21 +00:00
Stephan Bergmann
51e472296b loplugin:staticmethods: xmloff 
Change-Id: Iad001ce011cd6aff4af9bb2e9129abee7fb935dc
 2016-10-07 12:07:43 +02:00
Caolán McNamara
5d2210d5f3 might as well go back to a std::stack now 
after...

commit 8daf6707ef203b26a744140f74d7cd231a25f0dd
Author: Michael Stahl <mstahl@redhat.com>
Date:   Thu Oct 6 23:37:51 2016 +0200

    xmloff: fix crash in ~XMLParaContext on fdo72541-1.fodt

Change-Id: I57f10e60a2f76dde048a594d8391bb5b246dfc63
 2016-10-07 08:58:57 +01:00
Caolán McNamara
fd79f88272 crashtesting: use a stack with the expected dtor order for its elements 
contains test document which crashes if it doesn't

Change-Id: Ieeee6cc7007a90d37225fffd636c9648289f04d7
 2016-10-04 12:14:09 +01:00
Caolán McNamara
22cea99518 this is used as a stack, so convert to std::stack 
Change-Id: I248617ccbb985615f936ecd607ab7c8246ff8e71
 2016-10-04 12:14:09 +01:00
Markus Mohrhard
89804c14ee implement prototype for more stable calc cell style names 
This should ensure that as long as the style does not change the cell
style name is the same after an import export cycle.

Each ScPatternAttr stores a unique ID and we store the ID to name
mapping during import. During export if we find a ScPatternAttr that has
a key that is also stored in the map we write back the style name from
the map.
To avoid name collisions we block the style names from the import for
the export.

The missing piece to make this completely awesome is now to make sure
that styles are sorted by name during export. That way we can reduce the
diff between import and export even more.

Change-Id: Ie4fe2aa00f07efec27ea129e314ac0b6b7e0d8c0
Reviewed-on: https://gerrit.libreoffice.org/29255
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-09-26 19:37:12 +00:00
Markus Mohrhard
198fabe0f2 soon is now 
Change-Id: Ib4b8b949f00609149f9134fb2f286cd7e0dc0255
Reviewed-on: https://gerrit.libreoffice.org/29254
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-09-26 08:32:00 +00:00
Mohammed Abdul Azeem
5678bc99fb tdf#101935 and tdf#102201: 
This fixes both the bugs.

Change-Id: I7a64abc0cb12b5195a3b955549ce4f72f3530d57
Reviewed-on: https://gerrit.libreoffice.org/29263
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-25 13:22:51 +00:00
Michael Stahl
dbf87d2124 coverity#1372990 xmloff: use unique_ptr for RewindMaps 
Change-Id: I51e67607d94a465ce39e822f01a0c60efbf1a0f0
 2016-09-16 14:33:59 +02:00
Noel Grandin
0ea50b5b43 loplugin:countusersofdefaultparams in xmloff 
Change-Id: Ia92a878ac97b3cc668594946e77a718f27a3e3ed
Reviewed-on: https://gerrit.libreoffice.org/28890
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-14 08:47:48 +00:00
Stephan Bergmann
a53808c0ed loplugin:dllprivate 
Change-Id: I1fe70a39c50aba8b84c117653185fc37dbbfeab0
 2016-09-13 22:26:22 +02:00
Eike Rathke
e12c9b4101 do not add calendar modifier to format code when importing as E or EE keyword 
... with implicit calendar switch.

Change-Id: Ie4d848e261fe86bbe504954b2e0c7cf24bc181bc
 2016-09-13 20:03:54 +02:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Caolán McNamara
187e2dbd6e coverity#1372877 I'm guessing this is what might have been the intent 
warning is 'Constant' variable guards dead code

Change-Id: I06e65f576180d7ff62417828c26f969982788b55
 2016-09-13 11:49:29 +01:00
Stephan Bergmann
7ed3e749f7 Blind fix for MSVC 
Change-Id: I53e01f3c76cf1e52fbf5f95f525cfc3b643b9e77
 2016-09-10 07:49:02 +02:00
Markus Mohrhard
9f0bf2c32a fix the build 
Change-Id: I600d1820d95ecbd428bbda18b3a07ec225bd2db0
 2016-09-10 00:15:04 +02:00
David Tardon
8e11d35366 use std::unique_ptr 
Change-Id: I8ba37267e8a7058ade54783ea0e117a8f8816c45
 2016-09-09 16:16:45 +02:00
David Tardon
7469d75569 use std::unique_ptr 
Change-Id: I39475538ed838e4210e256d85c6dd46232f8dc50
 2016-09-09 16:16:45 +02:00
David Tardon
66e6278e9a use std::unique_ptr 
Change-Id: I507b19dfd7445144258554b08bbf2fea0ed1698f
 2016-09-09 16:16:45 +02:00
David Tardon
ecb2850003 use std::unique_ptr 
Change-Id: Ic0cb9399e5cfc7237a3cda666b1d4f926761a9ca
 2016-09-09 16:16:45 +02:00
Stephan Bergmann
9dc0f2b703 Blind fix for MSVC 
Change-Id: I1b3e21e9fdf1ac14e095df203cb48fdd1b4fd028
 2016-09-09 14:26:53 +02:00
David Tardon
87bc9685c2 use std::unique_ptr 
Change-Id: I33d75ede0031da63c00c35af7b42867fea0b8d80
 2016-09-09 12:14:04 +02:00
David Tardon
22547c51cf use std::shared_ptr 
Change-Id: Ie3f89c611f06be3c2fd5f43a4fa691f719078307
 2016-09-09 12:14:04 +02:00
David Tardon
1eb1ff0faa use std::unique_ptr 
Change-Id: I94aafd665116d01d2f6134c4b41ab70c34e23ab6
 2016-09-09 12:14:04 +02:00
Noel Grandin
d4b0ab2214 loplugin:refcounting 
Change-Id: I3ab5f1df08670fdad3e31aadafd3a02f1925dd88
 2016-09-09 10:24:24 +02:00
David Tardon
084de9dda4 remove manual memory management 
Change-Id: Ic715adae42ff34be892d19802629aa50077dc120
 2016-09-09 07:30:30 +02:00
David Tardon
a363175cfc remove direct memory management 
Change-Id: I9c7d53a9cfd5c03e1551626a96cdaa30fc4e546b
 2016-09-09 07:30:30 +02:00
David Tardon
a66933a890 use std::unique_ptr 
Change-Id: I5128b3e950657f3fe6fc71a8de56c9dd87ac2324
 2016-09-09 07:30:30 +02:00
David Tardon
3ef084c9bd remove direct memory management 
Change-Id: Id0278f15e0c46a32cf07900dffdf27b3acb2649c
 2016-09-09 07:30:30 +02:00
David Tardon
45df4baf4e use std::unique_ptr 
Change-Id: Ic6ebe839fa22e6a7b9904ad00877eddd78331ba4
 2016-09-09 07:30:30 +02:00
David Tardon
bb35e4dcf9 remove direct memory management 
Change-Id: I5dd5d9130f11f47c4b48c1aae9748434ac751d95
 2016-09-09 07:30:30 +02:00
David Tardon
1e8140083d remove direct memory management 
Change-Id: Ie5103347fc30095778d96d46ce702bf4f0da00a6
 2016-09-09 07:30:30 +02:00
David Tardon
32ccb4ea86 resolve the snafu with 2 separate refcounted bases 
Change-Id: Ia275596d54ea27436f03d01297fb78b6ca09e8a6
 2016-09-09 07:30:30 +02:00
Noel Grandin
702496391b loplugin:constantparam in vcl..xmlscript 
Change-Id: Icf66c08071b154259c9e551342d30331caf2b15a
Reviewed-on: https://gerrit.libreoffice.org/28685
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-09-07 06:48:56 +00:00
Stephan Bergmann
548ab842a8 Again avoid UBSan "left shift of 65536 by 16 places cannot be represented... 
...in type 'int'"; i.e., re-apply 11cc9bdc21be241f2feb3ab4822d9d365dba4f96
"Avoid UBSan 'left shift of 65536 by 16 places cannot be represented..." after
67ef208b2b586603e205105a384231645d7f6712 "Fixes for migrating SvXMLImport to use
FastParser" removed that fix, for no apparent reason.

Change-Id: I8379d2ae8a39ce8a655688d1168d8de67186472a
 2016-09-06 14:39:02 +02:00
David Tardon
c6383758c7 use std::unique_ptr 
Change-Id: I0cc84cc6b18849118a2b7824a8e4b37ca063cd50
 2016-09-06 14:38:06 +02:00
David Tardon
7e4d152105 drop unneeded dynamic allocation 
Change-Id: I9e19c33998137ee0065f92ccb980d1ff5a82115b
 2016-09-06 14:38:06 +02:00