wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
399,744 Commits 5 Branches 0 Tags
58e2f9a3e2b11d00aec85b2fdfd0fbf31101bf31
Commit Graph

203 Commits

Author SHA1 Message Date
Noel Grandin
c5498c310f loplugin:expandablemethods in UnoControls..vbahelper 
Change-Id: I7e607df2a1f6d4eb207ee0d3eb30f41fac44a0c6
Reviewed-on: https://gerrit.libreoffice.org/30262
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-25 11:16:02 +00:00
Noel Grandin
98b77ad1e6 loplugin:expandablemethods in UnoControls..vbahelper 
Change-Id: Iec2c5e13119d97c9ca87e083c0f7cb00227e5231
Reviewed-on: https://gerrit.libreoffice.org/29997
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-19 06:24:23 +00:00
Andrea Gelmini
8f9af8dd97 Fix typos 
Change-Id: Ie44267e7c9f92eb1920f05235826abff761251f1
Reviewed-on: https://gerrit.libreoffice.org/29430
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
 2016-10-03 13:43:44 +00:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin
508c95f1b6 improve passstuffbyref return analysis 
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:48:25 +00:00
nadith
bfe6c2dedb tdf#100726: Improve readability of OUString concatenation a bit 
Change-Id: I6c51b9004089721f199bc35b1e5c13df36847f02
Reviewed-on: https://gerrit.libreoffice.org/27227
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-15 08:38:00 +00:00
Noel Grandin
0b23eec200 teach refcounting clang plugin about uno::Reference 
uno::Reference is only allowed to used with classes that have a
::static_type member.
So convert all those places to rtl::Reference.

Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and
uno::Reference to make this a little smoother?

Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3
Reviewed-on: https://gerrit.libreoffice.org/25516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-31 06:25:45 +00:00
Noel Grandin
b19ac3c4c6 clang-tidy modernize-loop-convert in a* 
Change-Id: If8eada464c6dc7350e50fc90eb27aa47bd90e198
 2016-04-21 10:12:01 +02:00
Noel Grandin
c45d3badc9 new loplugin: commaoperator 
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
 2016-02-23 08:08:56 +02:00
Noel Grandin
dff9873c27 loplugin:unusedfields UnoControls,ucb 
Change-Id: I2ff2db21d79d80785f3b6849c879537d5111a960
 2015-12-21 12:45:50 +02:00
Noel Grandin
21a9bc8716 no need to take a mutex when only dealing with stack-local data 
Change-Id: Ie45e626aad55a8174a53b769a98601bf54dedf65
Reviewed-on: https://gerrit.libreoffice.org/19979
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-16 11:37:11 +00:00
Noel Grandin
25aec383f9 use initialiser for Sequence<OUString> 
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:18:55 +00:00
Noel Grandin
c504477e7c com::sun::star->css in UnoControls/ 
and remove some noise comments

Change-Id: I290ec365b58fa1b21838a6faf84006434c3e7bbd
Reviewed-on: https://gerrit.libreoffice.org/19904
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-11 11:01:31 +00:00
Stephan Bergmann
3bf5bc0374 loplugin:nullptr (automatic rewrite) 
Change-Id: I8be8b75317f0a8cf9005feefea05c053b76c7b0f
 2015-11-10 10:31:14 +01:00
Noel Grandin
065c8b48a6 use uno::Reference::set method instead of assignment 
Change-Id: I58410209f32f988f258a588364e0b037c2790211
 2015-10-30 08:10:22 +02:00
Noel Grandin
367105e024 cleanup some local var declarations 
found with
   git grep -nP '(\w+)\s+=\s+\g1\(' | lots-of-hand-filtering

Change-Id: I598b0cfa6607823eaef09d95e610e05145c727f7
 2015-10-19 13:08:29 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Andrea Gelmini
82f0a4f930 Fix typos 
Change-Id: I3926eca56ac9f54f9ddbf88610888ce97cf00b34
Reviewed-on: https://gerrit.libreoffice.org/18990
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-30 10:41:48 +00:00
Noel Grandin
2660d24a07 new loplugin: refcounting 
This was a feature requested by mmeeks, as a result of
tdf#92611.

It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.

Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-03 06:37:16 +00:00
Stephan Bergmann
cbce40e965 Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds 
...to avoid lots of loplugin:staticmethods warnings.  Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.

Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
 2015-07-13 18:14:11 +02:00
Andrea Gelmini
462e986e0d Fix typos 
Change-Id: Id9296115f30858e7fd470a199e59343a96d7deec
Reviewed-on: https://gerrit.libreoffice.org/16712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-07-04 10:18:19 +00:00
Stephan Bergmann
b997705c07 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I2828f5fe78efffaa5dee19a3d56592d12878d956
 2015-06-08 16:22:58 +02:00
Noel Grandin
d5129a9dd6 new clang plugin: loopvartoosmall 
Idea from bubli - look for loops where the index variable is of such
size that it cannot cover the range revealed by examining the length
part of the condition.

So far, I have only run the plugin up till the VCL module.

Also the plugin deliberately excludes anything more complicated than a
straightforward incrementing for loop.

Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
 2015-05-28 12:49:54 +02:00
Michael Stahl
cbaca2c1ce remove unused #include awt/InvalidateStyle.hpp 
Change-Id: I7ea52365157fc642401db64c3b4a40d4643d16ae
 2015-05-05 15:51:09 +02:00
Michael Meeks
5d5f447e73 UnoControls, toolkit, uuoi, xmlsecurity: convert new to ::Create. 
Change-Id: I7b8c7ece656589c50fb066e9fa1565fd59f930da
 2015-04-16 22:21:04 +01:00
Stephan Bergmann
d246f47422 Replace remaining getCppuType et al with cppu::UnoType 
Change-Id: I61a85caf1587291eaa6b999050a52c92d9e416e3
 2015-04-01 08:35:13 +02:00
Noel Grandin
44790193a7 loplugin:staticfunction 
Change-Id: I982ba552579019e4902ae59fddf14a6b34ba5954
 2015-03-27 10:51:08 +02:00
Stephan Bergmann
3099c70b11 Fix various XServiceInfo implementations 
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
 2015-03-17 12:25:11 +01:00
Caolán McNamara
556373c41f V668 no sense in testing the result of new against null 
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
 2015-03-11 09:58:36 +00:00
Julien Nabet
5f6fcb4e7c Typos 
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
 2015-03-08 16:45:30 +01:00
Julien Nabet
c1b9402d49 Typos 
Change-Id: I151957e415eff793e3d054050526b7d6892d28d4
 2015-02-28 14:54:12 +01:00
Noel Grandin
ba233e87ef remove unnecessary parenthesis in return statements 
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'

Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
 2015-02-23 09:26:58 +02:00
Andrea Gelmini
81cb993127 Fix of a few typos 
Change-Id: Ib2a311f0341d165a8f9d3f7a11ec36378fd69519
Reviewed-on: https://gerrit.libreoffice.org/14373
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-02-09 16:20:09 +00:00
Noel Grandin
45ec1d9b56 brute-force find-and-remove of unused #define constants. 
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
 2015-01-08 10:39:36 +02:00
Stephan Bergmann
1990c75175 Daft += "\0" triggers assert 
...try

GetProcessServiceManager().createInstance("stardiv.UnoControls.ProgressMonitor").addText("foo", "bar", false)

in Basic...

Change-Id: I30318c3e8e671a97b6a3fe2dd9ec03add21794ab
 2014-12-16 13:31:48 +01:00
Stephan Bergmann
8502d64878 Daft "\0" triggers assert in OUString literal ctor 
...try

GetProcessServiceManager().createInstance("stardiv.UnoControls.StatusIndicator")

in Basic...

Change-Id: Iafc22188feb8a1d3f1b19ac4f6e209be62a44d17
 2014-12-16 13:23:19 +01:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use 
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
 2014-11-18 18:51:49 +01:00
Noel Grandin
0371a63365 remove unnecessary 'using namespace rtl' declarations 
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-29 11:28:54 +00:00
Noel Grandin
a2320eaf39 loplugin: cstylecast 
Change-Id: I28443b688f8ab752162846e5cea661f26d269cad
 2014-09-29 12:50:36 +02:00
Stephan Bergmann
15652daf08 UnoControls: sal_False/True -> false/true 
Change-Id: If30d43a2693c6df2d483ec135efa54ccb643fdb0
 2014-09-15 17:23:23 +02:00
Takeshi Abe
9bac4d413e typo: more then -> more than 
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
 2014-08-01 23:40:12 +09:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Stephan Bergmann
dc0b96639f -Werror,-Wtautological-undefined-compare 
Change-Id: If546680f4c16ccd733188a65d82129ec2358017b
 2014-06-10 10:53:46 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Julien Nabet
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20 
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
 2014-05-23 22:11:52 +02:00
Pedro Giffuni
4d878a0809 Many spelling fixes: some more files. 
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades.

(cherry picked from commit e62c0f54ef18a5a79b76e934834b148523c69847)

Conflicts:
	LICENSE
	NOTICE_category_b
	UnoControls/source/base/basecontainercontrol.cxx
	UnoControls/source/base/registercontrols.cxx
	UnoControls/source/controls/OConnectionPointContainerHelper.cxx
	UnoControls/source/controls/progressbar.cxx
	UnoControls/source/controls/progressmonitor.cxx
	UnoControls/source/controls/statusindicator.cxx
	UnoControls/source/inc/framecontrol.hxx

Change-Id: I882a1d640d931b4e89b2d19f3585fd35fdd320ca
 2014-04-30 13:30:20 +01:00
Jan Holesovsky
e6ac6cbccf automaticly -> automatically. 
Change-Id: Iae55083160eee86ac8301f272634dd3ae65fd847
 2014-04-27 01:28:55 +02:00
Thomas Arnhold
8bb2ce61c0 fixincludeguards.sh: some smaller dirs 
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
 2014-04-19 11:10:13 +02:00
Tor Lillqvist
1e0fae45a6 Bin empty @seealso, @param, @return and @onerror metacomments 
Change-Id: I6517028670a953954b31599fa3e23f4c8ee8cfc9
 2014-04-06 20:00:28 +03:00
Tor Lillqvist
fdecbd4a41 Kill superfluous spacing before semicolons 
Change-Id: I2c5c2c2e8c57796d147141748fb57a4c5645a96a
 2014-04-06 20:00:28 +03:00