9bac4d413e
typo: more then -> more than
...
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
e5b0aa9a7c
basic: -Werror=sign-compare
...
Change-Id: I7c776faa74a61b0d263c3b446972da9461b3d4f6
2014-07-29 18:06:06 +02:00
ae7ca8b957
fdo#46037: remove unused comphelper/configurationhelper.hxx
...
Change-Id: I66f9d2912202ba1393d0c65189f8a945bca4fcaa
Reviewed-on: https://gerrit.libreoffice.org/10603
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-07-29 15:40:41 +00:00
c694837aea
convert linked list to std::vector in SbxDimArray
...
Change-Id: I2640cfe1f9606d992f622b99ff3c607555771e23
Reviewed-on: https://gerrit.libreoffice.org/10298
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-07-29 15:38:56 +00:00
1392a88c25
fdo#52076 remove empty library instead of writing it out empty
...
Change-Id: Id4fd8c4f34e8ed07044eb428049731c4b9b694ca
Reviewed-on: https://gerrit.libreoffice.org/10507
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu >
Tested-by: Lionel Elie Mamane <lionel@mamane.lu >
2014-07-24 15:34:09 +00:00
ea5ef0a72e
Drop unused #includes
...
Change-Id: I77ca957204bacee95e32a7f2a54c9311002aeef9
2014-07-24 01:06:15 +09:00
50725318e4
Drop an unused function
...
Change-Id: I59eb46f9d57e9fd72ed86c972685be93d154e3c7
2014-07-18 23:24:58 +09:00
fffc9b2f26
fdo#75757: remove inheritance to std::vector
...
... which was introduced at 2110397670695991b3a5cd28a15ba0ffd2a3a611.
Change-Id: If0f634b29e1891574267edf8cc07b24d07a9406c
Reviewed-on: https://gerrit.libreoffice.org/10363
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2014-07-17 21:29:50 +00:00
6a873638fa
Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xx
...
- Remove includes from files where they are not needed.
- Update pch files
Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-07-17 08:47:58 +00:00
d97b5e420f
Avoid possible memory leaks in case of exceptions
...
Change-Id: Icecc2cce52d7f27c030270639e6b85877e3aa620
2014-07-16 18:01:39 +09:00
dac4ca5f68
new loplugin: externalandnotdefined
...
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.
Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
eb9b890bc9
DBG_ASSERT->assert when followed by dereference
...
Change-Id: I9390228721df1b713d8cf2e719854b74d6b639c8
2014-07-06 21:06:06 +01:00
c80be30203
coverity#706241 Uncaught exception
...
we've already checked to see if the element exists, so
we know that its not there.
Change-Id: I538c0d48a883d478e4c748d222b21958d083c049
2014-07-03 08:29:41 +01:00
b35f3dfb1a
coverity#706240 Uncaught exception
...
Change-Id: Ie31f5e1ff74ff8b9f35d7ce08e1f02a780375890
2014-07-01 16:43:05 +01:00
42fcd888ae
coverity#735397 dead code
...
Change-Id: If8d82a39af7a506f42b6c13d8408ffc479b564e7
2014-07-01 12:44:06 +02:00
5ace3f3b4f
clang scan-build: various warnings
...
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
e48a233960
loplugin:unreffun: also warn about redundant redeclarations
...
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-27 15:27:39 +02:00
daa6898578
clang: Dead initialization
...
Change-Id: Ieae5303e55f21044ef8e91e63c4896696cfad51c
2014-06-26 16:29:15 +01:00
a7fcb3ed07
clang: Returning null reference
...
Change-Id: I2cfc14e73696a027283dfa5eef98f784505dc5a3
2014-06-26 16:29:13 +01:00
2daceb87b9
clang: Uninitialized argument value
...
Change-Id: Id65c5815185cf022171e3523c6ad92545830104c
2014-06-26 16:29:13 +01:00
ec1636fa09
Remove this weird inheritance from smart-pointer-wrapped class.
...
SbxVarEntry is now its own class.
Change-Id: I5c5ce1990fa83930acced1d507f5b0de60bf221e
2014-06-25 15:03:46 -04:00
e14abb13dc
Use boost::optional to store alias name.
...
Change-Id: I809b21ea156061a265c0d83d58534df10bc273bc
2014-06-25 15:03:46 -04:00
ff0ecb2621
pData -> mpVarEntries.
...
pData is a nightmare with grepping as it's too generic of a name.
Change-Id: I01b3f1b503f21ee13c97733fa66804874a2cddc4
2014-06-25 15:03:46 -04:00
bb6d9b0123
Remove this class that only derives from std::vector and not much else.
...
Change-Id: Ibc584f4148cec49a9ac34a240cc2fa3e87daf443
2014-06-25 15:03:46 -04:00
533c6cb6ba
fixes for up-casting to Reference<XInterface>
...
Fix regressions introduced with
6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking
Reference constructor to reduce code noise"
Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-06-25 17:10:43 +02:00
f870059a5a
basic: silence expected SAL_WARN output
...
These were HACK() and DbgOut() messages previously, none of these ended
up on stderr. It seems that they are more or less harmless, so as long
as nobody fixes them, silence them, so more useful warnings are not
hidden when one does e.g. xray on a drawinglayer shape.
Change-Id: I7343d93d2916d9978852418aca725d027eb09128
2014-06-19 11:29:31 +02:00
136a2bc384
coverity#1210096 Uncaught exception
...
Change-Id: I1d06c7a6a61556c2b501a16c224ccc6fe52307d0
2014-06-17 10:58:01 +01:00
66f98136fd
coverity#1210098 Uncaught exception
...
Change-Id: I531891fa1cce10a331dd651ee9ce52d1f8d0c169
2014-06-17 10:58:01 +01:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
f8ef1fe95b
loplugin:staticcall
...
Change-Id: I6cd46964c523c9393e9d249fdb43aaa38679fa06
2014-06-13 17:54:23 +02:00
2278e8f80e
coverity#1213486 Uncaught exception
...
Change-Id: Ia4d919d88bf22168aa770ad35fd8360b0b155efe
2014-06-13 09:50:53 +01:00
9284a63add
iprevent violation of exception spec
...
Change-Id: I1f638ae3a2e88e0cadaab0046ef087fe77e16b06
2014-06-10 15:58:24 +02:00
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
dd8f095940
WaE: warning C4101: 'ex' : unreferenced local variable
...
Change-Id: Ib8b71b50fe52a7cc4e261626549ac3e067851797
2014-06-04 08:30:26 +02:00
3038794d2e
basic: typo
...
Change-Id: I10c9e480a94a966dac4f6c17fc69fa8892c56955
2014-06-02 12:04:31 +02:00
6b4c596b01
Fix memory leak for BASIC sub (as well as void function)
...
d88593af59d9126cdbcd6c0a5b06fb9c673dc6f9 "INTEGRATION: CWS ab34: #i73457#
Prevent sub from beeing set as param 0 for return type void" to fix i#73457
"Memory Leak in all Basic type void Method calls" had made the PutDirect call
dependent on != SbxVOID only (which would cover void functions) but not also on
!= SbxEMPTY (which would apparently be required to also cover subs, as seen with
CppunitTest_basic_vba run under lsan). Either this was an oversight with the
original fix, or subs have meanwhile changed from GetType() == SbxVOID to
SbxEMPTY?
Change-Id: I3e5dbf79bfd5eea3cfec8ed3fa984d13167aa501
2014-06-02 11:12:11 +02:00
6a53ea218c
Avoid possible memory leaks in case of exceptions
...
Change-Id: Iad3de981a1c9660b1322315640e531c9891db0bf
2014-05-31 00:35:27 +09:00
a916b6ff7f
Detach all DocBasicItem objects upon process termination.
...
To prevent rogue DocBasicItem objects (which are global objects) from
attempting to stop listening after the main app is dead.
Change-Id: I68a667137ca4e0eff18278f4d2d5dd67466eaf34
2014-05-29 21:59:48 -04:00
5a827671d1
Avoid static local of a singleton. This crashed writer unit tests.
...
Change-Id: I7c5f2d372676cdb317a8dad636bf1aab7dd5db37
2014-05-29 21:59:42 -04:00
a71ae24a23
Avoid possible memory leaks in case of exceptions
...
Change-Id: Iac63a5d60478e5cd8e2b77c889c7b312d3d15f67
2014-05-29 09:29:15 +09:00
3d046b753d
coverity#706235 Uncaught exception
...
Change-Id: I06321ca2b686207a1d9bd698461aedf84daf31e1
2014-05-28 13:49:50 +01:00
9986fe77f4
coverity#706234 Uncaught exception
...
Change-Id: I7542008369ed3433cd8bfce7702f036148195516
2014-05-28 13:49:50 +01:00
cf16d4eb9d
coverity#706232 Uncaught exception
...
Change-Id: I07e13af4f4578d5d6823b6d10aa9c37d04ecc395
2014-05-28 13:49:49 +01:00
1b48561586
coverity#706231 Uncaught exception
...
Change-Id: I1f1acb91a97ff7c9fb50ad36eca7b91d361a1276
2014-05-28 13:49:49 +01:00
145b64c4eb
Avoid undefined signed integer overflow
...
Change-Id: I3f32ea88dbb34a05baccba49c15b6691d923753e
2014-05-28 14:34:13 +02:00
a77a7f6083
Fix memory leak
...
...by using css::uno::Type instead of a naked typelib_TypeDescription.
Change-Id: I387692265e9e032cb5ed6519739ebb3307db6f28
2014-05-28 14:34:12 +02:00
b8a329989c
Fix memory leak (missing typelib_TypeDescription_release)
...
...by radically simplifying TypeToIdlClass(). It is unclear to me why this was
so complicated. The only mildly plausible reaons would be that the old code
was careful to return null instead of throwing an exception for an unknown type,
but the TypeToIdlClass-call-sites either strongly expect a non-null return value
(by dereferencing it without any further checking) or use OSL_ASSERT or similar
to verify it. So lets hope this is good.
Change-Id: I3e24eb6117e84c9d33f4c5f0e2fa88da4c4f2c30
2014-05-28 14:34:12 +02:00
ea491d056d
OSL_TRACE -> SAL_INFO
...
Change-Id: Ib9e1ed6119b5286871ac10136f7fcbefffe7aebe
2014-05-27 12:34:30 +02:00
0f2824b117
remove more unnecessary use of OUString constructor
...
Change-Id: Iae14cb3df65295b6894fd9e05411c5698e9c8aba
2014-05-27 08:20:12 +02:00
e7bc3cab01
remove boilerplate in UNO Exception constructor calls
...
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.
Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
