wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
339,899 Commits 5 Branches 0 Tags
5b03bc8a4d92fee2fdfdca4917b321985feb930a
Commit Graph

1267 Commits

Author SHA1 Message Date
Lionel Elie Mamane
56cdaa1869 fdo#72163 belts and suspenders 
1) Do not dispose m_xComposer, might still be used by our m_pCache

2) Do not create a new m_xComposer if the previous one will do, so
   that we do not gratiously use a different one than our m_pCache.

Change-Id: I6540c035c9159017c694b36e676721ec3e42db51
 2013-12-02 23:57:16 +01:00
Lionel Elie Mamane
d4b7e3d12a fdo#72163 after updating m_xComposer, command facets are not dirty anymore 
Else we dispose m_xComposer too eagerly; still used by m_pCacheSet.

Change-Id: I205488465c19a356534df17b8a5e9a20ce6766c9
 2013-12-02 23:57:15 +01:00
Noel Grandin
071c3f3e93 remove unnecessary use of OUString constructor in equalsIgnoreAsciiCase 
Convert code like:
    sType.equalsIgnoreAsciiCase(OUString("VIEW"));
to:
    sType.equalsIgnoreAsciiCase("VIEW");

Change-Id: I6fb47e6a83b561c7e5a25da76b63606a3174858d
 2013-11-22 08:07:18 +02:00
Noel Grandin
363cc39717 convert equalsAsciiL calls to startWith calls where possible 
Simplify code like:
    aStr.equalsAsciiL( "%", 1 )
to
    aStr.startsWith( "%" )

Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
 2013-11-19 12:49:29 +02:00
Noel Grandin
3ef88d370e remove unnecessary use of OUString constructor in DBACCESS module 
Change-Id: I831a6506211be30c5b743c20724904c903c5b3c0
 2013-11-11 11:21:24 +02:00
Thomas Arnhold
fed3c2bf20 dbaccess: cleanup 
* remove an external guard
* fix some include guards

Change-Id: I4e5b5fc5c50acfd81321377e7956e33c838edeba
 2013-11-05 09:28:54 +01:00
Thomas Arnhold
bfbe8c0b5b fixincludeguards.sh: dbaccess 
Change-Id: Iadd4326d58a5df5761a0ed5ce7fd5fb01fb87d11
 2013-11-05 09:28:52 +01:00
Noel Grandin
5285beeaa4 remove redundant calls to OUString constructor in if expression 
Convert code like:
  if( aStr == OUString("xxxx") )
to this:
  if( aStr == "xxxx" )

Change-Id: I8d201f048477731eff590fb988259ef0935c080c
 2013-11-04 10:11:08 +02:00
Caolán McNamara
45e366eadb drop unnecessary tools/string includes 
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
 2013-10-20 19:00:36 +01:00
Lionel Elie Mamane
d9eac2ceb8 make sure value passed to updateBoolean is treated as a boolean 
Change-Id: I69549fd8ab95cf92ccb06fd9aed1b9dba2935d7d
 2013-10-16 18:45:21 +02:00
Lionel Elie Mamane
1883d4f10f when reading a bool from a database, treat is as a bool 
This in particular allows recognition of strings "true" and "false".

Change-Id: I590a5357206e4fb0b92b78b8ee4655e445e6f152
 2013-10-16 18:45:19 +02:00
Lionel Elie Mamane
a102d822c9 janitorial: more const, comments 
Change-Id: I5366840ab67fdf89575e890a0d97602b8e78f71a
 2013-10-02 19:02:33 +02:00
Stephan Bergmann
34063e35f7 -Werror,-Wunused-variable 
Change-Id: I805b898faaae631d047ec82e7139c6d6ccaea3b1
 2013-10-02 18:40:14 +02:00
Stephan Bergmann
0ff379fa1c -Werror,-Wunused-variable 
Change-Id: I0d587538c3bee7ad71acb2272c7f85f5f7454158
 2013-10-02 18:40:14 +02:00
Jelle van der Waa
2ec606730b fdo#62475 removed pointless comments 
Conflicts:
	dbaccess/source/filter/xml/xmlfilter.cxx
	dbaccess/source/ui/dlg/ConnectionPage.cxx
	dbaccess/source/ui/dlg/detailpages.cxx
	dbaccess/source/ui/dlg/odbcconfig.cxx
	dbaccess/source/ui/querydesign/querycontroller.cxx

Change-Id: I3a05649efa3a43dd8d8fb069fc1bce14ca0a6338
Reviewed-on: https://gerrit.libreoffice.org/5484
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
 2013-08-27 16:11:09 +00:00
Luboš Luňák
64b993e046 finish deprecation of O(U)String::valueOf() 
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
 2013-08-21 15:10:35 +02:00
Stephan Bergmann
67876ed105 SAL_INFO output contains the current thread ID anyway 
Change-Id: Ie51865e57a33e31c2aa115b68eed0fc0a1972c40
 2013-08-21 11:42:13 +02:00
Michael Meeks
1c7af455ab Re-work 8bit characters in source code, or remove them. 
Change-Id: I93e14d4936c0ffbe03425d4a54bb0e09bc62b3e3
Reviewed-on: https://gerrit.libreoffice.org/5550
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@suse.com>
Tested-by: Michael Meeks <michael.meeks@suse.com>
 2013-08-20 19:30:59 +00:00
Stephan Bergmann
c9db5e6f08 Do not use this ptr in ctor 
...offload to init() instead and wrap ctor in create().  That removes the need
for refcount fiddling and additional OContainerListener class.  Which in turn
removes code using dynamic_cast on UNO interface classes, which my claim at
<http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20130812/
086127.html> "ubsan: check type_info equality via strcmp" that "there should not
be uses of dynamic_cast involving [UNO] classes in the LibreOffice code base"
made me wonder about...

Change-Id: I5d72650f6bf081f971f7bd6bb65f4e58a342f791
 2013-08-16 15:02:30 +02:00
Lionel Elie Mamane
76b5ac2193 doing it once is sufficient 
Change-Id: If31845aa575b3f9459507deefb1b469ac3715e35
 2013-08-14 17:39:58 +02:00
Michael Stahl
91f3d77b98 tweak comment translations 
ede5f05c fb3a1bb9 5e04331f fd6089b9 66a1d406

Change-Id: I5077ce5f6182f9193cebaaf63190450d375679dd
 2013-08-08 23:25:25 +02:00
Lionel Elie Mamane
3d5a27bf5a for later... 
Change-Id: I266d2992bcd212a6539e4b50c9daf2c53ff98904
 2013-08-02 13:57:51 +02:00
Lionel Elie Mamane
a8f327a9fc make comment actually describe the code 
Change-Id: If4dda13ff8018d7fd855457a76db2acf8077a477
 2013-08-02 13:57:49 +02:00
Lionel Elie Mamane
0fafb92e97 janitorial: more const where possible 
Change-Id: If579b2b2990c3cdd4785077aa1b34c33bcc241b6
 2013-08-02 13:57:48 +02:00
Lionel Elie Mamane
6fc71eea1d SingleSelectQueryComposer: the name of a non-SELECT column is its "real" name 
That is, the name in the table.

Change-Id: I95326915f381ec0cf72c66f13352ce76d82e9517
 2013-08-02 13:57:47 +02:00
Andres Gomez
bcd5f5ebd4 fb-sdbc: Added temporal debugging in dbaccess 2013-07-16 16:40:07 +02:00
Javier Fernandez
d6855a708c Debug info and some API methods implementation. 
* getTypeInfo
  * getTables
  * prepared statements.

Change-Id: I549f4a9468b5346e22479363fe0fb81039bc6665
 2013-07-16 16:40:04 +02:00
Lionel Elie Mamane
b93b9e6d42 microoptimisation 
Change-Id: I977fbd8387b069574d9818923ada54392d39347a
 2013-07-11 17:53:32 +02:00
Lionel Elie Mamane
40370f759c ORDER BY columns are prioritarily *SELECT* columns 
as opposed to *table* columns,
and notwithstanding HSQLDB 1.8 (our embedded database) bugs.
Actually, supporting ORDER BY on non-select (but table) columns is OPTIONAL for DBMSs
(but quite common)

Change-Id: I6725dfda36b09429a78262bff6f3d3e3dd9032b6
 2013-07-11 17:53:30 +02:00
Lionel Elie Mamane
7f3bef3d14 don't use empty table name 
Change-Id: I9c8c3882f659747d53a047481ccabf1785835c99
 2013-07-10 03:15:13 +02:00
Julien Nabet
8dc5b9d6a2 unusedeasy remove ORowSet_CreateInstance 
Change-Id: I17e9eb168c664514dacc03d66911f72faf80e117
 2013-07-04 17:12:18 +02:00
Radu Ioan
61db96daa8 fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO 
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*

Change-Id: I26761cf1d4c1cfe21dec7d8ede6df6f177bf2c3e
Reviewed-on: https://gerrit.libreoffice.org/4620
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
 2013-07-03 07:59:33 +00:00
Lionel Elie Mamane
369e2d3e00 fdo#66464 initialise static join info at construct time 
to ensure that isReadOnly returns something sensible as soon as construct() finishes

Change-Id: I5f9bef049297c5232df0ecdb9084add968a0052f
 2013-07-02 00:57:50 +02:00
Thomas Arnhold
ba0a57702c remove OUString wrap for string literals 
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-06-29 21:52:54 +00:00
Jelle van der Waa
9a95669e50 fdo#43460 dbaccess: use isEmpty() 
Change-Id: Ie27a81f4e59c48ef5aa03fb82ab38e920c0646a1
Reviewed-on: https://gerrit.libreoffice.org/4321
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
 2013-06-17 19:45:38 +00:00
Julien Nabet
e6edfb6324 cppcheck: unread variable 
Change-Id: I809cdbeb71bf4cf014e6d578f35c8a646a5c937e
 2013-06-06 23:53:52 +02:00
Noel Grandin
95c0d568fd use uno::Reference#clear() method... 
...instead of assigning an empty value. Reduces code noise.

Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
 2013-06-05 08:13:23 +02:00
Lionel Elie Mamane
cd2f2e772c make OSingleSelectQueryComposer use *system* parse context 
and pass it to the parser and PredicateInput constructors.
This makes the whole story consistent; before system locale settings were already manually passed to parseNodeToPredicateStr, which led to some things being parsed as en_US and others as system locale.

Change-Id: Ib9571b10d79183571e8ab3f79660b41594dc2d1c
 2013-05-19 14:05:18 +02:00
Miklos Vajna
e894e57aab dbaccess: {DECLARE,IMPLEMENT}_CONSTASCII_USTRING are no longer needed 
Change-Id: Id404f8f3a5bdbf32c207ee81c6f6be9c9d328679
 2013-04-25 11:02:34 +02:00
Tor Lillqvist
0987f56912 WaE: unused variable 'insert_result' 
Change-Id: I5b0b7eeaa44e3e9e215b8d0bba7e7189c63c766c
 2013-04-09 01:49:04 +03:00
Luboš Luňák
ba044b1e96 remove needless forward rtl::OUString declarations 
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
 2013-04-07 14:23:12 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00
Noel Grandin
a789a2fc94 fdo#46808, convert sdb::QueryDesigner to new style 
Change-Id: I694dd16920304d0f07369e97c87a4a97b92eadeb
 2013-04-02 12:54:41 +02:00
Thomas Arnhold
2b7ee1db28 remove boilerplate comments 
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
 2013-04-01 22:45:36 +02:00
Noel Grandin
a066525b42 fdo#46808, Convert a bunch of comphelper::ComponentContext stuff 
.. to Reference<XComponentContext>
mostly in the dbaccess module, but it also affected some other
modules.

Change-Id: I09b3f6fe7a9b33498b11d98b5521b5aeeb8882be
 2013-03-20 07:32:53 +02:00
Thomas Arnhold
6dddefc6e7 fdo#43460: use isEmpty() 
Change-Id: Ia768e684d3cf255239c04d024b35488830cc9fe6
 2013-03-09 21:47:31 +01:00
Stephan Bergmann
3912e47044 Work around -Werror=unused-local-typedefs from comphelper/stl_types.hxx 
Change-Id: Id9f588e551b40a64bc86cae7c6d50f99659f94ab
 2013-03-09 13:03:06 +01:00
Thomas Arnhold
8035a3af26 some further OUString cleanup 
Change-Id: I13eb94092e29ececc9fbf494074acde5f893b605
 2013-03-08 04:51:28 +01:00
Thomas Arnhold
f5ca04caca Related to fdo#60724: correct spelling 
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
 2013-03-03 17:14:16 +01:00
Gregg King
db7a441342 Typo fix: informations -> information and a few other adjacent typos. 
FDO:60724

Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2013-03-02 02:45:55 +00:00