Commit Graph

1368 Commits

Author SHA1 Message Date
73342dbb82 remove unnecessary RTL_CONSTASCII_STRINGPARAM
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.

Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
2013-11-22 08:07:19 +02:00
f01580ce9c Windows: Require at least Windows XP SP2
* Windows XP SP2 is 0x0502, see
  http://msdn.microsoft.com/en-us/library/aa383745.aspx
* If a module changes the Windows SDK version setting,
  this is done module wide now. So the overall behavior
  is as before. This seems to be the best compromise for
  now.
* We need at least SP2 because of the bluetooth stuff
  used in sd/source/ui/remotecontrol.
* Now, we require at least Internet Explorer 7.0. IE6
  has been outdated for a long time.
* Leave StdAfx.h file definitions, as those are Microsoft
  project specific precompiled header files.
* All local definitions of WINVER are removed, because
  the global WINVER setting makes them obsolete now.

To the relation of the three macros:

Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION
automatically to the same value as _WIN32_WINNT.

WINVER and NTDDI_VERSION can be set idenpendently each
for itself.

Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb
Reviewed-on: https://gerrit.libreoffice.org/6496
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2013-11-20 07:15:16 -06:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
6b1aff89ed -Werror,-Wunused-member-function
Change-Id: I5c14c2c305aa6809b4a1e164b8bdc4eeb877abbd
2013-11-14 10:14:58 +01:00
89b1a0419f -Werror,-Wunused-exception-parameter
Change-Id: Ia5b7f7629a07b84b4e8042aa7f8778faa4a11b50
2013-11-14 10:14:58 +01:00
0a9ef5a18e convert OUString 0==compareToAscii to equalsAscii
Convert code like:
   0 == aStr.compareToAscii("XXX")
to
   aStr.equalsAscii("XXX")
which is both clearer and faster.

Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11 12:58:12 +02:00
da20c7f439 remove unnecessary use of OUString constructor in SHELL module
Change-Id: Ibdb750dc8e0f4cd0f186d5801c0a269edd939547
2013-11-08 14:50:59 +02:00
bcb51cff22 fdo#63020: Replace ::comphelper::stl_begin()...
And use some templates inside include/com/sun/star/uno/Sequence.hxx

Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47
Reviewed-on: https://gerrit.libreoffice.org/6599
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-07 10:43:34 -06:00
9bd00edca5 include <stack>
Change-Id: Iedaacd9981a6ca186ab5e1f9715ed4fcf4ff0cb7
2013-11-06 17:45:04 +09:00
9c2ab71230 Drop unnecessary #includes
Change-Id: I9659279233067a8946a9e54be2f22439854a961e
2013-11-06 17:08:58 +09:00
5811602287 windows: remove _CRTIMP and _NTSDK definitions
Those have no effects with current windows SDKs.

Change-Id: I6fb2f8045fe1fc0ed4beef51dde487b7a7dfdc28
2013-11-05 09:28:55 +01:00
48dd3571f8 fixincludeguards.sh: shell
Change-Id: I987c54b15c271fc80b7efd25933e13950f974423
2013-11-05 09:28:53 +01:00
a71a562a99 fdo 70998: Termchange: Graphics->Image
Change-Id: If451dfb24567157c86bca9a4a8564eb8de231a38
Reviewed-on: https://gerrit.libreoffice.org/6524
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-04 07:49:45 -06:00
326f3e40ba shell: mapix.h is not needed at all
Change-Id: I1a55a4c260b781f7427bf149d32f1cae6149fe9a
2013-10-31 21:07:02 +01:00
32a4efb8c5 gbuild: stop using stuff in OUTDIR/unittest/install
Change-Id: Icdfe1282d5e636a034ee7d1b16b9a113a9b70492
2013-10-29 00:58:42 +01:00
8df17a3409 gbuild: set Package default target to INSTDIR
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
2013-10-28 20:17:26 +01:00
a346904323 shell: just define _WIN32_IE and drop the undef
Because the compiler warns either way.

cl : Command line warning D9025 : overriding ´/D_WIN32_IE=0x0500´ with
´/U_WIN32_IE´

After this change the message what's overwritten gets more
clear to the reader.

Change-Id: I773e7499537aff879f857b9b50ec8afc4005130b
2013-10-28 15:16:20 +01:00
704f95e525 fdo#54938: More uses of cppu::supportsService
Change-Id: I90a7a07a43559b8d7e1d4b886b2624255200d46b
Reviewed-on: https://gerrit.libreoffice.org/6406
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-25 08:19:58 +00:00
fcdde111e4 fdo#69462 Properly escape URL in Mozilla -remote openURL(...) command
Verbatim ")" or "," in the URL will apparently cause problems when Mozilla-
derived browsers parse the openURL(...) command (see
<http://www-archive.mozilla.org/unix/remote.html> "remote control of unix
mozilla"), so percent-escape all "(", ")", and "," in the URL.  Also, remove the
space before "new-window" as "Commands should /not/ have spaces in them" (see
link above).

Change-Id: I4b0f3f6a19c94ed9346bb6c55e77d6eae82baba2
2013-10-17 10:23:33 +02:00
7ff0a2e41c Quoting clean-up
cosmetics only; even the unquoted echo $1 would not have caused any problems

Change-Id: Iabae872fe6232dc1cd627b736f0c4fc5a8611037
2013-10-17 10:23:33 +02:00
288d1a3ff4 Remove unused run_browser()
...unused right from the start in 3d5468a8590ff9b36ac16845782af118d07b7786
"INTEGRATION: CWS defaultbrowser: #i27120# new unix shell execute service
implementation."

Change-Id: I18ae3c4c372163787e9bd4f8c946e15128a9deeb
2013-10-17 10:23:33 +02:00
d67cd21033 fdo#56007 - Read more bytes on Zip read (for thumbnails)
Change-Id: Ia8c6caa44ed8019a8139beb5a855f0f28805544d
2013-10-14 22:23:05 +01:00
6efa9d1d23 cppcheck: reduce scope
Change-Id: Ie33ae5c3bd1213bc4032e66d0cd7a3faefc7dfcb
2013-10-11 23:33:00 +02:00
53138c9968 fdo#56007 - fast zip directory find to accelerate Windows Explorer thumbnail.
Change-Id: Id9436def56f40d2bb54dea35bea916bd99964653
2013-10-11 17:44:42 +01:00
6cea76189f fdo#67534: try to avoid file locking in Explorer shell extensions
Change-Id: I287395f6c25b1bfb9b9482166ae6f34d9af8f455
2013-10-04 21:34:33 +02:00
7f436c1fd3 typo fixes in comments
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
7a8db272e9 Start hacking --enable-canonical-installation-tree-structure back into shape
Had been totaly broken by the recent changes. (Which is fine, it is
just an experimental hack anyway, I am not sure whether it will ever
be used in anger. Just a pet peeve of mine, I dislike seeing
libraries, configuration files, resources etc mixed together in one
"program" folder, especially on OS X, where the convention is to have
app-specific dylibs and frameworks in "Frameworks", and resource files
in "Resources". But this is not any requirement as such; there are
apps in the Mac App Store that blatantly "break" this convention.)

Basically, replace uses of gb_PROGRAMDIRNAME and
gb_Package_PROGRAMDIRNAME with more specific LIBO_FOO_FOLDER, which
for normal builds all expand to the same "program" anyway.

Change-Id: I16c2b3351caa00e251e229aafbccb8346042d3c1
2013-09-25 22:13:23 +02:00
4c63fd10a5 Try to fix cross-compilation
Add more FOO_FOR_BUILD variables and some gb_Foo_for_build functions.

Get rid of gb_INSTROOT and gb_DEVINSTALLROOT, just use INSTROOT.

Change-Id: Iee531b02d14fae41edb68ad589a5dec829a60255
2013-09-23 00:54:43 +03:00
19d7fd2c41 Sprinkle more boost_headers love
Fix compilation errors when not using system boost. Might be more.

It's sad that one has to micro-manage boost use like this.

Change-Id: I3541789530fbdb0fb03e2b355144e63f8b031097
2013-09-19 11:12:46 +03:00
5397b49f4d Towards a working instdir for Mac OS X
Introduced gb_INSTROOT, which is the same as $(INSTDIR) except for Mac OS X,
where it is $(INSTDIR)/LibreOffice.app/Contents.  Most stuff ends up there (so
most occurrences of $(INSTDIR) have been replaced with $(gb_INSTROOT)), but SDK-
related stuff goes to $(INSTDIR)/$(gb_Package_SDKDIRNAME).  (And
GeneratedPackage needed to be made more flexible, to allow for packages that go
into either of those two places.)

For Android and iOS, gb_INSTROOT probably still needs to be set.

The most obvious missing thing yet to make instdir work for Mac OS X is the
instdir/*/LibreOffice.app/Contents/ure/ vs.
instdir/*/LibreOffice.app/Contents/ure-link/ split.

Change-Id: I4478edd27b14c92c96d92d5169bdca3ec50d78f5
2013-09-11 00:50:54 +02:00
81510ee8a5 ENABLE_LOCKDOWN Harmonize ENABLE_* variable to TRUE/<nothing>
Change-Id: I47b2d7a59bbf1f5a96523d451c8b6f4fa12c8e90
2013-08-30 23:12:19 -05:00
7113e2310b eliminated yet another language-country parser
Change-Id: I2aebe058a6d60431b7073aca641910dc365ead09
2013-08-30 14:42:39 +02:00
40ff64b93f and another one for fdo#68740
Change-Id: If07cffd30fe5fdfbe8fcb749b7682d1b8a3dcbb8
2013-08-30 13:54:48 +02:00
9f1d47f824 attempt to roughly fix fdo#68740
Actually that map wants a resolved fallback locale, not just a language
to ID mapping, which light fallback was a side effect of
MsLangId::convertIsoNamesToLanguage() and eliminated with the latest
changes to LanguageTag conversion.

Change-Id: I32f632c6b198383dd3eda8538ccb801c9275baca
2013-08-30 13:30:00 +02:00
ee149fdbcb valueOf is deprecated
Change-Id: I89b06a077eaceee7d06c7372dd596840e979e697
2013-08-21 16:42:05 +02:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
c6a7300974 Use subfolder names from <config_folders.h>
Change all instances of hardcoded "program", "share" etc subfolder names to
use those from <config_folders.h> instead. In normal builds, the end result
will not change.

Change-Id: I91c95cd8e482818be67307e889ae6df887763f53
2013-08-18 21:11:16 +03:00
4f4bed9b46 Test also the IStream part
Change-Id: If36de8daffb547b07d1417863ccc1a7904b379a5
2013-07-18 14:01:05 +02:00
2adf469b42 Try to make the ziptest a bit more generic
Change-Id: I2a380ebcc2b32fbb8e1c0ae6b83b5f34291e5d1d
2013-07-18 12:27:33 +02:00
cfda5af070 Trying to resurect the zip test
Change-Id: Ic022f25a4f8d69b8d60bea7974900db5223e1251
2013-07-18 12:27:33 +02:00
69f0c2cfd6 remove last users of gb_Executable_add_noexception_object
Change-Id: Iddee238aa800ecfee8f97a7132b38b6446e0b2a4
Reviewed-on: https://gerrit.libreoffice.org/4953
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2013-07-17 12:18:47 +00:00
2a4c55f6d4 bnc#829017 fix issue with negative seeks in win32 shell extension
Change-Id: Ia8072f78ad43281e406377922f50f8de53194f1b
2013-07-16 17:14:23 +02:00
85c7e212a2 gbuild: consolidate ULF copypaste in gb_CustomTarget_ulfex_rule
Change-Id: I0c5b68f6bc81c7c1c88be2cde42fc06949fff8e7
2013-07-16 16:54:59 +02:00
cea7cca5c8 remove obsolete CDE integration, and make TDE launcher conditional.
Change-Id: I5e830cd3f44627d789d789748e1b0f0ff5590d91
2013-07-01 15:39:24 +01:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
34f50399f1 fdo#43460 shell,vcl,xmlreader: use isEmpty()
Change-Id: Ie3d16da6c246b79c4c304b21476f84b2788f0d6e
Reviewed-on: https://gerrit.libreoffice.org/4444
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-24 09:00:20 +00:00
a47a153a7f Resolves: #i93995# Allow setting Body of a simple mail message
(cherry picked from commit 093977b1171fae4eaef13a6d32929451fc64ae66)

Conflicts:
	offapi/com/sun/star/system/makefile.mk
	shell/source/cmdmail/cmdmailmsg.cxx
	shell/source/cmdmail/cmdmailmsg.hxx
	shell/source/win32/simplemail/smplmailclient.cxx
	shell/source/win32/simplemail/smplmailclient.hxx
	shell/source/win32/simplemail/smplmailmsg.hxx
	shell/source/win32/simplemail/smplmailsuppl.hxx

Change-Id: Ief1aefee32a6750dfed96476d2968ce76b038440
2013-06-07 13:40:25 +01:00
95c0d568fd use uno::Reference#clear() method...
...instead of assigning an empty value. Reduces code noise.

Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-06-05 08:13:23 +02:00
717c9643bd More gb_PROGRAMDIRNAME clean up
Change-Id: I5af86e15bcb8958a680e7309f13d7a865f29d7a9
2013-05-10 14:06:47 +02:00
3c38b7727a zlib: remove ExternalPackage_zlib
Change-Id: I5bce88b2044279a6563fd68c35f9c1ac824c8850
2013-05-08 23:34:26 +02:00