610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
2c35fff7ec
remove most use of RTL_CONSTASCII_USTRINGPARAM macro
...
This is largely unnecessary when working with OUString
Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
ab5d1fbfb4
SAL_WARN_UNUSED com::sun: ⭐ :uno::Any
...
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14 21:02:40 +01:00
04dead1c6b
make l10n buildable separately
...
- this renames the 'almost' module target to non-l10n
- and adds a l10n target which is intended to only build l10n parts of
the product
- packagers should then be able to build l10n and non-l10n parts of the
product independently, thus:
- enable quicker rebuilds
- distribution of load
- updates to l10n without a full rebuild
- security fixes to binaries without rebuilding all l10n
- the new targets are called build-l10n-only and build-non-l10n-only
- note this is not intended to move a concept of split packages
upstream -- while this exsists in distros, the number of test
scenarios for this would explode upstream
Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863
Conflicts:
filter/Module_filter.mk
2013-11-14 16:45:02 +01:00
fcd1637d51
convert OUString compareToAscii == 0 to equalsAscii
...
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11 12:58:13 +02:00
16b91e13c7
Converge on SvtSecurityOptions::isTrustedLocation
...
Change-Id: Ibcf4b7d9d11295c7679637a37d41dc2960e04f8f
2013-11-09 16:24:56 +01:00
0121f632ef
remove unnecessary use of OUString constructor in XMLSECURITY module
...
Change-Id: I95b0eda83c60456f3db267183030fe5f6cd70bc4
2013-11-07 11:28:38 +02:00
5285beeaa4
remove redundant calls to OUString constructor in if expression
...
Convert code like:
if( aStr == OUString("xxxx") )
to this:
if( aStr == "xxxx" )
Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04 10:11:08 +02:00
54a17dd246
windows: warning 4355 is disabled globally in com_MSC_defs.mk
...
So there is no need to do this locally, too.
Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
2013-10-28 01:02:13 +01:00
a7724966ab
Bin comments that claim to say why some header is included
...
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
67aec43915
cleanup
...
Change-Id: I7bfd221f89718ba8634417c93a26b3a199178694
2013-10-16 05:41:26 +02:00
094f00651a
CID#708741 uninitialized members
...
Change-Id: I15475d560e889b0f0fc91d96cfa6ae97e81a41b5
2013-10-03 13:30:13 +01:00
4763c0acbd
-Werror,-Wunused-const-variable
...
Change-Id: Ic8279d6a52691532b987e7947709bdc14064cc3e
2013-10-02 16:49:40 +02:00
cb177b6d79
libxmlsec: stop delivering static and import libraries
...
... and also check COM instead of CROSS_COMPILING.
Change-Id: I049c9211d4b6eabe4012f66d39d86c7b025dc18c
2013-10-01 10:39:56 +02:00
2f6261fa07
find lots of external static libraries in UnpackedTarball dir
...
Note: do NOT put file paths to static libraries into FOO_LIBS variables
that are passed to bundled externals that are built with --enable-static:
on Mac OS X this will result in .a archives that contain other .a
archives as entries, and trying to link those results in errors like:
ld: warning: ignoring file .../libodfgen-0.0.a, file was built for
archive which is not the architecture being linked (i386)
Change-Id: If2c5a458058e4da76f80b3643e55b489d1edee24
2013-09-22 11:08:33 +02:00
6ea6a422fb
s/wiki.services.openoffice.org/wiki.openoffice.org/g
...
Change-Id: I059fbee385a109069c70f3869021c8e2ee48fee1
2013-09-07 14:21:22 +02:00
f1dd6b8d62
WaE: 'BufferNode::notifyAncestor': recursive call has no side effects
...
Interesting function that just traverses a chain of objects using
recursion, but does nothing at all otherwise. Kill it. But at least it
had an Enterprise Ready block comment in front.
Change-Id: If2296d2534cb9451d4ceadaf966b8c70f0a17557
2013-09-04 01:57:54 +03:00
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
b5e5ce956b
fdo#57950: Remove some chained appends in xmlsecurity
...
Change-Id: I35ac622abb995a9259f0774f463ec2816b3668b6
Reviewed-on: https://gerrit.libreoffice.org/5477
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
2013-08-18 13:53:54 +00:00
182bf2a63a
Revert "fdo#57950: Remove some chained appends in xmlsecurity"
...
This reverts commit 4f20c9f6f95c117bcdb520682df4fa1429a56477
Change-Id: I4d8cef801d570b0c20e580144e79a5940b100271
Reviewed-on: https://gerrit.libreoffice.org/5476
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
2013-08-17 15:28:01 +00:00
4f20c9f6f9
fdo#57950: Remove some chained appends in xmlsecurity
...
Change-Id: If70fa38ad4836b6dacdd0c5577c66b78be6826a6
Reviewed-on: https://gerrit.libreoffice.org/5465
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org >
2013-08-17 07:48:21 +00:00
9499df9f8c
Ifdef out code which had been accidentally un-commented-out
...
The code snippet had been commented out since its introduction in
2004. In 1452e5659796db395efa222d50cc8158275c5442 it was accidentally
un-commented-out, but it causes compilation errors. So ifdef it out
instead, with a comment. Note that I have no idea what the code does
and whether it actually is useful to keep for future reference or not.
Change-Id: Ie60ca065b2c65f86a7b382e246c1b650424daa1d
2013-08-12 09:28:57 +03:00
1452e56597
fdo#62475 removed pointless comments
...
Change-Id: I02b264a9661bcefaea96d6c5743352914154427d
Reviewed-on: https://gerrit.libreoffice.org/5345
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2013-08-11 19:37:59 +00:00
ec52a20edb
fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
...
Change-Id: Ie959aa5a6874aae3c60273355a959c344e82699e
Reviewed-on: https://gerrit.libreoffice.org/5083
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-07-24 20:18:36 +00:00
bddd4d4598
Mark as const
...
Change-Id: I2746b92b1360c3c181879a81f653c44ef609f351
2013-07-22 21:03:55 +09:00
52bce8fadd
convert versions of dialog to .ui
...
Change-Id: I1be2211b5c936e6e00f2fe81883b8fb1e67ef550
2013-07-16 12:45:56 +01:00
9eeacd2751
XmlReadOnlyImage is now unused post .ui conversions
...
Change-Id: Ib90966ed6e791371dacd8d9cdf8234fa66b02858
2013-07-02 11:59:52 +01:00
ba0a57702c
remove OUString wrap for string literals
...
For some functions and all kinds of Exceptions.
CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException
createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService
bash command:
for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
| cut -d ':' -f1 | sort -u
| xargs sed -i
-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
-e "s/\($i.*\)\"+ /\1\" + /g";
done
Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-06-29 21:52:54 +00:00
b6d97514cd
reduce some spacing
...
Change-Id: I72d494b1c0ff5ed3c52ae6a078815f497e4dd647
2013-06-29 18:38:14 +02:00
318f2b64cc
remove some createFromAscii usage
...
there are a lot more of them:
git grep 'createFromAscii[^)]*"'
Change-Id: Ibc2e9cae208d8b9c91667bb3b177c6bd6d3a9424
2013-06-29 16:23:23 +02:00
647ad63f9f
Resolves: #i122564# correct typo, save -> safe
...
(cherry picked from commit 1aedcb86f08affb4265539418d4cde377c4de80c)
Change-Id: I6af85ddfafa1fe1577fd43431a08d62e9c2a5a52
2013-06-20 12:15:28 +01:00
b5f3f55ce5
fdo#43460 unoxml,writerfilter,xmlsecurity: use isEmpty()
...
Change-Id: Iba3b39086212803bc41384f5c8f51e42712a5249
Reviewed-on: https://gerrit.libreoffice.org/4349
Reviewed-by: Noel Power <noel.power@suse.com >
Tested-by: Noel Power <noel.power@suse.com >
2013-06-19 10:11:34 +00:00
670e2329df
fdo#46808, Convert xml::crypto services to new style
...
Also remove the unnecessary XInitialization implementations.
Change-Id: I81f32b2cdcf69b84fe4b15382f9294073a7f2f20
2013-06-10 10:20:44 +02:00
9eb4e4dc51
Some more modules at least building with mingw64
...
Change-Id: I3ea039655aecb7885bb310b1f2c29d66f9f7bb4f
2013-06-06 19:49:56 +02:00
287bc2bb76
Drop unused XInitialization from implementation
...
...now that it has been dropped from the service declaration with
75a87d9bc25c9c74810591bbfa560b0f7184e940 "fdo#46808, Convert
xml::crypto::XMLEncryptionTemplate to new style"---appears to be nonsense that
had been in there "since the beginning."
Change-Id: I75826b7eb0a4d5538204394a8f0e9c9e9f1393da
2013-06-05 18:17:35 +02:00
496a2c2e46
Drop unused XInitialization from implementation
...
...now that it has been dropped from the service declaration with
6a12e13870f15df93d2627f1538f7c64ca46e9e5 "fdo#46808, Convert
XMLSignatureTemplate service to new style"---appears to be nonsense that had
been in there "since the beginning."
Change-Id: I4e4d3649f1aa0dacebdc8bdcee0348cee294ab89
2013-06-05 17:29:14 +02:00
d11e59088f
fix superclass-constructor call.
...
Was introduced in commit
a4196fc3cf1e20e32cda9477a33ff56515f0c24e
"fdo#46808, Convert XMultiServiceFactory in xmlsecurity module"
Change-Id: Ie06a3c89e3a8b4cf43e68afd575a0e86b48d6bc2
2013-06-05 15:22:49 +02:00
75a87d9bc2
fdo#46808, Convert xml::crypto::XMLEncryptionTemplate to new style
...
Change-Id: I45bcb3f0f4b9998105d361dbf6a98d8f5310da52
2013-06-05 14:48:20 +02:00
6a12e13870
fdo#46808, Convert XMLSignatureTemplate service to new style
...
Change-Id: I80530f84ad5a86eccc794f9ddd14f939d093a20d
2013-06-05 14:48:20 +02:00
a4196fc3cf
fdo#46808, Convert XMultiServiceFactory in xmlsecurity module
...
Change-Id: Ia134170d07f33c2649b2a2620f40bc7b45ec7e16
2013-06-05 14:48:19 +02:00
dcbaf7c253
remove unused componentcontext.hxx includes
...
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-05 08:13:21 +02:00
05eaada40d
translatable="yes" for some elements in .ui files
...
Change-Id: I915cd6e73f907850f17b102c7860a827b91eef37
2013-05-25 17:27:29 +02:00
dfc49e043b
fdo#46808, GetStorageFromURL now takes an XComponentContext
...
Change-Id: I300748914c913ecd9d433cb6f549a000717b538d
2013-05-21 08:24:00 +02:00
3d8a7a435c
Resolves: #i120675# the certificate store handles need to be closed
...
after closing the document
Found by: zhangjf
Patch by: zhangjf
(cherry picked from commit 33d9584bb6d285de1d935bf23adbb2c7666656f4)
Change-Id: I131a17276f33059eb944fc34272c50f838b6973f
2013-05-16 16:26:34 +01:00
1e8482db2d
Resolves: #i120635# Removed httpserv.jar and changed its dist directory
...
(cherry picked from commit efc6346ef6a3a9b618979230036d877149ce0d7d)
Change-Id: I983b106ef46bd9b95f6ef12d3c2432d604dd08a8
2013-05-13 21:04:01 +01:00
368e06b05a
officecfg: remove Package_cppheader
...
Instead include generated headers directly from workdir.
Change-Id: I9d2bcc07175d2bbc16d3cc548c2245e7a4fb0c65
2013-05-07 17:07:43 +02:00
e8eab43eeb
cleanup whitespaces due to RTL_CONSTASCII_USTRINGPARAM removal
...
In e2e2cc61144cb22227eebfadff0ea24b51ccfbd0 the method was removed
automatically leaving several line breaks etc. as visual noise.
2013-05-06 19:21:07 +02:00
e2e2cc6114
remove usage of RTL_CONSTASCII_USTRINGPARAM
...
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.
Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
402c8f5f1e
Java cleanup, close file handles when done with them
...
Change-Id: I79e6e0b8f53ae6f232c34aa8e833853d2ec24cf0
2013-05-06 11:45:56 +02:00
3155a8e60f
xmlsecurity: drop no longer needed RTL_ASCII_USTRINGPARAM macro
...
Change-Id: Ia08688ef3c262ba4379213231032c73404ae748b
2013-05-06 09:24:01 +02:00