Commit Graph

60 Commits

Author SHA1 Message Date
a940c8280d Folder icon redesign
Replaced old and busted icon design, with Google's generic app icon.
It is now a vector drawable, which means it will be sharp at any resolution,
while we only need to keep one tiny xml file for it. No folder thumbnail
support, but this a welcomed change nontheless.

Change-Id: Ie6e38a6ac8e6cf1bc2d22247c11b5de0bd0d8478
Reviewed-on: https://gerrit.libreoffice.org/32498
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2017-01-11 07:00:51 +00:00
d976f9151a Updated toolbar spinner to newer implementation
Lowered all-caps navigation labels to something more professional.
Added a Spinner to the Toolbar in XML.
Reworked many lines of LibreOfficeUIActivity to remove possible NPE's, and also
removed redundant lines, which were mostly deprecated, as well as switching to
a newer implementation of a toolbar-spinner navigation pattern. There are more
deprecated methods, but I wanted them in a separate commit.

Change-Id: I15d5365ed7c00880873bf7874bc794008436bb99
Reviewed-on: https://gerrit.libreoffice.org/32497
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2017-01-11 06:54:10 +00:00
11e443bfe1 Removed unnecessary imports
Import redundancy reported by Android Studio.

Change-Id: If46a43bb18268877d41d4957094acc543c4588fd
Reviewed-on: https://gerrit.libreoffice.org/32496
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-11 06:53:14 +00:00
45f75e2909 tdf#104856 - Fix for closing the document without asking for saving
Change-Id: I37b6fbf2639439a57c6d162b7817d009d1d49023
Reviewed-on: https://gerrit.libreoffice.org/32332
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-12-24 08:24:42 +00:00
252008d492 tdf#103524 - Fix Bottom Toolbars closing operation
Added variables to control state of bottom toolbars, and based
on their state open/close the bars

Change-Id: I5f9429b336451a354b95dcee18b71fb577c28559
Reviewed-on: https://gerrit.libreoffice.org/30298
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-12-06 08:31:00 +00:00
7d794b193e tdf#96797 - Android: Viewer file filter is not working on ownCloud
Change-Id: I6ffb450d935ae1f7b4900243b9ff2f8df408628f
Reviewed-on: https://gerrit.libreoffice.org/27829
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-09-19 06:14:52 +00:00
c57e7685f2 tdf#101260 - Android: Filter in External SD doesn't work
Change-Id: Iaba74749c11cbac972fecf816e5bb090edd9e06c
Reviewed-on: https://gerrit.libreoffice.org/27802
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-19 06:12:18 +00:00
fbda3f9a8d tdf#96810 - Fix Android Viewer: Keyboard can not hide with keyboard button.
Change-Id: I87d83953094d31ed4e1bcf60c55dd19056a7994e
Reviewed-on: https://gerrit.libreoffice.org/28005
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-09-09 08:16:55 +00:00
5bdea25f68 tdf#96771 - bug fix for owncloudfiles with white space characters
Change-Id: I373db55ed819ed5d2a574ba2590032ee628218f4
Reviewed-on: https://gerrit.libreoffice.org/27634
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-08-28 07:13:01 +00:00
428e23f4f7 Fix some spelling errors in comments and strings
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e
Reviewed-on: https://gerrit.libreoffice.org/26883
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-07-04 06:11:36 +00:00
66be4feef7 android: prevent crash if storage is unavailable
Change-Id: I350acc1735d5fd22a27434fc5ccf2ab39bf3d2cf
2016-07-02 17:20:52 +02:00
c6e8c96d50 tdf#99539 - fıx crash on android 5.1
Change-Id: I3d484f7d7d9e466ae1b2ac4afe2b59d060fa8b77
Reviewed-on: https://gerrit.libreoffice.org/24537
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-01 10:10:12 +00:00
fc2590cfa1 Fix typos
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73
Reviewed-on: https://gerrit.libreoffice.org/24317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-30 15:06:45 +00:00
c9c78dc1a5 formatting and whitespace
Change-Id: Icc086404a2ef32a38e972da9158f6156fdf74ef2
Reviewed-on: https://gerrit.libreoffice.org/23363
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-19 17:33:31 +00:00
956d48b5a5 android: document some parameters for doxygen
Change-Id: I4382949a35df3877fc6c93a83d6e84cd892756a8
2016-02-05 23:03:01 +11:00
1dfb68debb tdf#88389 - android document browser: external storage access
Background:
External SD cards are only partially supported by the Android system,
with a great deal of fragmentation on implementation across manufacturers
and android versions. There is no official support for OTG devices.

This commit adds:
1) External SD card support
2) OTG device support

Caveats:
1) Not tested on Android 6. Emulator crashes when opening
files on Android 6, using an unmodified build of the master branch.

2) OTG support currently works only if there is write access
to the OTG directory. The user must be aware of exact OTG directory
path or be able to navigate to it as well.

3) External SD card provider currently lacks file filtering.

Approach:
-----
Added new document providers.

External SD cards:
There are 2 different document providers external sd cards,
one for Android 4.4 and above, and the other for older versions.

1) New
Android 4.4 and above require usage of the DocumentFile wrapper class
to access files in external storage. Actual file paths are no longer
obtainable. As such, the underlying file will be cloned in a cache,
allowing us to get an actual file path and use LOK.
Some differences exist between 4.4 & 5+. The document provider handles
each case separately.

2) Legacy
Android 4.3 and below do not support the DocumentFile wrapper.
File object can be used in these versions, allowing actual file paths
to be obtained. The document provider guesses the root directory of
the SD card. If the guessing fails, the user is to navigate to
this directory himself.

OTG:
The OTG document provider resembles the legacy external SD card
document provider, requiring the user to locate the directory himself.
The document provider does not guess the root directory of the OTG
device as the location varies with manufacturer implementation.
-----

Supplementary Notes:
Attempting to use the internal app cache as the file cache like in
the ownCloud document provider did not work. Using the external app
cache works fine though. It could be because initializing LOK wipes
the internal app cache.

Would be good to test the ownCloud document provider to confirm if it
works.

Change-Id: Ie727cca265107bc49ca7e7b57130470f7fc52e06
Reviewed-on: https://gerrit.libreoffice.org/20738
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-02-02 19:25:41 +00:00
64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
fbec6ac089 Fix typos
Change-Id: I3fba2c76c83381eb398c80947ef4849bccf7ab27
Reviewed-on: https://gerrit.libreoffice.org/21078
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-05 13:40:54 +00:00
321dc29fc5 tdf#88391 android document browser: draw and impress icon is the same
Added missing code to set icon for draw in grid mode.

Change-Id: I9ee356d5ab1a296a90e5ece11f5f4c50e7600f13
Reviewed-on: https://gerrit.libreoffice.org/19921
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
Tested-by: Jenkins <ci@libreoffice.org>
2015-12-25 12:59:10 +00:00
6f5589d5ed android: another part where underline and strikethrough commands were swapped
Change-Id: I8fdde4b46e3e315a5b6a35cabc4495ebf69db057
2015-11-21 14:54:43 +01:00
9feffdbe0d android: underline and strikethrough commands were swapped
Change-Id: Id7157ea5fadd684dceec52f69ec9279c4107b5f1
2015-11-21 10:51:40 +01:00
506432f505 android: don't crash on empty filelist
Change-Id: I46caceed3fdf0ad0aa51c8a8ede1177ca3d1855e
2015-11-17 14:54:32 +00:00
d30e0aea02 android: rename "editMode" to "experimentalMode"
Change-Id: I3fcb7bb2fda925a1c5b2633ac7f6846fda0dabf8
2015-11-13 11:40:34 +01:00
8908920488 android: add undo/redo to the main toolbar
Change-Id: I64f76d22018fcd8af2991933ba5ab2069f84181f
2015-11-13 11:40:34 +01:00
6636476cf0 android: Add string searching + search toolbar
LOKit supports searching, but this was not implemented yet in the
Android GUI. This adds a bottom search toolbar where you can type
a search string + up/down search handles to search for the string
from the current cursor position.

Change-Id: Ia7461d2c6399c23201d2ea81f0b44c38533939a1
2015-11-13 11:40:33 +01:00
319623a334 android: Add bottom formatting toolbar
The bottom formatting toolbar now shows the formatting options
previously located in the main toolbar as a menu entry (bold,
italic, ...). In addition alignment options and selection of fonts
and sizes have been added.

Bottom formatting toolbar is not shown by default - it enables when
hitting the icon in main toolbar. Also soft keyboard and formatting
toolbar should not be shown at the same time.

Change-Id: I5f6cf8a9fcbdb4d154ae7504a65f9a226c99d694
2015-11-13 11:40:33 +01:00
96cd2abd74 LOK: setClientZoom() - sets the client zoom level
We need to know the client's view level to correctly handle the mouse
events in calc. PaintTile() set a zoom level that corresponds to the
requested tiles and previously postMouseEvent would call SetZoom(1,1).
Now we can make use of knowing the client's view level and call
SetZoom() with the correct parameters

Change-Id: I34b5afcdcc06a671a8ac92c03e87404e42adf4cd

Conflicts:
	sc/source/ui/unoobj/docuno.cxx
2015-11-13 09:55:19 +02:00
74463457b3 android: chanhe handles to use alias, tint handles with color
Change-Id: I86ad5eefd70bc8b768780cac66ca466aa0926dc4
2015-11-02 08:48:47 +01:00
37d41674c2 android: don't crash in LO when SurfaceView layout is 0 width
Change-Id: I49be19b273d0c263637369e9b095f374b345191b
2015-11-01 23:06:09 +01:00
9a52bad40a android: don't crash in TextureReaper when Integer is null
Change-Id: I1514aa7a3fbab682b0d282ba0f504470943d7e4a
2015-11-01 22:59:04 +01:00
6d9124de6f android: update JNI facade, rename mouse/keyboard event flags
Change-Id: Ia2b9a812717d05c7d98d47bf0fe5fd293029d045
2015-11-01 22:59:04 +01:00
075c4db284 android: remove MockTileProvider
Change-Id: I1b44c9fa4edfdc79e48f52ba95493f83f0421669
2015-10-21 15:17:10 +02:00
1956b50e3b android: show flat ODS files in the doc browser
I forgot about this when I enabled other Calc file types in
07997cba7745997d7e2ed908a8764ba1f0777f1e (android: adapt doc browser to
updated manifest that accepts Calc documents, 2015-01-19).

Change-Id: Iabacffbfc09d806f09bc7e0f9307830bda8ebbe1
2015-10-15 08:50:50 +02:00
b6430ed7fd tdf#94891 fix crash when rotating screen in docbrowser right after launch
will likely also lose the current directory, but much better than
crashing.

Change-Id: I9ce20e1954a6f58325413046e258ded75b6c8848
2015-10-11 18:13:46 +02:00
143fb0a4b5 move extracting assets to Java & use AssetManager to access assets
using AssetsManager in both java as well as native parts allows to
handle files both with and without compression transparently

Change-Id: If02f1159c498be7ea965fd9c217410722f2dca1f
2015-10-11 02:03:43 +02:00
cdfdf76787 android: avoid arrayIndexOutOfBounds when lokit payload doesn't have a value
and is not handled yet like ".uno:CharFontName="

Change-Id: I09d17b6be9ce9b9c9ae6883f8222c8628268815d
2015-10-03 22:54:38 +02:00
233b9b0ec9 android: make strikethrough work (it's not .uno:StrikeOut, but .uno:Strikeout)
Change-Id: I8d629272cf94eaac406c163c06c9bbdd6a248b79
2015-10-03 22:54:38 +02:00
c320161f48 compare strings using equals, not with ==
Change-Id: I8869980198123bbe9e86e12638e3316be24588c3
2015-10-03 22:54:37 +02:00
7b282e3db8 android: remove unused imports, call static methods the static way
and remove some redundant casts

Change-Id: If58a395227e4b9d54b0d757032d4a55c25315019
2015-10-03 22:54:37 +02:00
de376cb1c4 android: remove no longer used files
Change-Id: Id3b71ac50e3c8ce9705f6df18edaaaa6ba8ad3fd
2015-10-03 22:54:37 +02:00
9e4c87be31 Fix typos
Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3
Reviewed-on: https://gerrit.libreoffice.org/18938
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 05:53:57 +00:00
45c27ffcfd android.util.FloatMath is deprecated/was removed in ver 23
replace with corresponding Math functions and bump android sdk target to
23 to be able to use current appcompat-v7

pre-JIT FloatMath was faster, but since then was wrapper to Math anyway
http://developer.android.com/reference/android/util/FloatMath.html

Change-Id: I19e316fb7d32e616162a70fca8c565fa320a8c1a
2015-09-24 22:47:59 +02:00
ac22644352 Fix typos
Change-Id: I021589aeca9ef6bceb1c828c2197f5ff58f85b09
Reviewed-on: https://gerrit.libreoffice.org/18707
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-09-18 22:06:21 +00:00
a952540aeb Android: i18-ize some strings
Change-Id: I35d0ef7976d6dcca65f3335ff9175c799faa99fe
2015-09-11 18:32:49 +00:00
315ca033c6 Android: check file modify date to know if save is complete
The API does not allow to set a callback for the save operation, we
work this limitation around by checking the modification date of the
local file periodically. When that date changes, we are sure the
local save operation is complete and we can invoke the document
provider save operation to push the changes to the cloud, if
necessary.

Users may press "save" on a document with no changes, in this case we
have set a 20 seconds limit to stop checking the modification date.

We also add a "save complete" message for the user.

Change-Id: Ib8871fac682a5c03a187a7238e11874984143527
2015-09-11 18:29:58 +00:00
626ebde44f Android: Implement cloud save
The LOMainActivity now needs to be aware of Document Providers, so we
pass the providerId and documentUri in the Intent so it can rebuild
the DocumentProvider and the IFile objects.

We also implement the ownCloud save operation.

TODO: since the local save operation does not have a callback, we do
not know when the cloud save operation should be performed. Now we
just wait 5 seconds to trigger it.

Change-Id: I060969e12888eca07c8c56ddc82cbed6c45a0739
2015-09-11 18:29:01 +00:00
a3c3a13e84 Android: provide an ID to document providers
This ID will be useful to get an instance of a document provider back
from a different activity.

Change-Id: I9419ea23d51f8e9ffd70252bd8e367cf51bde1ad
2015-09-11 18:29:00 +00:00
0c18bedb73 java: 'final static' to 'static final'
this is the canonical order, and it makes the code easier to read

Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
Reviewed-on: https://gerrit.libreoffice.org/16242
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-15 08:45:19 +00:00
aa3cdfc8b6 Android: show drawer ("hamburger") icon on root directory
When browsing the root directory, the application home button (on the
top left corner) becomes a drawer icon. When not in the root dir, the
icon is an arrow as usual.

This will increase the visibility of the document providers feature.

Also, modified the behavior of the system back key to close the drawer
in case it is open.

Change-Id: Id0ce932907bcec4b8601029482eda0c1c1f0df35
Reviewed-on: https://gerrit.libreoffice.org/16246
Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-12 11:23:27 +00:00
d1f671e053 tdf#87434: android: system back key to go one level up
Added an additional check so back has to be pressed twice on the root
folder to actually leave the application. It's a check seen in many
other apps.

Change-Id: I26827113a41070aa8188fa616ba8fe53742329b3
Reviewed-on: https://gerrit.libreoffice.org/16245
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-12 09:32:12 +00:00