wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
401,915 Commits 5 Branches 0 Tags
5e355dabccdbaa94de8897edc1fd88b16993b493
Commit Graph

245 Commits

Author SHA1 Message Date
Noel Grandin
3a705ab405 OSL_TRACE->SAL in avmedia..canvas 
Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
 2016-12-13 08:14:00 +02:00
Noel Grandin
a66731982e convert SFX_HINT to scoped enum 
Notes

(*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a
dynamic_cast check.

(*) In SC, removed the hint id field from ScIndexHint, no point in
storing the hint id twice

(*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no
point in storing two different hint ids

(*) In some cases, multiple #define's used to map to the same SFX_HINT
value (notably the SFX_HINT_USER* values). I made all of those separate
values.

Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5
Reviewed-on: https://gerrit.libreoffice.org/31751
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-08 12:35:09 +00:00
Noel Grandin
06dd5b9c9e convert SbDEBUG constants to o3tl::typed_flags 
Change-Id: Ifcada5684bacae46ec90c5ce3e58980860fee29f
 2016-11-24 08:05:55 +02:00
Noel Grandin
f31d98f63c loplugin:expandablemethods in avmedia..canvas 
Change-Id: Ic230f1ef6b1dbe796ac7862a1a7e6a718f9e4e54
Reviewed-on: https://gerrit.libreoffice.org/30753
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-11 07:00:18 +00:00
Noel Grandin
5a5731cd05 loplugin:expandablemethodds in include/basic..comphelper 
Change-Id: I1aa9c12e8839325a9fd98530abc89a3d586ff62e
Reviewed-on: https://gerrit.libreoffice.org/30120
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-21 09:57:38 +00:00
Hieronymous
01dc6d098d tdf#96099 Reduce no. of useless typedefs for trivial containers. 
Reduced vector< OUString > typedefs in sbintern module.

Change-Id: I5b2fd6f0b5fe0ae538a12ac028a08458c6eb4714
Reviewed-on: https://gerrit.libreoffice.org/29916
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-16 10:41:20 +00:00
Jacek Fraczek
f004aa9951 tdf#89307: Removed SvRef::operator T*() 
Conditional statements are using SvRef::Is() method.
Changed static_cast<T*>(svRef<T>) occurances to svRef.get().
Added operator == and != to SvRef.

SbxObject::Execute is using SbxVariableRef internally.
SbxObject::FindQualified is using SbxVariableRef internally.

Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395
Reviewed-on: https://gerrit.libreoffice.org/29621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-10-10 08:48:30 +00:00
Noel Grandin
a2b77b4368 loplugin:singlevalfields in basic..idl 
Also fix obvious bug in the initialisation of the
connectivity::odbc::OConnection::m_bClosed field.
Probably closes some kind of connection leak there.

Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82
Reviewed-on: https://gerrit.libreoffice.org/28932
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-16 08:30:26 +00:00
Noel Grandin
20a9e101d9 loplugin:constantparam 
clean up the plugin a little, and try to catch params which are default
constructed, which doesn't seem to be working yet

Change-Id: Ife45f18502a45cd26306424b7432c55fcbb0fd12
Reviewed-on: https://gerrit.libreoffice.org/28861
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-14 08:47:06 +00:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin
b8064bdf7f new loplugin: countusersofdefaultparams 
Change-Id: I79e2c690f3e664c14af12cf763dd5a8ac20d6b04
Reviewed-on: https://gerrit.libreoffice.org/28353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-25 06:37:42 +00:00
Asela Dasanayaka
057ae1cfca tdf#96505 get rid of "long" integer literals 'L' 
Remove L from integer literals in module basic all 0L, 1L, 2L and 3L

Change-Id: Ia46ce3d206020e16fc17e95731244a557941528c
Reviewed-on: https://gerrit.libreoffice.org/27816
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
 2016-08-24 12:19:57 +00:00
Noel Grandin
508c95f1b6 improve passstuffbyref return analysis 
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:48:25 +00:00
Arnaud Versini
9b0995439e BASIC : Remove useless 16bits Remove function from SbxArray 
Change-Id: I050a034437d3370a28c9e5ab47abee369e634f7d
Reviewed-on: https://gerrit.libreoffice.org/27089
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-11 07:28:16 +00:00
Noel Grandin
f107d45381 Convert SbxClassType to scoped enum 
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b
Reviewed-on: https://gerrit.libreoffice.org/25259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-23 11:49:32 +00:00
Noel Grandin
5abc669599 new plugin stylepolice 
check for local variables which follow our member field naming
convention, which is highly confusing

Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
 2016-04-21 08:32:47 +02:00
Noel Grandin
494bd08c48 remove tools/solarmutex.hxx 
Deprecated in favour of comphelper::SolarMutex

Change-Id: I159077562660de5df25601fa471447f4b64a2cf1
Reviewed-on: https://gerrit.libreoffice.org/24079
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-15 08:09:01 +00:00
Noel Grandin
f3dabe7507 make GetGlobalUNOConstant and GetUNOConstant take an OUString 
and eliminate converting backwards and forwards between
sal_Char*/OString/OUString

Change-Id: Iaf52ce93f0e732ab338f75d21b95ab4b020a4d6f
Reviewed-on: https://gerrit.libreoffice.org/23919
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-11 06:20:10 +00:00
tymyjan
c20cc7e79b tdf#97499 Fixed containers parameters clearing #4 
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513
Reviewed-on: https://gerrit.libreoffice.org/23754
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-04 05:49:06 +00:00
Arnaud Versini
14420e8329 BASIC : Add tools::make_ref and simplify SvRef usage 
Change-Id: I8fe846dbd353bace05a8732a9b961f3507d97ef8
Reviewed-on: https://gerrit.libreoffice.org/22587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-22 12:33:52 +00:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Arnaud Versini
3a97b3619a BASIC : Remove useless virtual function override 
Change-Id: I0f8e480bf73256e7f1284e11983cc70c0426172c
Reviewed-on: https://gerrit.libreoffice.org/21513
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-16 17:08:46 +00:00
Arnaud Versini
1ae5ceccb8 BASIC : Remove useless methods in StarBasic 
Change-Id: I9e8ce92b967ee9c9485b7af15280f6a212ff599d
Reviewed-on: https://gerrit.libreoffice.org/21498
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-16 17:06:26 +00:00
Noel Grandin
bbfeab3b13 loplugin:unusedmethods unused return value in include/basic 
Change-Id: Ib1a006adaa92e257d40a20ff0d8beeb37e7c2fe0
Reviewed-on: https://gerrit.libreoffice.org/21360
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-12 06:40:03 +00:00
Johannes Hauf
bccd83ea54 Some cleanup for sal_uIntPtr usage 
Change-Id: Ia9779e6477d8848588f3543d09ea6b4477f594a2
Reviewed-on: https://gerrit.libreoffice.org/21022
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-01-07 14:13:49 +00:00
Arnaud Versini
5e0d36adc3 BASIC : use std::vector instead of SbArray for Modules. 
Change-Id: I9594efb13b3dccc637ccd61eea4b42255c2a775c
Reviewed-on: https://gerrit.libreoffice.org/20817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-01-07 12:18:40 +00:00
Andrea Gelmini
92e60e1b80 Fix typos 
Change-Id: I1b79005d9c4e32325b8dadcc4f805975d6bf2727
Reviewed-on: https://gerrit.libreoffice.org/21103
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
 2016-01-05 07:32:28 +00:00
Arnaud Versini
f146ddadf5 BASIC : Remove useless allocation operator overload 
Change-Id: I134cdbfe388347264a810bbfbff8b4f9f373e663
Reviewed-on: https://gerrit.libreoffice.org/20873
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2015-12-30 18:27:27 +00:00
Matteo Casalin
cb98c423bb sal_uLong/sal_uIntPtr/sal_uInt16 to sal_uInt32 
also avoid some explicit temporaries and group some checks.

Change-Id: I7795b208dde53fd383b8c75f72dd9f56429aea2b
 2015-12-27 16:51:27 +01:00
Arnaud Versini
4df183e2c9 BASIC: use c++ foreach loops when possible. 
Change-Id: Ia1c734e26da88010eef40a4375c423b0765f43ae
Reviewed-on: https://gerrit.libreoffice.org/20423
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2015-12-13 15:57:42 +00:00
Oliver Specht
fa91dd31f3 5th step to remove tools/rtti.hxx 
tools/rtti.hxx removed
completed the interface of some Sdr.*  Items
and removed pseudo items

Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-11-11 10:49:30 +00:00
Stephan Bergmann
08e49fa337 loplugin:nullptr (automatic rewrite) 
Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
 2015-11-10 10:31:17 +01:00
Stephan Bergmann
a80bab7058 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: I9979100550a86ac3f42d74a5403fb3ffd9d5006b
 2015-11-06 09:34:39 +01:00
Noel Grandin
0e8a40e8b8 calling IsSet() before Call() on Link<> is unnecessary 
the Call() already does a check

Found with:
git grep -A 1 -w 'IsSet()'
    | grep -B 1 '.Call('
    | grep ':'
    | cut -d ':' -f 1

Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
 2015-10-15 12:29:01 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Oliver Specht
89d39bc100 tdf#94559: 4th step to remove rtti.hxx 
replaced use of PTR_CAST, IS_TYPE, ISA in
    idl, editeng, sc, sd, sw, sfx2, sot, starmath

Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653
Reviewed-on: https://gerrit.libreoffice.org/19132
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-10-06 07:29:37 +00:00
Andrea Gelmini
9e4c87be31 Fix typos 
Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3
Reviewed-on: https://gerrit.libreoffice.org/18938
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2015-09-30 05:53:57 +00:00
Oliver Specht
d3c7c9ea81 tdf#94559: first step to remove rtti.hxx 
replaced use of PTR_CAST, IS_TYPE, ISA in
avmedia, basctl, basic, cui, dbaccess, vcl,xmloff

Change-Id: If4496762e82e896b6fbc362e6626502703c245f5
Reviewed-on: https://gerrit.libreoffice.org/18905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-09-29 12:26:20 +00:00
Stephan Bergmann
a6050c32f3 Clean up aEmpty 
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
 2015-08-27 08:00:32 +02:00
Noel Grandin
4f87e9da41 loplugin: defaultparams 
Change-Id: I29ef505ee77965df33677f8051ec39398ef0c74e
 2015-08-11 09:48:17 +02:00
Noel Grandin
b1c25a0d8f inline "old" SbERR constants 
Change-Id: I3e6665351de97692ae70207e8b623ad008ca8c9a
 2015-07-28 08:35:34 +02:00
Noel Grandin
01075a7274 inline the "old" SbxErr constants 
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
 2015-07-28 08:35:34 +02:00
Noel Grandin
9072c5c855 convert SbxFlagsBits to scoped enum 
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
 2015-07-28 08:35:34 +02:00
Noel Grandin
b4ee16da65 com::sun::star->css in basic 
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212
Reviewed-on: https://gerrit.libreoffice.org/17206
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-20 09:39:36 +00:00
Takeshi Abe
7640e244db tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants, in basic.

Change-Id: I13c5644bd6b9e964e42a98bee9c3019d959efb36
Reviewed-on: https://gerrit.libreoffice.org/16719
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-06 07:28:21 +00:00
Andrea Gelmini
ffa8892c5a Fix typos 
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc
Reviewed-on: https://gerrit.libreoffice.org/16705
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-07-04 10:23:17 +00:00
Noel Grandin
07d85c4499 remove SFX_NOTIFY macro 
it has not served any purpose since we switched to using normal C++ RTTI
for the SfxHint objects

Change-Id: Ic81353bcb7863ce892eb75296248ca14d8fd6c86
 2015-06-24 12:06:34 +02:00
Takeshi Abe
0980095619 Replace boost::scoped_array<T> with std::unique_ptr<T[]> 
This may reduce some degree of dependency on boost.
Done by running a script like:

git grep -l '#include  *.boost/scoped_array.hpp.' \
 | xargs sed -i -e 's@#include  *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
 | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'

... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.

Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-06-17 15:50:45 +00:00
Andrea Gelmini
f378e723d2 Fix typos 
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56
Reviewed-on: https://gerrit.libreoffice.org/16300
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 11:14:55 +00:00
Stephan Bergmann
761e0ae0a7 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
 2015-06-08 16:23:17 +02:00