Commit Graph

17 Commits

Author SHA1 Message Date
954f752cf1 convert MapUnit to scoped enum
I left a prefix on the names "Map" so that I would not have to re-arrange
each name too much, since I can't start identifiers with digits like "100thMM"

And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore.

Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224
Reviewed-on: https://gerrit.libreoffice.org/29096
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05 06:51:20 +00:00
396138a6bc Resolves: coverity#705366 Mixing enum types
and

coverity#705367 Mixing enum types
coverity#705371 Mixing enum types
coverity#982694 Mixing enum types
coverity#1027717 Mixing enum types
coverity#1371228 Mixing enum types
coverity#1371242 Mixing enum types
coverity#1371280 Mixing enum types
coverity#1371310 Mixing enum types

MapUnit and SfxMapUnit share the same values and
are freely cast from one to the other.

Now that

commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527
Date:   Thu Aug 11 15:02:19 2016 +0200

    loplugin:unusedenumconstants in package..svtools

removed the SfxMapUnit entries that were directly unused, they
don't match anymore and casting from one to the other is dangerous.

Why there was two of these anyway escapes me, get rid of SfxMapUnit
and just use MapUnit universally

Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e
Reviewed-on: https://gerrit.libreoffice.org/28234
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-19 11:25:18 +00:00
9cfa0810bd clang-tidy performance-unnecessary-value-param in chart2
Change-Id: Id33dce9714737dd28ce48c22f966c9747c2db20b
2016-04-12 11:25:18 +02:00
40c4a08652 loplugin:nullptr (automatic rewrite)
Change-Id: I71de514405bb9bcc746c1ab9633e7fe659888943
2015-11-10 10:31:18 +01:00
af77042f62 disable arrow heads in chart sidebar, tdf#94971
Change-Id: I631f34faf2befeb7cc61027c8fd59ef7b3543785
2015-10-12 23:54:14 +02:00
01cc898aac update the line panel for data points, related tdf#94969
Change-Id: Ieffdfd1cc0d6b5cc0dd8394896aeb49838096a6b
2015-10-12 23:54:14 +02:00
82cf6c6737 also update line panel for axis, related tdf#94933
Change-Id: Ie280fa01dbe25287d01b7f36d152ee55ce5dbe07
2015-10-10 16:54:43 +02:00
3ddad211de also update line panel for average and trend line, tdf#94933
Change-Id: I7ab991e94005665809ec52b8d4310209eb6ef75b
2015-10-10 16:44:51 +02:00
5f73eae61e we need to take the SolarMutex when we change the UI
Change-Id: I6347a1466038afd625cf59ae2ee87cb4e2014aa0
2015-10-10 16:21:29 +02:00
267f401e2a cppcheck: noExplicitConstructor
Change-Id: I2a1add8cf526cdb305ad99ccb138454a88f2fdbd
2015-09-07 09:56:07 +01:00
0075446151 make color button work in chart line sidebar panel
Change-Id: I2148fd9953b283945d2a1bcf24dbc47964b659ae
2015-08-20 03:15:57 +02:00
8b0109f28e avoid crash when chart model is disposed
Change-Id: I70c3a06e2aa9112cd5a47b7d8839c4bd701cfc1e
2015-07-31 17:38:40 +02:00
025fb3c660 prevent panel update when updating values from panel
Change-Id: I10debb5119ce78638db42315594cda4d65092fb0
2015-07-30 14:13:32 +02:00
bead8d0109 also handle line width correctly
Change-Id: Ia564d3c9b821a09586a0bcb32ee3f827e71f43de
2015-07-30 05:45:25 +02:00
3dc00a8de9 handle line dash in chart line panel
Change-Id: Ia3d466c269eef62f8fa419d15869f44213a6e001
2015-07-30 05:45:24 +02:00
e517948e71 set some properties from chart line panel
Change-Id: Idbe26d7ea554512391b22299ac6dccaeaa71d584
2015-07-30 05:45:23 +02:00
57dcf78e6b provide structure for chart line panel
Change-Id: I75204a012e4bc59f40a06db814bb9057a1cf8598
2015-07-30 05:45:22 +02:00