6c2725038b
Resolves: rhbz#1409634 crash on close storing clipboard of database table
...
Change-Id: I8e692314b4ef278f7881780d51bcecb60ca80c3f
2017-01-10 14:40:41 +00:00
a98334bc42
New loplugin:externvar: dbaccess
...
Change-Id: Ie1b87180b68c1f106128f0fc7a3a591c055b735f
2017-01-09 15:44:01 +01:00
d911663f0f
Typo: Acess->Access
...
Found thanks to Buovjaga
Change-Id: I73e36f50a1fd393859ba775ab084a488047864a3
Reviewed-on: https://gerrit.libreoffice.org/32810
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-01-07 10:08:48 +00:00
471b58e190
Typo: Postion->Position
...
Found thanks to Buovjaga
Change-Id: Iacf09325cdb58e0dbdcc9bf0570b2e02ed275132
Reviewed-on: https://gerrit.libreoffice.org/32808
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-01-07 10:08:36 +00:00
c03d803a72
Replace side-effect--only uses of makeStringAndClear() with setLength(0)
...
Change-Id: Iaf8011f1bd6a10b324653899b7f51458f7d0b68a
2017-01-05 13:52:17 +01:00
29f971d0d2
micro opt
...
Change-Id: I2d713783f1ad533c23a3fe319e7c37b7fd0e0e0d
2017-01-02 21:22:19 +00:00
43cc44107e
Remove newly added SAL_WARN_IF
...
Following Stephan's comment from https://gerrit.libreoffice.org/#/c/32643/
Change-Id: I6bb5c243313c3f0793286c6bae2967a6208dc854
Reviewed-on: https://gerrit.libreoffice.org/32651
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-01-02 15:48:17 +00:00
4b28e3b687
Typo: m_nColumnPostion->m_nColumnPosition
...
Change-Id: Iab83a89b5cfa1ca379cb59366682d5d2adeb0e31
Reviewed-on: https://gerrit.libreoffice.org/32645
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-01-02 15:13:05 +00:00
4e9af515d7
Remove some OSL legacies in dbaccess
...
Change-Id: Id809265c1df7df48e77ac2d8fbff685c599f8432
Reviewed-on: https://gerrit.libreoffice.org/32643
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-01-02 15:11:56 +00:00
7b588d7403
Translate German logs in QueryTabWinUndoAct (dbaccess)
...
Change-Id: Ia9a0dfac2174de6b0edc03d99cae0b9729cef36b
Reviewed-on: https://gerrit.libreoffice.org/32644
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-01-02 14:27:10 +00:00
7ed8646b07
osl/diagnose.h useless in userinformation (dbaccess)
...
Change-Id: I44c83f3655d49af9d28dd34a52e9266294b21552
Reviewed-on: https://gerrit.libreoffice.org/32639
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-01-02 13:49:40 +00:00
a29bd2dabb
cleanup tailing backslashes
...
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2
Reviewed-on: https://gerrit.libreoffice.org/32491
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-30 18:48:24 +00:00
833e6ca9d2
use std::vector instead of naked array in SfxItemPool
...
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4
Reviewed-on: https://gerrit.libreoffice.org/32384
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2016-12-26 18:35:59 +00:00
f37042f0f2
remove unused ImageLists
...
since...
commit 0dc13e9c06bf5bc188b427f0760d0dc2eee8f75e
Author: Caolán McNamara <caolanm@redhat.com >
Date: Tue Jun 10 12:32:03 2014 +0100
tweak things to allow switching between small and large toolbar icons
Change-Id: I3e1821297c5f7ea1a00356e51167d75265462ee7
2016-12-23 20:52:27 +00:00
6b8ee3c9ba
convert VclButtonsType to scoped enum
...
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1
Reviewed-on: https://gerrit.libreoffice.org/32285
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
2016-12-21 16:19:37 +00:00
e0b71d8e5a
remove newly unused SfxImageManager
...
Change-Id: If68637fe49b5d252ad4ec5d63d56261113be6a7c
2016-12-21 11:07:21 +00:00
5c2f401a5f
Minor simplification
...
Change-Id: Ia953a09f708fd83a2a5b2655dec2ed626891bb7c
Reviewed-on: https://gerrit.libreoffice.org/32099
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2016-12-17 16:12:52 +00:00
d15b4e2045
teach sallogareas plugin to catch inconsistencies
...
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a
Reviewed-on: https://gerrit.libreoffice.org/32004
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-15 06:45:14 +00:00
c3586b684c
OSL_TRACE->SAL in chart2..oox
...
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-13 06:12:00 +00:00
385f624027
Prevent use of ORowSetValue with sal_Bool as TINYINT
...
sal_Bool and sal_uInt8 are typedefs for the same underlying type, so any use of
ORowSetValue with sal_Bool instead of bool, apparently intending to treat the
value as a boolean, actually treated it as a TINYINT. (See e.g. recent
7b0c57b2faec875c790051d233d1e9abaed2a3bc "some compilers don't like implicit
bool-to-ORowSetValue conversion".)
Now that there's no way to create a sal_uInt8 ORowSetValue, getUInt8 and the
m_uInt8 union member can probably go away, too.
Change-Id: Ia27554f76e7e9edce6410284b578064573e54fd3
Reviewed-on: https://gerrit.libreoffice.org/31909
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2016-12-12 18:02:57 +00:00
2d48f5fc0a
convert VCLEVENT constants to scoped enum
...
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba
Reviewed-on: https://gerrit.libreoffice.org/31675
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-07 07:10:39 +00:00
0c6c37cb01
cleanup unused includes (related to tdf#88206)
...
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx
compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only
implbase*.hxx stuff is used.
Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995
Reviewed-on: https://gerrit.libreoffice.org/31686
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-06 18:17:06 +00:00
9ab9a15c06
only IMG_PRIMARY_KEY is actually used
...
Change-Id: Ie888ed93f0d511e0c040af32f41e8350113b586c
2016-12-05 21:38:52 +00:00
bfde4866e0
convert DecodeMechanism to scoped enum
...
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05 12:49:02 +02:00
803215142e
convert INetURLObject::EncodeMechanism to scoped enum
...
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05 12:49:02 +02:00
d12c8a0f2c
loplugin:unnecessaryoverride (dtors) in dbaccess
...
Change-Id: I22cf2fec8e543582a32b9a4f00221f1b2d864f7a
2016-12-05 09:05:38 +01:00
361c6eb18c
Use Size::Width/Height instead of inherited Pair::A/B
...
Change-Id: Ie0346d5ec054fbe7eff1d4b73814a5e2b9f654c2
2016-11-29 10:22:33 +01:00
e6ffb539ee
loplugin:vclwidgets check for assigning from VclPt<T> to T*
...
Inspired by a recent bug report where we were assigning the result
of VclPtr<T>::Create to a raw pointer.
As a consequence, we also need to change various methods that were
returning newly created Window subclasses via raw pointer, to
instead return those via VclPtr
Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b
Reviewed-on: https://gerrit.libreoffice.org/31318
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-29 06:45:42 +00:00
6bb20609a2
vcl: rename Window::Notify to EventNotify
...
There is annoying overloading between Window::Notify and
SfxListener::Notify, and the Window one has apparently fewer
implementations, so rename that and remove lots of disambiguating
"using Notify" in multiply inheriting classes.
Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-24 22:56:34 +01:00
04a84913ea
use o3tl::typed_flags in ConfigurationListener::ConfigurationChanged
...
Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e
2016-11-24 11:27:51 +02:00
ba9b0fb78a
convert SAD constants to o3tl::typed_flags
...
and drop unused SAD_TITLE_STORE_AS
Change-Id: I5114958b3954e3dc3ffd941334c6c4dbfbed7aea
2016-11-23 11:55:09 +02:00
a8b555a260
convert EF constants to o3tl::typed_flags
...
and remove now unused ByteVector typedef
Change-Id: I9c4b30aea2608cf97e597b00b4a4ea800efac4ec
2016-11-23 11:55:09 +02:00
8af0d5367e
convert CBTP constants to o3tl::typed_flags
...
Change-Id: I453a9bacef737a56e381c4172710ec6acf225f0b
2016-11-23 11:55:09 +02:00
e010834dc1
remove some more global OUStrings
...
Change-Id: Ic02754f98bfda3b7cd8c06857123d363a96e8d0e
Reviewed-on: https://gerrit.libreoffice.org/31071
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-22 12:37:51 +00:00
401d07f31f
loplugin:datamembershadow
...
Change-Id: I0206905ce95467a560f8ed24db4403df07d3680e
2016-11-17 11:19:55 +02:00
0d05173015
loplugin:constantparam
...
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0
Reviewed-on: https://gerrit.libreoffice.org/30858
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-15 12:56:26 +00:00
20043e3fa2
coverity#1394296 Dereference before null check
...
Change-Id: I143b7439b33695aa5bc4e32fd9386692eac37697
2016-11-12 12:21:59 +00:00
78b4a1fb01
update vclwidget loplugin to find ref-dropping assigment
...
Look for places where we are accidentally assigning a returned-by-value
VclPtr<T> to a T*, which generally ends up in a use-after-free.
Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9
Reviewed-on: https://gerrit.libreoffice.org/30749
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-11 06:55:41 +00:00
a71d6a2a84
loplugin:expandablemethods in dbaccess
...
Change-Id: I6087a3eff46926646ac1637615a0af30b38956a4
Reviewed-on: https://gerrit.libreoffice.org/30712
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-09 11:13:34 +00:00
389999abdb
make comphelper::containerToSequence a little smarter
...
So we don't have to specify the source and destination type as often.
Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624
Reviewed-on: https://gerrit.libreoffice.org/30700
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-09 07:48:18 +00:00
c123c528bf
loplugin:unnecessaryvirtual in comphelper..forms
...
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd
Reviewed-on: https://gerrit.libreoffice.org/30679
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-08 06:57:57 +00:00
14301589d7
style fix for cppcheck redundantCondition
...
Change-Id: I5d02c6f4c6b411c23a6de43374884a76e1c408fe
Reviewed-on: https://gerrit.libreoffice.org/30667
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-07 18:55:52 +00:00
028cc38a16
Resolves: #i119892# Missing "by" in description
...
Fixes spelling errors in some Base messages.
Reported by: Dwayne Henderson
Patch by: me
(cherry picked from commit 8df1c30b7f5e79c2757e7224677f9a487b1bed0a)
Change-Id: I18dcf20e51e941ca8ccb47315ea453399ca0d88a
2016-11-07 09:36:05 +00:00
c1805c48ae
loplugin:oncevar in dbaccess
...
Change-Id: I956063bb354fbbd002e922bb06d0b3863a2750fc
Reviewed-on: https://gerrit.libreoffice.org/30565
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-04 13:15:41 +00:00
164d8e3b1a
tdf#91222 VclBuilder constructor cleanup
...
Change-Id: I53bca2a9113862b8e7058937e231721c5f81a9de
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com >
Reviewed-on: https://gerrit.libreoffice.org/30511
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-03 06:37:42 +00:00
3fea7ac94b
loplugin:unusedfields
...
Change-Id: I96634c18ba6600f8f7d5d04a162dcd7e1e312923
Reviewed-on: https://gerrit.libreoffice.org/30474
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-02 07:54:20 +00:00
8826771e83
style fixes for cppcheck noExplicitConstructor
...
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34
Reviewed-on: https://gerrit.libreoffice.org/30460
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2016-11-01 18:44:20 +00:00
7441141bcf
No good reason for dbaccess::OCacheSet::updateRow to be pure?
...
Most of its virtual member functions are (though insertRow is already a curious
exception), even though they are defined, so smells like a copy/paste error
rather than deliberate design. And appears to have been the only reason why
loplugin:unnecessaryoverride filtered out such overriding of pure base
functions.
Change-Id: Ib2a40af9cd3cd3dbb26c4147f7d01de4e11f5f6e
2016-10-31 11:38:49 +01:00
978c6e7a8f
update vclwidgets plugin to check local variables
...
Change-Id: I91f7fc6b8419c0ed82194726eeb4c4657e998f22
Reviewed-on: https://gerrit.libreoffice.org/30428
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-31 09:44:46 +00:00
b1426b5b50
tdf#95014 initial support for 32 px icons in toolbar
...
This adds support for 32 pixel icons - mainly to get them into
the toolbar.
Most changes made are to change the behavior of having only small
and large icons as a boolean choice, but not every code path was
converted to non-boolean choice yet.
Breeze icon theme has the 32px variants so it can be used already.
Change-Id: Iadf832a87826c16b3a83522104dd6c35d61a0f87
Reviewed-on: https://gerrit.libreoffice.org/30398
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com >
Tested-by: Tomaž Vajngerl <quikee@gmail.com >
2016-10-30 18:00:05 +00:00
