71d8920b4d
New loplugin:externvar: extensions
...
Change-Id: I596eecab083092cccbe67062ade2279e6e25baab
2017-01-09 15:43:38 +01:00
c38aa3b734
loplugin:salbool
...
Change-Id: I7dfd48a04e2dff1391d10acb75180711b403af9b
2017-01-06 11:19:42 +01:00
5a6994870b
fold ResourceIndexAccessBase into ResourceStringIndexAccess
...
Change-Id: Icef518dc65d5edf4e7893df460aaae179eecfb45
2017-01-01 20:32:29 +00:00
705b435162
so ResourceStringListIndexAccess isn't needed
...
Change-Id: Ic25fc6f2f8f3e471a90e10c3f2319f40888520e6
2017-01-01 20:30:03 +00:00
e777637ffc
so we can drop StringList access from ResourceIndexAccess
...
Change-Id: Ie855a45f7994e9d58ddecc51b54c25424fc544d6
2017-01-01 20:28:47 +00:00
833e6ca9d2
use std::vector instead of naked array in SfxItemPool
...
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4
Reviewed-on: https://gerrit.libreoffice.org/32384
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2016-12-26 18:35:59 +00:00
ab72a07f1a
unwind RID_TOOLBAR_IMGLIST and RID_TOOLBAR_BIGIMGLIST ImageLists
...
Change-Id: Iae7ffce940f90e48dfb95b33abab35ca03a6b305
2016-12-24 15:28:42 +00:00
4a780e9e03
RID_SVXBMP->RID_EXTBMP
...
Change-Id: I19e5c60ea8b42223322da2a1e343b7c4c1c59928
2016-12-22 15:59:01 +00:00
87d1657d6b
loplugin:staticmethods
...
Change-Id: I04d3095c657deb72a20fa803964912cf6baf268b
2016-12-21 21:43:27 +01:00
20bd8d0426
-Werror,-Wmacro-redefined
...
Change-Id: Ifd246b642979df0d8b1aa20a59f8c73dc9ddc1b2
2016-12-21 20:20:12 +00:00
59a5664ffb
loplugin:staticmethods
...
Change-Id: I30456ec3a0440364b8b4c460d198588aed241034
2016-12-21 21:24:09 +02:00
6b8ee3c9ba
convert VclButtonsType to scoped enum
...
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1
Reviewed-on: https://gerrit.libreoffice.org/32285
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
2016-12-21 16:19:37 +00:00
7c7e1fb0f2
unwind RID_IL_FORMEXPLORER imagelist
...
Change-Id: I4c86aa99aecf22e842183966721976a921bafe7b
2016-12-21 16:02:28 +00:00
2e9c02feca
extensions: Drop empty file
...
Change-Id: I4962d739af889595f026c250b8f10a917b1dfb17
Reviewed-on: https://gerrit.libreoffice.org/32130
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp >
Tested-by: Takeshi Abe <tabe@fixedpoint.jp >
2016-12-20 00:18:05 +00:00
c3586b684c
OSL_TRACE->SAL in chart2..oox
...
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-13 06:12:00 +00:00
d6f2dd831a
remove useless Mutex guards
...
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51
Reviewed-on: https://gerrit.libreoffice.org/31875
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-12 09:16:09 +00:00
2d48f5fc0a
convert VCLEVENT constants to scoped enum
...
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba
Reviewed-on: https://gerrit.libreoffice.org/31675
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-07 07:10:39 +00:00
bfde4866e0
convert DecodeMechanism to scoped enum
...
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05 12:49:02 +02:00
803215142e
convert INetURLObject::EncodeMechanism to scoped enum
...
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05 12:49:02 +02:00
13ce97351d
loplugin:unnecessaryoverride (dtors) in extensions
...
Change-Id: Ia8250bc33c5d05861794619c5d240fdcb4002c13
2016-12-05 09:04:10 +01:00
d36ca60964
extensions,sc,sd,vcl: de-obfuscate assignments in conditions to help GCC
...
GCC 6.2.1 with -Og produces spurious -Werror=maybe-uninitialized
on variables that are assigned in conditions; perhaps it's better to
de-obfuscate the code if even GCC is confused about it.
Change-Id: Ia2f8209df893a8e5659ca72f4cde3d7d847574e1
Reviewed-on: https://gerrit.libreoffice.org/31332
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2016-11-29 09:49:48 +00:00
be37c23c58
loplugin:vclwidgets
...
Change-Id: If88a200fa26bcc6b20ad3c1dbc160e862054318f
2016-11-29 09:01:56 +01:00
e6ffb539ee
loplugin:vclwidgets check for assigning from VclPt<T> to T*
...
Inspired by a recent bug report where we were assigning the result
of VclPtr<T>::Create to a raw pointer.
As a consequence, we also need to change various methods that were
returning newly created Window subclasses via raw pointer, to
instead return those via VclPtr
Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b
Reviewed-on: https://gerrit.libreoffice.org/31318
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-29 06:45:42 +00:00
6bb20609a2
vcl: rename Window::Notify to EventNotify
...
There is annoying overloading between Window::Notify and
SfxListener::Notify, and the Window one has apparently fewer
implementations, so rename that and remove lots of disambiguating
"using Notify" in multiply inheriting classes.
Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-24 22:56:34 +01:00
b495eb4dba
loplugin:datamembershadow
...
Change-Id: I8a737a2f22c7be9630a1f7562b4309e687bb85f9
Reviewed-on: https://gerrit.libreoffice.org/30948
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-18 12:11:33 +00:00
1ba4bb6397
loplugin:countusersofdefaultparams in editeng..rsc
...
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-11 12:12:22 +02:00
78b4a1fb01
update vclwidget loplugin to find ref-dropping assigment
...
Look for places where we are accidentally assigning a returned-by-value
VclPtr<T> to a T*, which generally ends up in a use-after-free.
Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9
Reviewed-on: https://gerrit.libreoffice.org/30749
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-11 06:55:41 +00:00
389999abdb
make comphelper::containerToSequence a little smarter
...
So we don't have to specify the source and destination type as often.
Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624
Reviewed-on: https://gerrit.libreoffice.org/30700
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-09 07:48:18 +00:00
1b277a37c5
loplugin:expandablemethods in extensions
...
Change-Id: I93a770933de86146de1d25db9d596615916c3e28
Reviewed-on: https://gerrit.libreoffice.org/30689
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-08 11:11:52 +00:00
64a708cba9
Revert "Reverts a commit series that cripple windows ci."
...
with addition of...
- svxlo-SvxColorListBox
+ svxcorelo-SvxColorListBox
This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601.
Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128
Reviewed-on: https://gerrit.libreoffice.org/30598
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2016-11-07 21:04:50 +00:00
db380aab10
Reverts a commit series that cripple windows ci.
...
Revert "SvxShadowTabPage::Construct was removed"
f9a2c1c12ecad833c63b894c89d6008907477eb5.
Revert "replace OColorPopup with SvxColorWindow"
f300754bb1c6a347c92bb9548be7a65237176542.
Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID"
347c2c334589b18cc62af292674bb3df1dd54b71.
Revert "replace last ColorLB use with a listbox of colors"
604b35bf55351751a396e34dcca3f85e75860fd5.
Revert "simplify, its just a vector of colors"
351a97ce6bda3075677b59fa1387ba3d1ab17d7a.
Revert "replace user draw with an Image of the color"
df738e0f8ceedb4bad756960be14d9c41adc165d.
Revert "strip down to the used pieces"
commit 08d6cd788f2584ce10ab8fa10665245e953c59d9.
Revert "move now combined ColorLB to location of last user"
a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e.
Revert "fold ColorListBox and ColorLB together"
a989a0b1f2b425f05b58d0e44ce2de31c842ed65.
Revert "move ColorListBox beside sole thing that uses it"
760a198e697f3070a5e0e029e4eff7be220eb9cd.
Revert "extensions leaks out details of Color Selector, patch it up"
8bea644d6117a49405e6426dc97214220fc869d1.
Revert "inherit FillAttrLB from ListBox not ColorListBox"
d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0.
Revert "unify color selectors"
43bc3031483d172eccd72c3804e2d4fc2ef37de4.
2016-11-05 13:42:40 -05:00
8bea644d61
extensions leaks out details of Color Selector, patch it up
...
and rebase it on SvxColorListBox
Change-Id: I3afef689ab0dc3c34e465810d82bf21797907558
2016-11-04 17:14:26 +00:00
2dfc4c0845
loplugin:oncevar in desktop..filter
...
Change-Id: I21c47cacbcd68f06eea7ccbbfa6d04fc65e2b7ee
Reviewed-on: https://gerrit.libreoffice.org/30564
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-04 13:15:29 +00:00
02eaf40ba0
tdf#91222 VclBuilder constructor cleanup
...
Change-Id: I619cb50c3475519921ffd318b32875ae4ff2c0b8
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com >
Reviewed-on: https://gerrit.libreoffice.org/30545
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-04 07:18:19 +00:00
8826771e83
style fixes for cppcheck noExplicitConstructor
...
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34
Reviewed-on: https://gerrit.libreoffice.org/30460
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2016-11-01 18:44:20 +00:00
978c6e7a8f
update vclwidgets plugin to check local variables
...
Change-Id: I91f7fc6b8419c0ed82194726eeb4c4657e998f22
Reviewed-on: https://gerrit.libreoffice.org/30428
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-31 09:44:46 +00:00
8a22bc93e0
update unnecessaryoverride plugin to find pure forwarding methods
...
which can be replaced with using declarations.
Is there a more efficient way to code the search? Seems to slow the
build down a little.
Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f
Reviewed-on: https://gerrit.libreoffice.org/30157
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-28 12:56:17 +00:00
09cb920969
convert std::unique_ptr<VclAbstractDialog> to VclPtr
...
Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
2016-10-28 09:12:27 +02:00
7da765dde1
loplugin:expandablemethods in svtools
...
Change-Id: I126cc87c890867c3e762f86969a20d64aef63108
Reviewed-on: https://gerrit.libreoffice.org/30314
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-27 10:23:35 +00:00
98d9bb5eb2
Adapt Windows-only code to deletion of the "Any-to-Any" specializatios
...
...upcoming with <https://gerrit.libreoffice.org/#/c/30022/ > "Delete the 'Any-
to-Any' template specializations for LIBO_INTERNAL_ONLY"
Change-Id: If070825d88ffa7bb49e645b3bfeae9dfa387f000
2016-10-21 18:14:18 +02:00
6f96e86dae
loplugin:expandablemethodds in editeng..extensions
...
Change-Id: Ibe1929d74ff460955e39f2ccce3056b2051ddf08
Reviewed-on: https://gerrit.libreoffice.org/30013
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-19 06:31:43 +00:00
d1ea6ecda6
replace <<= with assign for <<= with rhs Any
...
found by deleting specialization of '<<=' template
Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c
Reviewed-on: https://gerrit.libreoffice.org/29956
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2016-10-18 19:16:44 +00:00
9939d2053d
so_activex_x64: Avoid warning LNK4070
...
Don't specify optional library name in DEF file that is used both
for 32-bit and 64-bit library: it's explicitly specified in command
line.
Change-Id: I20e732f2095367ec3648741dde26cf7ec101f28f
Reviewed-on: https://gerrit.libreoffice.org/30008
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
Tested-by: Mike Kaganski <mike.kaganski@collabora.com >
2016-10-18 13:30:13 +00:00
d11ac60459
clang-cl loplugin: extensions
...
Change-Id: I659d8a3b098c7417235006c86ea60e7fe1e56a44
Reviewed-on: https://gerrit.libreoffice.org/29867
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2016-10-16 14:19:16 +00:00
59ee2791e6
drop unused RID_RSC_BUTTON_IMAGES resource
...
Change-Id: If85a3491c3cb6ebb05a82e1c732083d99e91d6e8
2016-10-13 09:39:17 +01:00
15f5fdef97
move this monstrosity to the last place its used
...
Change-Id: I4691f20143406249afc8da1a6dfa901224f4a62d
2016-10-13 09:36:51 +01:00
170cf525e4
remove (yet yet another) StringListResource implementation
...
Change-Id: Ifaf89badfc339f8253a629c6960df8a943b8cce5
2016-10-13 09:36:51 +01:00
ad067cb0c7
remove StringListResource in favour of ResStringArray...
...
and turn local resources used as lists of strings into
string array resources
Change-Id: I9d67a790659963bca87aacba1c052d7b244b4e21
2016-10-12 14:03:00 +01:00
4ceadf4504
tdf#70979 make conference proceedings strings unique
...
Change-Id: I8386651390ba753108577ced29050585b72c5e78
Reviewed-on: https://gerrit.libreoffice.org/28813
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Yousuf Philips <philipz85@hotmail.com >
2016-10-12 12:15:03 +00:00
90021d3d3b
loplugin:unnecessaryoverride in extensions..filter
...
Change-Id: Ifd954bf48291cdc43c66fd44b4029e47eb7589f6
Reviewed-on: https://gerrit.libreoffice.org/29690
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-12 06:35:44 +00:00
