4ec87ca784
add dbtools for !HAVE_FEATURE_DBCONNECTIVITY anyway
...
Change-Id: I7a769ab3c7881eae80849efc5e75eca5846d254f
2016-12-17 15:47:15 +00:00
818d93f1db
more !HAVE_FEATURE_DBCONNECTIVITY build fixing
...
Change-Id: I1f949c29020c498200decdac487e0519f48a4142
2016-12-17 15:21:26 +00:00
bfde4866e0
convert DecodeMechanism to scoped enum
...
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05 12:49:02 +02:00
803215142e
convert INetURLObject::EncodeMechanism to scoped enum
...
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05 12:49:02 +02:00
ccda3f37a4
loplugin:unnecessaryoverride (dtors) in forms
...
Change-Id: Ia6787aa9dc7963b1e44604f22bfc95e0333a7f79
2016-12-05 09:03:49 +01:00
66ccfcd290
remove use of tryPropertyValue Any specialisation
...
change return value of getCurrentMultiValue from Any<Sequence<Any> >
to Sequence<Any>.
return value of getCurrentSingleValue (Any of connectivity::ORowSetValue)
can't be changed to use tryPropertyValue.
inline functionality
Change-Id: I3180cf5b9e63a3da9257b03ba02967a2d5402ec3
Reviewed-on: https://gerrit.libreoffice.org/30091
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2016-11-21 14:36:11 +00:00
bb674aa550
loplugin:unusedfields
...
Change-Id: Id2dbbf384637223db3d334d95332251832918003
Reviewed-on: https://gerrit.libreoffice.org/30927
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-17 13:10:42 +00:00
1ba4bb6397
loplugin:countusersofdefaultparams in editeng..rsc
...
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-11 12:12:22 +02:00
389999abdb
make comphelper::containerToSequence a little smarter
...
So we don't have to specify the source and destination type as often.
Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624
Reviewed-on: https://gerrit.libreoffice.org/30700
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-09 07:48:18 +00:00
bbf6c51717
loplugin:expandablemethods in forms..formula
...
Change-Id: Idc948ad06913def28cb642c3a4e5ea9322b9fb3b
Reviewed-on: https://gerrit.libreoffice.org/30688
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-08 09:49:48 +00:00
c123c528bf
loplugin:unnecessaryvirtual in comphelper..forms
...
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd
Reviewed-on: https://gerrit.libreoffice.org/30679
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-08 06:57:57 +00:00
8a22bc93e0
update unnecessaryoverride plugin to find pure forwarding methods
...
which can be replaced with using declarations.
Is there a more efficient way to code the search? Seems to slow the
build down a little.
Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f
Reviewed-on: https://gerrit.libreoffice.org/30157
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-28 12:56:17 +00:00
798c107a1a
coverity#1374310 Uncaught exception
...
Change-Id: Ie0ae4412d42d15e2c6c52a8cb0b7b3893405a16b
2016-10-27 21:47:03 +01:00
f20a45808f
coverity#1374311 Uncaught exception
...
Change-Id: I3f0e2fdfbf3c0517593ef87bc7bcbfe2ee693eef
2016-10-27 21:46:19 +01:00
7580c5e5bd
coverity#1374312 Uncaught exception
...
Change-Id: I901c5399cdc33d55c4d3bdfa7a566adc74340405
2016-10-27 21:45:06 +01:00
3cc1a10c7b
coverity#1374313 Uncaught exception
...
Change-Id: I9562deb23324f44b16735b0d376b4c37e20c58c1
2016-10-27 21:41:47 +01:00
db337150cd
coverity#1374315 Uncaught exception
...
Change-Id: Id7a01c652d1d11675b87ee732ff40ddd76de6236
2016-10-27 21:37:42 +01:00
6e14070332
coverity#1374316 Uncaught exception
...
Change-Id: I32f872d74f167604de006f1d77a9219a37011bfa
2016-10-27 21:34:57 +01:00
95af8bfcdf
coverity#1374286 Uncaught exception
...
Change-Id: Ied3abcd1f2bd7754e3861905f441c46f828f7f5d
2016-10-26 09:56:30 +01:00
b23e979157
coverity#1374281 Uncaught exception
...
Change-Id: Iaffb4b67c67b5877a5a53d9ae81927b28883fc56
2016-10-26 09:56:30 +01:00
77c3b365c6
coverity#1374280 Uncaught exception
...
Change-Id: I18f7f006256ac7df575d9235e7121b45fbd05370
2016-10-26 09:56:30 +01:00
f96f2adc28
coverity#1374279 Uncaught exception
...
Change-Id: I5818bb0a2fe64fd808de5ca7f6d8393f92ab55e2
2016-10-26 09:56:30 +01:00
b1de670d6a
coverity#1374278 Uncaught exception
...
Change-Id: Ide557d1a3237c36067107d357ac2df6186994e10
2016-10-26 09:56:30 +01:00
1ae7f7fcae
coverity#1374277 Uncaught exception
...
Change-Id: I2475056682252111af78a7594c04d15a93fda47f
2016-10-26 09:56:30 +01:00
487738732b
coverity#1374276 Uncaught exception
...
Change-Id: I0572e4365831cf0be2b73c5255812aaf4516ccb0
2016-10-26 09:56:30 +01:00
9b6cb97e43
coverity#1374275 Uncaught exception
...
Change-Id: I6fcc5d75d8a4b131dc4e3b2e294761b152763a1b
2016-10-26 09:56:30 +01:00
adf3ec2032
coverity#1374274 Uncaught exception
...
Change-Id: I9e3cee79dfdc06c751d1e5b3d0806c49a7e30da7
2016-10-26 09:56:30 +01:00
0aa597d063
coverity#1374273 Uncaught exception
...
Change-Id: Ia2738aeb9d1092dd0738801022c5a729b9081f26
2016-10-26 09:56:30 +01:00
0b069a35d3
coverity#1374272 Uncaught exception
...
Change-Id: Iea7cb5d35e78b89398e8aca7bbdbd17015cb7120
2016-10-26 09:56:30 +01:00
759c585e0c
coverity#1374271 Uncaught exception
...
Change-Id: I043cd76ae0da65cac09130f0e761266fd8730be6
2016-10-26 09:56:30 +01:00
07385355db
coverity#1374270 Uncaught exception
...
Change-Id: Ia29b644748f00aa7dc31af9ccc510976d8646241
2016-10-26 09:56:30 +01:00
ae68c27457
coverity#1374269 Uncaught exception
...
Change-Id: Ib3a876ea6463396784062bd53bfedff177818498
2016-10-26 09:56:30 +01:00
0aa24916cb
loplugin:expandablemethodds in filter..forms
...
Change-Id: Ic1f64f804acc10b1a48d82de9fc6a2b39af465a0
Reviewed-on: https://gerrit.libreoffice.org/30014
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-19 06:32:58 +00:00
d1ea6ecda6
replace <<= with assign for <<= with rhs Any
...
found by deleting specialization of '<<=' template
Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c
Reviewed-on: https://gerrit.libreoffice.org/29956
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2016-10-18 19:16:44 +00:00
7cf9028d3b
loplugin:unnecessaryoverride in forms/framework
...
Change-Id: Ia2aabec5af5559903be09e1ef81d156a7538ab3f
2016-10-05 13:53:28 +02:00
106ea87205
Remove _TYPED suffix from tools/link.hxx macros
...
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173
"remove untyped Link<>" removed the old versions.
Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-05 07:56:12 +02:00
d9da9a6e4d
Drop redundant cast
...
Change-Id: Ief00bc6e82cd4e54602e069c0bafd1dfc7bdd2ff
2016-09-16 06:25:16 +09:00
b647996a9b
replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)
...
... except in include/rtl, include/sal, include/uno, where sal_Size is
retained for compatibility, and where callers of rtl functions pass in
pointers that are incompatible on MSVC.
Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-15 12:01:11 +02:00
91dd2db17b
loplugin:override: No more need for the "MSVC dtor override" workaround
...
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
a6bc2ace5f
coverity#1372386 Uncaught exception
...
Change-Id: Ic1fd5486e6b26718086d2f062459f11c00f244d2
2016-09-01 10:40:14 +01:00
33b38082ca
put StreamMode masks in scope of enum class
...
Change-Id: I77682f7e289a59b986bb84edf014029a20266470
Reviewed-on: https://gerrit.libreoffice.org/28420
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-08-27 12:06:15 +00:00
8806a86c9d
loplugin:unusedenumconstants in forms..sot
...
Change-Id: Ic445e1bdd012c32ef7d84aec9df908467c3296a7
Reviewed-on: https://gerrit.libreoffice.org/28055
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-08-12 06:53:29 +00:00
b4e12269e8
loplugin:countusersofdefaultparams in editeng..fpicker
...
Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68
Reviewed-on: https://gerrit.libreoffice.org/27897
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-08-05 11:54:17 +00:00
36313d93ac
improve unnecessaryoverride plugin
...
to ignore ImplicitCastExpr when calling superclass method
Change-Id: I76a3068446acfee85aa1baeb216e57f63c7099c1
Reviewed-on: https://gerrit.libreoffice.org/27279
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-07-19 05:39:46 +00:00
018e89337d
Improve loplugin:unnecessaryoverride
...
<sberg> thorsten, remember what that "TODO" in
SvxAccessibleTextPropertySet::getSupportedServiceNames was to be about exactly,
in a909acb7009acadffa53e74ea05ddb88803490f1 ?
<thorsten> sberg: that's a nonsense, prolly copy'n'pasted, or a 'please review
me'
<sberg> thorsten, OK, thanks (that override will eventually go away with
loplugin:unnecessaryoverride, and the TODO comment be lost)
Change-Id: Iba964c61768459aac4067bbd4e1f7d4f78f6adac
Reviewed-on: https://gerrit.libreoffice.org/27232
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-07-15 14:08:07 +00:00
6e72f0251b
new loplugin unnecessary override
...
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-07-15 14:05:41 +00:00
cd71034b26
comphelper::OBaseMutex -> cppu::BaseMutex
...
convert usage of deprecated class, and remove the old class
Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2
Reviewed-on: https://gerrit.libreoffice.org/26843
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-07-04 06:49:07 +00:00
82da3d95c1
loplugin:salbool: Implicit conversions from non-Boolean fundamental types
...
Change-Id: I67eac95686678e6f5a2d60798535b2c65a9ba5d7
2016-06-19 21:29:43 +02:00
9741e7a437
Clean up uses of Any::getValue() in forms
...
Change-Id: I335aabc92ecb5de107dad3ecdfa6e025ec0d1b0f
2016-06-10 18:55:13 +02:00
6cd3882bec
remove some manual ref-counting in forms
...
Change-Id: I6334dca6e98bfd4531033bec203518ca27f64bc0
Reviewed-on: https://gerrit.libreoffice.org/26049
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-08 10:32:56 +00:00