Commit Graph

688 Commits

Author SHA1 Message Date
b36bf9f567 check length of string as this can be called untokenized, tdf#105024 related
i.e. during import of ODFF

Change-Id: I7f5419d393f89d8a84efca7444e8dde3a3e9199f
2017-01-06 18:29:16 +01:00
6b89bcf85a check "#ERRxxx!" constants for accepted error values, tdf#105024 follow-up
Change-Id: I9a11695710baa2f4e022c8e07f01b962cfabe2e7
2017-01-05 18:23:45 +01:00
857be5b2db Resolves: tdf#105024 generate and parse detailed "#ERRxxx!" error constants
Change-Id: I4e5d98cdbbc2f3e7746cd3892f70151376bc5808
2017-01-05 18:23:45 +01:00
39a33a548b Rewrite some (trivial) assignments inside if/while conditions: formula
Change-Id: I28d41341607abae82a3bc5d9cacdb70e7431be18
2016-11-29 17:20:52 +01:00
6bb20609a2 vcl: rename Window::Notify to EventNotify
There is annoying overloading between Window::Notify and
SfxListener::Notify, and the Window one has apparently fewer
implementations, so rename that and remove lots of disambiguating
"using Notify" in multiply inheriting classes.

Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-24 22:56:34 +01:00
1ba4bb6397 loplugin:countusersofdefaultparams in editeng..rsc
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-11 12:12:22 +02:00
bbf6c51717 loplugin:expandablemethods in forms..formula
Change-Id: Idc948ad06913def28cb642c3a4e5ea9322b9fb3b
Reviewed-on: https://gerrit.libreoffice.org/30688
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 09:49:48 +00:00
525a45f22f loplugin:unnecessaryvirtual in framework
Change-Id: I893bf955e45e661e3ec440dbd530fca22931c23b
Reviewed-on: https://gerrit.libreoffice.org/30666
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 06:11:28 +00:00
b01c5ae956 loplugin:unusedmethods unused return types
Change-Id: I88204bca60dd1e299b040c52bc87e500cbfaa930
Reviewed-on: https://gerrit.libreoffice.org/30519
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03 11:37:31 +00:00
ffed74ee54 -Werror,-Wunused-private-field
Change-Id: I695b3709c2b53f62773dc390b89966061c7b0ae9
2016-10-30 21:07:52 +01:00
c857e5ef42 display matching search per selected category, tdf#67974 follow-up
Also select category All while typing in Search, and display the LRU list
independently.

Change-Id: I8a734cc202e017d3a10d8a6f89b1814073a77c81
2016-10-29 19:25:49 +02:00
8a0318e4f8 filter hidden functions also in search, tdf#67974 follow-up
Change-Id: Iaa23759e01d8f86bfc5c0bbd8b333cd331b7b8cd
2016-10-29 17:59:05 +02:00
70e97ade2f tdf#67974 UI: Add a search box in function wizard in Spreadsheet
Change-Id: Idd243824a25ba99b2163f094c531dad7fe1153c8
Reviewed-on: https://gerrit.libreoffice.org/30118
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-10-29 15:32:51 +00:00
1276e95193 tdf#103088, improve interoperability with Excel for LOGNORMDIST().
Change-Id: I5f4ccbb54b212247a3ff8b13ff012c930d18a86c
Reviewed-on: https://gerrit.libreoffice.org/30020
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-10-26 11:13:09 +00:00
f23297e111 no Edit controls loaded from .src now
Change-Id: I42c7377c101c642ea39028e05e4ffd58fc7435d7
2016-10-25 11:41:23 +01:00
536258758a tdf#103186, make LOGINV ODFF1.2 compliant.
(Also retain Excel-interoperability and backward compatibility with Calc.)

Change-Id: Ibbe7224eabfb776cf6e7ecfeabae6d188178f4ed
Reviewed-on: https://gerrit.libreoffice.org/29885
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-10-24 12:08:33 +00:00
423936ffac loplugin:expandablemethodds in formula..framework
Change-Id: I6c8b1bb3b664faa92b2dc05955c30bfd35f6dfaa
Reviewed-on: https://gerrit.libreoffice.org/30015
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 07:57:11 +00:00
e944d95104 tdf#93894: Prohibit grouping when certain token types are present.
For instance, column / row label tokens don't work correctly in
grouped cells with the current implementation.

Change-Id: Idf86312ef15fbfd4382aa90ee6d131c671a80683
2016-10-18 20:27:16 -04:00
cf43ff5262 tdf#102948 Make HYPGEOMDIST ODFF1.2 compliant.
Also reduce duplicate code.
On Export to OOXML, HYPGEOMDIST is converted to HYPGEOM.DIST.

Change-Id: I70a70ee6b5c542e272ef574073ebcd1924f31083
Reviewed-on: https://gerrit.libreoffice.org/29767
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-10-14 15:23:57 +00:00
6e57881e99 I can't see any evidence of any remaining magenta mask using image resources
Change-Id: I12865d743daa3e6479edb60584d5bd01f88e818d
2016-10-06 15:09:22 +01:00
306add13e1 convert the last two lonely FixedInfos to FixedText
Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
2016-10-05 16:02:59 +01:00
954f752cf1 convert MapUnit to scoped enum
I left a prefix on the names "Map" so that I would not have to re-arrange
each name too much, since I can't start identifiers with digits like "100thMM"

And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore.

Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224
Reviewed-on: https://gerrit.libreoffice.org/29096
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05 06:51:20 +00:00
106ea87205 Remove _TYPED suffix from tools/link.hxx macros
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-05 07:56:12 +02:00
3e22dfa5eb convert formula error codes to scoped enum
Change-Id: I5ff214bf1ec9031e30344bc125bc99916fd11bfb
Reviewed-on: https://gerrit.libreoffice.org/28897
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-09-23 15:22:38 +00:00
96e9ffa647 loplogin:singlevalfields in include/
Change-Id: I27842162fcf82120ecb811ee8e89e187430931fc
Reviewed-on: https://gerrit.libreoffice.org/28931
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16 06:19:38 +00:00
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
f551477ab3 handle overwriting of symbols/opcodes in symbol map for known cases
This silences the SAL_WARN_IF like
warn:formula.core:6944:1:formula/source/core/api/FormulaCompiler.cxx:625:
OpCodeMap::putOpCode: reusing OpCode 161,
replacing '_xlfn.ORG.OPENOFFICE.ERRORTYPE' with 'ERRORTYPE'
in English map 0x1018000

that occurred during the first load of OOXML .xlsx documents since the
old bad entries were added with commit
89c4a69103b6e15e7f52401c51110b926c3ccf36

In fact the direction opcode -> string was replaced, which it should had
not. That specific mapping is only used though when loading msoxl
namespace formulas from ODF.

Also, the replacement of parameter separator and array column and row
separator worked merely by chance, depending on in which order the
entries where inserted to the hash map. Fixed along as it popped up with
the new handling.

Change-Id: I88017a8b38ccc30874c3dca7d78f0fa47a77a36f
2016-08-26 16:46:12 +02:00
b4e12269e8 loplugin:countusersofdefaultparams in editeng..fpicker
Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68
Reviewed-on: https://gerrit.libreoffice.org/27897
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05 11:54:17 +00:00
ced79363cc Resolves: tdf#69539 UI rename CONVERT to CONVERT_OOO, CONVERT_ADD to CONVERT
... with same syntax but different semantics that was even more confusing.

Change-Id: Ibe1efcd5c4e82c9ce8d9fe8ed0f85e86dac327f7
2016-08-03 18:57:37 +02:00
fa2fdb6607 rename ocConvert to ocConvertOOo and related
... to clarify that this is not the "real" CONVERT function.

Change-Id: Ia71949ffabd2c983be0dbf9fa36bb8c52f0077ee
2016-08-03 18:57:37 +02:00
dbbab7b1b0 UI rename DURATION to PDURATION, DURATION_ADD to DURATION, tdf#50488 related
Change-Id: I7ba783b59a711fc9c9d6bbe68dcf8c3c1a0d409d
2016-08-03 17:08:36 +02:00
3bc16f4a47 rename ocDuration to ocPDuration and related
... to clarify that these belong to PDURATION (currently DURATION in UI)
instead of DURATION (currently DURATION_ADD in UI). The confusing UI name
situation will be resolved separately.

Change-Id: I09a7bc8437be1c4c9e72f94e61c877111fb48806
2016-08-03 16:39:41 +02:00
4afd35f691 use GRAM_API instead of GRAM_PODF_A1 in API context
... which right now is identical but may get corrections in future.

Change-Id: Id4e1707afb32a3d8e073705072e5e65105f2a14a
2016-08-03 15:16:50 +02:00
f21a73bc5b InitSymbolsAPI() for FormulaLanguage::API
Change-Id: I203557ed50d0d54fe9977e3d51e7f979551b472b
2016-08-03 15:16:50 +02:00
41eb7eef76 introduce formula::FormulaGrammar::Grammar::GRAM_API
Change-Id: Iceaf114847129f0b014ffd61d547e131baf1f07b
2016-08-03 15:16:50 +02:00
a859c37ee0 introduce mxSymbolsAPI and InitSymbolsAPI()
Change-Id: I1c4673a25bb0f686e0705f87318a04166e6688bb
2016-08-02 00:25:35 +02:00
fc5342fb30 InitSymbolsPODF() from RID_STRLIST_FUNCTION_NAMES_ENGLISH_PODF
Change-Id: I03f8d183303b869a4cfaa76ea4170da95574e5d5
2016-08-02 00:25:35 +02:00
e128d2afa3 prepare to disentangle RID_STRLIST_FUNCTION_NAMES_ENGLISH
RID_STRLIST_FUNCTION_NAMES_ENGLISH grew to a conglomerate of English UI names,
names used in PODF (ODF 1.0/1.1) and XFunctionAccess API names. Copy it to
independent resources so we can start to correct names in English UI, keep PODF
oddnesses and cater for API compatibility needs.

Change-Id: I7c2053d7627c4da220d8fc991158e8e7a81f0b37
2016-08-02 00:25:34 +02:00
28a63715f4 keep a broken expression as originally broken
The invalid expression ISOWEEKNUM(A1,0+) lead to a replacement with
ISOWEEKNUM(A1+) which of course is also wrong but loses the original
context. Just exchange the call and convert to WEEKNUM_OOO(A1,0+)
without fiddling with the parameters.

Change-Id: Id1c42d3ba084382e09c164b6c35db996f2b0197a
2016-08-01 20:31:39 +02:00
2e3bc9fcee refine ISOWEEKNUM vs WEEKNUM_OOO detection
Change-Id: I7cf5d51946235ea1bc6a4d0999fa98e1a3f8a095
2016-08-01 18:12:29 +02:00
508c95f1b6 improve passstuffbyref return analysis
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27 06:48:25 +00:00
f7803b302a loplugin:commaoperator
Change-Id: I7ba83b999b3b12411348c21cabcd47b8ad9c4034
2016-07-15 10:53:25 +02:00
fc305bb6d6 strip second parameter from ISOWEEKNUM if literal double != 1.0
For other arguments convert to WEEKNUM_OOO, which now can be saved as
ORG.LIBREOFFICE.WEEKNUM_OOO.

Change-Id: I63fd3df1ec4ccaa535a1437200854d8734544a2c
2016-07-14 23:16:49 +02:00
77ccf8a9ca store WEEKNUM_OOO as ORG.LIBREOFFICE.WEEKNUM_OOO
Now that the previous two releases can read it.

Change-Id: Ie04c7b0fd94f5906b678d738370e4fc0696da79c
2016-07-14 23:13:41 +02:00
908449639b let FormulaTokenArray::RemoveToken() return the actual count of tokens removed
Change-Id: Iebf654e7b4c682036b4ff334298948557b755eac
2016-07-14 22:31:20 +02:00
f9021f7eea re-add FormulaTokenArray::ReplaceToken() that was removed as unused, grml..
with 4ff5a5558472beee85eb1234dcc2aa2ed9000f6c

Change-Id: Id99c3ae74515f24c55a3734698c560dcac8bacd9
2016-07-14 22:26:25 +02:00
69a3f884a5 yet more functions to save with prefix and namespace to OOXML
MULTIRANGE, GOALSEEK, EASTERSUNDAY, CURRENT and STYLE are LibreOffice /
OpenOffice.org only and need a _xlfn.ORG.OPENOFFICE. prefix and namespace when
saved to OOXML.

Change-Id: Ie5d4eb14b1ec958f9ebec5f149d0d1d7b4dd644e
2016-07-14 20:25:36 +02:00
feef105196 save ERRORTYPE as _xlfn.ORG.OPENOFFICE.ERRORTYPE to OOXML
Was wrongly saved as ERRORTYPE without _xlfn. prefix and namespace.
Be able to still read ERRORTYPE.

Change-Id: Ia028fe06d930f60b4260adf589ee3190b90ea099
2016-07-14 18:19:00 +02:00
7855ea4830 remove comphelper::string::remove
and replace it with OUString/OString::replaceAll

Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a
Reviewed-on: https://gerrit.libreoffice.org/26850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04 06:49:52 +00:00
2795cb694b add an isPODF() block to ScCompiler::IsOpCode(), tdf#100641 related
... as we can't rename RID_STRLIST_FUNCTION_NAMES_ENGLISH names.

Should we need yet another resource block to differentiate between
PODF/API names and actual always available English names? Ugly but
maybe. A much better approach would be if Text[en-US] would be always
available, additionally to the current localized resource.

Change-Id: If8eaf18643f4e24c811149c52efff1097a3c1596
2016-06-27 17:24:20 +02:00