21033d04fd
Clean up a usage of OUStringBuffer
...
Change-Id: I8435865f1a67a3a6d889c1b8a3d30e632ffc61fd
2017-01-05 14:24:28 +01:00
385f624027
Prevent use of ORowSetValue with sal_Bool as TINYINT
...
sal_Bool and sal_uInt8 are typedefs for the same underlying type, so any use of
ORowSetValue with sal_Bool instead of bool, apparently intending to treat the
value as a boolean, actually treated it as a TINYINT. (See e.g. recent
7b0c57b2faec875c790051d233d1e9abaed2a3bc "some compilers don't like implicit
bool-to-ORowSetValue conversion".)
Now that there's no way to create a sal_uInt8 ORowSetValue, getUInt8 and the
m_uInt8 union member can probably go away, too.
Change-Id: Ia27554f76e7e9edce6410284b578064573e54fd3
Reviewed-on: https://gerrit.libreoffice.org/31909
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2016-12-12 18:02:57 +00:00
d1a9c73ea1
tdf#88206 replace cppu::WeakImplHelper* misc
...
also edited two examples in canvas comments
Change-Id: Iac82b462168f869f995c33bb2c639f3dbe09cbd5
Reviewed-on: https://gerrit.libreoffice.org/31715
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-12-07 10:56:36 +00:00
0c6c37cb01
cleanup unused includes (related to tdf#88206)
...
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx
compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only
implbase*.hxx stuff is used.
Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995
Reviewed-on: https://gerrit.libreoffice.org/31686
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-06 18:17:06 +00:00
0a840edcc1
includes should be at the top of the file
...
not randomly scattered through the code
found with something like:
git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include"
Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351
Reviewed-on: https://gerrit.libreoffice.org/30952
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-18 09:25:06 +00:00
0d05173015
loplugin:constantparam
...
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0
Reviewed-on: https://gerrit.libreoffice.org/30858
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-15 12:56:26 +00:00
5c2c2d8dc4
loplugin:expandablemethods in comphelper..cppuhelper
...
Change-Id: I9d5487af4729bd3ee4f6450092e4b77f74a12e6d
Reviewed-on: https://gerrit.libreoffice.org/30717
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-10 06:51:53 +00:00
c123c528bf
loplugin:unnecessaryvirtual in comphelper..forms
...
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd
Reviewed-on: https://gerrit.libreoffice.org/30679
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-08 06:57:57 +00:00
807151aa13
coverity#1371275 Missing move assignment operator
...
Change-Id: I6c47c797d2654506bdc95c35b2558ce812f4070d
2016-10-28 10:09:32 +01:00
e4cb0742c8
loplugin:expandablemethodds in include/connectivity..drawinglayer
...
Change-Id: Ic58f86422ef8f1e2bb655157850e214fc3a1a9b4
Reviewed-on: https://gerrit.libreoffice.org/30136
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-23 12:09:33 +00:00
62223f9a8a
loplugin:unnecessaryoverride
...
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae
Reviewed-on: https://gerrit.libreoffice.org/29656
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-13 06:47:44 +00:00
1e49e33c26
loplugin:constantparam in chart2..connectivity
...
Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d
Reviewed-on: https://gerrit.libreoffice.org/28834
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-09-14 06:40:30 +00:00
91dd2db17b
loplugin:override: No more need for the "MSVC dtor override" workaround
...
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
98ce52b678
coverity#1372406 Uncaught exception
...
Change-Id: I24fe9cb3aa9002d4b94b6f934e39aff243c1e09d
2016-09-01 10:40:14 +01:00
321d5970c6
coverity#1372402 Uncaught exception
...
Change-Id: I63743ccdeca1be66da5622bd286f08daebdd74ff
2016-09-01 10:40:14 +01:00
9fda8f5ad6
fix move operator= and add move constructors
...
followup to:
19828cc0 "cid#1371315 Missing move assignment operator"
and
0e748707 "cid#1371320 Missing move assignment operator"
Change-Id: Id2479fef41cf8d98eef9246f3a86e6c9289c3d58
2016-08-25 12:05:59 +02:00
0e74870782
cid#1371320 Missing move assignment operator
...
Change-Id: I34da999f516abedd65135f67e7479706e64e7b20
Reviewed-on: https://gerrit.libreoffice.org/28376
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-08-25 09:37:00 +00:00
b8064bdf7f
new loplugin: countusersofdefaultparams
...
Change-Id: I79e2c690f3e664c14af12cf763dd5a8ac20d6b04
Reviewed-on: https://gerrit.libreoffice.org/28353
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-08-25 06:37:42 +00:00
8f30da6386
Some clang-tidy misc-move-constructor-init
...
...by turning the relevant ctor parameters into "const &".
Change-Id: Ia8d0aba5da10ad6b25f8689e2281e45b3d71c1fc
2016-08-19 16:55:06 +02:00
508c95f1b6
improve passstuffbyref return analysis
...
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-07-27 06:48:25 +00:00
6e72f0251b
new loplugin unnecessary override
...
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-07-15 14:05:41 +00:00
a6060e02f7
Fix typo relase_ChildImpl -> release_ChildImpl
...
Change-Id: I68faf8cfb8eb390e7970383b8a6596a9dd3f95f7
2016-07-12 15:57:36 +02:00
9624bde1c3
tdf#100866: Don't let exception pass connectivity::release
...
...which is only ever called from onexcept XInterface::release overrides:
connectivity::release itself appears to be only called from
connectivity::OSubComponent::relase_ChildImpl [sic], which in turn is only
called from various XInterface::release overrides across connectivity.
Change-Id: I94b682ec531acecd0ef9f8c100f67a71c361941e
2016-07-12 15:05:41 +02:00
cd71034b26
comphelper::OBaseMutex -> cppu::BaseMutex
...
convert usage of deprecated class, and remove the old class
Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2
Reviewed-on: https://gerrit.libreoffice.org/26843
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-07-04 06:49:07 +00:00
cdb4efad0e
connectivity: disable connectivity::release() for now
...
This bizarre thing essentially does the same as
WeakComponentImplHelperBase::release(), except that
1) it forgets to call disposeWeakConnectionPoint()
2) it doesn't catch exceptions from dispose()
3) it restores the m_xParent member after the dispose() call
4) it's racy because the "else" branch may be executed at a time
when another thread has already concurrently deleted the object
This is rather mysterious and there is no obvious reason why a manual
dispose() call should clear m_xParent (as the users tend to do, by calling
dispose_ChildImpl() from their disposing()), but a dispose() called from
release() should restore m_xParent again.
Let's try to stop doing this madness and see if anything breaks.
Change-Id: I88a60fe1a7eeb625442faf436c9a3deb3c59941c
Reviewed-on: https://gerrit.libreoffice.org/26554
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2016-06-21 19:44:32 +00:00
4d49c9601c
Let loplugin:passstuffbyref also look at fn defn not preceded by any decl
...
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-08 17:14:34 +02:00
22fa9289fd
tdf#96099 Remove various smart pointer typedefs
...
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f
Reviewed-on: https://gerrit.libreoffice.org/26014
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-08 11:09:44 +00:00
d0bc637426
Normalize on using @throws instead of @raise[s]
...
...as the former is used almost exclusively
Change-Id: I38ff11cd0d5125534550df99dd427666011c3b7b
2016-06-06 17:07:35 +02:00
8a9559c59c
tdf#89329: use unique_ptr for pImpl in TColumnHelper
...
Change-Id: I4a7594cb2a9424fddbd79e2b5d77431bf329eec9
Reviewed-on: https://gerrit.libreoffice.org/25903
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-06 07:08:18 +00:00
8a2149c105
clang-tidy misc-assign-operator-signature
...
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f
Reviewed-on: https://gerrit.libreoffice.org/25154
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-20 07:55:30 +00:00
2c8fe2e737
update unusedmethods plugin to deal with constructors
...
and fix the operator< implementations in some of the other
plugins too.
Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-18 10:03:44 +00:00
f3d9aab841
teach passstuffbyref plugin to check for..
...
unnecessarily passing primitives by const ref.
Suggested by Tor Lillqvist
Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6
Reviewed-on: https://gerrit.libreoffice.org/24672
Reviewed-by: Tor Lillqvist <tml@collabora.com >
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-06 06:48:38 +00:00
d916619658
No need to explicitly delete ctor the compiler wouldn't implicitly declare
...
Change-Id: Idd0e764765bd76e1f6a2d8ec6e18ebac27b91ec6
2016-05-04 14:24:47 +02:00
12c222a3ae
C++11: disable ctors with delete in include/
...
replace the old declare and don't implement pattern
with C++11 delete keyword
no need to hide this design choice behind access restrictions
Change-Id: I7e8430a07189aa48514a4613c3a8c2950b230f49
Reviewed-on: https://gerrit.libreoffice.org/24495
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2016-05-03 20:12:22 +00:00
ef26856260
loplugin:passstuffbyref in connectivity
...
Change-Id: I751977ecc1b532f72dd5673767471cb0a2cdbd06
2016-04-13 13:27:51 +02:00
4c7ec9f112
cleanup: remove unused com/sun/star/uno includes
...
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.
Add a few missing includes provided by them.
Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-12 06:38:26 +00:00
f3120c0aa8
clang-tidy performance-unnecessary-value-param in connectivity
...
Change-Id: Ie84eeac24f22c5e3d3a4f63728a73023d626ccc0
2016-04-11 11:38:57 +02:00
5aadbc15a5
Avoid reserved identifiers
...
Change-Id: I2217920ced336189a94c0a5d1e3ac0ccd3912881
2016-04-06 15:31:06 +02:00
576ab77255
tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionals
...
I either replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0
statements or i used SAL_INFO(..)s
Change-Id: Iefb6b83e86e1767e55600b6e1989ee91207fb220
Reviewed-on: https://gerrit.libreoffice.org/23000
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: jan iversen <jani@documentfoundation.org >
2016-03-08 13:31:09 +00:00
359e0b47a0
loplugin:unuseddefaultparams
...
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795
Reviewed-on: https://gerrit.libreoffice.org/22971
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-03-07 09:16:00 +00:00
37a6bafea8
loplugin:unuseddefaultparam in various
...
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0
Reviewed-on: https://gerrit.libreoffice.org/22900
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-03-07 05:56:59 +00:00
a9b7c6f4b7
loplugin:unuseddefaultparams in include/filter
...
Change-Id: I893b50835717d449e495e00e9b33de0b60467a6e
2016-03-03 11:15:52 +02:00
414a66587b
convert StandardSQLState to scoped enum
...
Change-Id: Ia0a1526140cfed35a73a6fea1a173d2fb5005960
2016-02-25 13:50:26 +02:00
960d4ebf76
convert SQLNodeType to scoped enum
...
Change-Id: I622e55622d38e6017993c8bc52625c85d0f74d74
2016-02-25 13:50:26 +02:00
aa0a20bdcc
convert TraversalParts to scoped enum
...
Change-Id: I34797d6ccdf8b9c75004c129056f3a09f169e1b4
2016-02-25 13:50:25 +02:00
d6c28b11e5
convert OSQLStatementType to scoped enum
...
Change-Id: I2df117cf0f405e88899e7ccab380156284720449
2016-02-25 13:50:25 +02:00
049d9a8161
convert ParameterClassification to scoped enum
...
Change-Id: Iab3d2db50acc1f70b352dd0fd5f1270693a8e991
2016-02-25 13:50:25 +02:00
ccb8b83070
convert FilterComponent to scoped enum
...
and simplify the overly-general logic in FilterManager
Change-Id: I2cbd9db6a53894cd13713a5cc0d1807cec456848
2016-02-25 13:50:25 +02:00
bf7690bc1b
convert EComposeRule to scoped enum
...
Change-Id: I5a2e4f6f6f0f353c75dff85e865608b12c2104f9
2016-02-25 13:50:25 +02:00
761e55d368
convert SQLExceptionInfo::TYPE to scoped enum
...
Change-Id: I2f21a742bc649fc42f89aebac2691c6054cd20d8
2016-02-25 13:50:25 +02:00
