wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
401,915 Commits 5 Branches 0 Tags
5e355dabccdbaa94de8897edc1fd88b16993b493
Commit Graph

174 Commits

Author SHA1 Message Date
Noel Grandin
f9fd6390cd ScrollableWrapper -> ScrollableDialog 
no point in having a template and a virtual base class when it's only
used for one type

Change-Id: Idb1a1a551064cc10896eff33652038eb5be0297e
Reviewed-on: https://gerrit.libreoffice.org/32041
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-19 06:04:33 +00:00
Jochen Nitschke
43de0518bc tdf#88206 replace cppu::WeakImplHelper* in toolkit 
Change-Id: I89713755023ea003559cc76fb77eb97de2135cae
Reviewed-on: https://gerrit.libreoffice.org/31696
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-07 06:40:04 +00:00
Jochen Nitschke
0c6c37cb01 cleanup unused includes (related to tdf#88206) 
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx

compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only
implbase*.hxx stuff is used.

Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995
Reviewed-on: https://gerrit.libreoffice.org/31686
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-06 18:17:06 +00:00
Caolán McNamara
6f71fa11c0 vcl makes no use of menu Get/Set DefaultItem 
this is exposed through uno however, so move it into VCLXMenu to continue to
support it doing nothing of great value there

Change-Id: I6888e61cbec85faa2d1fcca8731ab42023e594c6
 2016-11-24 14:56:13 +00:00
Noel Grandin
0a840edcc1 includes should be at the top of the file 
not randomly scattered through the code

found with something like:
   git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include"

Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351
Reviewed-on: https://gerrit.libreoffice.org/30952
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-18 09:25:06 +00:00
David Tardon
27a165cfc9 drop useless semicolons 
Change-Id: I039f8ff491b42ea9c3936bf13922df8095434228
 2016-11-13 19:08:22 +01:00
Noel Grandin
0f96b3f33f loplugin:unnecessaryvirtual in test..vbahelper 
Change-Id: I0e110af6eab798e11f96d0f7d282d59440d91965
Reviewed-on: https://gerrit.libreoffice.org/30649
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 10:11:33 +00:00
Noel Grandin
e5c1e15eda loplugin:expandablemethods in toolkit..tools 
Change-Id: I7221bf131d28804ee93474b11973bbc066cc2764
Reviewed-on: https://gerrit.libreoffice.org/30268
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-26 06:50:03 +00:00
Noel Grandin
62223f9a8a loplugin:unnecessaryoverride 
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae
Reviewed-on: https://gerrit.libreoffice.org/29656
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-13 06:47:44 +00:00
Stephan Bergmann
106ea87205 Remove _TYPED suffix from tools/link.hxx macros 
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
 2016-10-05 07:56:12 +02:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin
c158c00489 loplugin:constantparam in framework..vbahelper 
Change-Id: I592f73012ae8a4df8488ef04dc0956d9400625bc
 2016-09-07 10:04:44 +02:00
Noel Grandin
3069878c60 std::list<sal_uInt16> -> vector 
Change-Id: Ic08ac3fcb750ceff1f5b3201d4a3151ad567aa1f
 2016-09-01 11:05:21 +02:00
Noel Grandin
508c95f1b6 improve passstuffbyref return analysis 
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:48:25 +00:00
Noel Grandin
20b9cbd0e5 merge toolkit::NameContainer_Impl with toolkit::ScriptEventContainer 
Change-Id: I14e9401056e31ee9d4ad5945a73ca31969430b4c
Reviewed-on: https://gerrit.libreoffice.org/26891
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-04 10:55:08 +00:00
Noel Grandin
aa0d0536a4 tdf#97527 - vcl: reference-count Menu 
some places are marked with "dodgy"- need to check those to see
what is going on, because they are leaving dangling pointers behind
in the Menu class

Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b
Reviewed-on: https://gerrit.libreoffice.org/26516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-23 06:28:00 +00:00
Noel Grandin
c6075095dd loplugin:passstuffbyref in toolkit 
Change-Id: I0f44beaec29a24e81e3c3ccace00013091eeae92
 2016-04-14 09:21:39 +02:00
Noel Grandin
28c96a0910 clang-tidy performance-unnecessary-value-param in toolkit 
Change-Id: Ic08723ef15f2bc31031e3887b9916ecc7e2205da
 2016-04-11 15:12:10 +02:00
Noel Grandin
fd4b1fb453 sequence->vector in toolkit 
Change-Id: Ia042eea672bb7535192132ae0b133d1745dc8cde
Reviewed-on: https://gerrit.libreoffice.org/23759
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-04 09:16:31 +00:00
Stephan Bergmann
19a5374b06 Avoid reserved identifiers 
Change-Id: I52cab3f30c5a1365dd51d7db2c2cf2b3a609fa11
 2016-03-10 18:32:09 +01:00
Noel Grandin
c3a3e646c9 loplugin:constantparam in toolkit 
Change-Id: I45d6c37bfe17ef686b50d688698bcc3a7f3cc311
 2016-03-10 10:09:59 +02:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Stephan Bergmann
cd5431c071 Unwind trivial AccessibleExtendedComponentHelper_BASE typedefs 
Change-Id: I74b30cba1359045873a3d7a3f0e72f857ffa0ed0
 2016-01-27 10:23:48 +01:00
Noel Grandin
752cd07d08 InterfaceContainer2 with vector instead of Sequence 
create an InterfaceContainer2 class to replace InterfaceContainer.
It uses a std::vector instead of a Sequence for the mutable listener
list, which provides far better performance.

Switch all our internal use-sites to the new class.

Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
 2016-01-25 08:52:03 +02:00
Michael Meeks
7576f27325 tdf#94715 - ensure we remove ourselves from the same event source. 
Seemingly event removal was not occuring; also clean up historic
duplication of UNO and C++ references using rtl::Reference.

Change-Id: I56dfb76501929886f70495804670f8c4f70e796b
Reviewed-on: https://gerrit.libreoffice.org/21088
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
 2016-01-05 10:21:07 +00:00
Noel Grandin
1dbe54fd2e loplugin:unusedfields in /include 
Change-Id: Ia406e727890a365cc89831c96140cad8240f9b61
 2015-12-23 08:13:53 +02:00
Noel Grandin
631b679529 loplugin:unusedfields in include/toolkit,include/tools 
Change-Id: I22966b66b1b8e4dff2e565de456f21a668f33f28
 2015-11-25 08:25:10 +02:00
Stephan Bergmann
175e2adfd1 loplugin:nullptr (automatic rewrite) 
Change-Id: Ied9204441c07f1f6a6026c8c1a2fa21b93b98e1a
 2015-11-10 10:31:54 +01:00
Caolán McNamara
3f8a28f413 coverity#1338239 Uncaught exception 
Change-Id: I99ea322db83a6deb67483435de1549380bfec7fb
 2015-11-06 12:15:49 +00:00
Noel Grandin
e25669fced don't allocate uno::Reference on the heap 
There is no point, since it's the size of a pointer anyway

(found by temporarily making the new operator in uno::Reference
deleted).

Change-Id: I62a8b957fef9184f65d705600acfdab4116dcb34
Reviewed-on: https://gerrit.libreoffice.org/19603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-27 12:48:50 +00:00
Noel Grandin
3d784c4af6 remove extra spaces around :: 
just makes it harder to grep for methods

Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
 2015-10-26 09:12:05 +02:00
Noel Grandin
c06e2fcc2c com::sun::star->css in include/sot to include/typelib 
Change-Id: I9cd92b53370a6b6018d2f7c648890f9c014a27de
 2015-10-23 10:48:50 +02:00
Matthew J. Francis
59c38539bc Allow injection of keyboard and mouse events through UNO 
Change-Id: I3d139c6378f5274be1e7bfd88f72d1576c13243d
Reviewed-on: https://gerrit.libreoffice.org/19321
Reviewed-by: Matthew Francis <mjay.francis@gmail.com>
Tested-by: Matthew Francis <mjay.francis@gmail.com>
 2015-10-16 12:03:30 +00:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Stephan Bergmann
bff4c13475 Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code 
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
 2015-10-12 17:52:26 +02:00
Noel Grandin
1e67e94f1a convert Link<> to typed 
Change-Id: If3e2b00092440ebd42ae5b73ae2b0e44c3702683
 2015-09-21 08:03:52 +02:00
Noel Grandin
99bfc363a6 convert Link<> to typed 
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511
Reviewed-on: https://gerrit.libreoffice.org/18700
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-20 06:37:36 +00:00
Noel Grandin
71a83295d8 convert Link<> to typed 
and remove unused maChildEventListeners

Change-Id: I845a9af608c3429cf9ccb0e8041f24f423839513
 2015-09-11 08:48:55 +02:00
Noel Grandin
4ea70f87f7 convert Link<> to typed 
Change-Id: I2136c3db2742afcb4722f69297276bea1e0119f4
Reviewed-on: https://gerrit.libreoffice.org/18306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-04 06:31:30 +00:00
Norbert Thiebaud
ef46917ff3 Put Polygon from tools under tools:: namespace 
Polygon is one of these names that Clash with some system objects
A similar work has been done earlier with PolyPolygon.

Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5
Reviewed-on: https://gerrit.libreoffice.org/17789
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2015-08-17 02:07:43 +00:00
Noel Grandin
0ea54aed15 remove some unused defines 
Change-Id: I85a9a2bc12681e13fc482374165ff9bd6858dc93
 2015-08-03 11:12:31 +02:00
Michael Stahl
1841946863 toolkit: replace boost::function with std::function 
Change-Id: I4bf5b2aab1dd76e596c191ae2eec8eb18005b914
 2015-07-31 21:24:24 +02:00
Noel Grandin
38ecca9b30 inline a bunch of use-once macros 
no point in having a macro unless it's actually going to reduce the
number of lines of code

Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
 2015-07-27 08:18:16 +02:00
Noel Grandin
efac5fa06e remove some unused defines 
Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188
Reviewed-on: https://gerrit.libreoffice.org/17332
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-27 06:12:01 +00:00
Noel Grandin
a792aa2c48 loplugin:unusedmethods toolkit,package 
Change-Id: I83618cd2fd12fb0c1691dc7255fc7192e68649cd
Reviewed-on: https://gerrit.libreoffice.org/17031
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-14 09:28:14 +00:00
Andrea Gelmini
420923ba76 Fix typos 
Change-Id: Ie2bbe020fc6e3a4a4f913208c245f395849bb9ee
Reviewed-on: https://gerrit.libreoffice.org/16708
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-07-03 09:32:26 +00:00
Caolán McNamara
7d59a63471 coverity#1308539 Uncaught exception 
Change-Id: Id9cad4eaccd71c769fea06d71bbfdd03e8c112ae
 2015-06-28 17:56:00 +01:00
Andrea Gelmini
ae150c6a54 Fix typos 
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
Reviewed-on: https://gerrit.libreoffice.org/16314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2015-06-18 11:44:56 +00:00
Andrea Gelmini
01532b1ab8 Fix typos 
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072
Reviewed-on: https://gerrit.libreoffice.org/16297
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 11:05:58 +00:00
Noel Grandin
39078c247d cleanup DIALOG_NO_PARENT, follow on to tdf#91090 
remove the DIALOG_NO_PARENT abomination and replace it with a flags
parameter

Change-Id: I71b7dc46c619f2db56af6d4dc2c17daf0a2c8534
Reviewed-on: https://gerrit.libreoffice.org/15645
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2015-05-06 12:12:26 +00:00