wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
401,915 Commits 5 Branches 0 Tags
5e355dabccdbaa94de8897edc1fd88b16993b493
Commit Graph

1231 Commits

Author SHA1 Message Date
Stephan Bergmann
e838e360ff Some loplugin:conststringvar/stringconstant improvements: sdext 
Change-Id: I47884eeb14a67b7e260835b8603d7b76c7ec018b
 2017-01-11 11:26:38 +01:00
Stephan Bergmann
0999f6469e New loplugin:conststringvar: sdext 
Change-Id: I2452ef62e34b1837048ab79bde07660a50b6dec9
 2017-01-10 08:10:38 +01:00
Stephan Bergmann
86dfe7724a New loplugin:externvar: sdext 
Change-Id: I46185dcefcd369f623fe4f4773e78275711d7f18
 2017-01-09 15:40:58 +01:00
Stephan Bergmann
fe9a5a4b4a ODR violation (base class must be the same across compilation units) 
Change-Id: Ieb98d8984c8d39fb72afbceccca29a2d402dc41e
 2016-12-21 15:08:24 +01:00
Noel Grandin
3a705ab405 OSL_TRACE->SAL in avmedia..canvas 
Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
 2016-12-13 08:14:00 +02:00
Noel Grandin
02ed1924eb OSL_TRACE->SAL in sd..sdext 
Change-Id: I6b224fa890dc96aada7140af27078da5e25c3ff8
Reviewed-on: https://gerrit.libreoffice.org/31898
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-12 12:17:26 +00:00
Stephan Bergmann
4586cc8b62 loplugin:unnecessaryoverride (dtors) in sdext 
Change-Id: I02dd087722aa7df299ca09ba55bb32d5402319fc
 2016-12-05 09:00:09 +01:00
Michael Stahl
f6d2ff1cb7 presenter console: fix STL assert when exiting slide show 
AtkListener::handleChildRemoved() calls removeAccessibleEventListener(),
apparently without the listener being registered, so the remove() returns
end(), which isn't valid for erase().

(probably happens since e4e208fa2b0930be5a7cbbe2fab2ff2fe2c4a1ff)

Change-Id: Ia0de1bafe214f5a46f250d6573d8c4b408c9cf26
 2016-11-23 11:11:09 +01:00
Noel Grandin
e74e9586f5 spelling mutext->mutex 
Change-Id: If844c07d0d50d1bb9b0a1877c0fde4a198bcf781
 2016-11-09 13:14:40 +02:00
Noel Grandin
0a3eaf9f67 loplugin:unnecessaryvirtual in sd..sdext 
Change-Id: Id0bc82210fadc138b55d1abe4e06b1d2ed564df3
Reviewed-on: https://gerrit.libreoffice.org/30659
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 13:00:53 +00:00
Noel Grandin
7abd369964 loplugin:unusedmethods 
Change-Id: Ie1f840c3ec9a2d5888f95cf05e531a8a9464bf2e
Reviewed-on: https://gerrit.libreoffice.org/30524
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-04 07:13:58 +00:00
Noel Grandin
b1f8cf3782 loplugin:singlevalfields 
Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76
Reviewed-on: https://gerrit.libreoffice.org/30476
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-02 13:06:37 +00:00
Jochen Nitschke
8826771e83 style fixes for cppcheck noExplicitConstructor 
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34
Reviewed-on: https://gerrit.libreoffice.org/30460
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2016-11-01 18:44:20 +00:00
Noel Grandin
9bdec0831a loplugin:oncevar in sd..svgio 
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c
Reviewed-on: https://gerrit.libreoffice.org/30459
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-01 13:25:08 +00:00
Mike Kaganski
7de287ba42 Make stable sort more stable :) 
Account for negative widths/heights; only apply text fudge factor
to text elements. This prevents debug asserts that "less" comparison
is invalid.

Change-Id: Ifb46bb873bfc80fc8c07af4923073d2042d30b3a
Reviewed-on: https://gerrit.libreoffice.org/30391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-10-31 14:24:50 +00:00
Takeshi Abe
b589c4cd87 Omit comparator which is the same as default std::less<key_type> 
Change-Id: I72a0b618577caececaaf3eb4df53d4cb192251da
Reviewed-on: https://gerrit.libreoffice.org/30369
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2016-10-31 03:48:49 +00:00
Noel Grandin
e5438e9ef7 loplugin:expandablemethods in sdext 
Change-Id: I7d375d6eafdd450ac165539f8f7dd3d02826ac5b
Reviewed-on: https://gerrit.libreoffice.org/30323
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-27 11:39:37 +00:00
Noel Grandin
e7324c5705 loplugin:expandablemethodds in scaddins..sdext 
Change-Id: Ife021e368efaafe9097750b4ca1a5472e94352a9
Reviewed-on: https://gerrit.libreoffice.org/30054
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-20 06:11:51 +00:00
Jochen Nitschke
7567a4c230 '>>=' with rhs Any is a copy assignment 
replace '>>=' operator with '=' where return value is not checked
and simplify. (note: switches lhs with rhs)

Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8
Reviewed-on: https://gerrit.libreoffice.org/30004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-19 19:28:18 +00:00
Jochen Nitschke
d1ea6ecda6 replace <<= with assign for <<= with rhs Any 
found by deleting specialization of '<<=' template

Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c
Reviewed-on: https://gerrit.libreoffice.org/29956
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2016-10-18 19:16:44 +00:00
Stephan Bergmann
6ac0e9f4d1 clang-cl loplugin: sdext 
Change-Id: I9f5e73b6f561ccb635217227787c6e8a574bdc97
Reviewed-on: https://gerrit.libreoffice.org/29854
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-10-16 14:18:10 +00:00
Miklos Vajna
0f613adbfa xmlsecurity: add initial PDFSignatureHelper 
This splits most of the PDF signature code out of the pdfverify
executable, and puts it into the xmlsecurity library instead.

The PDFSignatureHelper now attempts to verify PDF signatures, and code
in sdext / sfx2 also calls it (even if PDF is not a ZIP-based format).

Change-Id: I7b8b3ac9c976e4ea4f3796b1cda07c8a2c97bd02
Reviewed-on: https://gerrit.libreoffice.org/29751
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-10-13 10:44:23 +00:00
Stephan Bergmann
187d7f8f52 CPPUNIT_ASSERT[_DOUBLES]_EQUAL 
Change-Id: I417cea926abcc511e74a090ee90a851c138ac0c0
 2016-10-06 16:35:53 +02:00
Andrea Gelmini
441fa1c036 Fix typos 
Change-Id: I1e0e6f1b99090f26a6cd657ee9019bf2fa906dd9
Reviewed-on: https://gerrit.libreoffice.org/29436
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-01 19:10:20 +00:00
Noel Grandin
c4cd079b8f loplugin:unusedmethods in sc..vcl 
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8
Reviewed-on: https://gerrit.libreoffice.org/29183
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-22 18:56:58 +00:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin
b1164b07f9 loplugin:constantparam in sd 
Change-Id: I2bc989802c12b379a1ba4202f54ecfef1f339c8c
Reviewed-on: https://gerrit.libreoffice.org/28774
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-09-10 11:28:16 +00:00
Stephan Bergmann
6810f00d09 loplugin:staticaccess: Extend loplugin:staticcall to cover all access... 
to static members (data, in addition to function) via class member access
syntax.  Also covers the (somewhat obscure) access to enumerator members.

Change-Id: Iec54b8df2fdb423c0caf21a0dd0f9fe8fdf33897
 2016-08-25 17:16:14 +02:00
Caolán McNamara
93295a069b coverity#1371125 Copy-paste error 
this went wrong with

commit 9b9e5cfd2fa629b2e1dc4a193e48a4a4e8d34126
Date:   Mon Jun 20 17:40:13 2016 +0300

    tdf#99589 - tolower / toupper - dangerous to Turks ...

restore the logic to the original logic, but with the new
api

Change-Id: I445064b19eeefabbd25849bae9ca569710cdfac5
 2016-08-18 15:50:56 +01:00
Caolán McNamara
8a6eb11160 cppcheck: nullPointerRedundantCheck 
Change-Id: I9d6c38ad3104369c7661bc8a8561807598aecfcb
 2016-08-18 14:24:11 +01:00
Noel Grandin
6c87b02840 loplugin:countusersofdefaultparams in sd 
Change-Id: I848d9b555a26e9d343efdfaaaec44a2c7d8be5b5
Reviewed-on: https://gerrit.libreoffice.org/27765
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-02 05:34:49 +00:00
Caolán McNamara
2a66c02553 Resolves: tdf#84121 wrong password passed to xpdfimport 
regression from...

commit eb276d11a652601f743d69ada7a38016bd97d73e
Author: Fridrich Štrba <fridrich.strba@bluewin.ch>
Date:   Mon Jul 8 14:01:17 2013 +0200

    fdo#38878: Upgrading internal xpdf -> poppler

before this the hashed _OOO_pdfi_Credentials_ was used
in the removed OOoImportSecurityhandler::authorize

but after this the hashed password continued to be
passed through stdin, while the unhashed password
was the required data.

Change-Id: Iadc8a372abcfab514f724dd95f05776e5153d007
 2016-07-29 10:00:59 +01:00
Noel Grandin
508c95f1b6 improve passstuffbyref return analysis 
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:48:25 +00:00
Stephan Bergmann
768a6fc9c0 loplugin:passstuffbyref also for {css::uno,rtl}::Reference 
Change-Id: I3774f16c09b89fc6888bff3a388c290c32bb8a14
 2016-07-07 18:59:55 +02:00
Noel Grandin
fbd23182ee loplugin:unusedfields 
Change-Id: If06fffa8db050df0f9c1c7da6163575bf522382e
Reviewed-on: https://gerrit.libreoffice.org/26754
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-30 07:01:41 +00:00
Noel Grandin
48a8d6d843 loplugin:singlevalfields in various 
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e
Reviewed-on: https://gerrit.libreoffice.org/26738
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-28 11:21:17 +00:00
Noel Grandin
b1225d201f loplugin:singlevalfields in sdext 
Change-Id: I9bf194fb58b3bd37071647a83a629b6782836890
Reviewed-on: https://gerrit.libreoffice.org/26659
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-27 05:21:45 +00:00
Gökhan Gurbetoğlu
9b9e5cfd2f tdf#99589 - tolower / toupper - dangerous to Turks ... 
Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683
Reviewed-on: https://gerrit.libreoffice.org/26537
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
 2016-06-23 09:59:49 +00:00
Vort
b65f46127a tdf#96080 PDF Import: fix incorrect whitespace characters sequence 
Change-Id: I0f8e0217cb661be318af611216191def1b209ea1
Reviewed-on: https://gerrit.libreoffice.org/26426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2016-06-20 22:29:33 +00:00
Stephan Bergmann
4d49c9601c Let loplugin:passstuffbyref also look at fn defn not preceded by any decl 
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
 2016-06-08 17:14:34 +02:00
Jan Holesovsky
6aa46396f6 Reintroduce some code removed with "Remove unneeded Pane code in ..." 
This code was removed in 71cf1aefca1ecf10272308d7c75201bd39d3b0f6, but it was
guarded by an "ifndef", not by an "ifdef", so it should still stay (unless I'm
missing something).

Change-Id: Ib344e73d39d1fcd3b84784977769708726d8ed1e
 2016-06-06 09:44:11 +02:00
Bryan Quigley
71cf1aefca Remove unneeded Pane code in Presenter Console 
This code hasn't been touched (on purpose) in years, it appears
to have been used to resize part of the console. (It's prefed off)

Change-Id: Iaaeaa8a95c71ae91299bbeeea24869bf2a237b6b
Reviewed-on: https://gerrit.libreoffice.org/24663
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
 2016-06-06 05:55:03 +00:00
Noel Grandin
0b23eec200 teach refcounting clang plugin about uno::Reference 
uno::Reference is only allowed to used with classes that have a
::static_type member.
So convert all those places to rtl::Reference.

Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and
uno::Reference to make this a little smoother?

Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3
Reviewed-on: https://gerrit.libreoffice.org/25516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-31 06:25:45 +00:00
Noel Grandin
b73f45ef0b loplugin:unusedmethods in sd 
Change-Id: I27da3e7afd86217ec9f75958775da9c144d7a0a5
Reviewed-on: https://gerrit.libreoffice.org/25111
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-19 06:42:34 +00:00
Noel Grandin
d96c114171 clang-tidy modernize-make-shared 
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a
Reviewed-on: https://gerrit.libreoffice.org/25056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 06:58:44 +00:00
Michael Stahl
98f759bec1 sdext: replace boost::bind 
MSVC 2013 with non-debug runtime requires an additional assignment operator
in OUStringBufferAppender.

Change-Id: Ic93fc8d6b1d4760f0eb89e34beb1fcb18e783f73
Reviewed-on: https://gerrit.libreoffice.org/24980
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-05-13 21:22:08 +00:00
Stephan Bergmann
94b361b005 loplugin:stringconstant 
Change-Id: I5515f35871b23b67564d5eda52bf3323e7e047bb
 2016-05-12 11:44:12 +02:00
Michael Stahl
28159e91ba sdext: replace boost::bind with C++11 lambdas, part 2 
Change-Id: Ife5fbf7a7a41182de00dca339cba160e3bb0062f
 2016-05-12 11:08:24 +02:00
Tor Lillqvist
e1efe3359c loplugin:stringconstant 
Change-Id: I9eed9713a0d208e7aa4cdddc0cedb97edf831239
 2016-05-12 08:48:57 +03:00
Tor Lillqvist
f1fa4a58fc loplugin:defaultparams 
Change-Id: I4905e4c1dd72dabe2229d99742ee0012295a9742
 2016-05-12 08:48:56 +03:00