Commit Graph

727 Commits

Author SHA1 Message Date
458c5a0f47 Defer OUString -> OString conversion
...to avoid converting back OString -> OUString in SbiIoSystem::WriteCon.

Change-Id: I17024891d0babaa589f2c65f1123f1905c4338bb
2013-10-15 10:33:26 +02:00
b680e35254 Test WNT instead of the vague UNX
Change-Id: Icacdae592f05bcdcf50223d607976d687e182c96
2013-10-12 09:55:48 +03:00
d22fb8a608 CID#1103740 uninitialized value
Change-Id: I2d10104277d8ad0781e3dd088d51d62fa759fe57
2013-10-11 09:12:38 +01:00
0f7e24bfae unused StringHashCode
Change-Id: I72b882292f62c4a2b4999fa3e553db3c617e03f4
2013-10-03 13:09:23 +01:00
41dec09ed3 convert BASIC from String to OUString
Change-Id: I4b046e4c460305acad29862341092af948639215
2013-09-17 09:05:52 +02:00
57482ed493 CID#707499 check for 0 nDims
Change-Id: I828339695db1b1880d7e884f8bf26911d04b8508
2013-09-12 13:09:04 +01:00
b31f33bcc1 Easier conversion between Basic Date and UNO Date/Time
Utility functions to convert between Basic Date type
and the representations of Date and Time in UNO, namely:
 - com.sun.star.util.Date
 - com.sun.star.util.Time
 - com.sun.star.util.DateTime

Name of new functions:
 - CDateToUnoDate
 - CDateFromUnoDate
 - CDateToUnoTime
 - CDateFromUnoTime
 - CDateToUnoDateTime
 - CDateFromUnoDateTime

Change-Id: I2b971df20df1c0351d071023e042169b548894f1
Reviewed-on: https://gerrit.libreoffice.org/5897
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-09-11 20:40:19 +00:00
37f1a6d35a WaE: use number() instead of valueOf()
Change-Id: Ic45dc030f76531d202a12e227130d11d3d1de805
2013-09-04 08:55:19 +03:00
e70a436fe3 fix runtime error when using extended types
note: using VBA objects with the code completion is not possible at
the moment. Unfortunately there is some hard coded hacks for flattening
the namespace used by checkUnoObject.

Change-Id: Ic3a3149f41a6959943e71fa7ac22ff4dab7f30a1
2013-09-02 18:16:48 +02:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
5e505896a5 Basic: make sure a messagebox has solarmutex
Change-Id: Icc5f05456e4031ffbc88d6128689465f08eb5f0d
2013-07-29 15:27:46 +02:00
c6de82163e drop intermediate strings
Change-Id: Ib4a2bf25fcb834bda1bc515152b01c292704893a
2013-07-10 09:50:06 +01:00
e436c49188 fixup nanosecond precision
This was broken before...
Time used to take centiseconds, so the nanoseconds should have been *divided* by 10^7 for conversion.
Now Time takes straight nanoseconds, so no conversion necessary.

Change-Id: Ibac3eeca7020c5d8c5ff4be3e7617fac26ee8180
2013-07-05 12:22:03 +02:00
6a08067902 OUString convertion for unotools
Change-Id: Ifae7f344e3827875e32afa3cda23c771f5735707
Reviewed-on: https://gerrit.libreoffice.org/4659
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-02 07:31:30 +00:00
e0cce521f1 Resolves: #i121504# Support for alpha channel in clipboard for all systems
(cherry picked from commit ef3931ff410117e1237b3bef7bc090e8b83b9519)

Conflicts:
	automation/source/server/statemnt.cxx
	basic/source/runtime/methods.cxx
	canvas/source/vcl/devicehelper.cxx
	canvas/source/vcl/spritedevicehelper.cxx
	drawinglayer/source/processor2d/vclhelperbufferdevice.cxx
	drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
	drawinglayer/source/tools/converters.cxx
	dtrans/source/win32/dtobj/FmtFilter.cxx
	editeng/source/items/bulitem.cxx
	extensions/source/scanner/sanedlg.cxx
	external/gcc3_specific/makefile.mk
	filter/source/graphicfilter/eos2met/eos2met.cxx
	filter/source/graphicfilter/ios2met/ios2met.cxx
	filter/source/msfilter/msdffimp.cxx
	fpicker/source/office/iodlg.cxx
	framework/source/fwe/classes/addonsoptions.cxx
	framework/source/fwe/helper/actiontriggerhelper.cxx
	sc/source/filter/excel/xiescher.cxx
	sc/source/ui/docshell/docsh.cxx
	sc/source/ui/inc/viewfunc.hxx
	sd/source/ui/app/sdxfer.cxx
	sd/source/ui/unoidl/unopage.cxx
	sd/source/ui/view/sdview3.cxx
	sfx2/source/appl/fileobj.cxx
	sfx2/source/appl/linkmgr2.cxx
	sfx2/source/dialog/filedlghelper.cxx
	sfx2/source/dialog/intro.cxx
	sfx2/source/doc/docinf.cxx
	sot/inc/sot/formats.hxx
	sot/source/base/formats.cxx
	svtools/bmpmaker/bmpcore.cxx
	svtools/bmpmaker/bmpsum.cxx
	svtools/inc/svtools/transfer.hxx
	svtools/source/filter/filter.cxx
	svtools/source/filter/wmf/emfwr.cxx
	svtools/source/filter/wmf/enhwmf.cxx
	svtools/source/filter/wmf/winwmf.cxx
	svtools/source/filter/wmf/wmfwr.cxx
	svtools/source/graphic/graphic.cxx
	svtools/source/graphic/provider.cxx
	svtools/source/misc/transfer.cxx
	svx/inc/svx/xoutbmp.hxx
	svx/source/sdr/overlay/overlaymanagerbuffered.cxx
	svx/source/xoutdev/_xoutbmp.cxx
	sw/source/core/view/viewsh.cxx
	sw/source/filter/ww1/w1filter.cxx
	sw/source/filter/ww8/ww8par.hxx
	sw/source/ui/dochdl/swdtflvr.cxx
	toolkit/source/awt/vclxbitmap.cxx
	toolkit/source/helper/vclunohelper.cxx
	vcl/Library_vcl.mk
	vcl/Package_inc.mk
	vcl/aqua/source/dtrans/DataFlavorMapping.cxx
	vcl/aqua/source/dtrans/OSXTransferable.cxx
	vcl/aqua/source/dtrans/PictToBmpFlt.cxx
	vcl/aqua/source/dtrans/PictToBmpFlt.hxx
	vcl/inc/vcl/alpha.hxx
	vcl/inc/vcl/bitmap.hxx
	vcl/inc/vcl/bitmapex.hxx
	vcl/inc/vcl/pngwrite.hxx
	vcl/inc/vcl/salbtype.hxx
	vcl/inc/vcl/wall.hxx
	vcl/source/gdi/animate.cxx
	vcl/source/gdi/bitmap2.cxx
	vcl/source/gdi/bitmapex.cxx
	vcl/source/gdi/bmpconv.cxx
	vcl/source/gdi/cvtsvm.cxx
	vcl/source/gdi/impgraph.cxx
	vcl/source/gdi/impimagetree.cxx
	vcl/source/gdi/metaact.cxx
	vcl/source/gdi/wall.cxx

Change-Id: I79938bc412c048c3d4e64f430f216e73bec16167
2013-06-13 14:50:46 +01:00
c32dd08cfb blind ( windows ) fix re. uno::Refererence vs rtl::Reference foobar fdo#65545
Change-Id: I81b877e8e1b6945c2f1265947ad915ed1070800a
2013-06-13 11:43:46 +01:00
a5d26f86e8 Werror: labels ... not handled in switch
Change-Id: Ib73d757ffb313ce365caa3f70c472f662f6d9719
2013-06-10 14:03:34 +02:00
35a65baefe Slowly, but surely going on compiling for mingw64
Change-Id: I590aa6a854a040281bf73d5be768c05d4906a984
2013-06-06 15:52:05 +02:00
5405451440 bogus TRUE/FALSE -> sal_False/sal_True
Change-Id: I72e0b6b3261422bd5fc47445d38cc64241d62362
2013-05-29 12:58:47 +01:00
1d1825db86 fdo#46808, Convert awt::UnoControlDialog to new style
Change-Id: I9a5256c8dbacda60167403b4e26900588943a9b2
2013-05-28 08:10:22 +02:00
e36f83d81c Revert "fdo#46808, Convert awt::UnoControlDialogModel to new style"
This reverts commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654.  As discussed at
<http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re:
fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd
change in 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get
CreateUnoDialog() work again" appears to fix things again:

  The problem is that the implementation of the css.awt.UnoControlDialogModel
  involves UNO aggregation
  (IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in
  toolkit/soruce/helper/registerservices.cxx creating a
  OGeometryControlModel<UnoControlDialogModel> instance that aggregates a
  UnoControlDialogModel instance).  That means that queryInterface can return a
  reference to something that is technically a different object, and that's
  what's happening here, and explains why calling setPropertyValue in two
  different ways on what logically appears to be a single object can end up
  calling two different implementations (of two different physical objects).
  (UNO aggregation is known to be broken and should not be used.  Nevertheless,
  there's still code that does---code that is a horrible mess and hard to clean
  up.)

  That all this worked as intended in the past is just sheer luck, but any
  way of substantially touching it is asking for trouble.  I'm going to
  revert 6c61b20a8d4a6dcac28801cde82a211fb7e30654 again.

I wasn't able to revert without also reverting
be50ad28f5bbdaeff527f646481ce263843c2401 "fdo#46808, Convert
awt::XUnoControlDialog to new style," as the two were tightly dependant.  Also
reverts all the follow-up fixes cb4b6dde8fda2a5848e11063028bf44d72f85431
"-Werror,-Wuninitialized" (sans the const-ness fix in
UpdateHandler::insertControlModel), 697a007c61b9cabceb9767fad87cd5822b300452
"Fix exception specifications," 2ce6828bbbf6ba181bb2276adeec279e74151ef6 "fix
awt::UnoControlModelDialog crash," and 2e2a4827ce6708f0e8677dba9cc92e1479a44086
"scripting: get CreateUnoDialog() work again."

Conflicts:
	basctl/source/dlged/dlged.cxx
	filter/source/t602/t602filter.cxx
	xmlscript/test/imexp.cxx

Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998
2013-05-25 11:45:47 +02:00
be50ad28f5 fdo#46808, Convert awt::XUnoControlDialog to new style
Change-Id: I40d2e2ddd92186a2ba22ebfbdda8367391e8d355
2013-05-21 08:23:59 +02:00
1755091764 fix wildcard handling regression( for basic functions like Dir ) fdo#64536
Tweak another fallout from String->OUString

Change-Id: I3932bdb441fe6b08cefa6331870956664ade77bd
2013-05-20 12:19:36 +01:00
cb6d67c21f Spelling "separate" (etc) correctly is hard 2013-05-15 11:14:28 +03:00
894a0348dc fix VBA mode MkDir when passed folder is not a full path
Change-Id: I7fd804999f1b96e6aab112445edcd9dcf7753c24
2013-05-09 14:11:21 +01:00
52b71a2b5e fix windows build
Change-Id: Id5d51292c0ee9c6bf62a2ceac6a80cbfd3e09605
2013-04-26 18:45:59 +02:00
1e83da9aed some more namespace cleanup
Change-Id: Ib1e80d717f199db8f8ac4181d4377a86d88e3244
2013-04-26 18:01:51 +02:00
d12a3e8b76 Combine fairly pointlessly split source code for SbiRuntime into one file
Insert basic/source/runtime/step[012].cxx into
basic/source/runtime/runtime.cxx.

Follow-up to https://gerrit.libreoffice.org/#/c/3373/ .

In many cases the sources for some class have been split up into several
source files, typically suffixed with a number 0, 1, 2 etc. Presumably this
has been done because some compiler years ago was not capable of compiling all
the source for that class at one time, or some other no longer relevant
reason.

It would be nice to get rid of this convention, so that clever compilers have
a better chance of noticing unused private fields in a class, for
instance. Just combining the source files in question into one source file and
removing the old source files from git leads to a discontinuity in version
control history. But the consensus seems to be that this is not such a big
deal.

I picked these sources just because they happened to be the first ones I came
across when looking for files called *0.cxx.

Change-Id: Ia7e8ece9a4374721bbcce6b0e2aba5721436faae
2013-04-24 11:07:15 +03:00
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
29bfb507b3 get rid of some Germanism (and some Windowsism)
Change-Id: I2ca1b34ff688a7d4fcf6c84c02035eda3ab0dee8
2013-04-18 23:43:18 +02:00
1ef2cce787 Revert "svformatter already accept OUString input", fdo#63306
This reverts commit c5e5699c80cfb32a164696a2c5144b5ccb0a91a9.

And adapts to OUString.

Conflicts:
	basic/source/runtime/runtime.cxx

Change-Id: Icd7c1e1e57162eefb1f3631aa5509fd3a09c9b08
2013-04-18 22:57:47 +02:00
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
52ede08a65 -Werror=unused-macros (MinGW, GradientStyle_RECT)
...hopefully unnecessary today anyway?

Change-Id: Ib3c621f46311c90d159fe0f08655c01d25024d7d
2013-04-17 11:51:13 +02:00
ba044b1e96 remove needless forward rtl::OUString declarations
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
2013-04-07 14:23:12 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
876c619b94 new module i18nlangtag
Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.

This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.

Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
2013-04-05 19:10:48 +02:00
47664d3f2e fdo#58807 bring Beep() for basic back
The functionality was removed by fdo#48549.

This partially reverts

0f6101cfef4c2e45d9f1f1b3a61ef94799e4526b
0bdf6fc7c71c4c49e6d6f83d56ac953272ad16d5
85cb9084533605657aca0394afe4516058a8e4ef

I changed the behavior to always beep, because only the basic macro
function is using Beep(). Looks like the Beep macro function didn't
even work correctly before the removal, because the default was to
not beep for most platforms. So I set the volume from disable (0)
to 50% for XBell().

Change-Id: I663ffb7af75d2fd6d2c1f94073e4412d9744de4a
Reviewed-on: https://gerrit.libreoffice.org/3124
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-04-03 10:24:40 +00:00
5be14df244 ResMgr with LanguageTag
Change-Id: Ie5ce9157a7ea59db7b0509fbaec61d07f8f9edf0
2013-03-29 14:09:01 +01:00
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
7f4a34e314 basic: Remove non working AboutStarBasic
The content of this function was commented out since the first import. So as it does nothing remove it.

Change-Id: Ia46674f7bdc12e80d61a8142697e875f5c58f482
Reviewed-on: https://gerrit.libreoffice.org/2899
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-24 14:49:52 +00:00
97fa9a882c coverity#704205/704206/704207 Logically dead code
Change-Id: Ic2cbd96f393a21cf2c6634d3c5e5a4c5a5b486ef
2013-03-23 14:13:20 +01:00
e8638ad5a7 in Val() check status after stringToDouble()
instead of calling checkArithmeticOverflow()

Change-Id: I2e3307ee054db77bab0a106d886823dba9e56ea8
2013-03-22 17:47:17 +01:00
5f0ad2a5ac windows build fix
Change-Id: I6ff724052660d73b583fb1e44265a60a6fa4379f
2013-03-19 23:01:16 +01:00
438efb38ec fdo#39445 writing out tools/fsys.hxx (basic)
Change-Id: I2ec7546572fa72359615f371715b4aa82b1182ca
2013-03-19 22:42:02 +01:00
a1e22bdeb4 remove unused header: tools/fsys.hxx
Change-Id: Id6ac74e88e7e57dfbee9aa70a83909c3280a58cd
2013-03-19 18:27:53 +01:00
cd49ebe1aa fdo#39445 writing out tools/fsys.hxx (basic)
removed unused include from runtime.cxx and step0.cxx
changed DirEntry::GetAccessDelimiter() to SAL_PATHDELIMITER in methods1.cxx
removed unused DirEntry declaration from methods1.cxx

Change-Id: I0d8c64b6498cf5b16757edaf13e1108f279934dd
Reviewed-on: https://gerrit.libreoffice.org/2848
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-03-19 17:23:43 +00:00
0054b43801 follow on fix for fdo#62090 ensure out of range startpos is handled
Change-Id: Ic1f57480a36415998748faeea3b606a47d277181
2013-03-19 15:59:21 +00:00
205277f5e6 remove commented out line I inserted to screw up Juliens patch
Change-Id: I7f874267a640a7cc754eb7477b764f7546fdc5ea
2013-03-19 15:48:39 +00:00
14d452d0c2 fix for fdo#62090 Mid function regression
Change-Id: Ia6a73d6a44a34345b512922037d01b8b40ac24a8
2013-03-19 15:45:56 +00:00
4158ae52fb WaE: Werror=shadow
Change-Id: I7f1bddbed85076f1c909d0d9f4ecdd1cda6f1880
2013-03-15 20:49:11 +00:00