wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
395,205 Commits 5 Branches 0 Tags
626a1aa960ed36f5c3370e2aab1e72d41df875cf
Commit Graph

2678 Commits

Author SHA1 Message Date
nadith
efef273e2c tdf#100726: Improve readability of OUString concatenation 
this bug fixed in the modules between canvas - cppu

Change-Id: I2022b022897dafde20251352376e3facdb9b8d75
Reviewed-on: https://gerrit.libreoffice.org/27663
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-01 06:12:30 +00:00
Noel Grandin
508c95f1b6 improve passstuffbyref return analysis 
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:48:25 +00:00
Caolán McNamara
a860df25dd masses of MessBoxes not being disposed promptly 
since...

commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f
Date:   Thu May 28 21:35:43 2015 +0100

    tdf#91702 - fix stack-based MessBox allocation.

There is no special ScopedVclPtr<X>::Create or
ScopedVclPtrInstance<X>::Create just
VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo
doesn't call dispose on the owned X

Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
 2016-07-26 11:26:52 +01:00
Noel Grandin
938821fb08 new loplugin overrideparam 
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.

Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-25 06:09:17 +00:00
Michael Stahl
580ed47cf7 chart2: missing header <iterator> reportedly breaks MSVC2015 
Change-Id: I09b5a292e38044f14cd033a05e459cc69197de57
 2016-07-22 19:33:26 +02:00
Stephan Bergmann
8babcb7e66 loplugin:staticcall 
Change-Id: I4ec0585bec93c7bc79a31c699df7d68b955eef56
 2016-07-17 21:58:35 +02:00
Stephan Bergmann
8569cf1d91 loplugin:passstuffbyref 
Change-Id: I0114bd98b92b9810d7d829ddce8461a2844e0506
 2016-07-17 21:57:33 +02:00
krishna keshav
bd9644249d tdf#100913 Remove tOID typedefs in ObjectHierarchy class 
Replace use of toID with ObjectIdentifier in 'ObjectIdentifier.hxx'.

Change-Id: Ic0157974eca2992167319f7d19a0224056cc985e
Reviewed-on: https://gerrit.libreoffice.org/27243
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-07-17 12:20:42 +00:00
Markus Mohrhard
d2b2278aab uitest: provide wrapper for chart objects 
This allows now to operate on chart objects and call commands on them.

Change-Id: I399b275c563deb507aaf4f3f49373871e733af91
 2016-07-16 18:27:14 +02:00
Markus Mohrhard
a980b6c8ae no need for this temporary OString 
Change-Id: I8b5d69f7e64a83e52a41c285f5ef186a666ccd55
 2016-07-16 18:27:14 +02:00
Markus Mohrhard
8781dbe099 uitest: provide all the children for charts 
This now also includes legend entries and data points.

Change-Id: I0e4d1f21a20035cd632a7755dbbea17baec4b083
 2016-07-16 18:27:13 +02:00
Markus Mohrhard
0f03a80131 uitest: some initial work on the chart selection 
Change-Id: I3317eba5383206de6f619da548ee3047861eef07
 2016-07-16 18:27:13 +02:00
Markus Mohrhard
b1e1b38349 uitest: add initial support for selecting chart elements 
Change-Id: I3af11d44067618b5188f3dbf4abccc171dd98d0c
 2016-07-16 18:27:13 +02:00
Noel Grandin
6e72f0251b new loplugin unnecessary override 
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-07-15 14:05:41 +00:00
Jochen Nitschke
194d4a02b9 chart2: remove unused ContainerHelper.hxx includes 
remove using namespace :💹:ContainerHelper;
to match other uses

Change-Id: I343086a6b7d70c84499b209680973431c7317219
Reviewed-on: https://gerrit.libreoffice.org/27184
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-07-13 12:58:55 +00:00
Jochen Nitschke
5ce65d04fd chart2: cleanup local var assignments 
and remove comments about a gcc 3.3 workaround.
some comments went obsolete with other commits
like 367105e0248c7b80b60b2554d04f5f248b4259b3

Change-Id: I15fff464e2f71a6ade29c141bb17216770f54ced
Reviewed-on: https://gerrit.libreoffice.org/27127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-13 07:26:45 +00:00
Stephan Bergmann
cd1e2f5cc3 Avoid global data with (non-constexpr) ctors/dtors 
Change-Id: I787ec685275d119dd4eea86f51b6dd85bc0260d1
 2016-07-12 09:43:56 +02:00
Jochen Nitschke
43bc09d6dd chart2: make m_aEntryMap a non member constant 
Change-Id: Ic45ba10808ea2ce6bc6520bb4222cd8b3ebd8ea6
Reviewed-on: https://gerrit.libreoffice.org/27098
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-12 06:31:08 +00:00
Stephan Bergmann
d956a5d29e loplugin:passstuffbyref also for {css::uno,rtl}::Reference 
Change-Id: I5c973d41381f2bfd39e7a8cf48fd5807852bdc72
 2016-07-07 18:59:55 +02:00
Noel Grandin
7001ca25ec merge LineProperties with chart::ErrorBar 
Change-Id: Ic3490a15339ff981e90a86cb69c206c231db9161
Reviewed-on: https://gerrit.libreoffice.org/26932
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-05 10:51:09 +00:00
Noel Grandin
0f17e34330 loplugin:singlevalfields in chart2 
Change-Id: I8b8bf093736a191c90d765dce82b00e15bb398d6
Reviewed-on: https://gerrit.libreoffice.org/26708
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-28 08:35:03 +00:00
Szymon Kłos
1df394503f GSoC notebookbar: switching tabs depending on context 
+ sfx2::sidebar::EnumContext moved to the vcl module
+ TabPage contains vector with context values
+ vcl builder reads control's contexts from the "class" mark
+ ContextTabControl shows tabs depending on context

Change-Id: I661b0d3f35d46ace2a2e8eb1d374148f0c60017d
Reviewed-on: https://gerrit.libreoffice.org/26447
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-06-27 17:51:56 +00:00
Markus Mohrhard
c4a6f300f5 uitest: set id for chart window 
Change-Id: I443dcccf6d560c252da38a0f0c63cc48a212c127
Reviewed-on: https://gerrit.libreoffice.org/26494
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-06-20 02:26:45 +00:00
Stephan Bergmann
f35b1397ae Clean up uses of Any::getValue() in chart2 
Change-Id: I53224053ea05c715f5e359a4c68e1ae5efbfe792
 2016-06-17 08:45:28 +02:00
Muhammet Kara
6786842337 Move accessibility relations to .ui files, Part 8: tdf#87026 
By removing unnecessary variables/strings/function calls,
and making proper changes in the related .ui files.

Change-Id: I04244b360b4bb32ccbbe5bde4756a9166ae1fcaf
Reviewed-on: https://gerrit.libreoffice.org/26018
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2016-06-10 13:54:37 +00:00
Maxim Monastirsky
bdd67652b6 Try to get rid of svt::ContextMenuHelper 
Change-Id: I7b43e417607b20c300e3c18e7da76a6173a18b7d
Reviewed-on: https://gerrit.libreoffice.org/26098
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-06-09 12:53:43 +00:00
Markus Mohrhard
78b100ec9c only init the OpenGL context if we need it 
Change-Id: Ia88a1720d204b9933f1476bd703b99180e45abde
Reviewed-on: https://gerrit.libreoffice.org/26023
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-06-07 16:11:20 +00:00
Noel Grandin
11b4a6ddce Convert DeactivePage return code to scoped enum 
Change-Id: Idd5372ad20fc6676864b31b3796f8b9bc0ad73dd
Reviewed-on: https://gerrit.libreoffice.org/25918
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-06 07:02:20 +00:00
Noel Grandin
9f138ffe9d remove unused constants in HRC files 
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1
Reviewed-on: https://gerrit.libreoffice.org/25817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-06 07:01:43 +00:00
Muhammet Kara
3498fd9fe9 Remove SetAccessibleRelationLabeledBy calls tdf#87026 
And make proper changes in the related .ui files

Change-Id: Iea998b6de25831c08950a8afa725713288113bfa
Reviewed-on: https://gerrit.libreoffice.org/25807
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-06-02 10:36:59 +00:00
Jochen Nitschke
4ca9e85538 replace simple macros in chart2 
with static constantants or a named value (enum)

Change-Id: I8ef21bc3b9797ed9319e790fc12241d59f07b88c
Reviewed-on: https://gerrit.libreoffice.org/25760
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-02 07:31:39 +00:00
Jochen Nitschke
ef3585340e remove ENABLE_GL3D_BARCHART define 
enabled since commit dfb2ab0cee2ba04ce8816580447e7db8160ffac4

Change-Id: Ib260ff1ce4089ecf4778114d249d59af67c94c2c
Reviewed-on: https://gerrit.libreoffice.org/25759
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-02 07:29:05 +00:00
Noel Grandin
850a8d27ca Convert GRAPHIC to scoped enum 
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea
Reviewed-on: https://gerrit.libreoffice.org/25534
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-27 12:59:23 +00:00
Noel Grandin
9eb2e683ab tdf#34465 remove calls to SfxItemSet::Put(const SfxPoolItem&, sal_uInt16) 
and put an assert in SfxPoolItem::SetWhich() so nothing new
creeps in.

Change-Id: I6497650fa61ffb2b6941ffff2d471c8f117be1df
Reviewed-on: https://gerrit.libreoffice.org/24324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-27 07:21:45 +00:00
Noel Grandin
21a68e1745 convert TAB to scoped enum 
and rename the SID constant to something more meaningful

Change-Id: Ic07888936df3d537158fd2fb671b0df11350d676
Reviewed-on: https://gerrit.libreoffice.org/24986
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 10:13:57 +00:00
Noel Grandin
2c8fe2e737 update unusedmethods plugin to deal with constructors 
and fix the operator< implementations in some of the other
plugins too.

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 10:03:44 +00:00
Stephan Bergmann
ca6c108caa Missing break in switch 
First 749a0845500d69f99bf1901bab82361f67b5e4f6 "don't show area and line panel
in pie chart Chart selection, tdf#94320" added the case OBJECTTYPE_DIAGRAM
falling through to the default break case.  Then
14237c1678167da725fee079532c4669264d697f "use trendline context for trendlines,
tdf#94931, tdf#94934" added the case OBJECTTYPE_DATA_CURVE,
OBJECTTYPE_DATA_AVERAGE_LINE block in between.

Change-Id: I9d06b5054128c4a31381e33620f4a2b898e0e969
 2016-05-10 17:39:13 +02:00
Stephan Bergmann
14cd5182c5 Replace fallthrough comments with new SAL_FALLTHROUGH macro 
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
 2016-05-10 16:42:16 +02:00
Noel Grandin
17076d8ecf convert OUTLINER_MODE to scoped enum 
Change-Id: I7ac45d7fbd5e77a105cbe942c6d4fd6cfc8ff909
Reviewed-on: https://gerrit.libreoffice.org/24789
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-09 11:15:16 +00:00
Feyza Yavuz
0ab7ad3bb0 tdf#92768 Support hiding title objects 
Change-Id: I879fc3d81a8fe8ca2f928305f5dc7fd9ebcfd294
Reviewed-on: https://gerrit.libreoffice.org/24564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-05-08 20:20:40 +00:00
Thorsten Behrens
2cf939b2da -Werror=maybe-uninitialized 
Change-Id: Id516aa921d13ff5c0085fb9cf76fefd56acb31ad
 2016-05-04 14:15:43 +02:00
Noel Grandin
58a32075ca use Any constructor instead of temporaries 
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
 2016-05-04 12:39:40 +02:00
Andrea Gelmini
fc2590cfa1 Fix typos 
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73
Reviewed-on: https://gerrit.libreoffice.org/24317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-30 15:06:45 +00:00
Noel Grandin
43b4903db3 teach stylepolice plugin about ref-counted-pointer naming 
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752
Reviewed-on: https://gerrit.libreoffice.org/24459
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-28 09:31:16 +00:00
Stephan Bergmann
81105d9534 -Werror,-Wvarargs 
"passing an object that undergoes default argument promotion to 'va_start' has
undefined behavior [-Werror,-Wvarargs]"

just drop the variadic overload and use the one taking a WizardPath (i.e., a vector)

Change-Id: I6e389f60f8b7cb0633bf173bde69af1c5af86048
 2016-04-27 13:47:30 +02:00
Laurent Balland-Poirier
fe2bf7b059 tdf#99518 Use correct decimal separator 
Change-Id: I39169e7c7344fcfd594a0e0d2ab0a762cc3d5829
Reviewed-on: https://gerrit.libreoffice.org/23961
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-27 00:29:42 +00:00
Stephan Bergmann
279f050554 Some more sal_Bool -> bool 
Change-Id: I4df1afecfe4c554fa98060e6ba1507911323656c
 2016-04-25 16:40:05 +02:00
Noel Grandin
adff28271b the container document commands std::set can be static 
Change-Id: I00558dad4b8206e5e2a7bf004e32196a15dba3cd
 2016-04-25 09:21:44 +02:00
Noel Grandin
b2e2400736 no need to copy the list of available commands on every call 
Change-Id: I131f34a94c998f3dd9fd7a457fb213778040c771
 2016-04-25 09:18:12 +02:00
Stephan Bergmann
a82805f8f9 Kill comphelper::MakeMap 
Change-Id: I97e9e79ef51e3d78f01b831dd3eee91218058823
Reviewed-on: https://gerrit.libreoffice.org/24344
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-04-25 06:11:27 +00:00