Commit Graph

1811 Commits

Author SHA1 Message Date
a29bd2dabb cleanup tailing backslashes
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2
Reviewed-on: https://gerrit.libreoffice.org/32491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-30 18:48:24 +00:00
6b8ee3c9ba convert VclButtonsType to scoped enum
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1
Reviewed-on: https://gerrit.libreoffice.org/32285
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-21 16:19:37 +00:00
cc69d4f26b loplugin:unnecessaryoverride (clang-cl)
Change-Id: I9e4f210c9670b28a99b779d15ec32303832ce48b
2016-12-16 15:21:59 +01:00
d15b4e2045 teach sallogareas plugin to catch inconsistencies
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a
Reviewed-on: https://gerrit.libreoffice.org/32004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-15 06:45:14 +00:00
c3586b684c OSL_TRACE->SAL in chart2..oox
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13 06:12:00 +00:00
3531358218 loplugin:staticmethods
Change-Id: I701dfbe69380b5e4024fe55d0045c909bd4b607a
2016-12-06 13:48:58 +02:00
b80dc58271 unwind fpicker RID_FILEPICKER_IMAGES imagelist
Change-Id: I1b55e4581c7fcbdf228c3b903269e28d37e53297
2016-12-06 10:12:32 +00:00
9b8fb82150 loplugin:unnecessaryoverride
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-06 10:20:01 +01:00
b0e7282bdd IMG_FILEDLG_BTN_STD is unused
Change-Id: Id41d43ec74575ba0edc59f87ffa8b6c9b1485010
2016-12-05 21:38:53 +00:00
50151db9f7 convert FSysStyle to o3tl::typed_flags
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05 12:49:02 +02:00
bfde4866e0 convert DecodeMechanism to scoped enum
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05 12:49:02 +02:00
803215142e convert INetURLObject::EncodeMechanism to scoped enum
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05 12:49:02 +02:00
6bb20609a2 vcl: rename Window::Notify to EventNotify
There is annoying overloading between Window::Notify and
SfxListener::Notify, and the Window one has apparently fewer
implementations, so rename that and remove lots of disambiguating
"using Notify" in multiply inheriting classes.

Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-24 22:56:34 +01:00
e77c931f44 convert FLT constants to o3tl::typed_flags
and remove the unused ALLFILESFILTER value

Change-Id: I4d7484ed2d9a5efacac652c6557f14caadd89d34
2016-11-23 11:55:09 +02:00
a31e1f1a32 convert PROPERTY_FLAG to o3tl::typed_flags
Change-Id: Ib652b83b1beed048cabce91aee22fc98605fd654
2016-11-23 11:55:09 +02:00
bd614b9135 Delete the "Any-to-Any" template specializations for LIBO_INTERNAL_ONLY
i.e., css::uno::Any function template specializations

  Any::has<Any>() const
  Any::get(Any const &) const
  operator >>=(Any const &, Any &)
  operator <<=(Any &, Any const &)

that don't make much sense (the first is always true, the rest can be replaced
with operator =, which additionally supports move semantics).  For 3rd-party
compatibility, do this only for LIBO_INTERNAL_ONLY, however.

However, some generic template code did benefit from operator >>= working also
for Any, so make up for that with a new (LIBO_INTERNAL_ONLY, given that
operator >>= still covers if fine for !LIBO_INTERNAL_ONLY) fromAny,
complementing the existing toAny.

Change-Id: I8b1b5f803f0b909808159916366d53c948206a88
Reviewed-on: https://gerrit.libreoffice.org/30022
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-21 19:44:56 +00:00
bbb9264610 add missing deps on ui files
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-21 09:44:39 +01:00
d8a8ed04b1 gbuild allow unitest to run once per lang in WITH_LANG_LIST
this is motivated by the new screenshot feature
the initial proposed solution involved running make screenshot once per lang
which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big
windows slavebot.

with this patch, one can run make screenshot just once and get all the screenshot
the elapsed time is 36 inutes on the same box/same config a 10x improvement.

Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939
Reviewed-on: https://gerrit.libreoffice.org/30970
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-20 13:34:40 +00:00
ec4e48c750 Fix typos
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672
Reviewed-on: https://gerrit.libreoffice.org/30872
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15 14:51:34 +00:00
be55107da2 loplugin fixes here, too
Change-Id: I32cf90d524f8dd9fb454d4145d314b748ac0b281
2016-11-10 23:27:37 +02:00
df2e37eb03 use-after-free fix here, too
Change-Id: I228b6367abadfc25c85fdb6821faebc7e4e8dda8
2016-11-10 23:27:24 +02:00
a16296429f Typos
Change-Id: I87a63c4b1a13186efa5d0bd807605092197082e0
2016-11-10 23:16:38 +02:00
8826771e83 style fixes for cppcheck noExplicitConstructor
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34
Reviewed-on: https://gerrit.libreoffice.org/30460
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-11-01 18:44:20 +00:00
074defe26f Strange OUString null check
...ever since 035d20bd248b4f958c185001752688ef88318af6 "INTEGRATION: CWS
aquafilepicker01".  Unclear whether this was written under the assumption that
m_aCurrentFilter is a pointer (which would explain the OSL_TRACE message talking
about "null"), or whether it really wanted to check for an empty string (which
the code acutally happened to do).  So lets keep the empty-string check in,
given it was in there ever since the code's introduction in 2007.

Change-Id: I9e48b6ceccaf069c6a6a88d3918ba88379a72497
2016-10-31 13:22:06 +01:00
1ec08fe00b loplugin:unnecessaryoverride
Change-Id: Ib75f2c8c06c6219aa0f2a8b2b29d19fb95e09527
2016-10-28 18:02:32 +02:00
99fbcffa3d tdf#89329: use unique_ptr for pImpl in fpicker/
Change-Id: I4a5db5ceafe509bffc32a8800ab3d678f41244f7
Reviewed-on: https://gerrit.libreoffice.org/30309
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28 12:26:09 +00:00
624ff6633c only draw menubutton separator when two sides do something different
Change-Id: If6e3b72eacef2325f9f30770bbed32c627bc035c
2016-10-28 12:37:05 +01:00
94af3da7e1 rename and explain the MENUBUTTON_MENUMODE_TIMED stuff
Change-Id: Ifc6ddfb0cc249e537c01f28bab84b42c6b1577d9
2016-10-28 12:22:52 +01:00
98d9bb5eb2 Adapt Windows-only code to deletion of the "Any-to-Any" specializatios
...upcoming with <https://gerrit.libreoffice.org/#/c/30022/> "Delete the 'Any-
to-Any' template specializations for LIBO_INTERNAL_ONLY"

Change-Id: If070825d88ffa7bb49e645b3bfeae9dfa387f000
2016-10-21 18:14:18 +02:00
423936ffac loplugin:expandablemethodds in formula..framework
Change-Id: I6c8b1bb3b664faa92b2dc05955c30bfd35f6dfaa
Reviewed-on: https://gerrit.libreoffice.org/30015
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 07:57:11 +00:00
d1ea6ecda6 replace <<= with assign for <<= with rhs Any
found by deleting specialization of '<<=' template

Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c
Reviewed-on: https://gerrit.libreoffice.org/29956
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18 19:16:44 +00:00
432e3162e6 clang-cl loplugin: fpicker
Change-Id: Ib19175affd48610fc164a996d609b369256d4f72
Reviewed-on: https://gerrit.libreoffice.org/29865
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-16 14:19:12 +00:00
e35e95560d ReleaseSolarMutexOnMainThreadContext is unused
...ever since its introduction in 29da2639353762a64673d6ae5b32a36045caa7d3
"CWS-TOOLING: integrate CWS filepicker01"

Change-Id: I2bd989e7e950bf58a8f26708f79eeed223c4fb4a
Reviewed-on: https://gerrit.libreoffice.org/29799
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14 05:36:31 +00:00
f74a76391c _OPENFILENAME_SIZE_VERISON_400 is unused
...since b30f91c58419e90a789f79a1391b13f2064997ab "Drop Win9x stuff"

Change-Id: I4ef6b13865165c84288a77c83daf0758f5083810
Reviewed-on: https://gerrit.libreoffice.org/29793
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14 05:36:12 +00:00
04ba40c749 ImageList just reads and discards the MaskColor, so drop it
Change-Id: I243e739fea28e3f38b91534182cc54c2aa660f0e
2016-10-06 13:29:39 +01:00
954f752cf1 convert MapUnit to scoped enum
I left a prefix on the names "Map" so that I would not have to re-arrange
each name too much, since I can't start identifiers with digits like "100thMM"

And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore.

Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224
Reviewed-on: https://gerrit.libreoffice.org/29096
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05 06:51:20 +00:00
106ea87205 Remove _TYPED suffix from tools/link.hxx macros
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-05 07:56:12 +02:00
f0249a88fc Fix typos
Change-Id: I6730c6c5eab9157533822e5045e9f86109062580
Reviewed-on: https://gerrit.libreoffice.org/29433
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-03 11:21:52 +00:00
652c97b821 tdf#101549: Remove tooltip_markup from glade .ui files
where there is also an identical tooltip_text.
And convert the remaining tooltip_markup properties
to tooltip_text.

Change-Id: Id9995217468fb7046a2822dcef9a99072a7269ee
Reviewed-on: https://gerrit.libreoffice.org/29367
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-09-28 20:57:21 +00:00
b932b19960 loplugin:override
Change-Id: I1971301f2b07a6d0608d13d1ab60c6339a079468
2016-09-14 14:25:06 +02:00
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
01755200f6 Bin some noise comments and superfluous vertical whitespace
Change-Id: I3c19457bb29cd1392f14598fc8798aed4b1a1a7f
2016-09-12 23:29:32 +03:00
774d2a94d3 loplugin:constantparam in extensions..lotuswordpro
Change-Id: Ifb30d5d53536045638d872761626a1b60fa52dad
Reviewed-on: https://gerrit.libreoffice.org/28831
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-12 11:09:43 +00:00
4e8e637374 tdf#101766: Fix new folder creation in 'Save Remote Server' dialog.
Change-Id: I5297918ff6acf0631b8be370de3ac96bed474a47
Reviewed-on: https://gerrit.libreoffice.org/28458
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-29 18:43:05 +00:00
25aa9f3048 Resolves: #i96720# FilePicker: setDefaultName...
setDefaultDirectory "broken"

Display the proposed filename even when the URL
specified for the file picker directory is invalid.

As the Win32 file picker sadly allows both paths and URLs
for directories, users try paths on other more
restrictive platforms, and since the file picker there
shows neither the directory nor the file, they wrongly
conclude both are broken.

Patch by: me

(cherry picked from commit 42d181e761c9903bfe5dd71334cadacebd1d0dc8)

Change-Id: I3f99937b667d7fe5198f6445ccd4d0e22d48c7c7
Reviewed-on: https://gerrit.libreoffice.org/28426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-27 18:26:31 +00:00
ce6cbf86a5 screenshots: add new global make target
Up to now the screenshot creation was added/dependent of
target slowcheck. Since quite some modules have added screenshot
creations now, I added an own target 'screenshot' to allow to keep
current slowcheck and screenshot creation separated

Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
2016-08-18 02:39:15 +02:00
2a5ac6f634 screenshots: unify dumping of dialog test batch file
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18 02:39:15 +02:00
7906b063d3 screenshots: add dialog test cases for fpicker
Change-Id: I6c94ff393e823552ea9c2332bd05abf5b2fafd54
2016-08-18 02:39:13 +02:00
b4e12269e8 loplugin:countusersofdefaultparams in editeng..fpicker
Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68
Reviewed-on: https://gerrit.libreoffice.org/27897
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05 11:54:17 +00:00
938821fb08 new loplugin overrideparam
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.

Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25 06:09:17 +00:00